142550 2015-03-10 16:19:28 -0700 Functions should have initialization precedence over arguments. 2015-03-11 16:53:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mmirman mmirman bfulgham commit-queue fpizlo ggaren mmirman msaboff oldest_to_newest 1076125 0 mmirman 2015-03-10 16:19:28 -0700 patch forthcoming. rdar://problem/19702564 1076130 1 248369 mmirman 2015-03-10 16:27:23 -0700 Created attachment 248369 Patch. Ran JSC stress tests on debug without any failures. 1076132 2 248369 ggaren 2015-03-10 16:47:20 -0700 Comment on attachment 248369 Patch. r=me 1076144 3 248369 commit-queue 2015-03-10 17:33:33 -0700 Comment on attachment 248369 Patch. Clearing flags on attachment: 248369 Committed r181353: <http://trac.webkit.org/changeset/181353> 1076145 4 commit-queue 2015-03-10 17:33:37 -0700 All reviewed patches have been landed. Closing bug. 1076463 5 ap 2015-03-11 15:43:20 -0700 Looks like this broke fast/events/event-attribute.html on Windows: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html And when I say "broke", I mean "made it pass": -FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was undefined. +PASS /*img*/ typeof (element["ontouchstart"]) is "function" +PASS /*img*/ typeof (element["ontouchmove"]) is "function" +PASS /*img*/ typeof (element["ontouchend"]) is "function" +PASS /*img*/ typeof (element["ontouchcancel"]) is "function" 1076489 6 mmirman 2015-03-11 16:53:48 -0700 (In reply to comment #5) > Looks like this broke fast/events/event-attribute.html on Windows: > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html > > And when I say "broke", I mean "made it pass": > > -FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was > undefined. > +PASS /*img*/ typeof (element["ontouchstart"]) is "function" > +PASS /*img*/ typeof (element["ontouchmove"]) is "function" > +PASS /*img*/ typeof (element["ontouchend"]) is "function" > +PASS /*img*/ typeof (element["ontouchcancel"]) is "function" http://trac.webkit.org/changeset/181414 248369 2015-03-10 16:27:23 -0700 2015-03-10 17:33:33 -0700 Patch. 0001-Functions-should-have-initialization-precedence-over.patch text/plain 2755 mmirman RnJvbSBjOGQyMjc2ZmVhNWM4NDM4NjUyNmUwYjcyNjg5MmJhMDA2YjY2ZjdhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0aGV3IE1pcm1hbiA8bW1pcm1hbkBhcHBsZS5jb20+CkRh dGU6IFR1ZSwgMTAgTWFyIDIwMTUgMTY6MjU6MzIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGdW5j dGlvbnMgc2hvdWxkIGhhdmUgaW5pdGlhbGl6YXRpb24gcHJlY2VkZW5jZSBvdmVyCiBhcmd1bWVu dHMuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1NTAKIHJkYXI6 Ly9wcm9ibGVtLzE5NzAyNTY0CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogYnl0ZWNv bXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoKKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OkJ5 dGVjb2RlR2VuZXJhdG9yKToKKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmluaXRpYWxpemVDYXB0 dXJlZFZhcmlhYmxlKToKKiB0ZXN0cy9zdHJlc3MvaW5pdGlhbGl6ZV9mdW5jdGlvbnNfYWZ0ZXJf YXJndW1lbnRzLmpzOiBBZGRlZC4KCmRpZmYgLS1naXQgU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDY2NGMxYjYuLjJj ZWVhYjcgMTAwNjQ0Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDMtMTAg IE1hdHRoZXcgTWlybWFuICA8bW1pcm1hbkBhcHBsZS5jb20+CisKKyAgICAgICAgRnVuY3Rpb25z IHNob3VsZCBoYXZlIGluaXRpYWxpemF0aW9uIHByZWNlZGVuY2Ugb3ZlciBhcmd1bWVudHMuIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNTUwCisg ICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE5NzAyNTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3Iu Y3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3Ip OgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6aW5pdGlhbGl6ZUNhcHR1cmVkVmFy aWFibGUpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9pbml0aWFsaXplX2Z1bmN0aW9uc19hZnRl cl9hcmd1bWVudHMuanM6IEFkZGVkLgorCiAyMDE1LTAzLTEwICBBbmRyZWFzIEtsaW5nICA8YWts aW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBFZGVuIGNvbGxlY3Rpb25zIHNob3VsZCB0cmlnZ2Vy IHN3ZWVwIG9mIE1hcmtlZEJsb2NrcyBjb250YWluaW5nIG5ldyBvYmplY3RzLgpkaWZmIC0tZ2l0 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3Bw IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3Bw CmluZGV4IGZiMTY1YmYuLjJkYjI1Y2MgMTAwNjQ0Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKQEAgLTM4OCw3ICszODgsNyBA QCBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IoVk0mIHZtLCBGdW5jdGlvbk5v ZGUqIGZ1bmN0aW9uTm9kZSwgVW5saW5rZQogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAg IH0KICAgICAgICAgYXV0byBzaW1wbGVQYXJhbWV0ZXIgPSBzdGF0aWNfY2FzdDxjb25zdCBCaW5k aW5nTm9kZSo+KHBhdHRlcm4pOwotICAgICAgICBpZiAoY2FwdHVyZWRBcmd1bWVudHMuc2l6ZSgp ICYmIGNhcHR1cmVkQXJndW1lbnRzW2ldKSB7CisgICAgICAgIGlmIChjYXB0dXJlZEFyZ3VtZW50 cy5zaXplKCkgJiYgY2FwdHVyZWRBcmd1bWVudHNbaV0gJiYgIW1fZnVuY3Rpb25zLmNvbnRhaW5z KHNpbXBsZVBhcmFtZXRlci0+Ym91bmRQcm9wZXJ0eSgpLmltcGwoKSkpIHsKICAgICAgICAgICAg IEFTU0VSVCgoZnVuY3Rpb25Ob2RlLT5oYXNDYXB0dXJlZFZhcmlhYmxlcygpICYmIGZ1bmN0aW9u Tm9kZS0+Y2FwdHVyZXMoc2ltcGxlUGFyYW1ldGVyLT5ib3VuZFByb3BlcnR5KCkpKSB8fCBzaG91 bGRDYXB0dXJlQWxsVGhlVGhpbmdzKTsKICAgICAgICAgICAgIGluZGV4ID0gY2FwdHVyZWRBcmd1 bWVudHNbaV0tPmluZGV4KCk7CiAgICAgICAgICAgICBSZWdpc3RlcklEIG9yaWdpbmFsKG5leHRQ YXJhbWV0ZXJJbmRleCk7CmRpZmYgLS1naXQgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0 cmVzcy9pbml0aWFsaXplX2Z1bmN0aW9uc19hZnRlcl9hcmd1bWVudHMuanMgU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9pbml0aWFsaXplX2Z1bmN0aW9uc19hZnRlcl9hcmd1bWVu dHMuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNjQ5OGE2NgotLS0gL2Rl di9udWxsCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2luaXRpYWxpemVf ZnVuY3Rpb25zX2FmdGVyX2FyZ3VtZW50cy5qcwpAQCAtMCwwICsxLDggQEAKKyhmdW5jdGlvbiAo VGhpbmcpeworICAgIGZ1bmN0aW9uIFRoaW5nKCkgeworICAgIH0KKyAgICBmdW5jdGlvbiBvdGhl cigpIHsKKyAgICAgICAgVGhpbmc7CisgICAgfQorICAgIFRoaW5nKCk7Cit9KSgyKQotLSAKMi4y LjEgKEFwcGxlIEdpdC01MykKCg==