142548 2015-03-10 15:37:35 -0700 Add support for more emoji with variation 2015-03-10 17:20:42 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica webkit-unassigned oldest_to_newest 1076108 0 enrica 2015-03-10 15:37:35 -0700 ICU rules need to be adjusted. 1076113 1 248366 enrica 2015-03-10 15:41:13 -0700 Created attachment 248366 Patch 1076121 2 248366 thorton 2015-03-10 16:06:10 -0700 Comment on attachment 248366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review > LayoutTests/editing/selection/extend-by-character-007.html:11 > +<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> quotes around the src value, no need for language or type attrs. > LayoutTests/editing/selection/extend-by-character-007.html:16 > + for (i = 0; i < 4; i++) { var i 1076122 3 enrica 2015-03-10 16:13:34 -0700 Committed revision 181351. 1076136 4 248366 mmaxfield 2015-03-10 17:20:42 -0700 Comment on attachment 248366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review > LayoutTests/editing/selection/extend-by-character-007-expected.txt:16 > + text run at (14,16) width 275: "\x{D83D}\x{DEA3}\x{D83C}\x{DFFB}\x{D83D}\x{DEA3}\x{D83C}\x{DFFC}\x{D83D}\x{DEA3}\x{D83C}\x{DFFD}\x{D83D}\x{DEA3}\x{D83C}\x{DFFE}\x{D83D}\x{DEA3}\x{D83C}\x{DFFF}\x{D83D}\x{DEA3}" Does this actually test anything? It looks like this is the same string as in the .html 248366 2015-03-10 15:41:13 -0700 2015-03-10 16:06:10 -0700 Patch roweremoji.txt text/plain 6891 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTM0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAzLTEwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIG1v cmUgZW1vamkgd2l0aCB2YXJpYXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDI1NDgKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjAxMDUwMDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUg SUNVIHJ1bGVzIHRvIHN1cHBvcnQgbmV3IGVtb2ppIHdpdGggdmFyaWF0aW9uLgorCisgICAgICAg IFRlc3Q6IGVkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1ieS1jaGFyYWN0ZXItMDA3Lmh0bWwKKwor ICAgICAgICAqIHBsYXRmb3JtL3RleHQvVGV4dEJyZWFrSXRlcmF0b3IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Y3Vyc29yTW92ZW1lbnRJdGVyYXRvcik6CisKIDIwMTUtMDMtMTAgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVc2UgdW5zaWdu ZWQgZm9yIEhhc2hTZXQgc2l6ZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv VGV4dEJyZWFrSXRlcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvVGV4dEJyZWFrSXRlcmF0b3IuY3BwCShyZXZpc2lvbiAxODEyODMpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRCcmVha0l0ZXJhdG9yLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjEwLDcgKzIxMCw3IEBAIFRleHRCcmVha0l0ZXJhdG9yKiBjdXJzb3JNb3ZlbWVu dEl0ZXJhdG8KICAgICAgICAgIiRaV0ogICAgID0gXFx1MjAwRDsiICAgICAgICAgICAgICAgLy8g WmVybyB3aWR0aCBqb2luZXIKICAgICAgICAgIiRFbW9qaVZhciA9IFtcXHVGRTBGXTsiICAgICAg ICAgICAgLy8gRW1vamktc3R5bGUgdmFyaWF0aW9uIHNlbGVjdG9yCiAgICAgICAgICIkRW1vamlG b3JTZXFzID0gW1xcdTI3NjQgXFxVMDAwMUY0NjYtXFxVMDAwMUY0NjkgXFxVMDAwMUY0OEJdOyIg Ly8gRW1vamkgdGhhdCBwYXJ0aWNpcGF0ZSBpbiBaV0ogc2VxdWVuY2VzCi0gICAgICAgICIkRW1v amlGb3JNb2RzID0gW1xcdTI2MUQgXFx1MjcwQS1cXHUyNzBDIFxcVTAwMDFGMzg1IFxcVTAwMDFG M0MzLVxcVTAwMDFGM0M0IFxcVTAwMDFGM0M3IFxcVTAwMDFGM0NBIFxcVTAwMDFGNDQyLVxcVTAw MDFGNDQzIFxcVTAwMDFGNDQ2LVxcVTAwMDFGNDUwIFxcVTAwMDFGNDY2LVxcVTAwMDFGNDY5IFxc VTAwMDFGNDZFLVxcVTAwMDFGNDc4IFxcVTAwMDFGNDdDIFxcVTAwMDFGNDgxLVxcVTAwMDFGNDgz IFxcVTAwMDFGNDg1LVxcVTAwMDFGNDg3IFxcVTAwMDFGNEFBIFxcVTAwMDFGNjQ1LVxcVTAwMDFG NjQ3IFxcVTAwMDFGNjRCLVxcVTAwMDFGNjRGIFxcVTAwMDFGNkI0LVxcVTAwMDFGNkI2IFxcVTAw MDFGNkMwXTsiIC8vIEVtb2ppIHRoYXQgdGFrZSBGaXR6cGF0cmljayBtb2RpZmllcnMKKyAgICAg ICAgIiRFbW9qaUZvck1vZHMgPSBbXFx1MjYxRCBcXHUyNzBBLVxcdTI3MEMgXFxVMDAwMUYzODUg XFxVMDAwMUYzQzMtXFxVMDAwMUYzQzQgXFxVMDAwMUYzQzcgXFxVMDAwMUYzQ0EgXFxVMDAwMUY0 NDItXFxVMDAwMUY0NDMgXFxVMDAwMUY0NDYtXFxVMDAwMUY0NTAgXFxVMDAwMUY0NjYtXFxVMDAw MUY0NjkgXFxVMDAwMUY0NkUtXFxVMDAwMUY0NzggXFxVMDAwMUY0N0MgXFxVMDAwMUY0ODEtXFxV MDAwMUY0ODMgXFxVMDAwMUY0ODUtXFxVMDAwMUY0ODcgXFxVMDAwMUY0QUEgXFxVMDAwMUY1OTYg XFxVMDAwMUY2NDUtXFxVMDAwMUY2NDcgXFxVMDAwMUY2NEItXFxVMDAwMUY2NEYgXFxVMDAwMUY2 QTMgXFxVMDAwMUY2QjQtXFxVMDAwMUY2QjYgXFxVMDAwMUY2QzBdIDsiIC8vIEVtb2ppIHRoYXQg dGFrZSBGaXR6cGF0cmljayBtb2RpZmllcnMKICAgICAgICAgIiRFbW9qaU1vZHMgPSBbXFxVMDAw MUYzRkItXFxVMDAwMUYzRkZdOyIgLy8gRml0enBhdHJpY2sgbW9kaWZpZXJzCiAgICAgICAgICIh IWNoYWluOyIKICAgICAgICAgIiEhZm9yd2FyZDsiCkBAIC00MTEsNyArNDExLDcgQEAgc3RhdGlj IGNvbnN0IGNoYXIqIHVheDE0QXNzaWdubWVudHNBZnRlcgogICAgICIkWldKID0gXFx1MjAwRDsi CiAgICAgIiRFbW9qaVZhciA9IFxcdUZFMEY7IgogICAgICIkRW1vamlGb3JTZXFzID0gW1xcdTI3 NjQgXFxVMDAwMUY0NjYtXFxVMDAwMUY0NjkgXFxVMDAwMUY0OEJdOyIKLSAgICAiJEVtb2ppRm9y TW9kcyA9IFtcXHUyNjFEIFxcdTI3MEEtXFx1MjcwQyBcXFUwMDAxRjM4NSBcXFUwMDAxRjNDMy1c XFUwMDAxRjNDNCBcXFUwMDAxRjNDNyBcXFUwMDAxRjNDQSBcXFUwMDAxRjQ0Mi1cXFUwMDAxRjQ0 MyBcXFUwMDAxRjQ0Ni1cXFUwMDAxRjQ1MCBcXFUwMDAxRjQ2Ni1cXFUwMDAxRjQ2OSBcXFUwMDAx RjQ2RS1cXFUwMDAxRjQ3OCBcXFUwMDAxRjQ3QyBcXFUwMDAxRjQ4MS1cXFUwMDAxRjQ4MyBcXFUw MDAxRjQ4NS1cXFUwMDAxRjQ4NyBcXFUwMDAxRjRBQSBcXFUwMDAxRjY0NS1cXFUwMDAxRjY0NyBc XFUwMDAxRjY0Qi1cXFUwMDAxRjY0RiBcXFUwMDAxRjZCNC1cXFUwMDAxRjZCNiBcXFUwMDAxRjZD MF07IgorICAgICIkRW1vamlGb3JNb2RzID0gW1xcdTI2MUQgXFx1MjcwQS1cXHUyNzBDIFxcVTAw MDFGMzg1IFxcVTAwMDFGM0MzLVxcVTAwMDFGM0M0IFxcVTAwMDFGM0M3IFxcVTAwMDFGM0NBIFxc VTAwMDFGNDQyLVxcVTAwMDFGNDQzIFxcVTAwMDFGNDQ2LVxcVTAwMDFGNDUwIFxcVTAwMDFGNDY2 LVxcVTAwMDFGNDY5IFxcVTAwMDFGNDZFLVxcVTAwMDFGNDc4IFxcVTAwMDFGNDdDIFxcVTAwMDFG NDgxLVxcVTAwMDFGNDgzIFxcVTAwMDFGNDg1LVxcVTAwMDFGNDg3IFxcVTAwMDFGNEFBIFxcVTAw MDFGNTk2IFxcVTAwMDFGNjQ1LVxcVTAwMDFGNjQ3IFxcVTAwMDFGNjRCLVxcVTAwMDFGNjRGIFxc VTAwMDFGNkEzIFxcVTAwMDFGNkI0LVxcVTAwMDFGNkI2IFxcVTAwMDFGNkMwXSA7IiAvLyBFbW9q aSB0aGF0IHRha2UgRml0enBhdHJpY2sgbW9kaWZpZXJzCiAgICAgIiRFbW9qaU1vZHMgPSBbXFxV MDAwMUYzRkItXFxVMDAwMUYzRkZdOyIKICAgICAiJGRpY3Rpb25hcnkgPSBbOkxpbmVCcmVhayA9 IENvbXBsZXhfQ29udGV4dDpdOyIKICAgICAiJEFMUGx1cyA9IFskQUwgJEFJICRTQSAkU0cgJFhY XTsiCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODEzNDgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNS0wMy0xMCAgRW5yaWNhIENhc3Vj Y2kgIDxlbnJpY2FAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBtb3JlIGVt b2ppIHdpdGggdmFyaWF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQyNTQ4CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzIwMTA1MDA4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0aW5nL3Nl bGVjdGlvbi9leHRlbmQtYnktY2hhcmFjdGVyLTAwNy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1ieS1jaGFyYWN0ZXItMDA3Lmh0bWw6IEFk ZGVkLgorCiAyMDE1LTAzLTEwICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29t PgogCiAgICAgICAgIFtNYWNdIFJlZmFjdG9yIG1lZGlhIGNvbnRyb2xzIGNvZGUKSW5kZXg6IExh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1ieS1jaGFyYWN0ZXItMDA3LWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRl bmQtYnktY2hhcmFjdGVyLTAwNy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtYnktY2hhcmFjdGVyLTAwNy1leHBlY3RlZC50 eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyMCBAQAorRURJVElORyBERUxFR0FURTogc2hv dWxkQmVnaW5FZGl0aW5nSW5ET01SYW5nZTpyYW5nZSBmcm9tIDAgb2YgRElWID4gQk9EWSA+IEhU TUwgPiAjZG9jdW1lbnQgdG8gNCBvZiBESVYgPiBCT0RZID4gSFRNTCA+ICNkb2N1bWVudAorRURJ VElORyBERUxFR0FURTogd2ViVmlld0RpZEJlZ2luRWRpdGluZzpXZWJWaWV3RGlkQmVnaW5FZGl0 aW5nTm90aWZpY2F0aW9uCitFRElUSU5HIERFTEVHQVRFOiB3ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0 aW9uOldlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb25Ob3RpZmljYXRpb24KK0VESVRJTkcgREVMRUdB VEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmlld0RpZENoYW5nZVNlbGVjdGlvbk5v dGlmaWNhdGlvbgorRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZENoYW5nZVNlbGVjdGlvbjpX ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uTm90aWZpY2F0aW9uCitFRElUSU5HIERFTEVHQVRFOiB3 ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uOldlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb25Ob3RpZmlj YXRpb24KK0VESVRJTkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmll d0RpZENoYW5nZVNlbGVjdGlvbk5vdGlmaWNhdGlvbgorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4 NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBz aXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAor ICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAorICAgICAgUmVuZGVy QmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6ZSA3ODR4NjAgW2JvcmRlcjogKDJweCBzb2xpZCAjRkYw MDAwKV0KKyAgICAgICAgUmVuZGVySW5saW5lIHtTUEFOfSBhdCAoMCwwKSBzaXplIDI3NXgyOAor ICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMTQsMTYpIHNpemUgMjc1eDI4CisgICAg ICAgICAgICB0ZXh0IHJ1biBhdCAoMTQsMTYpIHdpZHRoIDI3NTogIlx4e0Q4M0R9XHh7REVBM31c eHtEODNDfVx4e0RGRkJ9XHh7RDgzRH1ceHtERUEzfVx4e0Q4M0N9XHh7REZGQ31ceHtEODNEfVx4 e0RFQTN9XHh7RDgzQ31ceHtERkZEfVx4e0Q4M0R9XHh7REVBM31ceHtEODNDfVx4e0RGRkV9XHh7 RDgzRH1ceHtERUEzfVx4e0Q4M0N9XHh7REZGRn1ceHtEODNEfVx4e0RFQTN9IgorICAgICAgICBS ZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKKyAgICAgICAgUmVuZGVyVGV4dCB7 I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCitzZWxlY3Rpb24gc3RhcnQ6IHBvc2l0aW9uIDAgb2Yg Y2hpbGQgMCB7I3RleHR9IG9mIGNoaWxkIDEge1NQQU59IG9mIGNoaWxkIDMge0RJVn0gb2YgYm9k eQorc2VsZWN0aW9uIGVuZDogICBwb3NpdGlvbiAxNiBvZiBjaGlsZCAwIHsjdGV4dH0gb2YgY2hp bGQgMSB7U1BBTn0gb2YgY2hpbGQgMyB7RElWfSBvZiBib2R5CkluZGV4OiBMYXlvdXRUZXN0cy9l ZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtYnktY2hhcmFjdGVyLTAwNy5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1ieS1jaGFyYWN0ZXItMDA3 Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRl bmQtYnktY2hhcmFjdGVyLTAwNy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMzUgQEAK KzxodG1sPiAKKzxoZWFkPgorCis8c3R5bGU+CisuZWRpdGluZyB7IAorICAgIGJvcmRlcjogMnB4 IHNvbGlkIHJlZDsgCisgICAgcGFkZGluZzogMTJweDsgCisgICAgZm9udC1zaXplOiAyNHB4OyAK K30KKzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0uLi9lZGl0aW5nLmpzIGxhbmd1YWdlPSJKYXZhU2Ny aXB0IiB0eXBlPSJ0ZXh0L0phdmFTY3JpcHQiID48L3NjcmlwdD4KKworPHNjcmlwdD4KKworZnVu Y3Rpb24gZWRpdGluZ1Rlc3QoKSB7CisgICAgZm9yIChpID0gMDsgaSA8IDQ7IGkrKykgeworICAg ICAgICBleHRlbmRTZWxlY3Rpb25Gb3J3YXJkQnlDaGFyYWN0ZXJDb21tYW5kKCk7CisgICAgfQor fQorCis8L3NjcmlwdD4KKworPHRpdGxlPkVkaXRpbmcgVGVzdDwvdGl0bGU+IAorPC9oZWFkPiAK Kzxib2R5PgorPCEtLSByZGFyOi8vcHJvYmxlbS8yMDEwNTAwOCAvLy0tPgorPGRpdiBjb250ZW50 ZWRpdGFibGUgaWQ9InJvb3QiIGNsYXNzPSJlZGl0aW5nIj4KKzxzcGFuIGlkPSJ0ZXN0Ij4mI3gx RjZBMzsmI3gxRjNGQjsmI3gxRjZBMzsmI3gxRjNGQzsmI3gxRjZBMzsmI3gxRjNGRDsmI3gxRjZB MzsmI3gxRjNGRTsmI3gxRjZBMzsmI3gxRjNGRjsmI3gxRjZBMzs8L3NwYW4+CisKKzxzY3JpcHQ+ CitydW5FZGl0aW5nVGVzdCgpOworPC9zY3JpcHQ+CisKKzwvYm9keT4KKzwvaHRtbD4K