142547 2015-03-10 15:34:51 -0700 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 2015-03-18 17:03:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dburkart dburkart ap commit-queue dburkart ggaren glenn webkit-bug-importer oldest_to_newest 1076106 0 dburkart 2015-03-10 15:34:51 -0700 Alexey says: We have a test crash with ASan, because it tries to allocate too much, and ASan doesn't allow that. We need to change the default behavior: ==45420==WARNING: AddressSanitizer failed to allocate 0xffffffffaffff6a0 bytes ==45420==AddressSanitizer's allocator is terminating the process instead of returning 0 ==45420==If you don't like this behavior set allocator_may_return_null=1 ==45420==AddressSanitizer CHECK failed: /SourceCache/clang/clang-603.0.12/src/projects/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:149 "((0)) != (0)" (0x0, 0x0) 1076107 1 dburkart 2015-03-10 15:35:25 -0700 <rdar://problem/20111863> 1076112 2 248365 dburkart 2015-03-10 15:41:01 -0700 Created attachment 248365 Set allocator_may_return_null=1 1076114 3 248365 ggaren 2015-03-10 15:44:29 -0700 Comment on attachment 248365 Set allocator_may_return_null=1 r=me 1076115 4 ggaren 2015-03-10 15:44:42 -0700 Does this fix the plugin testcase? 1076127 5 248365 ap 2015-03-10 16:21:06 -0700 Comment on attachment 248365 Set allocator_may_return_null=1 Sadly, I don't think that this is going to work - ASAN_OPTIONS is a runtime variable, not a build time one AFAIK. 1076128 6 dburkart 2015-03-10 16:23:45 -0700 (In reply to comment #5) > Comment on attachment 248365 [details] > Set allocator_may_return_null=1 > > Sadly, I don't think that this is going to work - ASAN_OPTIONS is a runtime > variable, not a build time one AFAIK. Yeah, I misunderstood this. This is going to be more difficult since we don't actually set any ASan-specific settings at runtime, and will have to come up with some way to do this. 1078351 7 248981 dburkart 2015-03-18 16:31:09 -0700 Created attachment 248981 Set ASAN_OPTIONS in run-webkit-tests 1078353 8 commit-queue 2015-03-18 16:33:27 -0700 Attachment 248981 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/asan/utils.py:32: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/Scripts/webkitpy/common/asan/utils.py:36: whitespace before '}' [pep8/E202] [5] ERROR: Tools/Scripts/webkitpy/common/asan/__init__.py:1: no newline at end of file [pep8/W292] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1078356 9 248984 dburkart 2015-03-18 16:37:49 -0700 Created attachment 248984 Fix style 1078358 10 248981 ap 2015-03-18 16:39:46 -0700 Comment on attachment 248981 Set ASAN_OPTIONS in run-webkit-tests View in context: https://bugs.webkit.org/attachment.cgi?id=248981&action=review > Tools/Scripts/webkitpy/common/asan/__init__.py:2 > \ No newline at end of file Should one be added? > Tools/Scripts/webkitpy/common/asan/utils.py:13 > +# * Neither the name of Google Inc. nor the names of its Is this the right license? The preferred WebKit license text is at <http://www.webkit.org/coding/bsd-license.html>. > Tools/Scripts/webkitpy/common/asan/utils.py:34 > + "abort_on_error" : 1, I don't think that we want this. > Tools/Scripts/webkitpy/common/asan/utils.py:36 > + "handle_segv" : 0 Not sure about this, it should probably be in a separate fix if it's needed at all. > Tools/Scripts/webkitpy/port/driver.py:320 > + if ASanUtility.compiled_with_asan(self._port._path_to_driver()): I just thought... We do we care, can we just always set the environment variable? 1078359 11 248986 dburkart 2015-03-18 16:39:51 -0700 Created attachment 248986 Really fix style.... 1078364 12 commit-queue 2015-03-18 16:42:16 -0700 Attachment 248986 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/asan/utils.py:36: whitespace before '}' [pep8/E202] [5] ERROR: Tools/Scripts/webkitpy/common/asan/utils.py:50: blank line at end of file [pep8/W391] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1078365 13 248986 ap 2015-03-18 16:42:42 -0700 Comment on attachment 248986 Really fix style.... View in context: https://bugs.webkit.org/attachment.cgi?id=248986&action=review > Tools/Scripts/webkitpy/port/driver.py:320 > + if ASanUtility.compiled_with_asan(self._port._path_to_driver()): In addition to the above comments: this looks like code that is shared across all platforms, and we probably cannot run otool everywhere. 1078367 14 dburkart 2015-03-18 16:45:14 -0700 (In reply to comment #10) > Comment on attachment 248981 [details] > Set ASAN_OPTIONS in run-webkit-tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248981&action=review > > > Tools/Scripts/webkitpy/common/asan/__init__.py:2 > > \ No newline at end of file > > Should one be added? > > > Tools/Scripts/webkitpy/common/asan/utils.py:13 > > +# * Neither the name of Google Inc. nor the names of its > > Is this the right license? > > The preferred WebKit license text is at > <http://www.webkit.org/coding/bsd-license.html>. > > > Tools/Scripts/webkitpy/common/asan/utils.py:34 > > + "abort_on_error" : 1, > > I don't think that we want this. > > > Tools/Scripts/webkitpy/common/asan/utils.py:36 > > + "handle_segv" : 0 > > Not sure about this, it should probably be in a separate fix if it's needed > at all. > I added "abort_on_error" and "handle_segv", as David Kilzer had added them to his patch. If we don't need them I will take them out. > > Tools/Scripts/webkitpy/port/driver.py:320 > > + if ASanUtility.compiled_with_asan(self._port._path_to_driver()): > > I just thought... We do we care, can we just always set the environment > variable? I guess we don't care. I'll remove it. 1078368 15 248987 dburkart 2015-03-18 16:50:18 -0700 Created attachment 248987 Address Alexey's concerns 1078370 16 248987 ap 2015-03-18 16:52:09 -0700 Comment on attachment 248987 Address Alexey's concerns View in context: https://bugs.webkit.org/attachment.cgi?id=248987&action=review > Tools/Scripts/webkitpy/port/driver.py:320 > + environment['ASAN_OPTIONS'] = ASanUtility.environment_options() At this point, I think that it would be better to just say environment['ASAN_OPTIONS'] = "allocator_may_return_null=1" 1078371 17 commit-queue 2015-03-18 16:53:35 -0700 Attachment 248987 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/asan/utils.py:25: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1078373 18 dburkart 2015-03-18 16:56:36 -0700 (In reply to comment #16) > Comment on attachment 248987 [details] > Address Alexey's concerns > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248987&action=review > > > Tools/Scripts/webkitpy/port/driver.py:320 > > + environment['ASAN_OPTIONS'] = ASanUtility.environment_options() > > At this point, I think that it would be better to just say > > environment['ASAN_OPTIONS'] = "allocator_may_return_null=1" I agree, but I think that is going to get clunky soon, as I am sure we will be setting more environment variables soon. 1078374 19 dburkart 2015-03-18 17:02:27 -0700 Merged r181714. 248365 2015-03-10 15:41:01 -0700 2015-03-18 16:31:09 -0700 Set allocator_may_return_null=1 bug_142547.patch text/plain 987 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTM0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE1LTAzLTEwICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNBTl9PUFRJT05TPWFsbG9jYXRvcl9tYXlfcmV0dXJuX251bGw9MSBuZWVk cyB0byBiZSBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0MjU0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogYXNhbi9hc2FuLnhjY29uZmlnOgorCiAyMDE1LTAzLTEwICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXNlIHVuc2lnbmVkIGZvciBI YXNoU2V0IHNpemUuCkluZGV4OiBUb29scy9hc2FuL2FzYW4ueGNjb25maWcKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvYXNhbi9hc2FuLnhjY29uZmlnCShyZXZpc2lvbiAxODEzNDgpCisrKyBUb29scy9h c2FuL2FzYW4ueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTExLDYgKzExLDcgQEAgR0NDX09Q VElNSVpBVElPTl9MRVZFTF9SZWxlYXNlID0gMTsKIAogQ0xBTkdfQUREUkVTU19TQU5JVElaRVI9 WUVTCiAKK0FTQU5fT1BUSU9OUyA9IGFsbG9jYXRvcl9tYXlfcmV0dXJuX251bGw9MTsKIEFTQU5f T1RIRVJfQ0ZMQUdTID0gLWZzYW5pdGl6ZS1ibGFja2xpc3Q9JChBU0FOX0lHTk9SRSkgLWZuby1v bWl0LWZyYW1lLXBvaW50ZXIgLWc7CiBBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTID0gJChBU0FO X09USEVSX0NGTEFHUyk7CiAK 248981 2015-03-18 16:31:09 -0700 2015-03-18 16:50:18 -0700 Set ASAN_OPTIONS in run-webkit-tests bug_142547.patch text/plain 4778 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTcxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTAzLTE4ICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNBTl9PUFRJT05TPWFsbG9jYXRvcl9tYXlfcmV0dXJuX251bGw9MSBuZWVk cyB0byBiZSBzZXQgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDI1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW46IEFkZGVkLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vX19pbml0X18ucHk6IEFkZGVkLgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vdXRpbHMucHk6IEFkZGVkLgorICAgICAgICAo QVNhblV0aWxpdHkpOgorICAgICAgICAoQVNhblV0aWxpdHkuZW52aXJvbm1lbnRfb3B0aW9ucyk6 CisgICAgICAgIChBU2FuVXRpbGl0eS5jb21waWxlZF93aXRoX2FzYW4pOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHk6CisgICAgICAgIChEcml2ZXIuX3NldHVwX2Vu dmlyb25fZm9yX2RyaXZlcik6CisKIDIwMTUtMDMtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgVHdlYWsgaG93IEFwcGxlU3lzdGVtRm9udE9TU3VidmVy c2lvbiBkZWZhdWx0IGlzIGFkZGVkCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9hc2FuL19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2FzYW4vX19pbml0X18ucHkJKHJldmlzaW9uIDApCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9hc2FuL19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEg QEAKKyMgUmVxdWlyZWQgZm9yIFB5dGhvbiB0byBzZWFyY2ggdGhpcyBkaXJlY3RvcnkgZm9yIG1v ZHVsZSBmaWxlcwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2FzYW4vdXRpbHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vYXNhbi91dGlscy5weQkocmV2aXNpb24gMCkKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vdXRpbHMucHkJKHdvcmtpbmcgY29weSkKQEAg LTAsMCArMSw0NiBAQAorIyBDb3B5cmlnaHQgKGMpIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjCisj ICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJv dmUgY29weXJpZ2h0CisjIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBm b3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxp c3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisjIGluIHRoZSBk b2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyMg ZGlzdHJpYnV0aW9uLgorIyAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5v ciB0aGUgbmFtZXMgb2YgaXRzCisjIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNl IG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisjIHRoaXMgc29mdHdhcmUgd2l0aG91 dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisjCisjIFRISVMgU09GVFdBUkUg SVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyMg IkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcs IEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFO VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVND TEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisjIE9XTkVSIE9SIENPTlRS SUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAor IyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5H LCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMg T1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVT UyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyMgVEhFT1JZIE9GIExJ QUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAor IyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkg T1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRI RSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworaW1wb3J0IHJlCitpbXBvcnQgc3VicHJv Y2VzcworCitjbGFzcyBBU2FuVXRpbGl0eShvYmplY3QpOgorICAgIEFTQU5fT1BUSU9OUyA9IHsK KyAgICAgICAgImFib3J0X29uX2Vycm9yIiA6IDEsCisgICAgICAgICJhbGxvY2F0b3JfbWF5X3Jl dHVybl9udWxsIiA6IDEsCisgICAgICAgICJoYW5kbGVfc2VndiIgOiAwCisgICAgfQorCisgICAg QHN0YXRpY21ldGhvZAorICAgIGRlZiBlbnZpcm9ubWVudF9vcHRpb25zKCk6CisgICAgICAgIHJl dHVybiAnICcuam9pbihba2V5ICsgIj0iICsgc3RyKEFTYW5VdGlsaXR5LkFTQU5fT1BUSU9OU1tr ZXldKSBmb3Iga2V5IGluIEFTYW5VdGlsaXR5LkFTQU5fT1BUSU9OU10pCisKKyAgICBAc3RhdGlj bWV0aG9kCisgICAgZGVmIGNvbXBpbGVkX3dpdGhfYXNhbihwYXRoX3RvX2JpbmFyeSk6CisgICAg ICAgIG90b29sX291dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KFsnL3Vzci9iaW4vb3Rv b2wnLCAnLUwnLCBwYXRoX3RvX2JpbmFyeV0pCisgICAgICAgIHJldHVybiByZS5zZWFyY2goJ0By cGF0aC4qYXNhbicsIG90b29sX291dHB1dCwgZmxhZ3M9cmUuTVVMVElMSU5FKSAhPSBOb25lCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkJKHJldmlzaW9uIDE4MTcxMSkK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkJKHdvcmtpbmcgY29weSkK QEAgLTM4LDYgKzM4LDcgQEAgaW1wb3J0IG9zCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0g aW1wb3J0IHBhdGgKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5wcm9maWxlciBpbXBvcnQg UHJvZmlsZXJGYWN0b3J5CiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5zZXJ2ZXJzLndlYl9w bGF0Zm9ybV90ZXN0X3NlcnZlciBpbXBvcnQgV2ViUGxhdGZvcm1UZXN0U2VydmVyCitmcm9tIHdl YmtpdHB5LmNvbW1vbi5hc2FuLnV0aWxzIGltcG9ydCBBU2FuVXRpbGl0eQogCiAKIF9sb2cgPSBs b2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKQEAgLTMxNiw2ICszMTcsOCBAQCBjbGFzcyBEcml2 ZXIob2JqZWN0KToKICAgICAgICAgI2Vudmlyb25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10g PSBzdHIoc2VsZi5fcG9ydC5fZHJpdmVyX3RlbXBkaXJfZm9yX2Vudmlyb25tZW50KCkpCiAgICAg ICAgIGVudmlyb25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10gPSBzdHIoc2VsZi5fZHJpdmVy X3RlbXBkaXIpCiAgICAgICAgIGVudmlyb25tZW50WydMT0NBTF9SRVNPVVJDRV9ST09UJ10gPSBz ZWxmLl9wb3J0LmxheW91dF90ZXN0c19kaXIoKQorICAgICAgICBpZiBBU2FuVXRpbGl0eS5jb21w aWxlZF93aXRoX2FzYW4oc2VsZi5fcG9ydC5fcGF0aF90b19kcml2ZXIoKSk6CisgICAgICAgICAg ICBlbnZpcm9ubWVudFsnQVNBTl9PUFRJT05TJ10gPSBBU2FuVXRpbGl0eS5lbnZpcm9ubWVudF9v cHRpb25zKCkKICAgICAgICAgaWYgJ1dFQktJVF9PVVRQVVRESVInIGluIG9zLmVudmlyb246CiAg ICAgICAgICAgICBlbnZpcm9ubWVudFsnV0VCS0lUX09VVFBVVERJUiddID0gb3MuZW52aXJvblsn V0VCS0lUX09VVFBVVERJUiddCiAgICAgICAgIGlmIHNlbGYuX3Byb2ZpbGVyOgo= 248984 2015-03-18 16:37:49 -0700 2015-03-18 16:39:51 -0700 Fix style bug_142547.patch text/plain 4712 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTcxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTAzLTE4ICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNBTl9PUFRJT05TPWFsbG9jYXRvcl9tYXlfcmV0dXJuX251bGw9MSBuZWVk cyB0byBiZSBzZXQgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDI1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW46IEFkZGVkLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vX19pbml0X18ucHk6IEFkZGVkLgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vdXRpbHMucHk6IEFkZGVkLgorICAgICAgICAo QVNhblV0aWxpdHkpOgorICAgICAgICAoQVNhblV0aWxpdHkuZW52aXJvbm1lbnRfb3B0aW9ucyk6 CisgICAgICAgIChBU2FuVXRpbGl0eS5jb21waWxlZF93aXRoX2FzYW4pOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHk6CisgICAgICAgIChEcml2ZXIuX3NldHVwX2Vu dmlyb25fZm9yX2RyaXZlcik6CisKIDIwMTUtMDMtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgVHdlYWsgaG93IEFwcGxlU3lzdGVtRm9udE9TU3VidmVy c2lvbiBkZWZhdWx0IGlzIGFkZGVkCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9hc2FuL19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2FzYW4vX19pbml0X18ucHkJKHJldmlzaW9uIDApCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9hc2FuL19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEg QEAKKyMgUmVxdWlyZWQgZm9yIFB5dGhvbiB0byBzZWFyY2ggdGhpcyBkaXJlY3RvcnkgZm9yIG1v ZHVsZSBmaWxlcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vYXNhbi91dGls cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9hc2FuL3V0 aWxzLnB5CShyZXZpc2lvbiAwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vYXNh bi91dGlscy5weQkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQ5IEBACisjIENvcHlyaWdodCAo YykgMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAor IyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMKKyMgICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNv dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAgICAg KiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3Zl CisjIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIKKyMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1h dGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorIyBkaXN0cmlidXRpb24uCisjICAgICAqIE5laXRo ZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKKyMgY29udHJp YnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVk IGZyb20KKyMgdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVy bWlzc2lvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hU IEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworIyAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJ TVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBUSEUg SU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyMg QSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRI RSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisjIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09O U0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgUFJP Q1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisj IERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNU LCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgorCitpbXBvcnQgcmUKK2ltcG9ydCBzdWJwcm9jZXNzCisKKworQVNBTl9PUFRJT05TID0gewor ICAgICJhYm9ydF9vbl9lcnJvciIgOiAxLAorICAgICJhbGxvY2F0b3JfbWF5X3JldHVybl9udWxs IiA6IDEsCisgICAgImhhbmRsZV9zZWd2IiA6IDAKK30KKworCitjbGFzcyBBU2FuVXRpbGl0eShv YmplY3QpOgorCisgICAgQHN0YXRpY21ldGhvZAorICAgIGRlZiBlbnZpcm9ubWVudF9vcHRpb25z KCk6CisgICAgICAgIHJldHVybiAnICcuam9pbihba2V5ICsgIj0iICsgc3RyKEFTQU5fT1BUSU9O U1trZXldKSBmb3Iga2V5IGluIEFTQU5fT1BUSU9OU10pCisKKyAgICBAc3RhdGljbWV0aG9kCisg ICAgZGVmIGNvbXBpbGVkX3dpdGhfYXNhbihwYXRoX3RvX2JpbmFyeSk6CisgICAgICAgIG90b29s X291dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KFsnL3Vzci9iaW4vb3Rvb2wnLCAnLUwn LCBwYXRoX3RvX2JpbmFyeV0pCisgICAgICAgIHJldHVybiByZS5zZWFyY2goJ0BycGF0aC4qYXNh bicsIG90b29sX291dHB1dCwgZmxhZ3M9cmUuTVVMVElMSU5FKSAhPSBOb25lCkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkJKHJldmlzaW9uIDE4MTcxMSkKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTM4LDYg KzM4LDcgQEAgaW1wb3J0IG9zCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0gaW1wb3J0IHBh dGgKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5wcm9maWxlciBpbXBvcnQgUHJvZmlsZXJG YWN0b3J5CiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5zZXJ2ZXJzLndlYl9wbGF0Zm9ybV90 ZXN0X3NlcnZlciBpbXBvcnQgV2ViUGxhdGZvcm1UZXN0U2VydmVyCitmcm9tIHdlYmtpdHB5LmNv bW1vbi5hc2FuLnV0aWxzIGltcG9ydCBBU2FuVXRpbGl0eQogCiAKIF9sb2cgPSBsb2dnaW5nLmdl dExvZ2dlcihfX25hbWVfXykKQEAgLTMxNiw2ICszMTcsOCBAQCBjbGFzcyBEcml2ZXIob2JqZWN0 KToKICAgICAgICAgI2Vudmlyb25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10gPSBzdHIoc2Vs Zi5fcG9ydC5fZHJpdmVyX3RlbXBkaXJfZm9yX2Vudmlyb25tZW50KCkpCiAgICAgICAgIGVudmly b25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10gPSBzdHIoc2VsZi5fZHJpdmVyX3RlbXBkaXIp CiAgICAgICAgIGVudmlyb25tZW50WydMT0NBTF9SRVNPVVJDRV9ST09UJ10gPSBzZWxmLl9wb3J0 LmxheW91dF90ZXN0c19kaXIoKQorICAgICAgICBpZiBBU2FuVXRpbGl0eS5jb21waWxlZF93aXRo X2FzYW4oc2VsZi5fcG9ydC5fcGF0aF90b19kcml2ZXIoKSk6CisgICAgICAgICAgICBlbnZpcm9u bWVudFsnQVNBTl9PUFRJT05TJ10gPSBBU2FuVXRpbGl0eS5lbnZpcm9ubWVudF9vcHRpb25zKCkK ICAgICAgICAgaWYgJ1dFQktJVF9PVVRQVVRESVInIGluIG9zLmVudmlyb246CiAgICAgICAgICAg ICBlbnZpcm9ubWVudFsnV0VCS0lUX09VVFBVVERJUiddID0gb3MuZW52aXJvblsnV0VCS0lUX09V VFBVVERJUiddCiAgICAgICAgIGlmIHNlbGYuX3Byb2ZpbGVyOgo= 248986 2015-03-18 16:39:51 -0700 2015-03-18 16:50:18 -0700 Really fix style.... bug_142547.patch text/plain 4714 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTcxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTAzLTE4ICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNBTl9PUFRJT05TPWFsbG9jYXRvcl9tYXlfcmV0dXJuX251bGw9MSBuZWVk cyB0byBiZSBzZXQgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDI1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW46IEFkZGVkLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vX19pbml0X18ucHk6IEFkZGVkLgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vdXRpbHMucHk6IEFkZGVkLgorICAgICAgICAo QVNhblV0aWxpdHkpOgorICAgICAgICAoQVNhblV0aWxpdHkuZW52aXJvbm1lbnRfb3B0aW9ucyk6 CisgICAgICAgIChBU2FuVXRpbGl0eS5jb21waWxlZF93aXRoX2FzYW4pOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHk6CisgICAgICAgIChEcml2ZXIuX3NldHVwX2Vu dmlyb25fZm9yX2RyaXZlcik6CisKIDIwMTUtMDMtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgVHdlYWsgaG93IEFwcGxlU3lzdGVtRm9udE9TU3VidmVy c2lvbiBkZWZhdWx0IGlzIGFkZGVkCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9hc2FuL19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2FzYW4vX19pbml0X18ucHkJKHJldmlzaW9uIDApCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9hc2FuL19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEg QEAKKyMgUmVxdWlyZWQgZm9yIFB5dGhvbiB0byBzZWFyY2ggdGhpcyBkaXJlY3RvcnkgZm9yIG1v ZHVsZSBmaWxlcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vYXNhbi91dGls cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9hc2FuL3V0 aWxzLnB5CShyZXZpc2lvbiAwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vYXNh bi91dGlscy5weQkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDUwIEBACisjIENvcHlyaWdodCAo YykgMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAor IyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMKKyMgICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNv dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAgICAg KiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3Zl CisjIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIKKyMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1h dGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorIyBkaXN0cmlidXRpb24uCisjICAgICAqIE5laXRo ZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKKyMgY29udHJp YnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVk IGZyb20KKyMgdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVy bWlzc2lvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hU IEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworIyAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJ TVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBUSEUg SU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyMg QSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRI RSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisjIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09O U0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgUFJP Q1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisj IERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNU LCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgorCitpbXBvcnQgcmUKK2ltcG9ydCBzdWJwcm9jZXNzCisKKworQVNBTl9PUFRJT05TID0gewor ICAgICJhYm9ydF9vbl9lcnJvciIgOiAxLAorICAgICJhbGxvY2F0b3JfbWF5X3JldHVybl9udWxs IiA6IDEsCisgICAgImhhbmRsZV9zZWd2IiA6IDAKK30KKworCitjbGFzcyBBU2FuVXRpbGl0eShv YmplY3QpOgorCisgICAgQHN0YXRpY21ldGhvZAorICAgIGRlZiBlbnZpcm9ubWVudF9vcHRpb25z KCk6CisgICAgICAgIHJldHVybiAnICcuam9pbihba2V5ICsgIj0iICsgc3RyKEFTQU5fT1BUSU9O U1trZXldKSBmb3Iga2V5IGluIEFTQU5fT1BUSU9OU10pCisKKyAgICBAc3RhdGljbWV0aG9kCisg ICAgZGVmIGNvbXBpbGVkX3dpdGhfYXNhbihwYXRoX3RvX2JpbmFyeSk6CisgICAgICAgIG90b29s X291dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KFsnL3Vzci9iaW4vb3Rvb2wnLCAnLUwn LCBwYXRoX3RvX2JpbmFyeV0pCisgICAgICAgIHJldHVybiByZS5zZWFyY2goJ0BycGF0aC4qYXNh bicsIG90b29sX291dHB1dCwgZmxhZ3M9cmUuTVVMVElMSU5FKSAhPSBOb25lCisKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkocmV2aXNpb24gMTgxNzExKQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkod29ya2luZyBjb3B5KQpAQCAtMzgs NiArMzgsNyBAQCBpbXBvcnQgb3MKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbSBpbXBvcnQg cGF0aAogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLnByb2ZpbGVyIGltcG9ydCBQcm9maWxl ckZhY3RvcnkKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnNlcnZlcnMud2ViX3BsYXRmb3Jt X3Rlc3Rfc2VydmVyIGltcG9ydCBXZWJQbGF0Zm9ybVRlc3RTZXJ2ZXIKK2Zyb20gd2Via2l0cHku Y29tbW9uLmFzYW4udXRpbHMgaW1wb3J0IEFTYW5VdGlsaXR5CiAKIAogX2xvZyA9IGxvZ2dpbmcu Z2V0TG9nZ2VyKF9fbmFtZV9fKQpAQCAtMzE2LDYgKzMxNyw4IEBAIGNsYXNzIERyaXZlcihvYmpl Y3QpOgogICAgICAgICAjZW52aXJvbm1lbnRbJ0RVTVBSRU5ERVJUUkVFX1RFTVAnXSA9IHN0cihz ZWxmLl9wb3J0Ll9kcml2ZXJfdGVtcGRpcl9mb3JfZW52aXJvbm1lbnQoKSkKICAgICAgICAgZW52 aXJvbm1lbnRbJ0RVTVBSRU5ERVJUUkVFX1RFTVAnXSA9IHN0cihzZWxmLl9kcml2ZXJfdGVtcGRp cikKICAgICAgICAgZW52aXJvbm1lbnRbJ0xPQ0FMX1JFU09VUkNFX1JPT1QnXSA9IHNlbGYuX3Bv cnQubGF5b3V0X3Rlc3RzX2RpcigpCisgICAgICAgIGlmIEFTYW5VdGlsaXR5LmNvbXBpbGVkX3dp dGhfYXNhbihzZWxmLl9wb3J0Ll9wYXRoX3RvX2RyaXZlcigpKToKKyAgICAgICAgICAgIGVudmly b25tZW50WydBU0FOX09QVElPTlMnXSA9IEFTYW5VdGlsaXR5LmVudmlyb25tZW50X29wdGlvbnMo KQogICAgICAgICBpZiAnV0VCS0lUX09VVFBVVERJUicgaW4gb3MuZW52aXJvbjoKICAgICAgICAg ICAgIGVudmlyb25tZW50WydXRUJLSVRfT1VUUFVURElSJ10gPSBvcy5lbnZpcm9uWydXRUJLSVRf T1VUUFVURElSJ10KICAgICAgICAgaWYgc2VsZi5fcHJvZmlsZXI6Cg== 248987 2015-03-18 16:50:18 -0700 2015-03-18 16:52:09 -0700 Address Alexey's concerns bug_142547.patch text/plain 4106 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTcxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTAzLTE4ICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNBTl9PUFRJT05TPWFsbG9jYXRvcl9tYXlfcmV0dXJuX251bGw9MSBuZWVk cyB0byBiZSBzZXQgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDI1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW46IEFkZGVkLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vX19pbml0X18ucHk6IEFkZGVkLgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2FzYW4vdXRpbHMucHk6IEFkZGVkLgorICAgICAgICAo QVNhblV0aWxpdHkpOgorICAgICAgICAoQVNhblV0aWxpdHkuZW52aXJvbm1lbnRfb3B0aW9ucyk6 CisgICAgICAgIChBU2FuVXRpbGl0eS5jb21waWxlZF93aXRoX2FzYW4pOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHk6CisgICAgICAgIChEcml2ZXIuX3NldHVwX2Vu dmlyb25fZm9yX2RyaXZlcik6CisKIDIwMTUtMDMtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgVHdlYWsgaG93IEFwcGxlU3lzdGVtRm9udE9TU3VidmVy c2lvbiBkZWZhdWx0IGlzIGFkZGVkCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9hc2FuL19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2FzYW4vX19pbml0X18ucHkJKHJldmlzaW9uIDApCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9hc2FuL19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEg QEAKKyMgUmVxdWlyZWQgZm9yIFB5dGhvbiB0byBzZWFyY2ggdGhpcyBkaXJlY3RvcnkgZm9yIG1v ZHVsZSBmaWxlcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vYXNhbi91dGls cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9hc2FuL3V0 aWxzLnB5CShyZXZpc2lvbiAwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vYXNh bi91dGlscy5weQkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMzIEBACisjIENvcHlyaWdodCAo QykgMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAor IyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2Ug Y29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMg bGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjIDIuICBS ZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNv cHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZv bGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3Ro ZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMKKyMgVEhJUyBT T0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBg QVMgSVMnJyBBTkQgQU5ZCisjIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJ TkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKKyMgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorIyBE SVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRP UlMgQkUgTElBQkxFIEZPUiBBTlkKKyMgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BF Q0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF UlZJQ0VTOworIyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyMgQU5ZIFRIRU9SWSBPRiBMSUFCSUxJ VFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElO Q0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBP RiBUSEUgVVNFIE9GIFRISVMKKyMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9T U0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKKworQVNBTl9PUFRJT05TID0geworICAgICJhbGxv Y2F0b3JfbWF5X3JldHVybl9udWxsIiA6IDEKK30KKworCitjbGFzcyBBU2FuVXRpbGl0eShvYmpl Y3QpOgorCisgICAgQHN0YXRpY21ldGhvZAorICAgIGRlZiBlbnZpcm9ubWVudF9vcHRpb25zKCk6 CisgICAgICAgIHJldHVybiAnICcuam9pbihba2V5ICsgIj0iICsgc3RyKEFTQU5fT1BUSU9OU1tr ZXldKSBmb3Iga2V5IGluIEFTQU5fT1BUSU9OU10pCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvZHJpdmVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9kcml2ZXIucHkJKHJldmlzaW9uIDE4MTcxMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC9kcml2ZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTM4LDYgKzM4LDcgQEAgaW1wb3J0 IG9zCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0gaW1wb3J0IHBhdGgKIGZyb20gd2Via2l0 cHkuY29tbW9uLnN5c3RlbS5wcm9maWxlciBpbXBvcnQgUHJvZmlsZXJGYWN0b3J5CiBmcm9tIHdl YmtpdHB5LmxheW91dF90ZXN0cy5zZXJ2ZXJzLndlYl9wbGF0Zm9ybV90ZXN0X3NlcnZlciBpbXBv cnQgV2ViUGxhdGZvcm1UZXN0U2VydmVyCitmcm9tIHdlYmtpdHB5LmNvbW1vbi5hc2FuLnV0aWxz IGltcG9ydCBBU2FuVXRpbGl0eQogCiAKIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVf XykKQEAgLTMxNiw2ICszMTcsNyBAQCBjbGFzcyBEcml2ZXIob2JqZWN0KToKICAgICAgICAgI2Vu dmlyb25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10gPSBzdHIoc2VsZi5fcG9ydC5fZHJpdmVy X3RlbXBkaXJfZm9yX2Vudmlyb25tZW50KCkpCiAgICAgICAgIGVudmlyb25tZW50WydEVU1QUkVO REVSVFJFRV9URU1QJ10gPSBzdHIoc2VsZi5fZHJpdmVyX3RlbXBkaXIpCiAgICAgICAgIGVudmly b25tZW50WydMT0NBTF9SRVNPVVJDRV9ST09UJ10gPSBzZWxmLl9wb3J0LmxheW91dF90ZXN0c19k aXIoKQorICAgICAgICBlbnZpcm9ubWVudFsnQVNBTl9PUFRJT05TJ10gPSBBU2FuVXRpbGl0eS5l bnZpcm9ubWVudF9vcHRpb25zKCkKICAgICAgICAgaWYgJ1dFQktJVF9PVVRQVVRESVInIGluIG9z LmVudmlyb246CiAgICAgICAgICAgICBlbnZpcm9ubWVudFsnV0VCS0lUX09VVFBVVERJUiddID0g b3MuZW52aXJvblsnV0VCS0lUX09VVFBVVERJUiddCiAgICAgICAgIGlmIHNlbGYuX3Byb2ZpbGVy Ogo=