142537 2015-03-10 11:46:50 -0700 [GStreamer][GTK] Minimum required version for gst-plugins-base is actually 1.1 2015-03-12 12:32:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez slomo cgarcia commit-queue mrobinson pnormand slomo oldest_to_newest 1076012 0 clopez 2015-03-10 11:46:50 -0700 When finding the GStreamer libraries at Source/cmake/FindGStreamer.cmake the minimum required version for gst-plugins-base is 1.0. However the file Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp includes <gst/app/app.h> which is only available on gst-plugins-base >= 1.1 This include was added on r177085 <http://trac.webkit.org/r177085> So I guess we either need to raise the minimum version required or put some ifdefs. 1076131 1 slomo 2015-03-10 16:33:26 -0700 I'll provide a patch tomorrow to make it work again with 1.0 1076337 2 slomo 2015-03-11 09:18:08 -0700 Actually no, we include 1.2+ headers in various places unconditionally. I would recommend to just do it consistently and then require GStreamer >= 1.2.0. Opinions? I can prepare a patch for cleaning up the includes and the dependency check. 1076349 3 cgarcia 2015-03-11 09:57:45 -0700 (In reply to comment #2) > Actually no, we include 1.2+ headers in various places unconditionally. I > would recommend to just do it consistently and then require GStreamer >= > 1.2.0. > > Opinions? > > I can prepare a patch for cleaning up the includes and the dependency check. We have a policy of not bumping minimum requirements unless it's really needed (or until we break the ABI), so we should make sure it build with 1.0.3, see http://trac.webkit.org/wiki/WebKitGTK/Dependencies 1076351 4 slomo 2015-03-11 10:05:56 -0700 Ok, I can make a patch but I can't really test it. I have no 1.0.x anywhere anymore. So better if someone else does that 1076520 5 clopez 2015-03-11 18:11:01 -0700 (In reply to comment #4) > Ok, I can make a patch but I can't really test it. I have no 1.0.x anywhere > anymore. So better if someone else does that I have a development environment with 1.0.9, I can test the patch with that version. 1076596 6 slomo 2015-03-12 02:40:54 -0700 Awesome, I'll prepare one later today then and make sure it builds with 1.4 at least :) Thanks! 1076617 7 248512 slomo 2015-03-12 06:16:45 -0700 Created attachment 248512 Patch 1076618 8 slomo 2015-03-12 06:17:55 -0700 Please check if this indeed compiles with 1.0 or if anything else is missing. If it fails please paste the compiler errors here :) It builds at least on 1.4.5 with these changes. 1076680 9 clopez 2015-03-12 11:30:12 -0700 I tested it, and it builds fine with 1.0.9. Thanks! 1076685 10 248512 pnormand 2015-03-12 11:44:30 -0700 Comment on attachment 248512 Patch Ok let's land this then :) 1076704 11 248512 commit-queue 2015-03-12 12:32:07 -0700 Comment on attachment 248512 Patch Clearing flags on attachment: 248512 Committed r181449: <http://trac.webkit.org/changeset/181449> 1076705 12 commit-queue 2015-03-12 12:32:12 -0700 All reviewed patches have been landed. Closing bug. 248512 2015-03-12 06:16:45 -0700 2015-03-12 12:32:07 -0700 Patch bug-142537-20150312131831.patch text/plain 5931 slomo U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY1MTEwYWNlMjcyODM4 YTYwYjhlOTUwNzVmZTUyYWQ1NTE3MDY1Zi4uYjdlN2ZiYjg3ODYxYTc3ZGU1M2Y4ZDYxMjczNGFk YmY4YTY1ZTRkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAzLTEyICBTZWJh c3RpYW4gRHLDtmdlICA8c2ViYXN0aWFuQGNlbnRyaWN1bGFyLmNvbT4KKworICAgICAgICBTdG9w IHVzaW5nIHNpbmdsZS1pbmNsdWRlIGhlYWRlcnMgdGhhdCBhcmUgb25seSBhdmFpbGFibGUgc2lu Y2UgR1N0cmVhbWVyID49IDEuMi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQyNTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9EZXN0aW5hdGlv bkdTdHJlYW1lci5jcHA6CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlv RmlsZVJlYWRlckdTdHJlYW1lci5jcHA6CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0cmVh bWVyL0F1ZGlvU291cmNlUHJvdmlkZXJHU3RyZWFtZXIuY3BwOgorICAgICAgICAqIHBsYXRmb3Jt L2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHA6CisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclV0aWxpdGllcy5jcHA6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclV0aWxpdGll cy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdTdHJlYW1l ci5oOgorICAgICAgICBJbnN0ZWFkIG9mIHVzaW5nIHNpbmdsZS1pbmNsdWRlIGhlYWRlcnMgZm9y IHRoZSBHU3RyZWFtZXIgbGlicmFyaWVzLAorICAgICAgICBkaXJlY3RseSBpbmNsdWRlIHRoZSBo ZWFkZXJzIHdlIG5lZWQuIFRoZSBzaW5nbGUtaW5jbHVkZSBoZWFkZXJzIHdlcmUKKyAgICAgICAg b25seSBhZGRlZCBpbiAxLjIsIGFuZCB0aGlzIHdvdWxkIGJlIHRoZSBvbmx5IHJlYXNvbiB3aHkg d2Ugd291bGQKKyAgICAgICAgZGVwZW5kIG9uIDEuMi4KKwogMjAxNS0wMy0xMSAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZm9sbG93 LXVwIGZpeCB0byByMTgxNDI2LiBJbml0aWFsaXplIFRleHRQb3NpdGlvbiB3aXRoIHplcm9zIGlu IGNhc2UgaXQgZ2V0cyB1c2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIu Y3BwCmluZGV4IGYyNGE0MzllMzQwNmJjYmQwYTgxODIyODZhZjgyNzY5Nzk5NjdhMzcuLjUwYzk3 ZWQxNjNmZjM4MTZiNmJlNjYyZGQ5YzFlNjMxODI0NTVhZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9E ZXN0aW5hdGlvbkdTdHJlYW1lci5jcHAKQEAgLTI5LDcgKzI5LDYgQEAKICNpbmNsdWRlICJMb2dn aW5nLmgiCiAjaW5jbHVkZSAiV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuaCIKICNpbmNs dWRlIDxnc3QvZ3N0Lmg+Ci0jaW5jbHVkZSA8Z3N0L3BidXRpbHMvcGJ1dGlscy5oPgogI2luY2x1 ZGUgPHd0Zi9nb2JqZWN0L0dVbmlxdWVQdHIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRmls ZVJlYWRlckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3Ry ZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcAppbmRleCA5NGE5YTk1ZDFlYjNiY2I4 NDc5MGQ4ZjhhZDRjMmM2MzYxNDc4MjBmLi40OTc1ZTZmZGMyZTQ4NjJjOTE4MWYwMDE4ZjQyMjFl YzI2ODgyYWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3Ry ZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcApAQCAt MjcsOSArMjcsOCBAQAogCiAjaW5jbHVkZSA8Z2lvL2dpby5oPgogI2luY2x1ZGUgPGdzdC9hcHAv Z3N0YXBwc2luay5oPgotI2luY2x1ZGUgPGdzdC9hdWRpby9hdWRpby5oPgorI2luY2x1ZGUgPGdz dC9hdWRpby9hdWRpby1pbmZvLmg+CiAjaW5jbHVkZSA8Z3N0L2dzdC5oPgotI2luY2x1ZGUgPGdz dC9wYnV0aWxzL3BidXRpbHMuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNpbmNs dWRlIDx3dGYvZ29iamVjdC9HUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1RocmVh ZFNhZmVNYWluTG9vcFNvdXJjZS5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvU291cmNlUHJvdmlkZXJHU3RyZWFtZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvU291cmNlUHJvdmlkZXJH U3RyZWFtZXIuY3BwCmluZGV4IDg3YWRmYjI3MzdmZjYzYWU4MDAxNDFiN2M2MWY5YzFhNjFiNDY0 NjcuLjA2MmZhYzI3MWVlMjk3YzhhMjdkYjIwMzBhNTMyZjMwMDExOWUxY2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb1NvdXJjZVByb3Zp ZGVyR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3Ry ZWFtZXIvQXVkaW9Tb3VyY2VQcm92aWRlckdTdHJlYW1lci5jcHAKQEAgLTI0LDcgKzI0LDcgQEAK ICNpbmNsdWRlICJBdWRpb0J1cy5oIgogI2luY2x1ZGUgIkF1ZGlvU291cmNlUHJvdmlkZXJDbGll bnQuaCIKICNpbmNsdWRlIDxnc3QvYXBwL2dzdGFwcHNpbmsuaD4KLSNpbmNsdWRlIDxnc3QvYXVk aW8vYXVkaW8uaD4KKyNpbmNsdWRlIDxnc3QvYXVkaW8vYXVkaW8taW5mby5oPgogI2luY2x1ZGUg PGdzdC9iYXNlL2dzdGFkYXB0ZXIuaD4KICNpbmNsdWRlIDx3dGYvZ29iamVjdC9HTXV0ZXhMb2Nr ZXIuaD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVh bWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAK aW5kZXggMjA0MTRhOTBmZmQzNmYyM2QyNGI4N2NmZWFiYWIxZTJkZDdlZGNlYi4uODNiNTc0Yjlj ZDBjNTdlZGJhYmJiNDE5YWFiMWRiODE5OTdjNTgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0 V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC0yNyw5ICsyNyw5IEBACiAjaW5jbHVkZSAi QXVkaW9JT0NhbGxiYWNrLmgiCiAjaW5jbHVkZSAiR1JlZlB0ckdTdHJlYW1lci5oIgogI2luY2x1 ZGUgIkdTdHJlYW1lclV0aWxpdGllcy5oIgotI2luY2x1ZGUgPGdzdC9hcHAvYXBwLmg+Ci0jaW5j bHVkZSA8Z3N0L2F1ZGlvL2F1ZGlvLmg+Ci0jaW5jbHVkZSA8Z3N0L3BidXRpbHMvcGJ1dGlscy5o PgorI2luY2x1ZGUgPGdzdC9hcHAvZ3N0YXBwc3JjLmg+CisjaW5jbHVkZSA8Z3N0L2F1ZGlvL2F1 ZGlvLWluZm8uaD4KKyNpbmNsdWRlIDxnc3QvcGJ1dGlscy9taXNzaW5nLXBsdWdpbnMuaD4KICNp bmNsdWRlIDx3dGYvZ29iamVjdC9HVW5pcXVlUHRyLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJD b3JlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL0dTdHJlYW1lclV0aWxpdGllcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0aWVzLmNwcAppbmRleCA0ZDc3MzVkOWFjMWJi OWQ3MDBjM2I5ZGJjZmMyMDg0Y2I1N2ZjNzJlLi5jMmJlMWI3ZjRkMGM4MjYwYWNkMzM3MWZlNzM4 ZTIxYmQ2ZTE5M2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0aWVzLmNwcApAQCAtMjQs OCArMjQsOSBAQAogCiAjaW5jbHVkZSAiSW50U2l6ZS5oIgogCi0jaW5jbHVkZSA8Z3N0L2F1ZGlv L2F1ZGlvLmg+CisjaW5jbHVkZSA8Z3N0L2F1ZGlvL2F1ZGlvLWluZm8uaD4KICNpbmNsdWRlIDxn c3QvZ3N0Lmg+CisjaW5jbHVkZSA8Z3N0L3ZpZGVvL3ZpZGVvLWluZm8uaD4KICNpbmNsdWRlIDx3 dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dVbmlxdWVQdHIuaD4KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dT dHJlYW1lclV0aWxpdGllcy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL0dTdHJlYW1lclV0aWxpdGllcy5oCmluZGV4IDBlZDMxMzcyNTZjMTcwYjNmZDE5MzAx MGFkZjM0NTc2OTQ2OGNiYWMuLjZhMTJkZTYwNTQ5YzhiNjFjNDJhZWJhNzQ5MmY3ZmEzOGMzYTQ3 OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9HU3RyZWFtZXJVdGlsaXRpZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0aWVzLmgKQEAgLTE5LDcgKzE5LDcgQEAKICNp bmNsdWRlICJMb2dnaW5nLmgiCiAKICNpbmNsdWRlIDxnc3QvZ3N0Lmg+Ci0jaW5jbHVkZSA8Z3N0 L3ZpZGVvL3ZpZGVvLmg+CisjaW5jbHVkZSA8Z3N0L3ZpZGVvL3ZpZGVvLWZvcm1hdC5oPgogCiAj ZGVmaW5lIExPR19NRURJQV9NRVNTQUdFKC4uLikgZG8geyBcCiAgICAgR1NUX0RFQlVHKF9fVkFf QVJHU19fKTsgXApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL0ltYWdlR1N0cmVhbWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvSW1hZ2VHU3RyZWFtZXIuaAppbmRleCAzOTMxYTE5YTc0YjJkODA3Mzdj MmI3YTAxMzNiYThmYWQ4OWFlMWUwLi4xZWNkMzM0YmEwZjI2NjUzZjk0MDZlNDk0YzA2ZjcyOGQz YzBlYzcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvSW1hZ2VHU3RyZWFtZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvSW1hZ2VHU3RyZWFtZXIuaApAQCAtMjcsNyArMjcsNyBAQAogI2luY2x1 ZGUgIkdSZWZQdHJHU3RyZWFtZXIuaCIKIAogI2luY2x1ZGUgPGdzdC9nc3QuaD4KLSNpbmNsdWRl IDxnc3QvdmlkZW8vdmlkZW8uaD4KKyNpbmNsdWRlIDxnc3QvdmlkZW8vdmlkZW8tZnJhbWUuaD4K IAogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQu aD4K