142532 2015-03-10 06:43:04 -0700 [GTK] Contents not correctly laid out when the web view is not realized 2015-07-18 20:23:48 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1075955 0 cgarcia 2015-03-10 06:43:04 -0700 This can be easily reproduced with epiphany: 1- Go to google, and search for something you know will give a youtube link 2- Middle click the youtube link to open a new tab 3- Visit the tab After 3, sometimes the layout of youtube is like if the web view were a lot smaller (like the mobile layout, using a single column). I'm not sure the problem is related to the accelerated compositing mode, I've managed to reproduce the issue disabling AC, it didn't happen that often, but I could still reproduce the problem. So, maybe this is more related with the delayed resize we do when the web view hasn't been mapped yet. 1108545 1 cgarcia 2015-07-09 23:11:00 -0700 *** Bug 146798 has been marked as a duplicate of this bug. *** 1108561 2 256571 cgarcia 2015-07-10 02:42:59 -0700 Created attachment 256571 Patch 1108563 3 commit-queue 2015-07-10 02:44:33 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1108624 4 mcatanzaro 2015-07-10 09:05:20 -0700 Patch works great, thanks! 1108640 5 256571 darin 2015-07-10 09:54:25 -0700 Comment on attachment 256571 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256571&action=review > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:87 > + auto* drawingArea = static_cast<DrawingAreaProxyImpl*>(webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(m_viewWidget))->drawingArea()); Do we have a guarantee that webkitWebViewBaseGetPage never returns null? (If so, perhaps in the future it should return a reference rather than a pointer.) 1109070 6 cgarcia 2015-07-13 00:45:35 -0700 Committed r186761: <http://trac.webkit.org/changeset/186761> 1110426 7 mcatanzaro 2015-07-18 20:23:48 -0700 So far I've found this has fixed: * YouTube video pages * Images in Vox articles * Layout and images in CNN articles And no doubt many more. Also, it made anchor links work. 256571 2015-07-10 02:42:59 -0700 2015-07-10 09:54:25 -0700 Patch wk2-no-resize-on-map.diff text/plain 6070 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwMTFlMjVlLi41NGNjMGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMg QEAKKzIwMTUtMDctMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIENvbnRlbnRzIG5vdCBjb3JyZWN0bHkgbGFpZCBvdXQgd2hlbiB0 aGUgd2ViIHZpZXcgaXMgbm90IHJlYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IHdlIGFyZSBub3QgcmVwb3J0 aW5nIGFueSBzaXplIHVudGlsIHRoZSB3ZWIKKyAgICAgICAgdmlldyBpcyByZWFsaXplZCwgc28g YW55IHdlYiB2aWV3IGxvYWRlZCBpbiBhIHNlcGFyYXRlIHRhYiBpbiB0aGUKKyAgICAgICAgYnJv d3Nlciwgd2lsbCByZXBvcnQgMHgwIGFzIHRoZSB3aW5kb3cuaW5uZXJXaWR0aCwKKyAgICAgICAg d2luZG93LmlubmVySGVpZ2h0IHVudGlsIHRoZSB2aWV3IGlzIHJlYWxpemVkLiBXZWJzaXRlcyB0 aGF0IHVzZQorICAgICAgICB0aGUgd2luZG93LmlubmVyV2lkdGgvaW5uZXJIZWlnaHQgZHVyaW5n IHRoZSBwYWdlIGxvYWQgdG8gZGVjaWRlCisgICAgICAgIGhvdyB0byBsYXkgb3V0IHRoZSBjb250 ZW50cyB3aWxsIGJlIHJlbmRlcmVkIHdyb25nbHkuCisgICAgICAgIEkgaGF2ZW4ndCBiZWVuIGFi bGUgdG8gcmVwcm9kdWNlIHRoaXMgd2l0aCB1bml0IHRlc3RzLCBhcyB0aGlzCisgICAgICAgIHJl cXVpcmVzIHRoZSBwYXJ0aWN1bGFyIGNhc2Ugb2Ygc2FtZSB3aW5kb3cgYnV0IGRpZmZlcmVudCB3 ZWIKKyAgICAgICAgdmlld3MgdXNpbmcgdGFicyBmb3IgZXhhbXBsZS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFn ZUNsaWVudEltcGw6OnZpZXdTaXplKTogQWx3YXlzIHJlcG9ydCB0aGUgZHJhd2luZyBhcmVhCisg ICAgICAgIHNpemUgdG8gbWFrZSB1c3JlIGl0J3MgaW4gc3luYyB3aXRoIHRoZSBXZWJQcm9jZXNz IHBhZ2Ugc2l6ZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVNpemVBbGxvY2F0ZSk6IFJlbW92ZSB0 aGUgb3B0aW1pemF0aW9uIG9mIG9ubHkKKyAgICAgICAgcmVwb3J0IHRoZSBzaXplIHdoZW4gaXQg aGFzIGNoYW5nZWQsIHNpbmNlIGJvdGggdGhlIHJlZGlyZWN0ZWQKKyAgICAgICAgd2luZG93IGFu ZCB0aGUgZHJhd2luZyBhcmVhIGFscmVhZHkgZG8gdGhhdCBjaGVjay4gQWxzbyByZW1vdmUgdGhl CisgICAgICAgIG9wdGltaXphdGlvbiBvZiB3YWl0aW5nIHVudGlsIHRoZSB2aWV3IGlzIG1hcHBl ZCB0byByZXBvcnQgaXRzCisgICAgICAgIHNpemUsIHNpbmNlIHRoYXQncyBvZnRlbiB0b28gbGF0 ZSBmb3Igd2Vic2l0ZXMgdXNpbmcgdGhlIHdpbmRvdworICAgICAgICBzaXplIGR1cmluZyBsb2Fk LgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VNYXApOiBOZXZlciByZXBvcnQgc2l6ZSBvbiBt YXAsIGl0IHNob3VsZCBoYXZlCisgICAgICAgIGFscmVhZHkgYmVlbiByZXBvcnRlZCBieSBzaXpl LWFsbG9jYXRlLgorCiAyMDE1LTA3LTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgQVBJIHRvIGFsbG93IGV4ZWN1dGluZyBl ZGl0aW5nIGNvbW1hbmRzIHRoYXQgcmVxdWlyZSBhbiBhcmd1bWVudApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IGQ2NDli NGEuLmE0ZTUyYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1BhZ2VDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9QYWdlQ2xpZW50SW1wbC5jcHAKQEAgLTg0LDExICs4NCw4IEBAIHZvaWQgUGFnZUNsaWVudElt cGw6OnJlcXVlc3RTY3JvbGwoY29uc3QgV2ViQ29yZTo6RmxvYXRQb2ludCYsIGJvb2wpCiAKIFdl YkNvcmU6OkludFNpemUgUGFnZUNsaWVudEltcGw6OnZpZXdTaXplKCkKIHsKLSAgICBpZiAoIWd0 a193aWRnZXRfZ2V0X3JlYWxpemVkKG1fdmlld1dpZGdldCkpCi0gICAgICAgIHJldHVybiBJbnRT aXplKCk7Ci0gICAgR3RrQWxsb2NhdGlvbiBhbGxvY2F0aW9uOwotICAgIGd0a193aWRnZXRfZ2V0 X2FsbG9jYXRpb24obV92aWV3V2lkZ2V0LCAmYWxsb2NhdGlvbik7Ci0gICAgcmV0dXJuIEludFNp emUoYWxsb2NhdGlvbi53aWR0aCwgYWxsb2NhdGlvbi5oZWlnaHQpOworICAgIGF1dG8qIGRyYXdp bmdBcmVhID0gc3RhdGljX2Nhc3Q8RHJhd2luZ0FyZWFQcm94eUltcGwqPih3ZWJraXRXZWJWaWV3 QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0UobV92aWV3V2lkZ2V0KSktPmRyYXdpbmdB cmVhKCkpOworICAgIHJldHVybiBkcmF3aW5nQXJlYSA/IGRyYXdpbmdBcmVhLT5zaXplKCkgOiBJ bnRTaXplKCk7CiB9CiAKIGJvb2wgUGFnZUNsaWVudEltcGw6OmlzVmlld1dpbmRvd0FjdGl2ZSgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3QmFzZS5jcHAKaW5kZXggNmY3M2Y0NC4uYzUzY2Q0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMTU1 LDcgKzE1NSw2IEBAIHN0cnVjdCBfV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlIHsKICAgICBDU3Ry aW5nIHRvb2x0aXBUZXh0OwogICAgIEludFJlY3QgdG9vbHRpcEFyZWE7CiAgICAgR1JlZlB0cjxB dGtPYmplY3Q+IGFjY2Vzc2libGU7Ci0gICAgYm9vbCBuZWVkc1Jlc2l6ZU9uTWFwOwogICAgIEd0 a1dpZGdldCogYXV0aGVudGljYXRpb25EaWFsb2c7CiAgICAgR3RrV2lkZ2V0KiBpbnNwZWN0b3JW aWV3OwogICAgIEF0dGFjaG1lbnRTaWRlIGluc3BlY3RvckF0dGFjaG1lbnRTaWRlOwpAQCAtNTUx LDggKzU1MCwxMSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUNoaWxkQWxsb2NhdGUo R3RrV2lkZ2V0KiBjaGlsZCwgZ3BvaW50ZXIgdXNlckRhdGEpCiAgICAgcHJpdi0+Y2hpbGRyZW4u c2V0KGNoaWxkLCBJbnRSZWN0KCkpOwogfQogCi1zdGF0aWMgdm9pZCByZXNpemVXZWJLaXRXZWJW aWV3QmFzZUZyb21BbGxvY2F0aW9uKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgR3Rr QWxsb2NhdGlvbiogYWxsb2NhdGlvbiwgYm9vbCBzaXplQ2hhbmdlZCkKK3N0YXRpYyB2b2lkIHdl YmtpdFdlYlZpZXdCYXNlU2l6ZUFsbG9jYXRlKEd0a1dpZGdldCogd2lkZ2V0LCBHdGtBbGxvY2F0 aW9uKiBhbGxvY2F0aW9uKQogeworICAgIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3 X2Jhc2VfcGFyZW50X2NsYXNzKS0+c2l6ZV9hbGxvY2F0ZSh3aWRnZXQsIGFsbG9jYXRpb24pOwor CisgICAgV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlID0gV0VCS0lUX1dFQl9WSUVXX0JB U0Uod2lkZ2V0KTsKICAgICBndGtfY29udGFpbmVyX2ZvcmVhY2goR1RLX0NPTlRBSU5FUih3ZWJW aWV3QmFzZSksIHdlYmtpdFdlYlZpZXdCYXNlQ2hpbGRBbGxvY2F0ZSwgd2ViVmlld0Jhc2UpOwog CiAgICAgSW50UmVjdCB2aWV3UmVjdChhbGxvY2F0aW9uLT54LCBhbGxvY2F0aW9uLT55LCBhbGxv Y2F0aW9uLT53aWR0aCwgYWxsb2NhdGlvbi0+aGVpZ2h0KTsKQEAgLTU5NCwzMiArNTk2LDE2IEBA IHN0YXRpYyB2b2lkIHJlc2l6ZVdlYktpdFdlYlZpZXdCYXNlRnJvbUFsbG9jYXRpb24oV2ViS2l0 V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlCiAgICAgfQogCiAgICAgRHJhd2luZ0FyZWFQcm94eUlt cGwqIGRyYXdpbmdBcmVhID0gc3RhdGljX2Nhc3Q8RHJhd2luZ0FyZWFQcm94eUltcGwqPihwcml2 LT5wYWdlUHJveHktPmRyYXdpbmdBcmVhKCkpOworICAgIGlmICghZHJhd2luZ0FyZWEpCisgICAg ICAgIHJldHVybjsKKwogCiAjaWYgVVNFKFJFRElSRUNURURfWENPTVBPU0lURV9XSU5ET1cpCi0g ICAgaWYgKHNpemVDaGFuZ2VkICYmIHByaXYtPnJlZGlyZWN0ZWRXaW5kb3cgJiYgZHJhd2luZ0Fy ZWEgJiYgZHJhd2luZ0FyZWEtPmlzSW5BY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZSgpKQorICAg IGlmIChwcml2LT5yZWRpcmVjdGVkV2luZG93ICYmIGRyYXdpbmdBcmVhLT5pc0luQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGUoKSkKICAgICAgICAgcHJpdi0+cmVkaXJlY3RlZFdpbmRvdy0+cmVz aXplKHZpZXdSZWN0LnNpemUoKSk7Ci0jZWxzZQotICAgIFVOVVNFRF9QQVJBTShzaXplQ2hhbmdl ZCk7CiAjZW5kaWYKIAotICAgIGlmIChkcmF3aW5nQXJlYSkKLSAgICAgICAgZHJhd2luZ0FyZWEt PnNldFNpemUodmlld1JlY3Quc2l6ZSgpLCBJbnRTaXplKCksIEludFNpemUoKSk7Ci19Ci0KLXN0 YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlU2l6ZUFsbG9jYXRlKEd0a1dpZGdldCogd2lkZ2V0 LCBHdGtBbGxvY2F0aW9uKiBhbGxvY2F0aW9uKQotewotICAgIGJvb2wgc2l6ZUNoYW5nZWQgPSBn dGtfd2lkZ2V0X2dldF9hbGxvY2F0ZWRfd2lkdGgod2lkZ2V0KSAhPSBhbGxvY2F0aW9uLT53aWR0 aAotICAgICAgICAgICAgICAgICAgICAgICB8fCBndGtfd2lkZ2V0X2dldF9hbGxvY2F0ZWRfaGVp Z2h0KHdpZGdldCkgIT0gYWxsb2NhdGlvbi0+aGVpZ2h0OwotCi0gICAgR1RLX1dJREdFVF9DTEFT Uyh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9wYXJlbnRfY2xhc3MpLT5zaXplX2FsbG9jYXRlKHdpZGdl dCwgYWxsb2NhdGlvbik7Ci0KLSAgICBXZWJLaXRXZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UgPSBX RUJLSVRfV0VCX1ZJRVdfQkFTRSh3aWRnZXQpOwotICAgIGlmIChzaXplQ2hhbmdlZCAmJiAhZ3Rr X3dpZGdldF9nZXRfbWFwcGVkKHdpZGdldCkpIHsKLSAgICAgICAgd2ViVmlld0Jhc2UtPnByaXYt Pm5lZWRzUmVzaXplT25NYXAgPSB0cnVlOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAg cmVzaXplV2ViS2l0V2ViVmlld0Jhc2VGcm9tQWxsb2NhdGlvbih3ZWJWaWV3QmFzZSwgYWxsb2Nh dGlvbiwgc2l6ZUNoYW5nZWQpOworICAgIGRyYXdpbmdBcmVhLT5zZXRTaXplKHZpZXdSZWN0LnNp emUoKSwgSW50U2l6ZSgpLCBJbnRTaXplKCkpOwogfQogCiBzdGF0aWMgdm9pZCB3ZWJraXRXZWJW aWV3QmFzZU1hcChHdGtXaWRnZXQqIHdpZGdldCkKQEAgLTYzMiwxNCArNjE4LDYgQEAgc3RhdGlj IHZvaWQgd2Via2l0V2ViVmlld0Jhc2VNYXAoR3RrV2lkZ2V0KiB3aWRnZXQpCiAgICAgICAgIHBy aXYtPmlzVmlzaWJsZSA9IHRydWU7CiAgICAgICAgIHByaXYtPnBhZ2VQcm94eS0+dmlld1N0YXRl RGlkQ2hhbmdlKFZpZXdTdGF0ZTo6SXNWaXNpYmxlKTsKICAgICB9Ci0KLSAgICBpZiAoIXByaXYt Pm5lZWRzUmVzaXplT25NYXApCi0gICAgICAgIHJldHVybjsKLQotICAgIEd0a0FsbG9jYXRpb24g YWxsb2NhdGlvbjsKLSAgICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKHdpZGdldCwgJmFsbG9j YXRpb24pOwotICAgIHJlc2l6ZVdlYktpdFdlYlZpZXdCYXNlRnJvbUFsbG9jYXRpb24od2ViVmll d0Jhc2UsICZhbGxvY2F0aW9uLCB0cnVlIC8qIHNpemVDaGFuZ2VkICovKTsKLSAgICBwcml2LT5u ZWVkc1Jlc2l6ZU9uTWFwID0gZmFsc2U7CiB9CiAKIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdC YXNlVW5tYXAoR3RrV2lkZ2V0KiB3aWRnZXQpCg==