142529 2015-03-10 03:10:02 -0700 [GTK] GL_MAX_VARYING_FLOATS is not defined in OpenGL ES 2 2015-03-10 06:27:10 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue dino jdapena kondapallykalyan noam roger_fong zan oldest_to_newest 1075933 0 cgarcia 2015-03-10 03:10:02 -0700 In GraphicsContext3DOpenGLCommon.cpp is used protected by #if !PLATFORM(IOS) && !(PLATFORM(WIN) && USE(OPENGL_ES_2)) but I don't think GL_MAX_VARYING_FLOATS is available when using GLES2 in any other platforms 1075934 1 zan 2015-03-10 03:14:11 -0700 (In reply to comment #0) > In GraphicsContext3DOpenGLCommon.cpp is used protected by > > #if !PLATFORM(IOS) && !(PLATFORM(WIN) && USE(OPENGL_ES_2)) > > but I don't think GL_MAX_VARYING_FLOATS is available when using GLES2 in any > other platforms PLATFORM(WIN) => (PLATFORM(WIN) || PLATFORM(GTK)) I guess. 1075935 2 cgarcia 2015-03-10 03:17:23 -0700 (In reply to comment #1) > (In reply to comment #0) > > In GraphicsContext3DOpenGLCommon.cpp is used protected by > > > > #if !PLATFORM(IOS) && !(PLATFORM(WIN) && USE(OPENGL_ES_2)) > > > > but I don't think GL_MAX_VARYING_FLOATS is available when using GLES2 in any > > other platforms > > PLATFORM(WIN) => (PLATFORM(WIN) || PLATFORM(GTK)) I guess. Or simply #if !PLATFORM(IOS) && !USE(OPENGL_ES_2) ? or am I wrong assuming GL_MAX_VARYING_FLOATS is ot available in OpenGL ES 2? 1075937 3 cgarcia 2015-03-10 03:28:11 -0700 I'll use PLATFORM(GTK) just in case to avoid breaking EFL 1075938 4 248325 cgarcia 2015-03-10 03:29:45 -0700 Created attachment 248325 Patch 1075952 5 cgarcia 2015-03-10 06:27:10 -0700 Committed r181323: <http://trac.webkit.org/changeset/181323> 248325 2015-03-10 03:29:45 -0700 2015-03-10 04:10:37 -0700 Patch wk-max-varying-floats.diff text/plain 1528 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYWM2M2FiLi42YzI2NzZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMDMtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEdMX01BWF9WQVJZSU5HX0ZMT0FUUyBpcyBub3QgZGVmaW5lZCBp biBPcGVuR0wgRVMgMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQyNTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRG8gbm90IHVzZSBHTF9NQVhfVkFSWUlOR19GTE9BVFMgd2hlbiBwbGF0Zm9ybSBpcyBH VEsrIGFuZCB1c2luZworICAgICAgICBPcGVuR0wgRVMgMi4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Y2hlY2tWYXJ5aW5nc1BhY2tpbmcpOgor CiAyMDE1LTAzLTEwICBKb3PDqSBEYXBlbmEgUGF6ICA8amRhcGVuYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQuIEZpeCBHVEsrIGJ1aWxkIHdpdGggT3BlbkdMIEVTIDIgZW5hYmxl ZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9H cmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCmluZGV4 IDg5MGMxNjcuLmMyYmNjNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3Bl bkdMQ29tbW9uLmNwcApAQCAtMzc4LDcgKzM3OCw3IEBAIGJvb2wgR3JhcGhpY3NDb250ZXh0M0Q6 OmNoZWNrVmFyeWluZ3NQYWNraW5nKFBsYXRmb3JtM0RPYmplY3QgdmVydGV4U2hhZGVyLCBQbGF0 CiAgICAgfQogCiAgICAgR0MzRGludCBtYXhWYXJ5aW5nVmVjdG9ycyA9IDA7Ci0jaWYgIVBMQVRG T1JNKElPUykgJiYgIShQTEFURk9STShXSU4pICYmIFVTRShPUEVOR0xfRVNfMikpCisjaWYgIVBM QVRGT1JNKElPUykgJiYgISgoUExBVEZPUk0oV0lOKSB8fCBQTEFURk9STShHVEspKSAmJiBVU0Uo T1BFTkdMX0VTXzIpKQogICAgIEdDM0RpbnQgbWF4VmFyeWluZ0Zsb2F0cyA9IDA7CiAgICAgOjpn bEdldEludGVnZXJ2KEdMX01BWF9WQVJZSU5HX0ZMT0FUUywgJm1heFZhcnlpbmdGbG9hdHMpOwog ICAgIG1heFZhcnlpbmdWZWN0b3JzID0gbWF4VmFyeWluZ0Zsb2F0cyAvIDQ7Cg==