142517 2015-03-09 17:32:50 -0700 Assertion in ScrollController::processWheelEventForScrollSnapOnAxis when scrolling with mechanical wheel mouse 2015-03-09 18:00:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 1075824 0 bfulgham 2015-03-09 17:32:50 -0700 In Bug 141973 (<https://trac.webkit.org/changeset/180987>) I introduced a regression for mechanical wheel mice users. After my change, WebKit always creates a snap scroll animation state context, which triggers new scroll snap point logic when processing wheel events. If you work with a mechanical wheel mouse, the scroll snap point handler does not understand the gesture (since mechanical mice only produce "stateless" wheel events), and complains via an assertion. 1075825 1 bfulgham 2015-03-09 17:33:17 -0700 <rdar://problem/20088167> 1075827 2 bfulgham 2015-03-09 17:35:35 -0700 Note: additional work for mechanical wheel mice is being done under Bug 142501. 1075832 3 248301 bfulgham 2015-03-09 17:38:09 -0700 Created attachment 248301 Patch 1075835 4 248302 bfulgham 2015-03-09 17:47:16 -0700 Created attachment 248302 Patch 1075839 5 bfulgham 2015-03-09 18:00:41 -0700 Committed r181300: <http://trac.webkit.org/changeset/181300> 248301 2015-03-09 17:38:09 -0700 2015-03-09 17:47:14 -0700 Patch bug-142517-20150309173746.patch text/plain 2011 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTI5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAzLTA5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBpbiBTY3Jv bGxDb250cm9sbGVyOjpwcm9jZXNzV2hlZWxFdmVudEZvclNjcm9sbFNuYXBPbkF4aXMgd2hlbiBz Y3JvbGxpbmcgd2l0aCBtZWNoYW5pY2FsIHdoZWVsIG1vdXNlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1MTcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRy b2xsZXIubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxDb250cm9sbGVyOjp1cGRhdGVTY3Jv bGxTbmFwUG9pbnRzKTogRG9uJ3QgYmVnaW4gdHJhY2tpbmcgc2Nyb2xsIHNuYXAgc3RhdGUgaWYg dGhlcmUgaXMgbm90CisgICAgICAgIHNjcm9sbCBzbmFwIHBvaW50IGRlZmluZWQgaW4gdGhlIG1h cmt1cC4KKwogMjAxNS0wMy0wOSAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE3Njk3OCk6IElubGluZS1ibG9ja3Mgd2l0aCBv dmVyZmxvd2luZyBjb250ZW50cyBoYXZlIGFzY2VudHMgdGhhdCBhcmUgdG9vIGxhcmdlCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9TY3JvbGxDb250cm9sbGVyLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRyb2xsZXIu bW0JKHJldmlzaW9uIDE4MTI3MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1Nj cm9sbENvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTU4OCwxMCArNTg4LDEwIEBAIHZv aWQgU2Nyb2xsQ29udHJvbGxlcjo6dXBkYXRlU2Nyb2xsU25hcFAKIHsKICAgICAvLyBGSVhNRTog Q3VycmVudGx5LCBzY3JvbGwgc25hcCBhbmltYXRvcnMgYXJlIHJlY3JlYXRlZCBldmVuIHRob3Vn aCB0aGUgc25hcCBvZmZzZXRzIGFsb25lIGNhbiBiZSB1cGRhdGVkLgogICAgIGlmIChheGlzID09 IFNjcm9sbEV2ZW50QXhpczo6SG9yaXpvbnRhbCkKLSAgICAgICAgbV9ob3Jpem9udGFsU2Nyb2xs U25hcFN0YXRlID0gc3RkOjptYWtlX3VuaXF1ZTxTY3JvbGxTbmFwQW5pbWF0b3JTdGF0ZT4oU2Ny b2xsRXZlbnRBeGlzOjpIb3Jpem9udGFsLCBzbmFwUG9pbnRzKTsKKyAgICAgICAgbV9ob3Jpem9u dGFsU2Nyb2xsU25hcFN0YXRlID0gIXNuYXBQb2ludHMuaXNFbXB0eSgpID8gc3RkOjptYWtlX3Vu aXF1ZTxTY3JvbGxTbmFwQW5pbWF0b3JTdGF0ZT4oU2Nyb2xsRXZlbnRBeGlzOjpIb3Jpem9udGFs LCBzbmFwUG9pbnRzKSA6IG51bGxwdHI7CiAKICAgICBpZiAoYXhpcyA9PSBTY3JvbGxFdmVudEF4 aXM6OlZlcnRpY2FsKQotICAgICAgICBtX3ZlcnRpY2FsU2Nyb2xsU25hcFN0YXRlID0gc3RkOjpt YWtlX3VuaXF1ZTxTY3JvbGxTbmFwQW5pbWF0b3JTdGF0ZT4oU2Nyb2xsRXZlbnRBeGlzOjpWZXJ0 aWNhbCwgc25hcFBvaW50cyk7CisgICAgICAgIG1fdmVydGljYWxTY3JvbGxTbmFwU3RhdGUgPSAh c25hcFBvaW50cy5pc0VtcHR5KCkgPyBzdGQ6Om1ha2VfdW5pcXVlPFNjcm9sbFNuYXBBbmltYXRv clN0YXRlPihTY3JvbGxFdmVudEF4aXM6OlZlcnRpY2FsLCBzbmFwUG9pbnRzKSA6IG51bGxwdHI7 CiB9CiAKIHZvaWQgU2Nyb2xsQ29udHJvbGxlcjo6c3RhcnRTY3JvbGxTbmFwVGltZXIoU2Nyb2xs RXZlbnRBeGlzIGF4aXMpCg== 248302 2015-03-09 17:47:16 -0700 2015-03-09 17:49:31 -0700 Patch bug-142517-20150309174652.patch text/plain 3374 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTI5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTA5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBpbiBTY3Jv bGxDb250cm9sbGVyOjpwcm9jZXNzV2hlZWxFdmVudEZvclNjcm9sbFNuYXBPbkF4aXMgd2hlbiBz Y3JvbGxpbmcgd2l0aCBtZWNoYW5pY2FsIHdoZWVsIG1vdXNlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1MTcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRy b2xsZXIubW06CisgICAgICAgIChXZWJDb3JlOjp0b1doZWVsRXZlbnRTdGF0dXMpOiBSZWNvZ25p emUgc3RhdGVsZXNzIG1lY2hhbmljYWwgd2hlZWwgZXZlbnRzLgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsQ29udHJvbGxlcjo6cHJvY2Vzc1doZWVsRXZlbnRGb3JTY3JvbGxTbmFwT25BeGlzKTog SWYgYSBtZWNoYW5pY2FsIHdoZWVsIGV2ZW50IGlzIHByb2Nlc3NlZCB3aGlsZQorICAgICAgICBj b25zaWRlcmluZyBzY3JvbGwgc25hcCBsb2dpYywgZW5kIGFueSBzbmFwIGFuaW1hdGlvbnMgYW5k IGNsZWFuIHVwLgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQ29udHJvbGxlcjo6dXBkYXRlU2Ny b2xsU25hcFBvaW50cyk6IERvbid0IGJlZ2luIHRyYWNraW5nIHNjcm9sbCBzbmFwIHN0YXRlIGlm IHRoZXJlIGlzIG5vdAorICAgICAgICBzY3JvbGwgc25hcCBwb2ludCBkZWZpbmVkIGluIHRoZSBt YXJrdXAuCisKIDIwMTUtMDMtMDkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNzY5NzgpOiBJbmxpbmUtYmxvY2tzIHdpdGgg b3ZlcmZsb3dpbmcgY29udGVudHMgaGF2ZSBhc2NlbnRzIHRoYXQgYXJlIHRvbyBsYXJnZQpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvU2Nyb2xsQ29udHJvbGxlci5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9TY3JvbGxDb250cm9sbGVy Lm1tCShyZXZpc2lvbiAxODEyNzIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9T Y3JvbGxDb250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5MCw3IEBAIGVudW0g Y2xhc3MgV2hlZWxFdmVudFN0YXR1cyB7CiAgICAgSW5lcnRpYWxTY3JvbGxCZWdpbiwKICAgICBJ bmVydGlhbFNjcm9sbGluZywKICAgICBJbmVydGlhbFNjcm9sbEVuZCwKKyAgICBTdGF0ZWxlc3NT Y3JvbGxFdmVudCwKICAgICBVbmtub3duCiB9OwogCkBAIC00NzYsNyArNDc3LDEwIEBAIHN0YXRp YyBpbmxpbmUgV2hlZWxFdmVudFN0YXR1cyB0b1doZWVsRXYKICAgICAgICAgICAgICAgICAKICAg ICAgICAgY2FzZSBQbGF0Zm9ybVdoZWVsRXZlbnRQaGFzZUVuZGVkOgogICAgICAgICAgICAgcmV0 dXJuIFdoZWVsRXZlbnRTdGF0dXM6OkluZXJ0aWFsU2Nyb2xsRW5kOwotICAgICAgICAgICAgICAg IAorCisgICAgICAgIGNhc2UgUGxhdGZvcm1XaGVlbEV2ZW50UGhhc2VOb25lOgorICAgICAgICAg ICAgcmV0dXJuIFdoZWVsRXZlbnRTdGF0dXM6OlN0YXRlbGVzc1Njcm9sbEV2ZW50OworCiAgICAg ICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICByZXR1cm4gV2hlZWxFdmVudFN0YXR1czo6VW5rbm93 bjsKICAgICAgICAgfQpAQCAtNTQwLDcgKzU0NCwxMyBAQCB2b2lkIFNjcm9sbENvbnRyb2xsZXI6 OnByb2Nlc3NXaGVlbEV2ZW50CiAgICAgICAgIHNuYXBTdGF0ZS5jbGVhckluaXRpYWxXaGVlbERl bHRhV2luZG93KCk7CiAgICAgICAgIHNuYXBTdGF0ZS5tX3Nob3VsZE92ZXJyaWRlV2hlZWxFdmVu dCA9IGZhbHNlOwogICAgICAgICBicmVhazsKLSAgICAgICAgCisKKyAgICBjYXNlIFdoZWVsRXZl bnRTdGF0dXM6OlN0YXRlbGVzc1Njcm9sbEV2ZW50OgorICAgICAgICBlbmRTY3JvbGxTbmFwQW5p bWF0aW9uKGF4aXMsIFNjcm9sbFNuYXBTdGF0ZTo6VXNlckludGVyYWN0aW9uKTsKKyAgICAgICAg c25hcFN0YXRlLmNsZWFySW5pdGlhbFdoZWVsRGVsdGFXaW5kb3coKTsKKyAgICAgICAgc25hcFN0 YXRlLm1fc2hvdWxkT3ZlcnJpZGVXaGVlbEV2ZW50ID0gZmFsc2U7CisgICAgICAgIGJyZWFrOwor CiAgICAgY2FzZSBXaGVlbEV2ZW50U3RhdHVzOjpVbmtub3duOgogICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKICAgICAgICAgYnJlYWs7CkBAIC01ODgsMTAgKzU5OCwxMCBAQCB2b2lkIFNj cm9sbENvbnRyb2xsZXI6OnVwZGF0ZVNjcm9sbFNuYXBQCiB7CiAgICAgLy8gRklYTUU6IEN1cnJl bnRseSwgc2Nyb2xsIHNuYXAgYW5pbWF0b3JzIGFyZSByZWNyZWF0ZWQgZXZlbiB0aG91Z2ggdGhl IHNuYXAgb2Zmc2V0cyBhbG9uZSBjYW4gYmUgdXBkYXRlZC4KICAgICBpZiAoYXhpcyA9PSBTY3Jv bGxFdmVudEF4aXM6Okhvcml6b250YWwpCi0gICAgICAgIG1faG9yaXpvbnRhbFNjcm9sbFNuYXBT dGF0ZSA9IHN0ZDo6bWFrZV91bmlxdWU8U2Nyb2xsU25hcEFuaW1hdG9yU3RhdGU+KFNjcm9sbEV2 ZW50QXhpczo6SG9yaXpvbnRhbCwgc25hcFBvaW50cyk7CisgICAgICAgIG1faG9yaXpvbnRhbFNj cm9sbFNuYXBTdGF0ZSA9ICFzbmFwUG9pbnRzLmlzRW1wdHkoKSA/IHN0ZDo6bWFrZV91bmlxdWU8 U2Nyb2xsU25hcEFuaW1hdG9yU3RhdGU+KFNjcm9sbEV2ZW50QXhpczo6SG9yaXpvbnRhbCwgc25h cFBvaW50cykgOiBudWxscHRyOwogCiAgICAgaWYgKGF4aXMgPT0gU2Nyb2xsRXZlbnRBeGlzOjpW ZXJ0aWNhbCkKLSAgICAgICAgbV92ZXJ0aWNhbFNjcm9sbFNuYXBTdGF0ZSA9IHN0ZDo6bWFrZV91 bmlxdWU8U2Nyb2xsU25hcEFuaW1hdG9yU3RhdGU+KFNjcm9sbEV2ZW50QXhpczo6VmVydGljYWws IHNuYXBQb2ludHMpOworICAgICAgICBtX3ZlcnRpY2FsU2Nyb2xsU25hcFN0YXRlID0gIXNuYXBQ b2ludHMuaXNFbXB0eSgpID8gc3RkOjptYWtlX3VuaXF1ZTxTY3JvbGxTbmFwQW5pbWF0b3JTdGF0 ZT4oU2Nyb2xsRXZlbnRBeGlzOjpWZXJ0aWNhbCwgc25hcFBvaW50cykgOiBudWxscHRyOwogfQog CiB2b2lkIFNjcm9sbENvbnRyb2xsZXI6OnN0YXJ0U2Nyb2xsU25hcFRpbWVyKFNjcm9sbEV2ZW50 QXhpcyBheGlzKQo=