142515 2015-03-09 17:09:01 -0700 [Content Filtering] Give ContentFilter subclasses private constructors, and make them fast-allocated and non-copyable 2015-03-09 18:39:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128858 1 aestes aestes kling oldest_to_newest 1075816 0 aestes 2015-03-09 17:09:01 -0700 [Content Filtering] Give ContentFilter subclasses private constructors, and make them fast-allocated and non-copyable 1075819 1 248292 aestes 2015-03-09 17:10:53 -0700 Created attachment 248292 Patch 1075847 2 248292 kling 2015-03-09 18:37:11 -0700 Comment on attachment 248292 Patch r=me 1075849 3 aestes 2015-03-09 18:39:17 -0700 Committed r181302: <http://trac.webkit.org/changeset/181302> 248292 2015-03-09 17:10:53 -0700 2015-03-09 18:37:11 -0700 Patch bug-142515-20150309171029.patch text/plain 4425 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM2MDVmYTJlODI0MmVk NjA5ZTJlOWE2YjIzYmNmMjYyZmQzYTY5OS4uZDk5OTg4NzE2NDRiNTNmNGZlNGE5YjJhZWZmYzIz OWNhYzYxOTBjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTAzLTA5ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBbQ29udGVudCBGaWx0ZXJpbmdd IEdpdmUgQ29udGVudEZpbHRlciBzdWJjbGFzc2VzIHByaXZhdGUgY29uc3RydWN0b3JzLCBhbmQg bWFrZSB0aGVtIGZhc3QtYWxsb2NhdGVkIGFuZCBub24tY29weWFibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjUxNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY29jb2EvTmV0d29y a0V4dGVuc2lvbkNvbnRlbnRGaWx0ZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9QYXJl bnRhbENvbnRyb2xzQ29udGVudEZpbHRlci5oOgorICAgICAgICAqIHRlc3RpbmcvTW9ja0NvbnRl bnRGaWx0ZXIuaDoKKworMjAxNS0wMy0wOSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+ CisKICAgICAgICAgW0NvbnRlbnQgRmlsdGVyaW5nXSBBZGQgdGVzdHMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjQ3NQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9OZXR3b3JrRXh0ZW5zaW9uQ29udGVudEZpbHRl ci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvTmV0d29ya0V4dGVuc2lvbkNvbnRl bnRGaWx0ZXIuaAppbmRleCBmMzhlNjU3Njg0N2RlY2YzZTU4MGNhNWYyNDc4Nzc1NDNiN2YyYjkw Li40NjQwNzYyMDk5N2VlM2Y3MjllMTFiMmU2NzhjOTQ2ZGY2ZTdiZGY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9OZXR3b3JrRXh0ZW5zaW9uQ29udGVudEZpbHRl ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL05ldHdvcmtFeHRlbnNpb25D b250ZW50RmlsdGVyLmgKQEAgLTM4LDEzICszOCwxNSBAQCBPQkpDX0NMQVNTIE5TTXV0YWJsZURh dGE7CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIE5ldHdvcmtFeHRlbnNpb25Db250ZW50 RmlsdGVyIGZpbmFsIDogcHVibGljIENvbnRlbnRGaWx0ZXIgeworICAgIFdURl9NQUtFX0ZBU1Rf QUxMT0NBVEVEOworICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKE5ldHdvcmtFeHRlbnNpb25Db250 ZW50RmlsdGVyKTsKKyAgICBmcmllbmQgc3RkOjp1bmlxdWVfcHRyPE5ldHdvcmtFeHRlbnNpb25D b250ZW50RmlsdGVyPiBzdGQ6Om1ha2VfdW5pcXVlPE5ldHdvcmtFeHRlbnNpb25Db250ZW50Rmls dGVyPihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJik7CisKIHB1YmxpYzoKICAgICBzdGF0aWMgYm9v bCBjYW5IYW5kbGVSZXNwb25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJik7CiAgICAgc3RhdGlj IHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrRXh0ZW5zaW9uQ29udGVudEZpbHRlcj4gY3JlYXRlKGNv bnN0IFJlc291cmNlUmVzcG9uc2UmKTsKIAotICAgIGV4cGxpY2l0IE5ldHdvcmtFeHRlbnNpb25D b250ZW50RmlsdGVyKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKTsKICAgICB+TmV0d29ya0V4dGVu c2lvbkNvbnRlbnRGaWx0ZXIoKSBvdmVycmlkZTsKLQogICAgIHZvaWQgYWRkRGF0YShjb25zdCBj aGFyKiBkYXRhLCBpbnQgbGVuZ3RoKSBvdmVycmlkZTsKICAgICB2b2lkIGZpbmlzaGVkQWRkaW5n RGF0YSgpIG92ZXJyaWRlOwogICAgIGJvb2wgbmVlZHNNb3JlRGF0YSgpIGNvbnN0IG92ZXJyaWRl OwpAQCAtNTMsNiArNTUsOCBAQCBwdWJsaWM6CiAgICAgQ29udGVudEZpbHRlclVuYmxvY2tIYW5k bGVyIHVuYmxvY2tIYW5kbGVyKCkgY29uc3Qgb3ZlcnJpZGU7CiAKIHByaXZhdGU6CisgICAgZXhw bGljaXQgTmV0d29ya0V4dGVuc2lvbkNvbnRlbnRGaWx0ZXIoY29uc3QgUmVzb3VyY2VSZXNwb25z ZSYpOworCiAgICAgbG9uZyBtX25lRmlsdGVyU291cmNlU3RhdHVzOwogICAgIFJldGFpblB0cjxO RUZpbHRlclNvdXJjZT4gbV9uZUZpbHRlclNvdXJjZTsKICAgICBkaXNwYXRjaF9xdWV1ZV90IG1f bmVGaWx0ZXJTb3VyY2VRdWV1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2NvY29hL1BhcmVudGFsQ29udHJvbHNDb250ZW50RmlsdGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jb2NvYS9QYXJlbnRhbENvbnRyb2xzQ29udGVudEZpbHRlci5oCmluZGV4IGE2OWE1 YmIzMWZjZDU2NzZjOWQ4NDQwNzcwZjRhYTQwNjMwN2ZhM2YuLmZkZDgyNTc2Nzk3NDU1Y2JhNzJh MGNjOTU0Nzg1MmUzNzI3NGNjNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2NvY29hL1BhcmVudGFsQ29udHJvbHNDb250ZW50RmlsdGVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vY29jb2EvUGFyZW50YWxDb250cm9sc0NvbnRlbnRGaWx0ZXIuaApAQCAtMzYs MTIgKzM2LDE0IEBAIE9CSkNfQ0xBU1MgV2ViRmlsdGVyRXZhbHVhdG9yOwogbmFtZXNwYWNlIFdl YkNvcmUgewogCiBjbGFzcyBQYXJlbnRhbENvbnRyb2xzQ29udGVudEZpbHRlciBmaW5hbCA6IHB1 YmxpYyBDb250ZW50RmlsdGVyIHsKKyAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKKyAgICBX VEZfTUFLRV9OT05DT1BZQUJMRShQYXJlbnRhbENvbnRyb2xzQ29udGVudEZpbHRlcik7CisgICAg ZnJpZW5kIHN0ZDo6dW5pcXVlX3B0cjxQYXJlbnRhbENvbnRyb2xzQ29udGVudEZpbHRlcj4gc3Rk OjptYWtlX3VuaXF1ZTxQYXJlbnRhbENvbnRyb2xzQ29udGVudEZpbHRlcj4oY29uc3QgUmVzb3Vy Y2VSZXNwb25zZSYpOworCiBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wgY2FuSGFuZGxlUmVzcG9u c2UoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOwogICAgIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8 UGFyZW50YWxDb250cm9sc0NvbnRlbnRGaWx0ZXI+IGNyZWF0ZShjb25zdCBSZXNvdXJjZVJlc3Bv bnNlJik7CiAKLSAgICBleHBsaWNpdCBQYXJlbnRhbENvbnRyb2xzQ29udGVudEZpbHRlcihjb25z dCBSZXNvdXJjZVJlc3BvbnNlJik7Ci0KICAgICB2b2lkIGFkZERhdGEoY29uc3QgY2hhciogZGF0 YSwgaW50IGxlbmd0aCkgb3ZlcnJpZGU7CiAgICAgdm9pZCBmaW5pc2hlZEFkZGluZ0RhdGEoKSBv dmVycmlkZTsKICAgICBib29sIG5lZWRzTW9yZURhdGEoKSBjb25zdCBvdmVycmlkZTsKQEAgLTUw LDYgKzUyLDggQEAgcHVibGljOgogICAgIENvbnRlbnRGaWx0ZXJVbmJsb2NrSGFuZGxlciB1bmJs b2NrSGFuZGxlcigpIGNvbnN0IG92ZXJyaWRlOwogCiBwcml2YXRlOgorICAgIGV4cGxpY2l0IFBh cmVudGFsQ29udHJvbHNDb250ZW50RmlsdGVyKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKTsKKwog ICAgIFJldGFpblB0cjxXZWJGaWx0ZXJFdmFsdWF0b3I+IG1fd2ViRmlsdGVyRXZhbHVhdG9yOwog ICAgIFJldGFpblB0cjxOU0RhdGE+IG1fcmVwbGFjZW1lbnREYXRhOwogfTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvTW9ja0NvbnRlbnRGaWx0ZXIuaCBiL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvTW9ja0NvbnRlbnRGaWx0ZXIuaAppbmRleCBlMDkwNGMyN2YxMmE2YWEzYTE0 MDEwNDJiYTZmZDhmODEyMTE5N2E3Li45Y2I4NzYwMjllMjE0NzI5MGNmMTIxYjIxNDM1N2ZjODc3 MGZlZjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL01vY2tDb250ZW50Rmls dGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9Nb2NrQ29udGVudEZpbHRlci5oCkBA IC0zMiw5ICszMiwxMCBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBNb2NrQ29udGVu dEZpbHRlciBmaW5hbCA6IHB1YmxpYyBDb250ZW50RmlsdGVyIHsKLSAgICBXVEZfTUFLRV9OT05D T1BZQUJMRShNb2NrQ29udGVudEZpbHRlcik7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7 CisgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoTW9ja0NvbnRlbnRGaWx0ZXIpOwogICAgIGZyaWVu ZCBzdGQ6OnVuaXF1ZV9wdHI8TW9ja0NvbnRlbnRGaWx0ZXI+IHN0ZDo6bWFrZV91bmlxdWU8TW9j a0NvbnRlbnRGaWx0ZXI+KGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKTsKKwogcHVibGljOgogICAg IHN0YXRpYyB2b2lkIGVuc3VyZUluc3RhbGxlZCgpOwogICAgIHN0YXRpYyBib29sIGNhbkhhbmRs ZVJlc3BvbnNlKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKTsK