14251 2007-06-20 16:47:37 -0700 onchange handler for select controls doesn't fire when changing via keyboard 2007-06-27 23:19:19 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) PC Windows XP RESOLVED FIXED http://bugs.webkit.org/attachment.cgi?id=14705&action=view P2 Normal --- 0 mpComplete webkit-unassigned darin mrowe oldest_to_newest 6979 0 mpComplete 2007-06-20 16:47:37 -0700 I think the fix for 13857 causes this problem. Repro steps: 1. Load the above URL in Safari for Windows (it's the test case for 13857). 2. Focus the select control, then type "t" and hit Enter. 3. The selection changes, but no message is displayed. The onchange handler didn't fire. 4. If you change the selection with the mouse, or cause the popup to open, the onchange handler will fire. What's happening is that saveLastSelection(); is getting called before firing the onchange event, which actually saves the *current* selection (it changes immediately when you type "t"). Immediately after that, there's a check in menuListOnChange to see if the current selection is the same as the one we just saved, which of course it is. This doesn't happen in the mac port because there is platform-specific code guarded by ARROW_KEYS_POP_MENU that calls menuListOnChange before we get to the above code. 6977 1 15151 mpComplete 2007-06-20 17:47:38 -0700 Created attachment 15151 patch No regression test needed. fast/forms/select-double-onchange.html was failing if ARROW_KEYS_POP_MENU = 0 in HTMLSelectElement.cpp (which it is on the Windows port). This patch fixes that. 6802 2 15151 darin 2007-06-21 23:49:45 -0700 Comment on attachment 15151 patch Needs a layout test. We require tests for bug fixes like this one so they don't regress in the future. Fix itself looks pretty good, although the (size_t) casts don't see to be part of the fix (and so should be done separately). 6694 3 mpComplete 2007-06-22 11:10:43 -0700 I don't understand. This is a bug fix for a broken layout test (which only fails if ARROW_KEYS_POP_MENU = 0). fast/forms/select-double-onchange.html IS the layout test for this fix. 6673 4 15151 darin 2007-06-22 13:56:09 -0700 Comment on attachment 15151 patch Oops, my mistake. Putting back up for review. 6252 5 15151 aroben 2007-06-26 00:34:43 -0700 Comment on attachment 15151 patch Remove the (size_t) casts and I think we have a winner. 6205 6 15253 mpComplete 2007-06-26 11:46:25 -0700 Created attachment 15253 patch without casts Same as above patch, but without the size_t casts. 6181 7 15253 aroben 2007-06-26 12:43:55 -0700 Comment on attachment 15253 patch without casts r=me 6124 8 mrowe 2007-06-26 22:12:14 -0700 Hrm, svn-apply claims the patch is invalid? 6053 9 15281 mpComplete 2007-06-27 16:06:01 -0700 Created attachment 15281 remake of above patch This one should actually apply. 6038 10 15281 aroben 2007-06-27 20:53:40 -0700 Comment on attachment 15281 remake of above patch r=me 6014 11 mrowe 2007-06-27 23:19:19 -0700 Landed in r23845. 15151 2007-06-20 17:47:38 -0700 2007-06-26 11:46:25 -0700 patch onchange.patch text/plain 2889 mpComplete SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzY3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDYtMjAgIE1hdHQgUGVycnkgIDxtcENvbXBsZXRlQGdtYWls LmNvbT4KKworICAgICAgICAtIEZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDI1MToKKyAgICAgICAgICBvbmNoYW5nZSBoYW5kbGVyIGZvciBzZWxlY3QgY29udHJv bHMgZG9lc24ndCBmaXJlIHdoZW4gY2hhbmdpbmcgdmlhIGtleWJvYXJkCisKKyAgICAgICAgKiBo dG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RF bGVtZW50OjptZW51TGlzdERlZmF1bHRFdmVudEhhbmRsZXIpOiBHb3QgcmlkIG9mCisgICAgICAg IGEgY2FsbCB0byBzYXZlTGFzdFNlbGVjdGlvbiBpbiB0aGUgIkVudGVyIiBrZXkgaGFuZGxlciBm b3Igc2VsZWN0CisgICAgICAgIGNvbnRyb2xzIHRoYXQgd2FzIHByZXZlbnRpbmcgb25jaGFuZ2Ug ZnJvbSBmaXJpbmcuICBBbHNvIGNsZWFuZWQgdXAKKyAgICAgICAgc29tZSB3YXJuaW5ncy4KKwog MjAwNy0wNi0yMCAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQmV0aC4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAkocmV2aXNp b24gMjM1NjgpCisrKyBXZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02NDYsMjUgKzY0NiwyNSBAQCB2b2lkIEhUTUxTZWxlY3RFbGVtZW50OjptZW51 TGlzdERlZmF1bHRFCiAgICAgICAgIGlmIChrZXlJZGVudGlmaWVyID09ICJEb3duIiB8fCBrZXlJ ZGVudGlmaWVyID09ICJSaWdodCIpIHsKICAgICAgICAgICAgIHNpemVfdCBzaXplID0gbGlzdEl0 ZW1zKCkuc2l6ZSgpOwogICAgICAgICAgICAgZm9yIChsaXN0SW5kZXggKz0gMTsKLSAgICAgICAg ICAgICAgICAgbGlzdEluZGV4ID49IDAgJiYgbGlzdEluZGV4IDwgc2l6ZSAmJiAobGlzdEl0ZW1z KClbbGlzdEluZGV4XS0+ZGlzYWJsZWQoKSB8fCAhbGlzdEl0ZW1zKClbbGlzdEluZGV4XS0+aGFz VGFnTmFtZShvcHRpb25UYWcpKTsKKyAgICAgICAgICAgICAgICAgbGlzdEluZGV4ID49IDAgJiYg KHNpemVfdClsaXN0SW5kZXggPCBzaXplICYmIChsaXN0SXRlbXMoKVtsaXN0SW5kZXhdLT5kaXNh YmxlZCgpIHx8ICFsaXN0SXRlbXMoKVtsaXN0SW5kZXhdLT5oYXNUYWdOYW1lKG9wdGlvblRhZykp OwogICAgICAgICAgICAgICAgICArK2xpc3RJbmRleCk7CiAgICAgICAgICAgICAKLSAgICAgICAg ICAgIGlmIChsaXN0SW5kZXggPj0gMCAmJiBsaXN0SW5kZXggPCBzaXplKQorICAgICAgICAgICAg aWYgKGxpc3RJbmRleCA+PSAwICYmIChzaXplX3QpbGlzdEluZGV4IDwgc2l6ZSkKICAgICAgICAg ICAgICAgICBzZXRTZWxlY3RlZEluZGV4KGxpc3RUb09wdGlvbkluZGV4KGxpc3RJbmRleCkpOwog ICAgICAgICAgICAgaGFuZGxlZCA9IHRydWU7CiAgICAgICAgIH0gZWxzZSBpZiAoa2V5SWRlbnRp ZmllciA9PSAiVXAiIHx8IGtleUlkZW50aWZpZXIgPT0gIkxlZnQiKSB7CiAgICAgICAgICAgICBz aXplX3Qgc2l6ZSA9IGxpc3RJdGVtcygpLnNpemUoKTsKICAgICAgICAgICAgIGZvciAobGlzdElu ZGV4IC09IDE7Ci0gICAgICAgICAgICAgICAgIGxpc3RJbmRleCA+PSAwICYmIGxpc3RJbmRleCA8 IHNpemUgJiYgKGxpc3RJdGVtcygpW2xpc3RJbmRleF0tPmRpc2FibGVkKCkgfHwgIWxpc3RJdGVt cygpW2xpc3RJbmRleF0tPmhhc1RhZ05hbWUob3B0aW9uVGFnKSk7CisgICAgICAgICAgICAgICAg IGxpc3RJbmRleCA+PSAwICYmIChzaXplX3QpbGlzdEluZGV4IDwgc2l6ZSAmJiAobGlzdEl0ZW1z KClbbGlzdEluZGV4XS0+ZGlzYWJsZWQoKSB8fCAhbGlzdEl0ZW1zKClbbGlzdEluZGV4XS0+aGFz VGFnTmFtZShvcHRpb25UYWcpKTsKICAgICAgICAgICAgICAgICAgLS1saXN0SW5kZXgpOwogICAg ICAgICAgICAgCi0gICAgICAgICAgICBpZiAobGlzdEluZGV4ID49IDAgJiYgbGlzdEluZGV4IDwg c2l6ZSkKKyAgICAgICAgICAgIGlmIChsaXN0SW5kZXggPj0gMCAmJiAoc2l6ZV90KWxpc3RJbmRl eCA8IHNpemUpCiAgICAgICAgICAgICAgICAgc2V0U2VsZWN0ZWRJbmRleChsaXN0VG9PcHRpb25J bmRleChsaXN0SW5kZXgpKTsKICAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOwogICAgICAgICB9 IGVsc2UgaWYgKGtleUlkZW50aWZpZXIgPT0gIkVudGVyIikgewotICAgICAgICAgICAgLy8gU2F2 ZSB0aGUgc2VsZWN0aW9uIHNvIGl0IGNhbiBiZSBjb21wYXJlZCB0byB0aGUgbmV3IHNlbGVjdGlv biB3aGVuIHdlIGNhbGwgb25DaGFuZ2UgZHVyaW5nIHNldFNldFNlbGVjdGVkSW5kZXguCi0gICAg ICAgICAgICBzYXZlTGFzdFNlbGVjdGlvbigpOworICAgICAgICAgICAgLy8gbGlzdEluZGV4IHNo b3VsZCBhbHJlYWR5IGJlIHNlbGVjdGVkLCBidXQgdGhpcyB3aWxsIGZpcmUgdGhlIG9uY2hhbmdl IGhhbmRsZXIuCiAgICAgICAgICAgICBzZXRTZWxlY3RlZEluZGV4KGxpc3RUb09wdGlvbkluZGV4 KGxpc3RJbmRleCksIHRydWUsIHRydWUpOworICAgICAgICAgICAgaGFuZGxlZCA9IHRydWU7CiAg ICAgICAgIH0KICNlbmRpZgogICAgICAgICBpZiAoaGFuZGxlZCkK 15253 2007-06-26 11:46:25 -0700 2007-06-27 16:06:01 -0700 patch without casts onchange-2.patch text/plain 1538 mpComplete SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzY3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDYtMjAgIE1hdHQgUGVycnkgIDxtcENvbXBsZXRlQGdtYWls LmNvbT4KKworICAgICAgICAtIEZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDI1MToKKyAgICAgICAgICBvbmNoYW5nZSBoYW5kbGVyIGZvciBzZWxlY3QgY29udHJv bHMgZG9lc24ndCBmaXJlIHdoZW4gY2hhbmdpbmcgdmlhIGtleWJvYXJkCisKKyAgICAgICAgKiBo dG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RF bGVtZW50OjptZW51TGlzdERlZmF1bHRFdmVudEhhbmRsZXIpOiBHb3QgcmlkIG9mCisgICAgICAg IGEgY2FsbCB0byBzYXZlTGFzdFNlbGVjdGlvbiBpbiB0aGUgIkVudGVyIiBrZXkgaGFuZGxlciBm b3Igc2VsZWN0CisgICAgICAgIGNvbnRyb2xzIHRoYXQgd2FzIHByZXZlbnRpbmcgb25jaGFuZ2Ug ZnJvbSBmaXJpbmcuCisKIDIwMDctMDYtMjAgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGguCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTFNl bGVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxl bWVudC5jcHAJKHJldmlzaW9uIDIzNTY4KQorKysgV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVt ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYyLDkgKzY2Miw5IEBAIHZvaWQgSFRNTFNlbGVj dEVsZW1lbnQ6Om1lbnVMaXN0RGVmYXVsdEUKICAgICAgICAgICAgICAgICBzZXRTZWxlY3RlZElu ZGV4KGxpc3RUb09wdGlvbkluZGV4KGxpc3RJbmRleCkpOwogICAgICAgICAgICAgaGFuZGxlZCA9 IHRydWU7CiAgICAgICAgIH0gZWxzZSBpZiAoa2V5SWRlbnRpZmllciA9PSAiRW50ZXIiKSB7Ci0g ICAgICAgICAgICAvLyBTYXZlIHRoZSBzZWxlY3Rpb24gc28gaXQgY2FuIGJlIGNvbXBhcmVkIHRv IHRoZSBuZXcgc2VsZWN0aW9uIHdoZW4gd2UgY2FsbCBvbkNoYW5nZSBkdXJpbmcgc2V0U2V0U2Vs ZWN0ZWRJbmRleC4KLSAgICAgICAgICAgIHNhdmVMYXN0U2VsZWN0aW9uKCk7CisgICAgICAgICAg ICAvLyBsaXN0SW5kZXggc2hvdWxkIGFscmVhZHkgYmUgc2VsZWN0ZWQsIGJ1dCB0aGlzIHdpbGwg ZmlyZSB0aGUgb25jaGFuZ2UgaGFuZGxlci4KICAgICAgICAgICAgIHNldFNlbGVjdGVkSW5kZXgo bGlzdFRvT3B0aW9uSW5kZXgobGlzdEluZGV4KSwgdHJ1ZSwgdHJ1ZSk7CisgICAgICAgICAgICBo YW5kbGVkID0gdHJ1ZTsKICAgICAgICAgfQogI2VuZGlmCiAgICAgICAgIGlmIChoYW5kbGVkKQo= 15281 2007-06-27 16:06:01 -0700 2007-06-27 20:53:40 -0700 remake of above patch onchange-3.patch text/plain 1556 mpComplete SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzc5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKysyMDA3LTA2LTIwICBNYXR0IFBlcnJ5ICA8bXBDb21wbGV0ZUBnbWFp bC5jb20+CisKKyAgICAgICAgLSBGaXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQyNTE6CisgICAgICAgICAgb25jaGFuZ2UgaGFuZGxlciBmb3Igc2VsZWN0IGNvbnRy b2xzIGRvZXNuJ3QgZmlyZSB3aGVuIGNoYW5naW5nIHZpYSBrZXlib2FyZAorCisgICAgICAgICog aHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0 RWxlbWVudDo6bWVudUxpc3REZWZhdWx0RXZlbnRIYW5kbGVyKTogR290IHJpZCBvZgorICAgICAg ICBhIGNhbGwgdG8gc2F2ZUxhc3RTZWxlY3Rpb24gaW4gdGhlICJFbnRlciIga2V5IGhhbmRsZXIg Zm9yIHNlbGVjdAorICAgICAgICBjb250cm9scyB0aGF0IHdhcyBwcmV2ZW50aW5nIG9uY2hhbmdl IGZyb20gZmlyaW5nLgorCiAyMDA3LTA2LTI2ICBUcmlzdGFuIE8nVGllcm5leSAgPHRyaXN0YW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBX ZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv aHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAJKHJldmlzaW9uIDIzNzk3KQorKysgV2ViQ29yZS9o dG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYyLDkgKzY2Miw5 IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6Om1lbnVMaXN0RGVmYXVsdEUKICAgICAgICAgICAg ICAgICBzZXRTZWxlY3RlZEluZGV4KGxpc3RUb09wdGlvbkluZGV4KGxpc3RJbmRleCkpOwogICAg ICAgICAgICAgaGFuZGxlZCA9IHRydWU7CiAgICAgICAgIH0gZWxzZSBpZiAoa2V5SWRlbnRpZmll ciA9PSAiRW50ZXIiKSB7Ci0gICAgICAgICAgICAvLyBTYXZlIHRoZSBzZWxlY3Rpb24gc28gaXQg Y2FuIGJlIGNvbXBhcmVkIHRvIHRoZSBuZXcgc2VsZWN0aW9uIHdoZW4gd2UgY2FsbCBvbkNoYW5n ZSBkdXJpbmcgc2V0U2V0U2VsZWN0ZWRJbmRleC4KLSAgICAgICAgICAgIHNhdmVMYXN0U2VsZWN0 aW9uKCk7CisgICAgICAgICAgICAvLyBsaXN0SW5kZXggc2hvdWxkIGFscmVhZHkgYmUgc2VsZWN0 ZWQsIGJ1dCB0aGlzIHdpbGwgZmlyZSB0aGUgb25jaGFuZ2UgaGFuZGxlci4KICAgICAgICAgICAg IHNldFNlbGVjdGVkSW5kZXgobGlzdFRvT3B0aW9uSW5kZXgobGlzdEluZGV4KSwgdHJ1ZSwgdHJ1 ZSk7CisgICAgICAgICAgICBoYW5kbGVkID0gdHJ1ZTsKICAgICAgICAgfQogI2VuZGlmCiAgICAg ICAgIGlmIChoYW5kbGVkKQo=