142509 2015-03-09 15:10:21 -0700 Adjustments to media control fonts. 2015-03-10 12:08:00 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned dino roger_fong oldest_to_newest 1075774 0 roger_fong 2015-03-09 15:10:21 -0700 Need to use system font (and thus need to adjust surrounding divs) and also need to sub pixel antialias. rdar://problem/20085228 1075776 1 248281 roger_fong 2015-03-09 15:12:30 -0700 Created attachment 248281 patch 1075977 2 248281 darin 2015-03-10 10:14:52 -0700 Comment on attachment 248281 patch View in context: https://bugs.webkit.org/attachment.cgi?id=248281&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:261 > + font: -webkit-small-control; > + -webkit-font-smoothing: subpixel-antialiased; Can we apply these rules more globally to the entire tree? Seems it would be harmless for elements that don’t display any text; we could avoid having to repeat this. 1076021 3 roger_fong 2015-03-10 12:08:00 -0700 Done. Committed: http://trac.webkit.org/changeset/181332 248281 2015-03-09 15:12:30 -0700 2015-03-10 10:14:52 -0700 patch patch.patch text/plain 4745 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTI4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTAzLTA5ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRqdXN0bWVudHMgdG8gbWVk aWEgY29udHJvbCBmb250cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MjUwOS4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwMDg1MjI4PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBzeXN0ZW0g Zm9udCBmb3IgY29udHJvbHMuIEFkanVzdCBzdXJyb3VuZGluZyBkaXZzIGFjY29yZGluZ2x5Lgor ICAgICAgICBBcHBseSBzdWJwaXhlbCBhbnRpYWxpYXNpbmcgdG8gYWxsIG1lZGlhIGNvbnRyb2wg dGV4dC4KKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxl LmNzczoKKyAgICAgICAgKGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3NlZC1jYXB0 aW9ucy1jb250YWluZXIgLmxpc3QpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29u dHJvbHMtc3RhdHVzLWRpc3BsYXkpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29u dHJvbHMtdGltZWxpbmUpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMt dGltZS1yZW1haW5pbmctZGlzcGxheSk6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1j b250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxheSk6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1t ZWRpYS1jb250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5LmZpdmUtZGlnaXQtdGltZSk6Cisg ICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxh eS5maXZlLWRpZ2l0LXRpbWUpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJv bHMtdGltZS1yZW1haW5pbmctZGlzcGxheS5zaXgtZGlnaXQtdGltZSk6CisgICAgICAgIChhdWRp bzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxheS5zaXgtZGlnaXQt dGltZSk6CisKIDIwMTUtMDMtMDkgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIENTUyBKSVQ6IGFkZCBhbGlhc2VzIGJldHdlZW4gOm50aC1jaGlsZCgp LzpudGgtbGFzdC1jaGlsZCgpIGFuZCA6Zmlyc3QtY2hpbGQvOmxhc3QtY2hpbGQKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuY3Nz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRp YUNvbnRyb2xzQXBwbGUuY3NzCShyZXZpc2lvbiAxODExODgpCisrKyBTb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmNzcwkod29ya2luZyBjb3B5 KQpAQCAtMjU3LDggKzI1Nyw4IEBAIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3Nl ZC1jYXAKIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3NlZC1jYXB0aW9ucy1jb250 YWluZXIgLmxpc3QsCiBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jbG9zZWQtY2FwdGlv bnMtY29udGFpbmVyIC5saXN0IHsKICAgICBkaXNwbGF5OiBibG9jazsKLSAgICBmb250LWZhbWls eTogIkhlbHZldGljYSBOZXVlIiwgSGVsdmV0aWNhLCBzYW5zLXNlcmlmOwotICAgIGZvbnQtc2l6 ZTogMTFweDsKKyAgICBmb250OiAtd2Via2l0LXNtYWxsLWNvbnRyb2w7CisgICAgLXdlYmtpdC1m b250LXNtb290aGluZzogc3VicGl4ZWwtYW50aWFsaWFzZWQ7CiAgICAgLXdlYmtpdC11c2VyLXNl bGVjdDogbm9uZTsKIH0KIApAQCAtMzQ5LDggKzM0OSw4IEBAIGF1ZGlvOjotd2Via2l0LW1lZGlh LWNvbnRyb2xzLW9wdGltaXplZC0KIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXN0YXR1 cy1kaXNwbGF5LAogYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtc3RhdHVzLWRpc3BsYXkg ewogICAgIGN1cnNvcjogZGVmYXVsdDsKLSAgICBmb250LWZhbWlseTogIkhlbHZldGljYSBOZXVl IiwgSGVsdmV0aWNhLCBzYW5zLXNlcmlmOwotICAgIGZvbnQtc2l6ZTogMTFweDsKKyAgICBmb250 OiAtd2Via2l0LXNtYWxsLWNvbnRyb2w7CisgICAgLXdlYmtpdC1mb250LXNtb290aGluZzogc3Vi cGl4ZWwtYW50aWFsaWFzZWQ7CiAgICAgb3ZlcmZsb3c6IGhpZGRlbjsKICAgICBjb2xvcjogd2hp dGU7CiAgICAgdGV4dC1zaGFkb3c6IGJsYWNrIDBweCAxcHggMXB4OwpAQCAtMzc2LDggKzM3Niw4 IEBAIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVsaW5lIHsKICAgICBiYWNrZ3Jv dW5kLXNpemU6IDEwMCUgMTAwJSAhaW1wb3J0YW50OwogICAgIGJhY2tncm91bmQtcmVwZWF0OiBu by1yZXBlYXQ7CiAgICAgYmFja2dyb3VuZC1jb2xvcjogdHJhbnNwYXJlbnQ7Ci0KIH0KKwogdmlk ZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmU6Oi13ZWJraXQtc2xpZGVyLXRodW1i LAogYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxpbmU6Oi13ZWJraXQtc2xpZGVy LXRodW1iIHsKICAgICAtd2Via2l0LWFwcGVhcmFuY2U6IG5vbmUgIWltcG9ydGFudDsKQEAgLTM5 NSw4ICszOTUsOCBAQCBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lLXJlbWFpCiAg ICAgY3Vyc29yOiBkZWZhdWx0OwogICAgIG92ZXJmbG93LXk6IGhpZGRlbjsKICAgICBvdmVyZmxv dy14OiBoaWRkZW47Ci0gICAgZm9udC1mYW1pbHk6ICJIZWx2ZXRpY2EgTmV1ZSIsIEhlbHZldGlj YSwgc2Fucy1zZXJpZjsKLSAgICBmb250LXNpemU6IDExcHg7CisgICAgZm9udDogLXdlYmtpdC1z bWFsbC1jb250cm9sOworICAgIC13ZWJraXQtZm9udC1zbW9vdGhpbmc6IHN1YnBpeGVsLWFudGlh bGlhc2VkOwogICAgIGNvbG9yOiB3aGl0ZTsKICAgICB0ZXh0LXNoYWRvdzogYmxhY2sgMHB4IDFw eCAxcHg7CiAgICAgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsKQEAgLTQxMSw4ICs0MTEsOCBAQCB2 aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRpCiBhdWRpbzo6LXdlYmtpdC1t ZWRpYS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxheSB7CiAgICAgbWFyZ2luLWxlZnQ6IDhw eDsKICAgICBtYXJnaW4tcmlnaHQ6IDhweDsKLSAgICB3aWR0aDogMjhweDsKLSAgICBtaW4td2lk dGg6IDI4cHg7CisgICAgd2lkdGg6IDMwcHg7CisgICAgbWluLXdpZHRoOiAzMHB4OwogICAgIC13 ZWJraXQtYWxpZ24taXRlbXM6IGZsZXgtZW5kOwogICAgIC13ZWJraXQtanVzdGlmeS1jb250ZW50 OiBmbGV4LWVuZDsKIH0KQEAgLTQyMSwzMCArNDIxLDMwIEBAIHZpZGVvOjotd2Via2l0LW1lZGlh LWNvbnRyb2xzLXRpbWUtcmVtYWkKIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWUt cmVtYWluaW5nLWRpc3BsYXkgewogICAgIG1hcmdpbi1sZWZ0OiA4cHg7CiAgICAgbWFyZ2luLXJp Z2h0OiAxNnB4OwotICAgIHdpZHRoOiAzMnB4OwotICAgIG1pbi13aWR0aDogMzJweDsKKyAgICB3 aWR0aDogMzRweDsKKyAgICBtaW4td2lkdGg6IDM0cHg7CiAgICAgLXdlYmtpdC1hbGlnbi1pdGVt czogZmxleC1zdGFydDsKICAgICAtd2Via2l0LWp1c3RpZnktY29udGVudDogZmxleC1zdGFydDsK IH0KIAogdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1haW5pbmctZGlzcGxh eS5maXZlLWRpZ2l0LXRpbWUsCiBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lLXJl bWFpbmluZy1kaXNwbGF5LmZpdmUtZGlnaXQtdGltZSB7Ci0gICAgbWluLXdpZHRoOiA0MXB4Owor ICAgIG1pbi13aWR0aDogNDZweDsKIH0KIAogdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMt Y3VycmVudC10aW1lLWRpc3BsYXkuZml2ZS1kaWdpdC10aW1lLAogYXVkaW86Oi13ZWJraXQtbWVk aWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXkuZml2ZS1kaWdpdC10aW1lIHsKLSAgICBt aW4td2lkdGg6IDM3cHg7CisgICAgbWluLXdpZHRoOiA0MnB4OwogfQogCiB2aWRlbzo6LXdlYmtp dC1tZWRpYS1jb250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5LnNpeC1kaWdpdC10aW1lLAog YXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1haW5pbmctZGlzcGxheS5zaXgt ZGlnaXQtdGltZSB7Ci0gICAgbWluLXdpZHRoOiA0OHB4OworICAgIG1pbi13aWR0aDogNTNweDsK IH0KIAogdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXku c2l4LWRpZ2l0LXRpbWUsCiBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRp bWUtZGlzcGxheS5zaXgtZGlnaXQtdGltZSB7Ci0gICAgbWluLXdpZHRoOiA0NHB4OworICAgIG1p bi13aWR0aDogNDlweDsKIH0KIAogdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxp bmUtY29udGFpbmVyLAo=