142496 2015-03-09 10:41:09 -0700 Only call showControls if controls are hidden 2015-03-09 13:27:10 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned dino roger_fong oldest_to_newest 1075647 0 roger_fong 2015-03-09 10:41:09 -0700 rdar://problem/20083732 Right now we call showControls unconditionally on mousemove, which is very unnecessary. Only call if if the controls are hidden. 1075652 1 248256 roger_fong 2015-03-09 10:46:17 -0700 Created attachment 248256 patch 1075684 2 248256 dino 2015-03-09 11:47:58 -0700 Comment on attachment 248256 patch All this is a bit dodgy. I'm kind of scared this will break some things :) 1075691 3 roger_fong 2015-03-09 11:58:56 -0700 Is it? The controlsAreHidden method wasn't working at all in the first place and the only other place it's used is to update the time displays... 1075731 4 roger_fong 2015-03-09 13:27:10 -0700 http://trac.webkit.org/changeset/181279 248256 2015-03-09 10:46:17 -0700 2015-03-09 11:47:58 -0700 patch patch.patch text/plain 1767 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTI3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTA5ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgT25seSBjYWxsIHNob3dDb250 cm9scyBpZiBjb250cm9scyBhcmUgaGlkZGVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNDk2LgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjAw ODM3MzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzOgorICAgICAgICAo Q29udHJvbGxlci5wcm90b3R5cGUuaGFuZGxlV3JhcHBlck1vdXNlTW92ZSk6CisgICAgICAgIChD b250cm9sbGVyLnByb3RvdHlwZS5jb250cm9sc0FyZUhpZGRlbik6CisgICAgICAgIENvbnRyb2xz IGFyZSBoaWRkZW4gaWYgdGhlIOKAmHNob3figJkgY2xhc3MgbmFtZSBpcyBub3QgcHJlc2VudCwK KyAgICAgICAgbm90IGlmIHRoZSDigJhoaWRkZW7igJkgY2xhc3MgbmFtZSBpcy4KKwogMjAxNS0w My0wOSAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuIFJlLWFkZCBDU1MgcHJvcGVydHkgdGhhdCB3YXMgdW5pbnRlbnRpb25hbGx5IHJlbW92 ZWQgaW4gcjE4MDg5MwpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNBcHBsZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCShyZXZpc2lvbiAxODExNjcp CisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fw cGxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC02NzUsNyArNjc1LDggQEAgQ29udHJvbGxlci5wcm90 b3R5cGUgPSB7CiAKICAgICBoYW5kbGVXcmFwcGVyTW91c2VNb3ZlOiBmdW5jdGlvbihldmVudCkK ICAgICB7Ci0gICAgICAgIHRoaXMuc2hvd0NvbnRyb2xzKCk7CisgICAgICAgIGlmICh0aGlzLmNv bnRyb2xzQXJlSGlkZGVuKCkpCisgICAgICAgICAgICB0aGlzLnNob3dDb250cm9scygpOwogICAg ICAgICB0aGlzLnJlc2V0SGlkZUNvbnRyb2xzVGltZXIoKTsKIAogICAgICAgICBpZiAoIXRoaXMu aXNEcmFnZ2luZykKQEAgLTEyMjksNyArMTIzMCw3IEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0g ewogCiAgICAgY29udHJvbHNBcmVIaWRkZW46IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHJl dHVybiAhdGhpcy5pc0F1ZGlvKCkgJiYgdGhpcy5jb250cm9scy5wYW5lbC5jbGFzc0xpc3QuY29u dGFpbnModGhpcy5DbGFzc05hbWVzLmhpZGRlbik7CisgICAgICAgIHJldHVybiAhdGhpcy5pc0F1 ZGlvKCkgJiYgIXRoaXMuY29udHJvbHMucGFuZWwuY2xhc3NMaXN0LmNvbnRhaW5zKHRoaXMuQ2xh c3NOYW1lcy5zaG93KTsKICAgICB9LAogCiAgICAgcmVtb3ZlQ29udHJvbHM6IGZ1bmN0aW9uKCkK