142482 2015-03-09 04:26:25 -0700 [GTK] Layout Test http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html is failing 2017-08-28 04:20:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chavarria1991 Ms2ger bugs-noreply cgarcia chavarria1991 commit-queue mcatanzaro Ms2ger oliver webkit-bug-importer oldest_to_newest 1075572 0 chavarria1991 2015-03-09 04:26:25 -0700 The http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html layout test is failing on GTK+ since r181134 (https://trac.webkit.org/changeset/r181134). The diff is the following: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-actual.txt @@ -1,5 +1,5 @@ -CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.mp4. +CONSOLE MESSAGE: [blocked] The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html was not allowed to display insecure content from http://127.0.0.1:8080/resources/test.mp4. -CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.mp4. +CONSOLE MESSAGE: [blocked] The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html was not allowed to display insecure content from http://127.0.0.1:8080/resources/test.mp4. This test opens a window that loads insecure HTML5 audio and video. We should trigger a mixed content callback because the main frame in the window is HTTPS but is displaying insecure content. 1342786 1 319172 Ms2ger 2017-08-28 03:10:58 -0700 Created attachment 319172 Patch 1342791 2 319172 commit-queue 2017-08-28 04:02:59 -0700 Comment on attachment 319172 Patch Clearing flags on attachment: 319172 Committed r221237: <http://trac.webkit.org/changeset/221237> 1342792 3 commit-queue 2017-08-28 04:03:00 -0700 All reviewed patches have been landed. Closing bug. 1342793 4 webkit-bug-importer 2017-08-28 04:04:04 -0700 <rdar://problem/34108248> 1342796 5 mcatanzaro 2017-08-28 04:20:37 -0700 Good find, thanks! In this case, the global expectation is outdated because the console message changed, but the test result never got updated because the test has been failing on macOS this whole time. So we should update the global expectation instead of adding a platform-specific one. I'll handle it. 319172 2017-08-28 03:10:58 -0700 2017-08-28 04:02:59 -0700 Patch bug-142482-20170828121057.patch text/plain 2870 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMTgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGY4YTVmZDkwMWFhMDMwMjQ1YjA2 ZWU3ZjViZWEyMjI5MWQyM2MwNi4uZjc3N2FmNGVlYWNjODVjZDQ5YjA1ODIzMGU0ODc1NzJjN2E2 OWUxNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3LTA4LTI4ICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBSZWJhc2VsaW5lIGluc2VjdXJlLWF1ZGlvLXZp ZGVvLWluLW1haW4tZnJhbWUuaHRtbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0MjQ4MgorCisgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5p bmcuCisKKyAgICAgICAgVGhlIHRlc3QgaXMgZmFpbGluZyBkdWUgdG8gYSBkaWZmZXJlbnQgY29u c29sZSBtZXNzYWdlLiBJdCBzZWVtcyBiZXR0ZXIKKyAgICAgICAgdG8gYWRkIGEgcGxhdGZvcm0t c3BlY2lmaWMgYmFzZWxpbmUgc28gd2UgY2FuIGNhdGNoIGFjdHVhbCBmYWlsdXJlcy4KKworICAg ICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3Jt L2d0ay9odHRwL3Rlc3RzL3NlY3VyaXR5L21peGVkQ29udGVudC9pbnNlY3VyZS1hdWRpby12aWRl by1pbi1tYWluLWZyYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKKzIwMTctMDgtMjggIE1zMmdl ciAgPE1zMmdlckBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIEVuYWJsZSB1c2VyQWdlbnRT aGFkb3dET00gdGVzdHMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzYwMTUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cwppbmRleCA1Mzg2OTJiNGFkM2M5YWM5YjQzMzE2ZjA5ZGMwOWQwNjNlZTc5N2U3Li4xNDNmMzI0 NTU0N2RiYTUzZDBhYTZkYjFiYTVhOTRmZTZhNTQ2OTNmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjkyOSw4ICsyOTI5LDYgQEAgd2Via2l0Lm9yZy9i LzE0MjQ3OSBzdmcvdGV4dC9zZWxlY3QtdGV4dExlbmd0aC1zcGFjaW5nQW5kR2x5cGhzLXNxdWVl emUtNC5zdmcgWwogd2Via2l0Lm9yZy9iLzE0MjQ3OSBzdmcvdGV4dC9zZWxlY3QtdGV4dExlbmd0 aC1zcGFjaW5nQW5kR2x5cGhzLXN0cmV0Y2gtMi5zdmcgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcv Yi8xNDI0Nzkgc3ZnL3RleHQvc2VsZWN0LXRleHRMZW5ndGgtc3BhY2luZ0FuZEdseXBocy1zdHJl dGNoLTMuc3ZnIFsgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xNDI0ODIgaHR0cC90ZXN0cy9z ZWN1cml0eS9taXhlZENvbnRlbnQvaW5zZWN1cmUtYXVkaW8tdmlkZW8taW4tbWFpbi1mcmFtZS5o dG1sIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNDI2NjcgZmFzdC9mb3Jtcy9zZWFyY2gt dmVydGljYWwtYWxpZ25tZW50Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNDI2Njcg ZmFzdC9mb3Jtcy90ZXh0ZmllbGQtb3ZlcmZsb3ctYnktdmFsdWUtdXBkYXRlLmh0bWwgWyBGYWls dXJlIF0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2h0dHAvdGVzdHMv c2VjdXJpdHkvbWl4ZWRDb250ZW50L2luc2VjdXJlLWF1ZGlvLXZpZGVvLWluLW1haW4tZnJhbWUt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2h0dHAvdGVzdHMvc2VjdXJp dHkvbWl4ZWRDb250ZW50L2luc2VjdXJlLWF1ZGlvLXZpZGVvLWluLW1haW4tZnJhbWUtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjQ3NmFhMjczMzk1MWY5ZjE4YjdlYjI0N2NmM2RmNDc1NWM2MDUz MjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvaHR0cC90ZXN0 cy9zZWN1cml0eS9taXhlZENvbnRlbnQvaW5zZWN1cmUtYXVkaW8tdmlkZW8taW4tbWFpbi1mcmFt ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1IEBACitDT05TT0xFIE1FU1NBR0U6IFRoZSBwYWdl IGF0IGh0dHBzOi8vMTI3LjAuMC4xOjg0NDMvc2VjdXJpdHkvbWl4ZWRDb250ZW50L3Jlc291cmNl cy9mcmFtZS13aXRoLWluc2VjdXJlLWF1ZGlvLXZpZGVvLmh0bWwgd2FzIGFsbG93ZWQgdG8gZGlz cGxheSBpbnNlY3VyZSBjb250ZW50IGZyb20gaHR0cDovLzEyNy4wLjAuMTo4MDgwL3Jlc291cmNl cy90ZXN0Lm1wNC4KKworQ09OU09MRSBNRVNTQUdFOiBUaGUgcGFnZSBhdCBodHRwczovLzEyNy4w LjAuMTo4NDQzL3NlY3VyaXR5L21peGVkQ29udGVudC9yZXNvdXJjZXMvZnJhbWUtd2l0aC1pbnNl Y3VyZS1hdWRpby12aWRlby5odG1sIHdhcyBhbGxvd2VkIHRvIGRpc3BsYXkgaW5zZWN1cmUgY29u dGVudCBmcm9tIGh0dHA6Ly8xMjcuMC4wLjE6ODA4MC9yZXNvdXJjZXMvdGVzdC5tcDQuCisKK1Ro aXMgdGVzdCBvcGVucyBhIHdpbmRvdyB0aGF0IGxvYWRzIGluc2VjdXJlIEhUTUw1IGF1ZGlvIGFu ZCB2aWRlby4gV2Ugc2hvdWxkIHRyaWdnZXIgYSBtaXhlZCBjb250ZW50IGNhbGxiYWNrIGJlY2F1 c2UgdGhlIG1haW4gZnJhbWUgaW4gdGhlIHdpbmRvdyBpcyBIVFRQUyBidXQgaXMgZGlzcGxheWlu ZyBpbnNlY3VyZSBjb250ZW50Lgo=