142471 2015-03-08 20:23:52 -0700 [Win] WTF::WorkQueue does not balance ref/deref properly 2015-03-10 19:43:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 142432 142447 142560 1 bfulgham bfulgham andersca benjamin bfulgham cmarcelo commit-queue koivisto sam oldest_to_newest 1075514 0 bfulgham 2015-03-08 20:23:52 -0700 I overlooked a 'deref' in the WTF::WorkQueue implementation. I should have had a test to avoid this! Let's fix both problems. 1075517 1 248228 bfulgham 2015-03-08 20:36:25 -0700 Created attachment 248228 Patch 1075521 2 bfulgham 2015-03-08 21:16:06 -0700 Committed r181257: <http://trac.webkit.org/changeset/181257> 248228 2015-03-08 20:36:25 -0700 2015-03-08 20:48:50 -0700 Patch bug-142471-20150308204519.patch text/plain 5064 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODEyNTYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTA4ICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFdURjo6V29ya1F1ZXVlIGRvZXMgbm90 IGJhbGFuY2UgcmVmL2RlcmVmIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI0NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgd2UgZGVyZWYgdGhlIGNvdW50IHdoZW4gd2Ug ZXhlY3V0ZSBhIGZ1bmN0aW9uIGluIHRoZQorICAgICAgICBXb3JrUXVldWUuCisKKyAgICAgICAg KiB3dGYvd2luL1dvcmtRdWV1ZVdpbi5jcHA6CisgICAgICAgIChXVEY6OldvcmtRdWV1ZTo6cGVy Zm9ybVdvcmtPblJlZ2lzdGVyZWRXb3JrVGhyZWFkKToKKwogMjAxNS0wMy0wNyAgQnJlbnQgRnVs Z2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBSZXZpdmUgV1RGOjpX b3JrUXVldWUgb24gV2luZG93cwpJbmRleDogU291cmNlL1dURi93dGYvd2luL1dvcmtRdWV1ZVdp bi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvd2luL1dvcmtRdWV1ZVdpbi5jcHAJ KHJldmlzaW9uIDE4MTI1NikKKysrIFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04Miw4ICs4MiwxMCBAQCB2b2lkIFdvcmtRdWV1ZTo6cGVyZm9y bVdvcmtPblJlZ2lzdGVyZWRXCiAKICAgICAgICAgLy8gQWxsb3cgbW9yZSB3b3JrIHRvIGJlIHNj aGVkdWxlZCB3aGlsZSB3ZSdyZSBub3QgdXNpbmcgdGhlIHF1ZXVlIGRpcmVjdGx5LgogICAgICAg ICBtX3dvcmtJdGVtUXVldWVMb2NrLnVubG9jaygpOwotICAgICAgICBmb3IgKGF1dG8mIHdvcmtJ dGVtIDogd29ya0l0ZW1RdWV1ZSkKKyAgICAgICAgZm9yIChhdXRvJiB3b3JrSXRlbSA6IHdvcmtJ dGVtUXVldWUpIHsKICAgICAgICAgICAgIHdvcmtJdGVtLT5mdW5jdGlvbigpKCk7CisgICAgICAg ICAgICBkZXJlZigpOworICAgICAgICB9CiAgICAgICAgIG1fd29ya0l0ZW1RdWV1ZUxvY2subG9j aygpOwogICAgIH0KIApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0NoYW5nZUxvZwkocmV2aXNpb24gMTgxMjU2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDMtMDggIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbl0gV1RGOjpXb3JrUXVldWUgZG9lcyBub3Qg YmFsYW5jZSByZWYvZGVyZWYgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MjQ3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV29ya1F1ZXVlLmNw cDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOiBDaGVjayB0aGF0IHRoZSByZWZjb3Vu dCBpcyBjb3JyZWN0LgorCiAyMDE1LTAzLTA4ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1A c2Ftc3VuZy5jb20+CiAKICAgICAgICAgRG8gbm90IHNob3cgcGFzc2luZyB0ZXN0IHJlc3VsdCBv biBvdXRwdXQgb2YgRUZMIGxheW91dCB0ZXN0CkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9Xb3JrUXVldWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL1dvcmtRdWV1ZS5jcHAJKHJldmlzaW9uIDE4MTI1NikKKysrIFRvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV1RGL1dvcmtRdWV1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDEz ICs1MywxNSBAQCBURVNUKFdURl9Xb3JrUXVldWUsIFNpbXBsZSkKICAgICBzdGF0aWMgY29uc3Qg Y2hhciogdGhpcmRUZXN0TGFiZWwgPSAidGhpcmRUZXN0IjsKIAogICAgIGF1dG8gcXVldWUgPSBX b3JrUXVldWU6OmNyZWF0ZSgiY29tLmFwcGxlLldlYktpdC5UZXN0LnNpbXBsZSIpOwotICAgIAor ICAgIGludCBpbml0aWFsUmVmQ291bnQgPSBxdWV1ZS0+cmVmQ291bnQoKTsKKyAgICBFWFBFQ1Rf RVEoMSwgaW5pdGlhbFJlZkNvdW50KTsKKwogICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2xvY2sp OwogICAgIHF1ZXVlLT5kaXNwYXRjaChbJl0odm9pZCkgewogICAgICAgICBtX2Z1bmN0aW9uQ2Fs bE9yZGVyLmFwcGVuZChzaW1wbGVUZXN0TGFiZWwpOwogICAgICAgICBjYWxsZWRTaW1wbGVUZXN0 ID0gdHJ1ZTsKICAgICB9KTsKLSAgICAKKwogICAgIHF1ZXVlLT5kaXNwYXRjaChbJl0odm9pZCkg ewogICAgICAgICBtX2Z1bmN0aW9uQ2FsbE9yZGVyLmFwcGVuZChsb25nVGVzdExhYmVsKTsKICAg ICAgICAgc3RkOjp0aGlzX3RocmVhZDo6c2xlZXBfZm9yKHN0ZDo6Y2hyb25vOjpuYW5vc2Vjb25k cygxMDApKTsKQEAgLTc4LDEzICs4MCwxNyBAQCBURVNUKFdURl9Xb3JrUXVldWUsIFNpbXBsZSkK ICAgICAgICAgbV90ZXN0Q29tcGxldGVkLnNpZ25hbCgpOwogICAgIH0pOwogCisgICAgRVhQRUNU X0dUKHF1ZXVlLT5yZWZDb3VudCgpLCAxKTsKKwogICAgIG1fdGVzdENvbXBsZXRlZC53YWl0KG1f bG9jayk7CiAKKyAgICBFWFBFQ1RfRVEoMSwgcXVldWUtPnJlZkNvdW50KCkpOworCiAgICAgRVhQ RUNUX1RSVUUoY2FsbGVkU2ltcGxlVGVzdCk7CiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkTG9uZ1Rl c3QpOwogICAgIEVYUEVDVF9UUlVFKGNhbGxlZFRoaXJkVGVzdCk7CiAKLSAgICBFWFBFQ1RfRVEo bV9mdW5jdGlvbkNhbGxPcmRlci5zaXplKCksIHN0YXRpY19jYXN0PHNpemVfdD4oMykpOworICAg IEVYUEVDVF9FUShzdGF0aWNfY2FzdDxzaXplX3Q+KDMpLCBtX2Z1bmN0aW9uQ2FsbE9yZGVyLnNp emUoKSk7CiAgICAgRVhQRUNUX1NUUkVRKHNpbXBsZVRlc3RMYWJlbCwgbV9mdW5jdGlvbkNhbGxP cmRlclswXS5jX3N0cigpKTsKICAgICBFWFBFQ1RfU1RSRVEobG9uZ1Rlc3RMYWJlbCwgbV9mdW5j dGlvbkNhbGxPcmRlclsxXS5jX3N0cigpKTsKICAgICBFWFBFQ1RfU1RSRVEodGhpcmRUZXN0TGFi ZWwsIG1fZnVuY3Rpb25DYWxsT3JkZXJbMl0uY19zdHIoKSk7CkBAIC0xMDMsNiArMTA5LDExIEBA IFRFU1QoV1RGX1dvcmtRdWV1ZSwgVHdvUXVldWVzKQogICAgIGF1dG8gcXVldWUxID0gV29ya1F1 ZXVlOjpjcmVhdGUoImNvbS5hcHBsZS5XZWJLaXQuVGVzdC50d29RdWV1ZXMxIik7CiAgICAgYXV0 byBxdWV1ZTIgPSBXb3JrUXVldWU6OmNyZWF0ZSgiY29tLmFwcGxlLldlYktpdC5UZXN0LnR3b1F1 ZXVlczIiKTsKIAorICAgIGludCBpbml0aWFsUXVldWUxUmVmQ291bnQgPSBxdWV1ZTEtPnJlZkNv dW50KCk7CisgICAgaW50IGluaXRpYWxRdWV1ZTJSZWZDb3VudCA9IHF1ZXVlMi0+cmVmQ291bnQo KTsKKyAgICBFWFBFQ1RfRVEoMSwgaW5pdGlhbFF1ZXVlMVJlZkNvdW50KTsKKyAgICBFWFBFQ1Rf RVEoMSwgaW5pdGlhbFF1ZXVlMlJlZkNvdW50KTsKKwogICAgIE11dGV4TG9ja2VyIGxvY2tlciht X2xvY2spOwogICAgIAogICAgIHF1ZXVlMS0+ZGlzcGF0Y2goWyZdKHZvaWQpIHsKQEAgLTEzMiwx NCArMTQzLDE2IEBAIFRFU1QoV1RGX1dvcmtRdWV1ZSwgVHdvUXVldWVzKQogICAgIEVYUEVDVF9U UlVFKGNhbGxlZFNpbXBsZVRlc3QpOwogICAgIEVYUEVDVF9GQUxTRShjYWxsZWRMb25nVGVzdCk7 CiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkVGhpcmRUZXN0KTsKKyAgICBFWFBFQ1RfRVEoMSwgcXVl dWUxLT5yZWZDb3VudCgpKTsKIAogICAgIG1fdGVzdFF1ZXVlMkNvbXBsZXRlZC53YWl0KG1fbG9j ayk7CiAKICAgICBFWFBFQ1RfVFJVRShjYWxsZWRTaW1wbGVUZXN0KTsKICAgICBFWFBFQ1RfVFJV RShjYWxsZWRMb25nVGVzdCk7CiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkVGhpcmRUZXN0KTsKKyAg ICBFWFBFQ1RfRVEoMSwgcXVldWUyLT5yZWZDb3VudCgpKTsKIAotICAgIEVYUEVDVF9FUShtX2Z1 bmN0aW9uQ2FsbE9yZGVyLnNpemUoKSwgc3RhdGljX2Nhc3Q8c2l6ZV90PigzKSk7CisgICAgRVhQ RUNUX0VRKHN0YXRpY19jYXN0PHNpemVfdD4oMyksIG1fZnVuY3Rpb25DYWxsT3JkZXIuc2l6ZSgp KTsKICAgICBFWFBFQ1RfU1RSRVEoc2ltcGxlVGVzdExhYmVsLCBtX2Z1bmN0aW9uQ2FsbE9yZGVy WzBdLmNfc3RyKCkpOwogICAgIEVYUEVDVF9TVFJFUSh0aGlyZFRlc3RMYWJlbCwgbV9mdW5jdGlv bkNhbGxPcmRlclsxXS5jX3N0cigpKTsKICAgICBFWFBFQ1RfU1RSRVEobG9uZ1Rlc3RMYWJlbCwg bV9mdW5jdGlvbkNhbGxPcmRlclsyXS5jX3N0cigpKTsKQEAgLTE4Miw3ICsxOTUsNyBAQCBURVNU KFdURl9Xb3JrUXVldWUsIERpc3BhdGNoQWZ0ZXIpCiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkU2lt cGxlVGVzdCk7CiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkRGlzcGF0Y2hBZnRlclRlc3QpOwogCi0g ICAgRVhQRUNUX0VRKG1fZnVuY3Rpb25DYWxsT3JkZXIuc2l6ZSgpLCBzdGF0aWNfY2FzdDxzaXpl X3Q+KDIpKTsKKyAgICBFWFBFQ1RfRVEoc3RhdGljX2Nhc3Q8c2l6ZV90PigyKSwgbV9mdW5jdGlv bkNhbGxPcmRlci5zaXplKCkpOwogICAgIEVYUEVDVF9TVFJFUShzaW1wbGVUZXN0TGFiZWwsIG1f ZnVuY3Rpb25DYWxsT3JkZXJbMF0uY19zdHIoKSk7CiAgICAgRVhQRUNUX1NUUkVRKGRpc3BhdGNo QWZ0ZXJMYWJlbCwgbV9mdW5jdGlvbkNhbGxPcmRlclsxXS5jX3N0cigpKTsKIH0K