142465 2015-03-08 15:25:07 -0700 [SVG -> OTF Converter] x-height cannot be specified 2015-03-09 12:39:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino jonlee simon.fraser thorton oldest_to_newest 1075439 0 mmaxfield 2015-03-08 15:25:07 -0700 [SVG -> OTF Converter] x-height cannot be specified 1075441 1 248209 mmaxfield 2015-03-08 15:26:15 -0700 Created attachment 248209 Patch 1075454 2 248209 simon.fraser 2015-03-08 15:54:44 -0700 Comment on attachment 248209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248209&action=review > LayoutTests/ChangeLog:9 > + For all non-system fonts, OS X disregards the font's reported x-height. Therefore, > + it is impossible to satisfy this test. But is this test not useful for other platforms? 1075609 3 mmaxfield 2015-03-09 08:50:17 -0700 (In reply to comment #2) > Comment on attachment 248209 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248209&action=review > > > LayoutTests/ChangeLog:9 > > + For all non-system fonts, OS X disregards the font's reported x-height. Therefore, > > + it is impossible to satisfy this test. > > But is this test not useful for other platforms? I don't think so. The fact that the computed x-height has a particular value if it is unspecified 1. isn't in the spec, and 2. doesn't seem to be valuable. There doesn't seem to be any reason why we should hold ourselves to this particular quality of font-face. 1075612 4 mmaxfield 2015-03-09 08:54:20 -0700 *** Bug 140537 has been marked as a duplicate of this bug. *** 1075713 5 248209 commit-queue 2015-03-09 12:24:53 -0700 Comment on attachment 248209 Patch Rejecting attachment 248209 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 248209, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fast/css/ex-unit-with-no-x-height-expected.txt' patching file LayoutTests/fast/css/ex-unit-with-no-x-height.html rm 'LayoutTests/fast/css/ex-unit-with-no-x-height.html' patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1245. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5564885299625984 1075722 6 mmaxfield 2015-03-09 12:39:38 -0700 Committed r181277: <http://trac.webkit.org/changeset/181277> 248209 2015-03-08 15:26:15 -0700 2015-03-09 12:24:53 -0700 Patch bug-142465-20150308152552.patch text/plain 3794 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjE0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTI4Y2E0N2QyZjlhZjM0NGRmOWEy Mzk2YTBlZjFhMDExYTkzYjI2MS4uZDc1NDNiYmQwMTczODhiYjhhYjkyOTRhYTM5MzUyNGM3NGRk M2IxZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTA4ICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW1NWRyAtPiBPVEYgQ29udmVydGVy XSB4LWhlaWdodCBjYW5ub3QgYmUgc3BlY2lmaWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI0NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgYWxsIG5vbi1zeXN0ZW0gZm9udHMsIE9TIFggZGlz cmVnYXJkcyB0aGUgZm9udCdzIHJlcG9ydGVkIHgtaGVpZ2h0LiBUaGVyZWZvcmUsCisgICAgICAg IGl0IGlzIGltcG9zc2libGUgdG8gc2F0aXNmeSB0aGlzIHRlc3QuCisKKyAgICAgICAgKiBmYXN0 L2Nzcy9leC11bml0LXdpdGgtbm8teC1oZWlnaHQtZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAg ICAgICAqIGZhc3QvY3NzL2V4LXVuaXQtd2l0aC1uby14LWhlaWdodC5odG1sOiBSZW1vdmVkLgor ICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE1LTAzLTA2ICBH eXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBFRkwgZ2FyZGVuaW5nIG9uIDd0aCBNYXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2Nzcy9leC11bml0LXdpdGgtbm8teC1oZWlnaHQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9jc3MvZXgtdW5pdC13aXRoLW5vLXgtaGVpZ2h0LWV4cGVjdGVkLnR4dApkZWxldGVk IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggNjI3OTg4MGMxYmZmNjZmY2ZmOWNiZTI0M2IxMGQ4Mjcx OTZhNDM2ZS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9leC11bml0LXdpdGgtbm8teC1oZWlnaHQtZXhwZWN0ZWQudHh0 CisrKyAvZGV2L251bGwKQEAgLTEsMTAgKzAsMCBAQAotVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCB0 aGUgQ1NTICdleCcgdW5pdCBpcyB0cmVhdGVkIGFzIGhhbGYgdGhlIHNpemUgb2YgdGhlIENTUyAn ZW0nIHVuaXQgd2hlbiBhIGZvbnQgaGFzIG5vIHgtaGVpZ2h0IGluZm9ybWF0aW9uLgotCi1PbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCi0KLQotUEFTUyBtZWFzdXJlRXhCb3goKTsgaXMgJzUwcHgn Ci1QQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCi0KLVRFU1QgQ09NUExFVEUKLQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZXgtdW5pdC13aXRoLW5vLXgtaGVpZ2h0Lmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9leC11bml0LXdpdGgtbm8teC1oZWlnaHQuaHRtbApk ZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMGQ1NjAyOWEyOGIwZTI3ZTY3MTIxZDQzZTI3 ZDYxZTI5MzU0ZGZhOC4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9leC11bml0LXdpdGgtbm8teC1oZWlnaHQuaHRtbAor KysgL2Rldi9udWxsCkBAIC0xLDM4ICswLDAgQEAKLTwhZG9jdHlwZSBodG1sPgotPHN2ZyB4bWxu cyA9ICdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2Zycgc3R5bGU9J2Rpc3BsYXk6bm9uZSc+Ci0g IDxkZWZzPgotICAgIDxmb250IGlkPSJGb250MSI+Ci0gICAgICA8Zm9udC1mYWNlIGZvbnQtZmFt aWx5PSJibG9jayIgLz4KLSAgICA8L2ZvbnQ+Ci0gIDwvZGVmcz4KLTwvc3ZnPgotCi08c3R5bGU+ Ci0uZW0geyBoZWlnaHQ6IC41ZW07IHdpZHRoOiAuNWVtOyB9Ci0uZXggeyBoZWlnaHQ6IDFleDsg d2lkdGg6IDFleDsgfQotLmNvdmVyIHsgYmFja2dyb3VuZDogZ3JlZW47IH0KLS5iYWNrIHsgYmFj a2dyb3VuZDogcmVkOyB9Ci0ub25lIHsgbGVmdDogMTBweDsgfQotLnR3byB7IGxlZnQ6IDcwcHg7 IH0KLSN0ZXN0ID4gZGl2IHsgZm9udC1mYW1pbHk6IGJsb2NrOyBmb250LXNpemU6IDEwMHB4OyBw b3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTBweDsgfQotI2Rlc2NyaXB0aW9uIHsgbWFyZ2luLXRv cDogNzBweDsgfQotPC9zdHlsZT4KLQotPGRpdiBpZD0ndGVzdCc+Ci0gIDxkaXYgY2xhc3M9J2Jh Y2sgZW0gb25lJz48L2Rpdj4KLSAgPGRpdiBjbGFzcz0nY292ZXIgZXggb25lJyBpZD0nZXgnPjwv ZGl2PgotCi0gIDxkaXYgY2xhc3M9J2JhY2sgZXggdHdvJz48L2Rpdj4KLSAgPGRpdiBjbGFzcz0n Y292ZXIgZW0gdHdvJz48L2Rpdj4KLTwvZGl2PgotPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Ci08c2NyaXB0PgotZGVzY3JpcHRpb24oIlRoaXMg dGVzdCBlbnN1cmVzIHRoYXQgdGhlIENTUyAnZXgnIHVuaXQgaXMgdHJlYXRlZCBhcyBoYWxmIHRo ZSBzaXplIG9mIHRoZSBDU1MgJ2VtJyB1bml0IHdoZW4gYSBmb250IGhhcyBubyB4LWhlaWdodCBp bmZvcm1hdGlvbi4iKQotCi1mdW5jdGlvbiBtZWFzdXJlRXhCb3goKSB7Ci0gIHJldHVybiBnZXRD b21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdleCcpKS53aWR0aDsKLX0KLQot c2hvdWxkQmUoIm1lYXN1cmVFeEJveCgpOyIsICInNTBweCciKQotPC9zY3JpcHQ+Ci08c2NyaXB0 IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGNmMmViYjA3OTdkNDdiMzk0 MTdhMTg4MjAzYjQ4ZDIzOTg1OGYxNGYuLjIwNjBmY2I4Y2U3NWQ2M2M5ODEwMGZhMDRhYjFlZGI2 ZjI3MmY4MTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBA IC0xMjQ1LDcgKzEyNDUsNiBAQCB3ZWJraXQub3JnL2IvMTM5OTY4IHN2Zy90ZXh0L3NlbGVjdC10 ZXh0TGVuZ3RoLXNwYWNpbmdBbmRHbHlwaHMtc3RyZXRjaC0xLnN2ZyBbCiB3ZWJraXQub3JnL2Iv MTM5OTY4IHN2Zy90ZXh0L3NlbGVjdC10ZXh0TGVuZ3RoLXNwYWNpbmdBbmRHbHlwaHMtc3RyZXRj aC0yLnN2ZyBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEzOTk2OCBzdmcvdGV4dC9zZWxlY3Qt dGV4dExlbmd0aC1zcGFjaW5nQW5kR2x5cGhzLXN0cmV0Y2gtMy5zdmcgWyBGYWlsdXJlIF0KIHdl YmtpdC5vcmcvYi8xMzk5Njggc3ZnL2N1c3RvbS9zdmctZm9udHMtd2l0aG91dC1taXNzaW5nLWds eXBoLnhodG1sIFsgUGFzcyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNDA1MzcgZmFzdC9jc3Mv ZXgtdW5pdC13aXRoLW5vLXgtaGVpZ2h0Lmh0bWwgWyBGYWlsdXJlIF0KIAogIyBTb21ldGltZXMg aGFzIGFuIGV4dHJhIHNwYWNlIGF0IHRoZSBlbmQKIGZhc3QvZm9ybXMvZm9jdXMtc2VsZWN0aW9u LXRleHRhcmVhLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQo=