142460 2015-03-08 13:38:19 -0700 BuiltinExecutables keeps finalized Weaks around, pinning WeakBlocks. 2015-03-08 16:47:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue darin ggaren kling oldest_to_newest 1075407 0 kling 2015-03-08 13:38:19 -0700 I'm seeing a bunch of WeakBlocks that are only kept alive by the UnlinkedFunctionExecutable Weak pointers in VM::builtinExecutables(). 1075414 1 248201 kling 2015-03-08 13:42:20 -0700 Created attachment 248201 Patch 1075446 2 248201 ggaren 2015-03-08 15:46:31 -0700 Comment on attachment 248201 Patch r=me I'll give you a dollar if you write the patch that says that a WeakBlock with only nulls should not pin down a MarkedBlock. 1075467 3 kling 2015-03-08 16:40:48 -0700 (In reply to comment #2) > Comment on attachment 248201 [details] > Patch > > r=me > > I'll give you a dollar if you write the patch that says that a WeakBlock > with only nulls should not pin down a MarkedBlock. You're on! 1075470 4 248201 commit-queue 2015-03-08 16:47:52 -0700 Comment on attachment 248201 Patch Clearing flags on attachment: 248201 Committed r181248: <http://trac.webkit.org/changeset/181248> 1075471 5 commit-queue 2015-03-08 16:47:56 -0700 All reviewed patches have been landed. Closing bug. 248201 2015-03-08 13:42:20 -0700 2015-03-08 16:47:52 -0700 Patch bug-142460.diff text/plain 3401 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVmYTRiODIuLmE1ODcwYmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE1LTAzLTA4ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBCdWlsdGluRXhlY3V0YWJsZXMga2VlcHMg ZmluYWxpemVkIFdlYWtzIGFyb3VuZCwgcGlubmluZyBXZWFrQmxvY2tzLgorICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMTQyNDYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE1ha2UgQnVpbHRpbkV4ZWN1dGFibGVzIGEgV2Vha0hhbmRsZU93 bmVyIHNvIGl0IGNhbiBjbGVhciBvdXQgaXRzIHJlc3BlY3RpdmUgV2VhayBtZW1iZXJzCisgICAg ICAgIGlmIGFuZCB3aGVuIHRoZWlyIHBvaW50ZWVzIGdldCBnYXJiYWdlIGNvbGxlY3RlZC4KKwor ICAgICAgICBUaGlzIGZpeGVzIGFuIGlzc3VlIEkndmUgc2VlbiBsb2NhbGx5IHdoZXJlIGEgV2Vh a0Jsb2NrIGlzIHBpbm5lZCBkb3duIGJ5IGEgc2luZ2xlIG9uZSBvZgorICAgICAgICB0aGVzZSBX ZWFrPEJ1aWx0aW5FeGVjdXRhYmxlcz4uCisKKyAgICAgICAgKiBidWlsdGlucy9CdWlsdGluRXhl Y3V0YWJsZXMuaDogTWFrZSBCdWlsdGluRXhlY3V0YWJsZXMgaW5oZXJpdCBmcm9tIFdlYWtIYW5k bGVPd25lci4KKworICAgICAgICAqIGJ1aWx0aW5zL0J1aWx0aW5FeGVjdXRhYmxlcy5jcHA6Cisg ICAgICAgIChKU0M6OkJ1aWx0aW5FeGVjdXRhYmxlczo6ZmluYWxpemUpOiBDbGVhciBvdXQgdGhl IHJlbGV2YW50IG1lbWJlciBwb2ludGVyIHdoZW4gaXQncyBiZWVuCisgICAgICAgIGdhcmJhZ2Ug Y29sbGVjdGVkLiBXZSB1c2UgdGhlIFdlYWtJbXBsJ3MgImNvbnRleHQiIGZpZWxkIHRvIHBhc3Mg dGhlIGFkZHJlc3Mgb2YgdGhlIG1lbWJlci4KKworMjAxNS0wMy0wOCAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CisKICAgICAgICAgSklUVGh1bmtzIGtlZXBzIGZpbmFsaXplZCBX ZWFrcyBhcm91bmQsIHBpbm5pbmcgV2Vha0Jsb2Nrcy4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzE0MjQ1ND4KIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL0J1aWx0aW5FeGVjdXRhYmxlcy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRp bnMvQnVpbHRpbkV4ZWN1dGFibGVzLmNwcAppbmRleCA2MTJkNjQ1Li4zYzhkYWM1IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQnVpbHRpbkV4ZWN1dGFibGVzLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQnVpbHRpbkV4ZWN1dGFibGVz LmNwcApAQCAtODMsMTEgKzgzLDE2IEBAIFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKiBCdWls dGluRXhlY3V0YWJsZXM6OmNyZWF0ZUJ1aWx0aW5FeGVjdXRhYmxlKGNvbnN0IFNvCiAgICAgcmV0 dXJuIGZ1bmN0aW9uRXhlY3V0YWJsZTsKIH0KIAordm9pZCBCdWlsdGluRXhlY3V0YWJsZXM6OmZp bmFsaXplKEhhbmRsZTxVbmtub3duPiwgdm9pZCogY29udGV4dCkKK3sKKyAgICBzdGF0aWNfY2Fz dDxXZWFrPFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlPio+KGNvbnRleHQpLT5jbGVhcigpOwor fQorCiAjZGVmaW5lIERFRklORV9CVUlMVElOX0VYRUNVVEFCTEVTKG5hbWUsIGZ1bmN0aW9uTmFt ZSwgbGVuZ3RoKSBcCiBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZSogQnVpbHRpbkV4ZWN1dGFi bGVzOjpuYW1lIyNFeGVjdXRhYmxlKCkgXAoge1wKICAgICBpZiAoIW1fIyNuYW1lIyNFeGVjdXRh YmxlKVwKLSAgICAgICAgbV8jI25hbWUjI0V4ZWN1dGFibGUgPSBjcmVhdGVCdWlsdGluRXhlY3V0 YWJsZShtXyMjbmFtZSMjU291cmNlLCBtX3ZtLnByb3BlcnR5TmFtZXMtPmJ1aWx0aW5OYW1lcygp LmZ1bmN0aW9uTmFtZSMjUHVibGljTmFtZSgpKTtcCisgICAgICAgIG1fIyNuYW1lIyNFeGVjdXRh YmxlID0gV2VhazxVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZT4oY3JlYXRlQnVpbHRpbkV4ZWN1 dGFibGUobV8jI25hbWUjI1NvdXJjZSwgbV92bS5wcm9wZXJ0eU5hbWVzLT5idWlsdGluTmFtZXMo KS5mdW5jdGlvbk5hbWUjI1B1YmxpY05hbWUoKSksIHRoaXMsICZtXyMjbmFtZSMjRXhlY3V0YWJs ZSk7XAogICAgIHJldHVybiBtXyMjbmFtZSMjRXhlY3V0YWJsZS5nZXQoKTtcCiB9CiBKU0NfRk9S RUFDSF9CVUlMVElOKERFRklORV9CVUlMVElOX0VYRUNVVEFCTEVTKQpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL0J1aWx0aW5FeGVjdXRhYmxlcy5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL0J1aWx0aW5FeGVjdXRhYmxlcy5oCmluZGV4IGIwNTNh MGUuLmMzMzBlOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9C dWlsdGluRXhlY3V0YWJsZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMv QnVpbHRpbkV4ZWN1dGFibGVzLmgKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJKU0NCdWls dGlucy5oIgogI2luY2x1ZGUgIlNvdXJjZUNvZGUuaCIKICNpbmNsdWRlICJXZWFrLmgiCisjaW5j bHVkZSAiV2Vha0hhbmRsZU93bmVyLmgiCiAKIG5hbWVzcGFjZSBKU0MgewogCkBAIC0zNiw3ICsz Nyw3IEBAIGNsYXNzIFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlOwogY2xhc3MgSWRlbnRpZmll cjsKIGNsYXNzIFZNOwogCi1jbGFzcyBCdWlsdGluRXhlY3V0YWJsZXMgeworY2xhc3MgQnVpbHRp bkV4ZWN1dGFibGVzIGZpbmFsOiBwcml2YXRlIFdlYWtIYW5kbGVPd25lciB7CiAgICAgV1RGX01B S0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgZXhwbGljaXQgQnVpbHRpbkV4ZWN1dGFi bGVzKFZNJik7CkBAIC00OSw2ICs1MCw4IEBAIGNvbnN0IFNvdXJjZUNvZGUmIG5hbWUjI1NvdXJj ZSgpIHsgcmV0dXJuIG1fIyNuYW1lIyNTb3VyY2U7IH0KICN1bmRlZiBFWFBPU0VfQlVJTFRJTl9T T1VSQ0VTCiAgICAgCiBwcml2YXRlOgorICAgIHZvaWQgZmluYWxpemUoSGFuZGxlPFVua25vd24+ LCB2b2lkKiBjb250ZXh0KSBvdmVycmlkZTsKKwogICAgIFZNJiBtX3ZtOwogICAgIFVubGlua2Vk RnVuY3Rpb25FeGVjdXRhYmxlKiBjcmVhdGVCdWlsdGluRXhlY3V0YWJsZShjb25zdCBTb3VyY2VD b2RlJiwgY29uc3QgSWRlbnRpZmllciYpOwogI2RlZmluZSBERUNMQVJFX0JVSUxUSU5fU09VUkNF X01FTUJFUlMobmFtZSwgZnVuY3Rpb25OYW1lLCBsZW5ndGgpXAo=