142456 2015-03-08 12:08:36 -0700 Shrink the CSSPropertyID enum type 2015-03-10 02:21:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan oldest_to_newest 1075389 0 zan 2015-03-08 12:08:36 -0700 Shrink the CSSPropertyID enum type 1075393 1 248194 zan 2015-03-08 12:18:13 -0700 Created attachment 248194 Patch 1075410 2 248194 sam 2015-03-08 13:40:04 -0700 Comment on attachment 248194 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248194&action=review > Source/WebCore/css/makeprop.pl:279 > +enum CSSPropertyID : uint16_t { Can you generate a static_assert (in CSSPropertyNames.cpp or somewhere similar) that asserts that the largest generated CSSPropertyID fits in 16bits? 1075597 3 248243 zan 2015-03-09 06:50:53 -0700 Created attachment 248243 Patch 1075730 4 248243 darin 2015-03-09 13:23:55 -0700 Comment on attachment 248243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248243&action=review > Source/WebCore/css/makeprop.pl:137 > +static_assert(numCSSProperties + 1 <= std::numeric_limits<uint16_t>::max(), "CSSPropertyID should fit into uint16_t."); Windows compiler doesn’t seem to be able to handle assertions that involve the numeric_limits max function; insufficient constexpr implementation perhaps? > Source/WebCore/css/makeprop.pl:283 > +enum CSSPropertyID : uint16_t { Need to remove the "< 0" check in CSSPrimitiveValue.cpp to make the compiler happy. Not sure why that < 0 was there. 1075737 5 248243 zan 2015-03-09 13:47:28 -0700 Comment on attachment 248243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248243&action=review >> Source/WebCore/css/makeprop.pl:137 >> +static_assert(numCSSProperties + 1 <= std::numeric_limits<uint16_t>::max(), "CSSPropertyID should fit into uint16_t."); > > Windows compiler doesn’t seem to be able to handle assertions that involve the numeric_limits max function; insufficient constexpr implementation perhaps? constexpr support in MSVC 2013 is non-existent. 1075743 6 248273 zan 2015-03-09 14:01:49 -0700 Created attachment 248273 Patch 1075925 7 248273 zan 2015-03-10 02:21:47 -0700 Comment on attachment 248273 Patch Clearing flags on attachment: 248273 Committed r181320: <http://trac.webkit.org/changeset/181320> 1075926 8 zan 2015-03-10 02:21:56 -0700 All reviewed patches have been landed. Closing bug. 248194 2015-03-08 12:18:13 -0700 2015-03-09 06:50:46 -0700 Patch bug-142456-20150308122045.patch text/plain 1342 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThlYjFlZmU3NGRlMzU3 NzhkNDIyODM1ZGU2YjVkMmFkM2JjMzE4Ny4uZjA3MTViMmJlZmI5ZmFlODExZDBhNTEyODQ2Y2Rk Zjg2MzY3ZWM5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAzLTA4ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBTaHJpbmsgdGhlIENT U1Byb3BlcnR5SUQgZW51bSB0eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDI0NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTcGVjaWZ5IHVpbnQxNl90IGFzIHRoZSBiYXNlIHR5cGUgZm9yIHRoZSBD U1NQcm9wZXJ0eUlEIGVudW0uCisgICAgICAgIFRoaXMgaXMgZW5vdWdoIHRvIGNvdmVyIGFsbCBv ZiB0aGUgQ1NTIHByb3BlcnRpZXMgKDQyOSBhdCB0aGlzIG1vbWVudCkuCisgICAgICAgIEl0IGhh bHZlcyB0aGUgZW51bSB0eXBlIHNpemUsIGZyb20gNCBieXRlcyB0byAyLCByZWR1Y2luZyB0aGUg c2l6ZSBvZgorICAgICAgICB2YXJpb3VzIENTU1Byb3BlcnR5SUQgY29udGFpbmVycy4KKworICAg ICAgICBObyBuZXcgdGVzdHMgLS0gbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICog Y3NzL21ha2Vwcm9wLnBsOgorCiAyMDE1LTAzLTA2ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5v cmc+CiAKICAgICAgICAgW0NvbnRlbnQgRXh0ZW5zaW9uc10gTW92ZSBjb21waWxpbmcgb2YgY29u dGVudCBleHRlbnNpb25zIHRvIHRoZSBVSVByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9tYWtlcHJvcC5wbCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbAppbmRl eCBlMmU4YmJmMTdmNGJlNGQyY2VhODc1YWI0YzZiM2RmMmJlYzA0NzkyLi5iYTVjMWNkNDc4N2Vl Mzc1MjJjZjE0NDYzNThhMWViOTc4MTRmMmMwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvbWFrZXByb3AucGwKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCkBAIC0y NzYsNyArMjc2LDcgQEAgY2xhc3MgU3RyaW5nOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWVu dW0gQ1NTUHJvcGVydHlJRCB7CitlbnVtIENTU1Byb3BlcnR5SUQgOiB1aW50MTZfdCB7CiAgICAg Q1NTUHJvcGVydHlJbnZhbGlkID0gMCwKIEVPRgogCg== 248243 2015-03-09 06:50:53 -0700 2015-03-09 14:01:42 -0700 Patch bug-142456-20150309065326.patch text/plain 1849 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM3MmQ0NTFmMjM2N2Rh NGM5OWM4ZGIzZWFjNDYyNjY3YjljNWNlNC4uNGYwZWM1YTk5MzlhYjFkZWUwNjJkNWQ1Y2RkYmNi MWJjMGRkMDJkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAzLTA5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBTaHJpbmsgdGhlIENT U1Byb3BlcnR5SUQgZW51bSB0eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDI0NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTcGVjaWZ5IHVpbnQxNl90IGFzIHRoZSBiYXNlIHR5cGUgZm9yIHRoZSBD U1NQcm9wZXJ0eUlEIGVudW0uCisgICAgICAgIFRoaXMgaXMgZW5vdWdoIHRvIGNvdmVyIGFsbCBv ZiB0aGUgQ1NTIHByb3BlcnRpZXMgKDQyOSBhdCB0aGlzIG1vbWVudCwKKyAgICAgICAgd2l0aCBz dGF0aWNfYXNzZXJ0IGNvdmVyaW5nIGZ1dHVyZSBjaGFuZ2VzKS4gSXQgaGFsdmVzIHRoZSBlbnVt IHR5cGUgc2l6ZSwKKyAgICAgICAgZnJvbSA0IGJ5dGVzIHRvIDIsIHJlZHVjaW5nIHRoZSBzaXpl IG9mIHZhcmlvdXMgQ1NTUHJvcGVydHlJRCBjb250YWluZXJzLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAtLSBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBjc3MvbWFrZXByb3Au cGw6CisKIDIwMTUtMDMtMDggIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1MgTWVkaWFdIFZpZGVvIGJ1ZmZlciBwcm9ncmVzcyBtaXNzaW5nIG9uIGlQaG9uZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9tYWtlcHJvcC5wbAppbmRleCBlMmU4YmJmMTdmNGJlNGQyY2VhODc1YWI0YzZiM2Rm MmJlYzA0NzkyLi4yNDE5Y2M5MDgzMGYxOGE3NjIwNjBiYzQyN2I0YjVjMDY3MDgwNjE1IDEwMDc1 NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL21ha2Vwcm9wLnBsCkBAIC0xMTgsNiArMTE4LDcgQEAgcHJpbnQgR1BFUkYgPDwgIkVP RiI7CiAjaW5jbHVkZSBcIkNTU1Byb3BlcnR5LmhcIgogI2luY2x1ZGUgXCJDU1NQcm9wZXJ0eU5h bWVzLmhcIgogI2luY2x1ZGUgXCJIYXNoVG9vbHMuaFwiCisjaW5jbHVkZSA8bGltaXRzPgogI2lu Y2x1ZGUgPHN0cmluZy5oPgogCiAjaW5jbHVkZSA8d3RmL0FTQ0lJQ1R5cGUuaD4KQEAgLTEzMiw2 ICsxMzMsOSBAQCBwcmludCBHUEVSRiA8PCAiRU9GIjsKICNlbmRpZgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CisKK3N0YXRpY19hc3NlcnQobnVtQ1NTUHJvcGVydGllcyArIDEgPD0gc3RkOjpudW1l cmljX2xpbWl0czx1aW50MTZfdD46Om1heCgpLCAiQ1NTUHJvcGVydHlJRCBzaG91bGQgZml0IGlu dG8gdWludDE2X3QuIik7CisKIEVPRgogCiBwcmludCBHUEVSRiAiY29uc3QgY2hhciogY29uc3Qg cHJvcGVydHlOYW1lU3RyaW5nc1tudW1DU1NQcm9wZXJ0aWVzXSA9IHtcbiI7CkBAIC0yNzYsNyAr MjgwLDcgQEAgY2xhc3MgU3RyaW5nOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWVudW0gQ1NT UHJvcGVydHlJRCB7CitlbnVtIENTU1Byb3BlcnR5SUQgOiB1aW50MTZfdCB7CiAgICAgQ1NTUHJv cGVydHlJbnZhbGlkID0gMCwKIEVPRgogCg== 248273 2015-03-09 14:01:49 -0700 2015-03-10 02:21:47 -0700 Patch bug-142456-20150309140421.patch text/plain 2524 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM3MmQ0NTFmMjM2N2Rh NGM5OWM4ZGIzZWFjNDYyNjY3YjljNWNlNC4uMmQ1MzkzZDcwNjk4NzFkOGFjOTRhMmNmOTA2MGY4 NGM0MGY1MmU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAzLTA5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBTaHJpbmsgdGhlIENT U1Byb3BlcnR5SUQgZW51bSB0eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDI0NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTcGVjaWZ5IHVpbnQxNl90IGFzIHRoZSBiYXNlIHR5cGUgZm9yIHRoZSBD U1NQcm9wZXJ0eUlEIGVudW0uCisgICAgICAgIFRoaXMgaXMgZW5vdWdoIHRvIGNvdmVyIGFsbCBv ZiB0aGUgQ1NTIHByb3BlcnRpZXMgKDQyOSBhdCB0aGlzIG1vbWVudCwKKyAgICAgICAgd2l0aCBz dGF0aWNfYXNzZXJ0IGNvdmVyaW5nIGZ1dHVyZSBjaGFuZ2VzKS4gSXQgaGFsdmVzIHRoZSBlbnVt IHR5cGUgc2l6ZSwKKyAgICAgICAgZnJvbSA0IGJ5dGVzIHRvIDIsIHJlZHVjaW5nIHRoZSBzaXpl IG9mIHZhcmlvdXMgQ1NTUHJvcGVydHlJRCBjb250YWluZXJzLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAtLSBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0 aXZlVmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJvcGVydHlOYW1lKTogUmVtb3ZlIHRo ZSB1bm5lY2Vzc2FyeSBwcm9wZXJ0eUlEIDwgMCBjaGVjay4KKyAgICAgICAgKiBjc3MvbWFrZXBy b3AucGw6CisKIDIwMTUtMDMtMDggIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAg ICAgICAgIFtpT1MgTWVkaWFdIFZpZGVvIGJ1ZmZlciBwcm9ncmVzcyBtaXNzaW5nIG9uIGlQaG9u ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmluZGV4IDBiMzQ0YWQz MWVmNmU1OGY4ODM3OGIyODc5ZjE0NWI0YjdiM2Y5ZDkuLjRjZmVkNTQ4NTM1NmNiZWM0NWZmM2Qw NzliZmU5MzU5ZTk5MmM5MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmlt aXRpdmVWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVl LmNwcApAQCAtMjIwLDkgKzIyMCw2IEBAIHN0YXRpYyBjb25zdCBBdG9taWNTdHJpbmcmIHByb3Bl cnR5TmFtZShDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQpCiAgICAgQVNTRVJUX0FSRyhwcm9wZXJ0 eUlELCBwcm9wZXJ0eUlEID49IDApOwogICAgIEFTU0VSVF9BUkcocHJvcGVydHlJRCwgKHByb3Bl cnR5SUQgPj0gZmlyc3RDU1NQcm9wZXJ0eSAmJiBwcm9wZXJ0eUlEIDwgZmlyc3RDU1NQcm9wZXJ0 eSArIG51bUNTU1Byb3BlcnRpZXMpKTsKIAotICAgIGlmIChwcm9wZXJ0eUlEIDwgMCkKLSAgICAg ICAgcmV0dXJuIG51bGxBdG9tOwotCiAgICAgcmV0dXJuIGdldFByb3BlcnR5TmFtZUF0b21pY1N0 cmluZyhwcm9wZXJ0eUlEKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL21h a2Vwcm9wLnBsIGIvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCmluZGV4IGUyZThiYmYx N2Y0YmU0ZDJjZWE4NzVhYjRjNmIzZGYyYmVjMDQ3OTIuLjYzZDU4NzU2MjM0MmIyNDY2Mjk3NDBi NDI2NmFlZjEyZGZmOWQwMzcgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJv cC5wbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKQEAgLTEzMiw2ICsxMzIs MTEgQEAgcHJpbnQgR1BFUkYgPDwgIkVPRiI7CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUg eworCisvLyBVc2luZyBzdGQ6Om51bWVyaWNfbGltaXRzPHVpbnQxNl90Pjo6bWF4KCkgaGVyZSB3 b3VsZCBiZSBjbGVhbmVyLAorLy8gYnV0IGlzIG5vdCBwb3NzaWJsZSBkdWUgdG8gbWlzc2luZyBj b25zdGV4cHIgc3VwcG9ydCBpbiBNU1ZDIDIwMTMuCitzdGF0aWNfYXNzZXJ0KG51bUNTU1Byb3Bl cnRpZXMgKyAxIDw9IDY1NTM1LCAiQ1NTUHJvcGVydHlJRCBzaG91bGQgZml0IGludG8gdWludDE2 X3QuIik7CisKIEVPRgogCiBwcmludCBHUEVSRiAiY29uc3QgY2hhciogY29uc3QgcHJvcGVydHlO YW1lU3RyaW5nc1tudW1DU1NQcm9wZXJ0aWVzXSA9IHtcbiI7CkBAIC0yNzYsNyArMjgxLDcgQEAg Y2xhc3MgU3RyaW5nOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWVudW0gQ1NTUHJvcGVydHlJ RCB7CitlbnVtIENTU1Byb3BlcnR5SUQgOiB1aW50MTZfdCB7CiAgICAgQ1NTUHJvcGVydHlJbnZh bGlkID0gMCwKIEVPRgogCg==