142454 2015-03-08 04:20:28 -0700 JITThunks keeps finalized Weaks around, pinning WeakBlocks. 2015-03-08 16:59:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling ggaren kling oldest_to_newest 1075368 0 kling 2015-03-08 04:20:28 -0700 I'm seeing a bunch of WeakBlocks that are only kept alive by the host function Weak pointers in VM::jitStubs. 1075369 1 248188 kling 2015-03-08 04:25:16 -0700 Created attachment 248188 Proposed patch 1075379 2 248188 darin 2015-03-08 10:45:39 -0700 Comment on attachment 248188 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=248188&action=review > Source/JavaScriptCore/jit/JITThunks.cpp:81 > + NativeExecutable* nativeExecutable = jsCast<NativeExecutable*>(handle.get().asCell()); I would use auto* here instead of NativeExecutable* here since the type is already named over on the right side of the line. Maybe use a reference here since this can’t be null? > Source/JavaScriptCore/jit/JITThunks.h:48 > +class JITThunks final : public WeakHandleOwner { How about using private inheritance instead of public? The new code seems to be all inside JITThunks member functions. 1075475 3 kling 2015-03-08 16:59:38 -0700 Committed <https://trac.webkit.org/r181250> 248188 2015-03-08 04:25:16 -0700 2015-03-08 10:45:39 -0700 Proposed patch bug-142454.diff text/plain 4272 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDY3ZDcyYjEuLjVmYTRiODIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAzLTA4ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBKSVRUaHVua3Mga2VlcHMgZmluYWxpemVk IFdlYWtzIGFyb3VuZCwgcGlubmluZyBXZWFrQmxvY2tzLgorICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMTQyNDU0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1ha2UgSklUVGh1bmtzIGEgV2Vha0hhbmRsZU93bmVyIHNvIGl0IGNhbiBrZWVw IGl0cyBob3N0IGZ1bmN0aW9uIG1hcCBmcmVlIG9mIHN0YWxlIGVudHJpZXMuCisgICAgICAgIFRo aXMgZml4ZXMgYW4gaXNzdWUgSSB3YXMgc2VlaW5nIHdoZXJlIGEgYnVuY2ggb2YgV2Vha0Jsb2Nr cyBzdHVjayBhcm91bmQgd2l0aCBub3RoaW5nIGJ1dAorICAgICAgICBmaW5hbGl6ZWQgV2VhazxO YXRpdmVFeGVjdXRhYmxlPiBlbnRyaWVzLgorCisgICAgICAgICogaml0L0pJVFRodW5rcy5oOgor ICAgICAgICAqIGppdC9KSVRUaHVua3MuY3BwOgorICAgICAgICAoSlNDOjpKSVRUaHVua3M6OmZp bmFsaXplKTogTWFrZSBKSVRUaHVua3MgaW5oZXJpdCBmcm9tIFdlYWtIYW5kbGVPd25lciBzbyBp dCBjYW4gcmVjZWl2ZQorICAgICAgICBhIGNhbGxiYWNrIHdoZW4gdGhlIE5hdGl2ZUV4ZWN1dGFi bGVzIGdldCBnYXJiYWdlIGNvbGxlY3RlZC4KKworICAgICAgICAoSlNDOjpKSVRUaHVua3M6Omhv c3RGdW5jdGlvblN0dWIpOiBQYXNzICd0aGlzJyBhcyB0aGUgaGFuZGxlIG93bmVyIHdoZW4gY3Jl YXRpbmcgV2Vha3MuCisKIDIwMTUtMDMtMDcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxl LmNvbT4KIAogICAgICAgICBVc2UgRmFzdE1hbGxvYyAoYm1hbGxvYykgaW5zdGVhZCBvZiBCbG9j a0FsbG9jYXRvciBmb3IgR0MgcGFnZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUVGh1bmtzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUVGh1bmtz LmNwcAppbmRleCA2ZTcxZGY5Li43NzFlYTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0pJVFRodW5rcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRUaHVua3MuY3BwCkBAIC03Niw2ICs3NiwxMiBAQCBNYWNyb0Fzc2VtYmxlckNvZGVSZWYgSklU VGh1bmtzOjpjdGlTdHViKFZNKiB2bSwgVGh1bmtHZW5lcmF0b3IgZ2VuZXJhdG9yKQogICAgIHJl dHVybiBlbnRyeS5pdGVyYXRvci0+dmFsdWU7CiB9CiAKK3ZvaWQgSklUVGh1bmtzOjpmaW5hbGl6 ZShIYW5kbGU8VW5rbm93bj4gaGFuZGxlLCB2b2lkKikKK3sKKyAgICBOYXRpdmVFeGVjdXRhYmxl KiBuYXRpdmVFeGVjdXRhYmxlID0ganNDYXN0PE5hdGl2ZUV4ZWN1dGFibGUqPihoYW5kbGUuZ2V0 KCkuYXNDZWxsKCkpOworICAgIHdlYWtSZW1vdmUoKm1faG9zdEZ1bmN0aW9uU3R1Yk1hcCwgc3Rk OjptYWtlX3BhaXIobmF0aXZlRXhlY3V0YWJsZS0+ZnVuY3Rpb24oKSwgbmF0aXZlRXhlY3V0YWJs ZS0+Y29uc3RydWN0b3IoKSksIG5hdGl2ZUV4ZWN1dGFibGUpOworfQorCiBOYXRpdmVFeGVjdXRh YmxlKiBKSVRUaHVua3M6Omhvc3RGdW5jdGlvblN0dWIoVk0qIHZtLCBOYXRpdmVGdW5jdGlvbiBm dW5jdGlvbiwgTmF0aXZlRnVuY3Rpb24gY29uc3RydWN0b3IpCiB7CiAgICAgQVNTRVJUKCFpc0Nv bXBpbGF0aW9uVGhyZWFkKCkpOwpAQCAtODksNyArOTUsNyBAQCBOYXRpdmVFeGVjdXRhYmxlKiBK SVRUaHVua3M6Omhvc3RGdW5jdGlvblN0dWIoVk0qIHZtLCBOYXRpdmVGdW5jdGlvbiBmdW5jdGlv biwgTgogICAgICAgICBmdW5jdGlvbiwKICAgICAgICAgYWRvcHRSZWYobmV3IE5hdGl2ZUpJVENv ZGUoTWFjcm9Bc3NlbWJsZXJDb2RlUmVmOjpjcmVhdGVTZWxmTWFuYWdlZENvZGVSZWYoY3RpTmF0 aXZlQ29uc3RydWN0KHZtKSksIEpJVENvZGU6Okhvc3RDYWxsVGh1bmspKSwKICAgICAgICAgY29u c3RydWN0b3IsIE5vSW50cmluc2ljKTsKLSAgICB3ZWFrQWRkKCptX2hvc3RGdW5jdGlvblN0dWJN YXAsIHN0ZDo6bWFrZV9wYWlyKGZ1bmN0aW9uLCBjb25zdHJ1Y3RvciksIFdlYWs8TmF0aXZlRXhl Y3V0YWJsZT4obmF0aXZlRXhlY3V0YWJsZSkpOworICAgIHdlYWtBZGQoKm1faG9zdEZ1bmN0aW9u U3R1Yk1hcCwgc3RkOjptYWtlX3BhaXIoZnVuY3Rpb24sIGNvbnN0cnVjdG9yKSwgV2VhazxOYXRp dmVFeGVjdXRhYmxlPihuYXRpdmVFeGVjdXRhYmxlLCB0aGlzKSk7CiAgICAgcmV0dXJuIG5hdGl2 ZUV4ZWN1dGFibGU7CiB9CiAKQEAgLTExMSw3ICsxMTcsNyBAQCBOYXRpdmVFeGVjdXRhYmxlKiBK SVRUaHVua3M6Omhvc3RGdW5jdGlvblN0dWIoVk0qIHZtLCBOYXRpdmVGdW5jdGlvbiBmdW5jdGlv biwgVAogICAgIFJlZlB0cjxKSVRDb2RlPiBmb3JDb25zdHJ1Y3QgPSBhZG9wdFJlZihuZXcgTmF0 aXZlSklUQ29kZShNYWNyb0Fzc2VtYmxlckNvZGVSZWY6OmNyZWF0ZVNlbGZNYW5hZ2VkQ29kZVJl ZihjdGlOYXRpdmVDb25zdHJ1Y3Qodm0pKSwgSklUQ29kZTo6SG9zdENhbGxUaHVuaykpOwogICAg IAogICAgIE5hdGl2ZUV4ZWN1dGFibGUqIG5hdGl2ZUV4ZWN1dGFibGUgPSBOYXRpdmVFeGVjdXRh YmxlOjpjcmVhdGUoKnZtLCBmb3JDYWxsLCBmdW5jdGlvbiwgZm9yQ29uc3RydWN0LCBjYWxsSG9z dEZ1bmN0aW9uQXNDb25zdHJ1Y3RvciwgaW50cmluc2ljKTsKLSAgICB3ZWFrQWRkKCptX2hvc3RG dW5jdGlvblN0dWJNYXAsIHN0ZDo6bWFrZV9wYWlyKGZ1bmN0aW9uLCAmY2FsbEhvc3RGdW5jdGlv bkFzQ29uc3RydWN0b3IpLCBXZWFrPE5hdGl2ZUV4ZWN1dGFibGU+KG5hdGl2ZUV4ZWN1dGFibGUp KTsKKyAgICB3ZWFrQWRkKCptX2hvc3RGdW5jdGlvblN0dWJNYXAsIHN0ZDo6bWFrZV9wYWlyKGZ1 bmN0aW9uLCAmY2FsbEhvc3RGdW5jdGlvbkFzQ29uc3RydWN0b3IpLCBXZWFrPE5hdGl2ZUV4ZWN1 dGFibGU+KG5hdGl2ZUV4ZWN1dGFibGUsIHRoaXMpKTsKICAgICByZXR1cm4gbmF0aXZlRXhlY3V0 YWJsZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRUaHVu a3MuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUVGh1bmtzLmgKaW5kZXggM2M2MTU2 ZS4uNzEwZjVkYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRUaHVu a3MuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFRodW5rcy5oCkBAIC0zNCw2 ICszNCw3IEBACiAjaW5jbHVkZSAiTWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmgiCiAjaW5jbHVkZSAi VGh1bmtHZW5lcmF0b3IuaCIKICNpbmNsdWRlICJXZWFrLmgiCisjaW5jbHVkZSAiV2Vha0hhbmRs ZU93bmVyLmgiCiAjaW5jbHVkZSAiV2Vha0lubGluZXMuaCIKICNpbmNsdWRlIDx3dGYvSGFzaE1h cC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KQEAgLTQ0LDEwICs0NSwxMCBAQCBuYW1lc3Bh Y2UgSlNDIHsKIGNsYXNzIFZNOwogY2xhc3MgTmF0aXZlRXhlY3V0YWJsZTsKIAotY2xhc3MgSklU VGh1bmtzIHsKK2NsYXNzIEpJVFRodW5rcyBmaW5hbCA6IHB1YmxpYyBXZWFrSGFuZGxlT3duZXIg ewogcHVibGljOgogICAgIEpJVFRodW5rcygpOwotICAgIH5KSVRUaHVua3MoKTsKKyAgICB2aXJ0 dWFsIH5KSVRUaHVua3MoKTsKIAogICAgIE1hY3JvQXNzZW1ibGVyQ29kZVB0ciBjdGlOYXRpdmVD YWxsKFZNKik7CiAgICAgTWFjcm9Bc3NlbWJsZXJDb2RlUHRyIGN0aU5hdGl2ZUNvbnN0cnVjdChW TSopOwpAQCAtNjQsNiArNjUsOCBAQCBwcml2YXRlOgogICAgIC8vIE1haW4gdGhyZWFkIGNhbiBo b2xkIHRoaXMgbG9jayBmb3IgYSB3aGlsZSwgc28gdXNlIGFuIGFkYXB0aXZlIG11dGV4LgogICAg IHR5cGVkZWYgTXV0ZXggTG9jazsKICAgICB0eXBlZGVmIE11dGV4TG9ja2VyIExvY2tlcjsKKwor ICAgIHZvaWQgZmluYWxpemUoSGFuZGxlPFVua25vd24+LCB2b2lkKiBjb250ZXh0KSBvdmVycmlk ZTsKICAgICAKICAgICB0eXBlZGVmIEhhc2hNYXA8VGh1bmtHZW5lcmF0b3IsIE1hY3JvQXNzZW1i bGVyQ29kZVJlZj4gQ1RJU3R1Yk1hcDsKICAgICBDVElTdHViTWFwIG1fY3RpU3R1Yk1hcDsK