142448 2015-03-07 20:23:47 -0800 DumpRenderTree and WebKitTestRunner should rename WorkQueue to something that will not be confused with WTF::WorkQueue 2015-03-10 15:55:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 bfulgham webkit-unassigned andersca bfulgham koivisto sam oldest_to_newest 1075335 0 bfulgham 2015-03-07 20:23:47 -0800 For historical reasons, DumpRenderTree and WebKitTestRunner have their own WorkQueue implementations. Now that WorkQueue lives in WTF, we should merge these disparate implementations and standardize on one implementation. This will simplify the code, as well as increasing the test coverage for this functionality. 1075473 1 sam 2015-03-08 16:56:34 -0700 The WorkQueue classes in DRT and WKTR are not threading primitives like WTF::WorkQueue, but rather just a plain old queue of things to do (it's actually quite similar to WTF::MessageQueue). Having the same name does complicate things here, I admit. 1075777 2 andersca 2015-03-09 15:13:55 -0700 Are they really similar enough to WTF::WorkQueue that we could just use it? 1075779 3 bfulgham 2015-03-09 15:21:25 -0700 (In reply to comment #2) > Are they really similar enough to WTF::WorkQueue that we could just use it? Maybe not. I notice the DRT/WKTR version has the concept of being "frozen", which seems to mean "ignore any passed dispatch functions". I'm not sure we would want that "feature" to be part of the WTF::WorkQueue implementation, so maybe we should just leave things as-is. 1076079 4 sam 2015-03-10 14:19:39 -0700 (In reply to comment #3) > (In reply to comment #2) > > Are they really similar enough to WTF::WorkQueue that we could just use it? > > Maybe not. I notice the DRT/WKTR version has the concept of being "frozen", > which seems to mean "ignore any passed dispatch functions". I'm not sure we > would want that "feature" to be part of the WTF::WorkQueue implementation, > so maybe we should just leave things as-is. We should probably just mutate this bug into renaming the DRT/WKTR classes. I have not good ideas for names.