142428 2015-03-06 20:11:37 -0800 Web Inspector: JS Pretty Printing: "case" or "default" outside of switch causes unbalanced indentation 2015-03-06 22:11:08 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1075218 0 joepeck 2015-03-06 20:11:37 -0800 * SUMMARY JS Pretty Printing: "case" or "default" outside of switch causes unbalanced indentation. It breaks indentation of the rest of the file. * TEST function(){this.default;this.other;} * EXPECTED function(){ this.default; this.other; } * ACTUAL function(){ this.default; this.other; } 1075219 1 webkit-bug-importer 2015-03-06 20:12:09 -0800 <rdar://problem/20081419> 1075220 2 248136 joepeck 2015-03-06 20:13:22 -0800 Created attachment 248136 [PATCH] Proposed Fix 1075240 3 248136 commit-queue 2015-03-06 22:11:03 -0800 Comment on attachment 248136 [PATCH] Proposed Fix Clearing flags on attachment: 248136 Committed r181205: <http://trac.webkit.org/changeset/181205> 1075241 4 commit-queue 2015-03-06 22:11:08 -0800 All reviewed patches have been landed. Closing bug. 248136 2015-03-06 20:13:22 -0800 2015-03-06 22:11:03 -0800 [PATCH] Proposed Fix fix-pretty-print.patch text/plain 4299 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU5ZTI4ZmIuLjk0OWRjNjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTAzLTA2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSlMgUHJl dHR5IFByaW50aW5nOiAiY2FzZSIgb3IgImRlZmF1bHQiIG91dHNpZGUgb2Ygc3dpdGNoIGNhdXNl cyB1bmJhbGFuY2VkIGluZGVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDI0MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFRvb2xzL1ByZXR0eVByaW50aW5nL0NvZGVNaXJyb3JGb3JtYXR0 ZXJzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckZvcm1hdHRl cnMuanM6CisgICAgICAgIEZpeCAiY2FzZSIgYW5kICJkZWZhdWx0IiBpbmRlbnRhdGlvbiBydWxl cyB0byBvbmx5IGhhcHBlbiBpbnNpZGUgYSBzd2l0Y2guCisKKyAgICAgICAgKiBUb29scy9QcmV0 dHlQcmludGluZy9qcy10ZXN0cy9zd2l0Y2gtY2FzZS1kZWZhdWx0LWV4cGVjdGVkLmpzOgorICAg ICAgICAqIFRvb2xzL1ByZXR0eVByaW50aW5nL2pzLXRlc3RzL3N3aXRjaC1jYXNlLWRlZmF1bHQu anM6CisgICAgICAgIEFkZCB0ZXN0cyBmb3IgImNhc2UiIGFuZCAiZGVmYXVsdCIgbmVzdGVkIGlu c2lkZSBhbmQgb3V0c2lkZSBvZiBzd2l0Y2hlcy4KKworMjAxNS0wMy0wNiAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVTNjog SW1wcm92ZWQgU3VwcG9ydCBmb3IgSXRlcmF0b3IgT2JqZWN0cwogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNDIwCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Ub29scy9QcmV0dHlQcmludGluZy9Db2RlTWlycm9yRm9ybWF0dGVy cy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Ub29scy9QcmV0dHlQcmludGluZy9Db2RlTWly cm9yRm9ybWF0dGVycy5qcwppbmRleCBmZWM4MzkyLi43MTQzOWNkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVG9vbHMvUHJldHR5UHJpbnRpbmcvQ29kZU1pcnJvckZvcm1hdHRl cnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Rvb2xzL1ByZXR0eVByaW50aW5nL0Nv ZGVNaXJyb3JGb3JtYXR0ZXJzLmpzCkBAIC0xMzcsNyArMTM3LDEzIEBAIENvZGVNaXJyb3IuZXh0 ZW5kTW9kZSgiamF2YXNjcmlwdCIsIHsKIAogICAgIGluZGVudEFmdGVyVG9rZW46IGZ1bmN0aW9u KGxhc3RUb2tlbiwgbGFzdENvbnRlbnQsIHRva2VuLCBzdGF0ZSwgY29udGVudCwgaXNDb21tZW50 KQogICAgIHsKLSAgICAgICAgcmV0dXJuIGNvbnRlbnQgPT09ICJ7IiB8fCBjb250ZW50ID09PSAi Y2FzZSIgfHwgY29udGVudCA9PT0gImRlZmF1bHQiOworICAgICAgICBpZiAoY29udGVudCA9PT0g InsiKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICAgICAgaWYgKGNvbnRlbnQgPT09 ICJjYXNlIiB8fCBjb250ZW50ID09PSAiZGVmYXVsdCIpCisgICAgICAgICAgICByZXR1cm4gc3Rh dGUubGV4aWNhbC50eXBlID09PSAifSIgJiYgc3RhdGUubGV4aWNhbC5wcmV2ICYmIHN0YXRlLmxl eGljYWwucHJldi50eXBlID09PSAiZm9ybSI7IC8vIFN3aXRjaCBjYXNlL2RlZmF1bHQuCisKKyAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0sCiAKICAgICBuZXdsaW5lQmVmb3JlVG9rZW46IGZ1 bmN0aW9uKGxhc3RUb2tlbiwgbGFzdENvbnRlbnQsIHRva2VuLCBzdGF0ZSwgY29udGVudCwgaXND b21tZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Rvb2xzL1ByZXR0eVBy aW50aW5nL2pzLXRlc3RzL3N3aXRjaC1jYXNlLWRlZmF1bHQtZXhwZWN0ZWQuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVG9vbHMvUHJldHR5UHJpbnRpbmcvanMtdGVzdHMvc3dpdGNoLWNhc2Ut ZGVmYXVsdC1leHBlY3RlZC5qcwppbmRleCBlYjE5NDI0Li42ZTJkOTVlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVG9vbHMvUHJldHR5UHJpbnRpbmcvanMtdGVzdHMvc3dpdGNo LWNhc2UtZGVmYXVsdC1leHBlY3RlZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVG9v bHMvUHJldHR5UHJpbnRpbmcvanMtdGVzdHMvc3dpdGNoLWNhc2UtZGVmYXVsdC1leHBlY3RlZC5q cwpAQCAtMSw4ICsxLDE3IEBACitmdW5jdGlvbiBDdG9yMSgpIHsKKyAgICB0aGlzLmNhc2UgPSAx OworICAgIHRoaXMuc29tZXRoaW5nID0gMjsKK30KK2Z1bmN0aW9uIEN0b3IyKCkgeworICAgIHRo aXMuZGVmYXVsdCA9IDE7CisgICAgdGhpcy5zb21ldGhpbmcgPSAyOworfQorCiBzd2l0Y2ggKHgp IHsKIGNhc2UgImFiYyI6Ci0gICAgcmV0dXJuIDE7CisgICAgcmV0dXJuIHRoaXMuZGVmYXVsdDsK IGNhc2UgImRlZiI6Ci0gICAgcmV0dXJuIDI7CisgICAgcmV0dXJuIHRoaXMuY2FzZTsKIGRlZmF1 bHQ6CiAgICAgcmV0dXJuIDM7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VG9vbHMvUHJldHR5UHJpbnRpbmcvanMtdGVzdHMvc3dpdGNoLWNhc2UtZGVmYXVsdC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Ub29scy9QcmV0dHlQcmludGluZy9qcy10ZXN0cy9zd2l0Y2gt Y2FzZS1kZWZhdWx0LmpzCmluZGV4IDQ5ZGI4NmYuLjg3N2Q5ODggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Ub29scy9QcmV0dHlQcmludGluZy9qcy10ZXN0cy9zd2l0Y2gtY2Fz ZS1kZWZhdWx0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Ub29scy9QcmV0dHlQcmlu dGluZy9qcy10ZXN0cy9zd2l0Y2gtY2FzZS1kZWZhdWx0LmpzCkBAIC0xLDQgKzEsNyBAQAotc3dp dGNoKHgpe2Nhc2UgImFiYyI6cmV0dXJuIDE7Y2FzZSAiZGVmIjpyZXR1cm4gMjtkZWZhdWx0OnJl dHVybiAzO30KK2Z1bmN0aW9uIEN0b3IxKCl7dGhpcy5jYXNlPTE7dGhpcy5zb21ldGhpbmc9Mjt9 CitmdW5jdGlvbiBDdG9yMigpe3RoaXMuZGVmYXVsdD0xO3RoaXMuc29tZXRoaW5nPTI7fQorCitz d2l0Y2goeCl7Y2FzZSAiYWJjIjpyZXR1cm4gdGhpcy5kZWZhdWx0O2Nhc2UgImRlZiI6cmV0dXJu IHRoaXMuY2FzZTtkZWZhdWx0OnJldHVybiAzO30KIAogc3dpdGNoKHgpewogICBjYXNlICJhYmMi OgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv Q29kZU1pcnJvckZvcm1hdHRlcnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db2RlTWlycm9yRm9ybWF0dGVycy5qcwppbmRleCBmZWM4MzkyLi43MTQzOWNk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D b2RlTWlycm9yRm9ybWF0dGVycy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yRm9ybWF0dGVycy5qcwpAQCAtMTM3LDcgKzEzNywxMyBA QCBDb2RlTWlycm9yLmV4dGVuZE1vZGUoImphdmFzY3JpcHQiLCB7CiAKICAgICBpbmRlbnRBZnRl clRva2VuOiBmdW5jdGlvbihsYXN0VG9rZW4sIGxhc3RDb250ZW50LCB0b2tlbiwgc3RhdGUsIGNv bnRlbnQsIGlzQ29tbWVudCkKICAgICB7Ci0gICAgICAgIHJldHVybiBjb250ZW50ID09PSAieyIg fHwgY29udGVudCA9PT0gImNhc2UiIHx8IGNvbnRlbnQgPT09ICJkZWZhdWx0IjsKKyAgICAgICAg aWYgKGNvbnRlbnQgPT09ICJ7IikKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworCisgICAgICAg IGlmIChjb250ZW50ID09PSAiY2FzZSIgfHwgY29udGVudCA9PT0gImRlZmF1bHQiKQorICAgICAg ICAgICAgcmV0dXJuIHN0YXRlLmxleGljYWwudHlwZSA9PT0gIn0iICYmIHN0YXRlLmxleGljYWwu cHJldiAmJiBzdGF0ZS5sZXhpY2FsLnByZXYudHlwZSA9PT0gImZvcm0iOyAvLyBTd2l0Y2ggY2Fz ZS9kZWZhdWx0LgorCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9LAogCiAgICAgbmV3bGlu ZUJlZm9yZVRva2VuOiBmdW5jdGlvbihsYXN0VG9rZW4sIGxhc3RDb250ZW50LCB0b2tlbiwgc3Rh dGUsIGNvbnRlbnQsIGlzQ29tbWVudCkK