142424 2015-03-06 18:16:53 -0800 ES6: Iterator toString names should be consistent 2015-04-10 18:01:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck ysuzuki commit-queue ggaren joepeck ysuzuki oldest_to_newest 1075196 0 joepeck 2015-03-06 18:16:53 -0800 * SUMMARY Iterator Object Names in the spec right now have spaces. In our implementation some do and some don't. * TEST js> "string"[Symbol.iterator]().toString() <- "[object StringIterator]" js> (new Map).entries().toString() <- "[object Map Iterator]" We have Map/Set with spaces, but String/Array without spaces. Also, I don't know what would be expected of "ArgumentsIterator" given it is an internal type. * SPEC > 21.1.5.2.2 %StringIteratorPrototype% [ @@toStringTag ] > The initial value of the @@toStringTag property is the string value "String Iterator". > > 22.1.5.2.2 %ArrayIteratorPrototype% [ @@toStringTag ] > The initial value of the @@toStringTag property is the string value "Array Iterator". > > 23.1.5.2.2 %MapIteratorPrototype% [ @@toStringTag ] > The initial value of the @@toStringTag property is the string value "Map Iterator". > > 23.2.5.2.2 %SetIteratorPrototype% [ @@toStringTag ] > The initial value of the @@toStringTag property is the string value "Set Iterator". I think it is weird to have spaces. The spec defines "GeneratorFunction" without a space. Maybe this is something that should change in the spec or be discussed. 1084158 1 250491 ysuzuki 2015-04-09 18:08:07 -0700 Created attachment 250491 Patch 1084351 2 250491 ggaren 2015-04-10 11:30:45 -0700 Comment on attachment 250491 Patch r=me 1084430 3 250491 commit-queue 2015-04-10 18:01:05 -0700 Comment on attachment 250491 Patch Clearing flags on attachment: 250491 Committed r182647: <http://trac.webkit.org/changeset/182647> 1084431 4 commit-queue 2015-04-10 18:01:09 -0700 All reviewed patches have been landed. Closing bug. 250491 2015-04-09 18:08:07 -0700 2015-04-10 18:01:05 -0700 Patch bug-142424-20150410100715.patch text/plain 3764 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MDhhYzlhNDAwYmQ0NjFlNTU4ZDBkNzQ1MGFjZWRiNjI4MzRlNDg2Li43YmQwOTFjMThlZGY5MGRh ZjNmODQ1Mjc5ZTczNGQwZTYzZWE0MTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNS0wNC0wOSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBFUzY6IEl0ZXJhdG9yIHRvU3RyaW5nIG5hbWVzIHNob3VsZCBiZSBj b25zaXN0ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDI0MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJdGVyYXRvciBPYmplY3QgTmFtZXMgaW4gdGhlIHNwZWMgcmlnaHQgbm93IGhhdmUgc3BhY2Vz LgorICAgICAgICBJbiBvdXIgaW1wbGVtZW50YXRpb24gc29tZSBkbyBhbmQgc29tZSBkb24ndC4K KyAgICAgICAgVGhpcyBwYXRjaCBhbGlnbnMgSlNDIHRvIHRoZSBzcGVjLgorCisgICAgICAgICog cnVudGltZS9KU0FycmF5SXRlcmF0b3IuY3BwOgorICAgICAgICAqIHJ1bnRpbWUvSlNTdHJpbmdJ dGVyYXRvci5jcHA6CisgICAgICAgICogdGVzdHMvc3RyZXNzL2l0ZXJhdG9yLW5hbWVzLmpzOiBB ZGRlZC4KKyAgICAgICAgKHRlc3QpOgorICAgICAgICAoaXRlcik6CisgICAgICAgIChjaGVjayk6 CisKIDIwMTUtMDQtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBVc2UganNOb250cml2aWFsU3RyaW5nIGluIG1vcmUgcGxhY2VzIGlmIHRoZSBzdHJp bmcgaXMgZ3VhcmFudGVlZCB0byBiZSAyIG9yIG1vcmUgY2hhcmFjdGVycwpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheUl0ZXJhdG9yLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXlJdGVyYXRvci5jcHAKaW5kZXggZjIwMzll MWJlZWJlN2NhNmYyZDc5Nzc4OGM0MTM5OGEyMmRkYjg4NC4uMGFiYzlkMTIwZmIwMWJhYzIyMDIz Mjc2MWFlYWJiMDllNzBhMzMyMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNBcnJheUl0ZXJhdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0FycmF5SXRlcmF0b3IuY3BwCkBAIC0zMyw3ICszMyw3IEBACiAKIG5hbWVzcGFjZSBK U0MgewogCi1jb25zdCBDbGFzc0luZm8gSlNBcnJheUl0ZXJhdG9yOjpzX2luZm8gPSB7ICJBcnJh eUl0ZXJhdG9yIiwgJkJhc2U6OnNfaW5mbywgMCwgQ1JFQVRFX01FVEhPRF9UQUJMRShKU0FycmF5 SXRlcmF0b3IpIH07Citjb25zdCBDbGFzc0luZm8gSlNBcnJheUl0ZXJhdG9yOjpzX2luZm8gPSB7 ICJBcnJheSBJdGVyYXRvciIsICZCYXNlOjpzX2luZm8sIDAsIENSRUFURV9NRVRIT0RfVEFCTEUo SlNBcnJheUl0ZXJhdG9yKSB9OwogCiB2b2lkIEpTQXJyYXlJdGVyYXRvcjo6ZmluaXNoQ3JlYXRp b24oVk0mIHZtLCBKU0dsb2JhbE9iamVjdCosIEFycmF5SXRlcmF0aW9uS2luZCBraW5kLCBKU09i amVjdCogaXRlcmF0ZWRPYmplY3QpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU1N0cmluZ0l0ZXJhdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTU3RyaW5nSXRlcmF0b3IuY3BwCmluZGV4IDYyZDc0ODYwNGQwOTA4YTE1NGJiYzBl MzRhZTljNWQ2OTViOGIyZmEuLmM2ZmVkZTdhZGFmMTAwNWUxNmMxYjc0NGMyMjdlMDZlNjNkZmNi YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nSXRl cmF0b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nSXRl cmF0b3IuY3BwCkBAIC0zMiw3ICszMiw3IEBACiAKIG5hbWVzcGFjZSBKU0MgewogCi1jb25zdCBD bGFzc0luZm8gSlNTdHJpbmdJdGVyYXRvcjo6c19pbmZvID0geyAiU3RyaW5nSXRlcmF0b3IiLCAm QmFzZTo6c19pbmZvLCAwLCBDUkVBVEVfTUVUSE9EX1RBQkxFKEpTU3RyaW5nSXRlcmF0b3IpIH07 Citjb25zdCBDbGFzc0luZm8gSlNTdHJpbmdJdGVyYXRvcjo6c19pbmZvID0geyAiU3RyaW5nIEl0 ZXJhdG9yIiwgJkJhc2U6OnNfaW5mbywgMCwgQ1JFQVRFX01FVEhPRF9UQUJMRShKU1N0cmluZ0l0 ZXJhdG9yKSB9OwogCiB2b2lkIEpTU3RyaW5nSXRlcmF0b3I6OmZpbmlzaENyZWF0aW9uKFZNJiB2 bSwgSlNHbG9iYWxPYmplY3QqLCBKU1N0cmluZyogaXRlcmF0ZWRTdHJpbmcpCiB7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2l0ZXJhdG9yLW5hbWVzLmpz IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9pdGVyYXRvci1uYW1lcy5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi41ZmU4YWI0NTc2NzgwMjIxM2M2YmUxNjNkYTNlNjk2NWQ0MjE5MWNjCi0tLSAv ZGV2L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9pdGVyYXRv ci1uYW1lcy5qcwpAQCAtMCwwICsxLDM1IEBACitmdW5jdGlvbiB0ZXN0KG9iamVjdCwgbmFtZSkg eworICAgIHJldHVybiB7CisgICAgICAgIG9iamVjdCwKKyAgICAgICAgbmFtZTogJ1tvYmplY3Qg JyArIG5hbWUgKyAnXScKKyAgICB9OworfQorCitmdW5jdGlvbiBpdGVyKG9iamVjdCkgeworICAg IHJldHVybiBvYmplY3RbU3ltYm9sLml0ZXJhdG9yXSgpOworfQorCit2YXIgdGVzdHMgPSBbCisg ICAgdGVzdChpdGVyKFtdKSwgIkFycmF5IEl0ZXJhdG9yIiksCisgICAgdGVzdChpdGVyKG5ldyBB cnJheSksICJBcnJheSBJdGVyYXRvciIpLAorICAgIHRlc3QoW10ua2V5cygpLCAiQXJyYXkgSXRl cmF0b3IiKSwKKyAgICB0ZXN0KFtdLmVudHJpZXMoKSwgIkFycmF5IEl0ZXJhdG9yIiksCisgICAg dGVzdChpdGVyKG5ldyBNYXApLCAiTWFwIEl0ZXJhdG9yIiksCisgICAgdGVzdCgobmV3IE1hcCgp KS5rZXlzKCksICJNYXAgSXRlcmF0b3IiKSwKKyAgICB0ZXN0KChuZXcgTWFwKCkpLmVudHJpZXMo KSwgIk1hcCBJdGVyYXRvciIpLAorICAgIHRlc3QoaXRlcihuZXcgU2V0KSwgIlNldCBJdGVyYXRv ciIpLAorICAgIHRlc3QoKG5ldyBTZXQoKSkua2V5cygpLCAiU2V0IEl0ZXJhdG9yIiksCisgICAg dGVzdCgobmV3IFNldCgpKS5lbnRyaWVzKCksICJTZXQgSXRlcmF0b3IiKSwKKyAgICB0ZXN0KGl0 ZXIobmV3IFN0cmluZygiIikpLCAiU3RyaW5nIEl0ZXJhdG9yIiksCisgICAgdGVzdChpdGVyKCIi KSwgIlN0cmluZyBJdGVyYXRvciIpLAorXTsKKworZnVuY3Rpb24gY2hlY2soYWN0dWFsLCBleHBl Y3RlZCkgeworICAgIGlmIChhY3R1YWwgIT09IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcg RXJyb3IoJ2JhZCB2YWx1ZTogJyArIGFjdHVhbCk7Cit9CisKK2ZvciAodmFyIHsgb2JqZWN0LCBu YW1lIH0gb2YgdGVzdHMpIHsKKyAgICBjaGVjayhvYmplY3QudG9TdHJpbmcoKSwgbmFtZSk7Cisg ICAgY2hlY2soT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZy5jYWxsKG9iamVjdCksIG5hbWUpOwor fQo=