142418 2015-03-06 16:26:43 -0800 Add an option to run-webkit-tests to override the LayoutTests/ directory 2015-03-09 13:52:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble ap commit-queue ddkilzer eric.carlson glenn jonlee oldest_to_newest 1075147 0 jer.noble 2015-03-06 16:26:43 -0800 Add an option to run-webkit-tests to override the LayoutTests/ directory 1075150 1 248111 jer.noble 2015-03-06 16:30:14 -0800 Created attachment 248111 Patch 1075151 2 commit-queue 2015-03-06 16:32:42 -0800 Attachment 248111 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:212: whitespace before ']' [pep8/E202] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1075734 3 248111 ddkilzer 2015-03-09 13:39:04 -0700 Comment on attachment 248111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248111&action=review r=me if you shorten the switch name to just "Tools/Scripts/webkitpy/port/base_unittest.py". > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:212 > + optparse.make_option("--override-layout-tests-directory", action="store", default=None, > + help="Override the default layout test directory.", dest="layout_tests_dir") Let's remove "override-" from "--layout-tests-directory". You're implicitly overriding it by specifying a different directory, so no need for extra typing. 1075738 4 jer.noble 2015-03-09 13:52:22 -0700 Committed r181280: <http://trac.webkit.org/changeset/181280> 248111 2015-03-06 16:30:14 -0800 2015-03-09 13:39:04 -0700 Patch bug-142418-20150306162954.patch text/plain 2824 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMTg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGYxOTU3NmZjZjE0NTRjMTE2MWFlYThjZGNkYjNkY2Jk NzEyMWNlNi4uMDEyZjNkM2Q2NDM5NWQ5YjdkMWVjOTUxZWU3M2U5M2I5MTk1MTMxNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE1LTAzLTA2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAg ICAgIEFkZCBhbiBvcHRpb24gdG8gcnVuLXdlYmtpdC10ZXN0cyB0byBvdmVycmlkZSB0aGUgTGF5 b3V0VGVzdHMvIGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQyNDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGFuIGFydWdtZW50IHRvIHJ1bi13ZWJraXQtdGVzdHMgd2hpY2gsIHdo ZW4gc2V0LCBvdmVycmlkZXMgdGhlIHBvcnQncyBkZWZhdWx0IExheW91dFRlc3RzCisgICAgICAg IGRpcmVjdG9yeS4gVGhlIGJhc2UgcG9ydCB3aWxsIHBhcnNlIHRoZSBvcHRpb25zIGR1cmluZyBp bml0aWFsaXphdGlvbiBhbmQgc3RvcmUgdGhlIG92ZXJyaWRlCisgICAgICAgIGxvY2F0aW9uIGlm IHByZXNlbnQuIGxheW91dF90ZXN0c19kaXIoKSB3aWxsIHJldHVybiB0aGlzIG92ZXJyaWRkZW4g bG9jYXRpb24gaWYgc2V0LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKHBhcnNlX2FyZ3MpOgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5fX2luaXRfXyk6 CisgICAgICAgIChQb3J0LmxheW91dF90ZXN0c19kaXIpOgorCiAyMDE1LTAzLTA2ICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBUZXN0 IC93ZWJraXQyL1dlYktpdFdlYlZpZXcvc3luYy1yZXF1ZXN0LW9uLW1heC1jb25ucyBtaWdodCBm YWlsIGFmdGVyIGZpbmlzaGVkCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCBkODMyYTk0YWU5YWJlNWU3Zjk0 OGU3NGY3NjRlYWM1Mjg2ZjFkZGY2Li41NzVkYWU1Mjg1NmRmNzRjZGVhMzAxNGM5NmFlMTAyZWM5 ZThhMDY4IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTIwOCw2ICsyMDgsOCBAQCBkZWYgcGFyc2VfYXJn cyhhcmdzKToKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tamF2YSIsIGFjdGlvbj0i c3RvcmVfdHJ1ZSIsCiAgICAgICAgICAgICBkZWZhdWx0PUZhbHNlLAogICAgICAgICAgICAgaGVs cD0iQnVpbGQgamF2YSBzdXBwb3J0IGZpbGVzIiksCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0 aW9uKCItLW92ZXJyaWRlLWxheW91dC10ZXN0cy1kaXJlY3RvcnkiLCBhY3Rpb249InN0b3JlIiwg ZGVmYXVsdD1Ob25lLAorICAgICAgICAgICAgaGVscD0iT3ZlcnJpZGUgdGhlIGRlZmF1bHQgbGF5 b3V0IHRlc3QgZGlyZWN0b3J5LiIsIGRlc3Q9ImxheW91dF90ZXN0c19kaXIiKQogICAgIF0pKQog CiAgICAgb3B0aW9uX2dyb3VwX2RlZmluaXRpb25zLmFwcGVuZCgoIlRlc3RpbmcgT3B0aW9ucyIs IFsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKaW5kZXggZWJmNGJkZDY5NTA0NGE0OTdk MGRjMTg1ZjY5NzA4ZmJmYzkwYWY2OC4uNzBjZjU3OTRhMGM3NzU0OWQ1YTU0MTU2YmI0NThiMzZk YTQ1YzJlYSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKQEAgLTEzNyw2ICsxMzcs NyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX3Jlc3VsdHNfZGlyZWN0b3J5 ID0gTm9uZQogICAgICAgICBzZWxmLl9yb290X3dhc19zZXQgPSBoYXNhdHRyKG9wdGlvbnMsICdy b290JykgYW5kIG9wdGlvbnMucm9vdAogICAgICAgICBzZWxmLl9qaGJ1aWxkX3dyYXBwZXIgPSBb XQorICAgICAgICBzZWxmLl9sYXlvdXRfdGVzdHNfZGlyID0gaGFzYXR0cihvcHRpb25zLCAnbGF5 b3V0X3Rlc3RzX2RpcicpIGFuZCBvcHRpb25zLmxheW91dF90ZXN0c19kaXIKIAogICAgIGRlZiBh cmNoaXRlY3R1cmUoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLmdldF9vcHRpb24oJ2FyY2hp dGVjdHVyZScpCkBAIC02NjYsNiArNjY3LDggQEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgICAg ICByZXR1cm4gc2VsZi5fd2Via2l0X2ZpbmRlci5wYXRoX3RvX3NjcmlwdChzY3JpcHRfbmFtZSkK IAogICAgIGRlZiBsYXlvdXRfdGVzdHNfZGlyKHNlbGYpOgorICAgICAgICBpZiBzZWxmLl9sYXlv dXRfdGVzdHNfZGlyOgorICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2xheW91dF90ZXN0c19kaXIK ICAgICAgICAgcmV0dXJuIHNlbGYuX3dlYmtpdF9maW5kZXIubGF5b3V0X3Rlc3RzX2RpcigpCiAK ICAgICBkZWYgcGVyZl90ZXN0c19kaXIoc2VsZik6Cg==