142399 2015-03-06 09:17:59 -0800 ReadableStream does not not need to pass itself as callback parameter 2015-03-09 04:32:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141160 1 youennf youennf benjamin calvaris cgarcia commit-queue oldest_to_newest 1074955 0 youennf 2015-03-06 09:17:59 -0800 The callbacks can directly retrieve it by capturing the JSReadableStream object itself. 1074964 1 248070 youennf 2015-03-06 09:30:06 -0800 Created attachment 248070 Patch 1075128 2 248070 darin 2015-03-06 15:55:32 -0800 Comment on attachment 248070 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248070&action=review > Source/WebCore/bindings/js/JSReadableStreamCustom.cpp:74 > + wrapper.resolve(&impl()); What guarantees that "this" won’t be deallocated before this function gets called? > Source/WebCore/bindings/js/JSReadableStreamCustom.cpp:92 > + wrapper.resolve(&impl()); What guarantees that "this" won’t be deallocated before this function gets called? 1075565 3 248240 youennf 2015-03-09 03:41:13 -0700 Created attachment 248240 Patch for landing 1075570 4 youennf 2015-03-09 04:20:18 -0700 (In reply to comment #2) > Comment on attachment 248070 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248070&action=review > > > Source/WebCore/bindings/js/JSReadableStreamCustom.cpp:74 > > + wrapper.resolve(&impl()); > > What guarantees that "this" won’t be deallocated before this function gets > called? > > > Source/WebCore/bindings/js/JSReadableStreamCustom.cpp:92 > > + wrapper.resolve(&impl()); > > What guarantees that "this" won’t be deallocated before this function gets > called? Good point. It is not implemented yet. Plan is to use ActiveDOMObject from which ReadableStream is deriving. I filed bug 142478 for that purpose. 1075576 5 248240 commit-queue 2015-03-09 04:32:16 -0700 Comment on attachment 248240 Patch for landing Clearing flags on attachment: 248240 Committed r181262: <http://trac.webkit.org/changeset/181262> 1075577 6 commit-queue 2015-03-09 04:32:19 -0700 All reviewed patches have been landed. Closing bug. 248070 2015-03-06 09:30:06 -0800 2015-03-09 03:41:06 -0700 Patch bug-142399-20150306182944.patch text/plain 3040 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwOTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ3ODNiMTFmM2Y2OTQ1 OTIxNTYxMTkyMjkyZGQzNWM5ZWMyMjVmYS4uOGI1NGNkMTU4NTBiYTU0MWU5MjY2NDk4MDZiMzNj OTBkZWVkOWI1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTA2ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgUmVhZGFibGVTdHJl YW0gZG9lcyBub3Qgbm90IG5lZWQgdG8gcGFzcyBpdHNlbGYgYXMgY2FsbGJhY2sgcGFyYW1ldHJl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIzOTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFu Z2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJl YW0uaDogUmVtb3ZlIFJlYWRhYmxlU3RyZWFtIHBhcmFtZXRlciBmcm9tIFN1Y2Nlc3NDYWxsYmFj ayBkZWZpbml0aW9uLgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1DdXN0 b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNSZWFkYWJsZVN0cmVhbTo6cmVhZHkpOiBDYXB0 dXJlIEpTUmVhZGFibGVTdHJlYW0gaW5zdGFuY2UgaW5zdGVhZC4KKyAgICAgICAgKFdlYkNvcmU6 OkpTUmVhZGFibGVTdHJlYW06OmNsb3NlZCk6IENhcHR1cmUgSlNSZWFkYWJsZVN0cmVhbSBpbnN0 YW5jZSBpbnN0ZWFkLgorCiAyMDE1LTAzLTAzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgVHJ5IHRvIGZpeCB0aGUgYnVpbGQuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0uaCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbS5oCmluZGV4IDAwYjQ5NTAyYmM2 MzA2ZGVlYWQ4NTU1MDBhMmIyYmM1MmI0NTUxYTQuLjc2NDczZTE1ODcyNDk3ZjM2NzhlYWQ2NTQw ZDkyZjQwODhlMDYyMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFt cy9SZWFkYWJsZVN0cmVhbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9S ZWFkYWJsZVN0cmVhbS5oCkBAIC02MSw3ICs2MSw3IEBAIHB1YmxpYzoKICAgICAvLyBKUyBBUEkg aW1wbGVtZW50YXRpb24uCiAgICAgU3RyaW5nIHN0YXRlKCkgY29uc3Q7CiAKLSAgICB0eXBlZGVm IHN0ZDo6ZnVuY3Rpb248dm9pZChSZWZQdHI8UmVhZGFibGVTdHJlYW0+KT4gU3VjY2Vzc0NhbGxi YWNrOworICAgIHR5cGVkZWYgc3RkOjpmdW5jdGlvbjx2b2lkKCk+IFN1Y2Nlc3NDYWxsYmFjazsK ICAgICB2b2lkIGNsb3NlZChTdWNjZXNzQ2FsbGJhY2spOwogICAgIHZvaWQgcmVhZHkoU3VjY2Vz c0NhbGxiYWNrKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNS ZWFkYWJsZVN0cmVhbUN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1Jl YWRhYmxlU3RyZWFtQ3VzdG9tLmNwcAppbmRleCAwZjc5OTNkZWVjZTg4ZWRmNWExM2YwODVhNmI5 N2ViODAwYzQ1NGJlLi41YjZkMWQ1ZjZhMjRjN2EzZDVmMzQ3N2UwMWE1NjBjMmM3MjcyY2M2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1JlYWRhYmxlU3RyZWFtQ3Vz dG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1JlYWRhYmxlU3RyZWFt Q3VzdG9tLmNwcApAQCAtNzAsOCArNzAsOCBAQCBKU1ZhbHVlIEpTUmVhZGFibGVTdHJlYW06OnJl YWR5KEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKIHsKICAgICBKU1Byb21pc2VEZWZlcnJlZCogcHJv bWlzZURlZmVycmVkID0gZ2V0T3JDcmVhdGVQcm9taXNlRGVmZXJyZWRGcm9tT2JqZWN0KGV4ZWMs IHRoaXMsIGdsb2JhbE9iamVjdCgpLCByZWFkeVByb21pc2VTbG90TmFtZSgpKTsKICAgICBEZWZl cnJlZFdyYXBwZXIgd3JhcHBlcihleGVjLCBnbG9iYWxPYmplY3QoKSwgcHJvbWlzZURlZmVycmVk KTsKLSAgICBhdXRvIHN1Y2Nlc3NDYWxsYmFjayA9IFt3cmFwcGVyXShSZWZQdHI8UmVhZGFibGVT dHJlYW0+IHN0cmVhbSkgbXV0YWJsZSB7Ci0gICAgICAgIHdyYXBwZXIucmVzb2x2ZShzdHJlYW0u Z2V0KCkpOworICAgIGF1dG8gc3VjY2Vzc0NhbGxiYWNrID0gW3dyYXBwZXIsIHRoaXNdKCkgbXV0 YWJsZSB7CisgICAgICAgIHdyYXBwZXIucmVzb2x2ZSgmaW1wbCgpKTsKICAgICB9OwogICAgIGlt cGwoKS5yZWFkeShXVEY6Om1vdmUoc3VjY2Vzc0NhbGxiYWNrKSk7CiAKQEAgLTg4LDggKzg4LDgg QEAgSlNWYWx1ZSBKU1JlYWRhYmxlU3RyZWFtOjpjbG9zZWQoRXhlY1N0YXRlKiBleGVjKSBjb25z dAogewogICAgIEpTUHJvbWlzZURlZmVycmVkKiBwcm9taXNlRGVmZXJyZWQgPSBnZXRPckNyZWF0 ZVByb21pc2VEZWZlcnJlZEZyb21PYmplY3QoZXhlYywgdGhpcywgZ2xvYmFsT2JqZWN0KCksIGNs b3NlZFByb21pc2VTbG90TmFtZSgpKTsKICAgICBEZWZlcnJlZFdyYXBwZXIgd3JhcHBlcihleGVj LCBnbG9iYWxPYmplY3QoKSwgcHJvbWlzZURlZmVycmVkKTsKLSAgICBhdXRvIHN1Y2Nlc3NDYWxs YmFjayA9IFt3cmFwcGVyXShSZWZQdHI8UmVhZGFibGVTdHJlYW0+IHN0cmVhbSkgbXV0YWJsZSB7 Ci0gICAgICAgIHdyYXBwZXIucmVzb2x2ZShzdHJlYW0uZ2V0KCkpOworICAgIGF1dG8gc3VjY2Vz c0NhbGxiYWNrID0gW3dyYXBwZXIsIHRoaXNdKCkgbXV0YWJsZSB7CisgICAgICAgIHdyYXBwZXIu cmVzb2x2ZSgmaW1wbCgpKTsKICAgICB9OwogICAgIGltcGwoKS5jbG9zZWQoV1RGOjptb3ZlKHN1 Y2Nlc3NDYWxsYmFjaykpOwogCg== 248240 2015-03-09 03:41:13 -0700 2015-03-09 04:32:16 -0700 Patch for landing bug-142399-20150309114049.patch text/plain 3061 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM3MmQ0NTFmMjM2N2Rh NGM5OWM4ZGIzZWFjNDYyNjY3YjljNWNlNC4uNzUxMDIzNjcyOWE0M2NhYzg0OGRjMjgwNjkxYjMw OTA4NGY1MTdjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTA2ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgUmVhZGFibGVTdHJl YW0gZG9lcyBub3Qgbm90IG5lZWQgdG8gcGFzcyBpdHNlbGYgYXMgY2FsbGJhY2sgcGFyYW1ldGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIzOTkK KworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBObyBjaGFuZ2Ug aW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0u aDogUmVtb3ZlIFJlYWRhYmxlU3RyZWFtIHBhcmFtZXRlciBmcm9tIFN1Y2Nlc3NDYWxsYmFjayBk ZWZpbml0aW9uLgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1DdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNSZWFkYWJsZVN0cmVhbTo6cmVhZHkpOiBDYXB0dXJl IEpTUmVhZGFibGVTdHJlYW0gaW5zdGFuY2UgaW5zdGVhZC4KKyAgICAgICAgKFdlYkNvcmU6OkpT UmVhZGFibGVTdHJlYW06OmNsb3NlZCk6IENhcHR1cmUgSlNSZWFkYWJsZVN0cmVhbSBpbnN0YW5j ZSBpbnN0ZWFkLgorCiAyMDE1LTAzLTA4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TIE1lZGlhXSBWaWRlbyBidWZmZXIgcHJvZ3Jlc3MgbWlzc2luZyBvbiBp UGhvbmVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFi bGVTdHJlYW0uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVh bS5oCmluZGV4IDAwYjQ5NTAyYmM2MzA2ZGVlYWQ4NTU1MDBhMmIyYmM1MmI0NTUxYTQuLjc2NDcz ZTE1ODcyNDk3ZjM2NzhlYWQ2NTQwZDkyZjQwODhlMDYyMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbS5oCkBAIC02MSw3ICs2MSw3IEBAIHB1 YmxpYzoKICAgICAvLyBKUyBBUEkgaW1wbGVtZW50YXRpb24uCiAgICAgU3RyaW5nIHN0YXRlKCkg Y29uc3Q7CiAKLSAgICB0eXBlZGVmIHN0ZDo6ZnVuY3Rpb248dm9pZChSZWZQdHI8UmVhZGFibGVT dHJlYW0+KT4gU3VjY2Vzc0NhbGxiYWNrOworICAgIHR5cGVkZWYgc3RkOjpmdW5jdGlvbjx2b2lk KCk+IFN1Y2Nlc3NDYWxsYmFjazsKICAgICB2b2lkIGNsb3NlZChTdWNjZXNzQ2FsbGJhY2spOwog ICAgIHZvaWQgcmVhZHkoU3VjY2Vzc0NhbGxiYWNrKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNSZWFkYWJsZVN0cmVhbUN1c3RvbS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU1JlYWRhYmxlU3RyZWFtQ3VzdG9tLmNwcAppbmRleCAwZjc5OTNk ZWVjZTg4ZWRmNWExM2YwODVhNmI5N2ViODAwYzQ1NGJlLi41YjZkMWQ1ZjZhMjRjN2EzZDVmMzQ3 N2UwMWE1NjBjMmM3MjcyY2M2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU1JlYWRhYmxlU3RyZWFtQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU1JlYWRhYmxlU3RyZWFtQ3VzdG9tLmNwcApAQCAtNzAsOCArNzAsOCBAQCBKU1ZhbHVl IEpTUmVhZGFibGVTdHJlYW06OnJlYWR5KEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKIHsKICAgICBK U1Byb21pc2VEZWZlcnJlZCogcHJvbWlzZURlZmVycmVkID0gZ2V0T3JDcmVhdGVQcm9taXNlRGVm ZXJyZWRGcm9tT2JqZWN0KGV4ZWMsIHRoaXMsIGdsb2JhbE9iamVjdCgpLCByZWFkeVByb21pc2VT bG90TmFtZSgpKTsKICAgICBEZWZlcnJlZFdyYXBwZXIgd3JhcHBlcihleGVjLCBnbG9iYWxPYmpl Y3QoKSwgcHJvbWlzZURlZmVycmVkKTsKLSAgICBhdXRvIHN1Y2Nlc3NDYWxsYmFjayA9IFt3cmFw cGVyXShSZWZQdHI8UmVhZGFibGVTdHJlYW0+IHN0cmVhbSkgbXV0YWJsZSB7Ci0gICAgICAgIHdy YXBwZXIucmVzb2x2ZShzdHJlYW0uZ2V0KCkpOworICAgIGF1dG8gc3VjY2Vzc0NhbGxiYWNrID0g W3dyYXBwZXIsIHRoaXNdKCkgbXV0YWJsZSB7CisgICAgICAgIHdyYXBwZXIucmVzb2x2ZSgmaW1w bCgpKTsKICAgICB9OwogICAgIGltcGwoKS5yZWFkeShXVEY6Om1vdmUoc3VjY2Vzc0NhbGxiYWNr KSk7CiAKQEAgLTg4LDggKzg4LDggQEAgSlNWYWx1ZSBKU1JlYWRhYmxlU3RyZWFtOjpjbG9zZWQo RXhlY1N0YXRlKiBleGVjKSBjb25zdAogewogICAgIEpTUHJvbWlzZURlZmVycmVkKiBwcm9taXNl RGVmZXJyZWQgPSBnZXRPckNyZWF0ZVByb21pc2VEZWZlcnJlZEZyb21PYmplY3QoZXhlYywgdGhp cywgZ2xvYmFsT2JqZWN0KCksIGNsb3NlZFByb21pc2VTbG90TmFtZSgpKTsKICAgICBEZWZlcnJl ZFdyYXBwZXIgd3JhcHBlcihleGVjLCBnbG9iYWxPYmplY3QoKSwgcHJvbWlzZURlZmVycmVkKTsK LSAgICBhdXRvIHN1Y2Nlc3NDYWxsYmFjayA9IFt3cmFwcGVyXShSZWZQdHI8UmVhZGFibGVTdHJl YW0+IHN0cmVhbSkgbXV0YWJsZSB7Ci0gICAgICAgIHdyYXBwZXIucmVzb2x2ZShzdHJlYW0uZ2V0 KCkpOworICAgIGF1dG8gc3VjY2Vzc0NhbGxiYWNrID0gW3dyYXBwZXIsIHRoaXNdKCkgbXV0YWJs ZSB7CisgICAgICAgIHdyYXBwZXIucmVzb2x2ZSgmaW1wbCgpKTsKICAgICB9OwogICAgIGltcGwo KS5jbG9zZWQoV1RGOjptb3ZlKHN1Y2Nlc3NDYWxsYmFjaykpOwogCg==