142397 2015-03-06 08:57:26 -0800 ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator 2015-03-09 04:36:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141160 1 youennf youennf benjamin calvaris cgarcia commit-queue oldest_to_newest 1074946 0 youennf 2015-03-06 08:57:26 -0800 ReadableStreamJSSource uses JSC::Strong to keep JS objects. It should use UnspecifiedBoolType in lieu of checking for undefined values. 1074952 1 248066 youennf 2015-03-06 09:09:00 -0800 Created attachment 248066 Patch 1075518 2 248066 benjamin 2015-03-08 20:39:12 -0700 Comment on attachment 248066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248066&action=review Oh boy, why didn't anyone review this :( > Source/WebCore/bindings/js/ReadableStreamJSSource.h:55 > + virtual bool isErrored() { return m_error; } !!m_error 1075564 3 248239 youennf 2015-03-09 03:37:52 -0700 Created attachment 248239 Patch for landing 1075580 4 commit-queue 2015-03-09 04:35:17 -0700 The commit-queue encountered the following flaky tests while processing attachment 248239: media/track/track-insert-after-load-crash.html bug 142484 (author: bfulgham@webkit.org) The commit-queue is continuing to process your patch. 1075581 5 248239 commit-queue 2015-03-09 04:36:42 -0700 Comment on attachment 248239 Patch for landing Clearing flags on attachment: 248239 Committed r181264: <http://trac.webkit.org/changeset/181264> 1075582 6 commit-queue 2015-03-09 04:36:46 -0700 All reviewed patches have been landed. Closing bug. 248066 2015-03-06 09:09:00 -0800 2015-03-09 03:36:24 -0700 Patch bug-142397-20150306180839.patch text/plain 2037 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwOTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ3ODNiMTFmM2Y2OTQ1 OTIxNTYxMTkyMjkyZGQzNWM5ZWMyMjVmYS4uMGQ4NWVjYjQyYWY3MjkwNzdmMGE5ZjBlM2Q1Njcz ZjNjNDIwZTc4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTA2ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4gYW5kIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KKworICAgICAgICBSZWFkYWJsZVN0cmVh bUpTU291cmNlIHNob3VsZCB1c2UgSlNDOjpTdHJvbmcgVW5zcGVjaWZpZWRCb29sVHlwZSBvcGVy YXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQy Mzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g YmVoYXZpb3IgY2hhbmdlLiBDdXJyZW50IHRlc3RzIGNvdmVyIHRoZSBjaGFuZ2VzLgorCisgICAg ICAgICogYmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW1KU1NvdXJjZS5jcHA6CisgICAgICAgICog YmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW1KU1NvdXJjZS5oOgorCiAyMDE1LTAzLTAzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgVHJ5IHRvIGZpeCB0 aGUgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9SZWFkYWJs ZVN0cmVhbUpTU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxl U3RyZWFtSlNTb3VyY2UuY3BwCmluZGV4IGI4MWFhY2Q1MDA4YjU3NDQ4MmQ5ZWMxNjNhN2EzNzBh ZWQ3Y2Q3ZDcuLjNjMzM2NTUxNTJkYmYyMjk1NGZhNDk3ZTQxODA4ZTNmZTNmZTM1MDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxlU3RyZWFtSlNTb3VyY2Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxlU3RyZWFtSlNTb3Vy Y2UuY3BwCkBAIC02Nyw3ICs2Nyw2IEBAIFJlZjxSZWFkYWJsZVN0cmVhbUpTU291cmNlPiBSZWFk YWJsZVN0cmVhbUpTU291cmNlOjpjcmVhdGUoSlNDOjpFeGVjU3RhdGUqIGV4ZWMpCiB9CiAKIFJl YWRhYmxlU3RyZWFtSlNTb3VyY2U6OlJlYWRhYmxlU3RyZWFtSlNTb3VyY2UoSlNDOjpFeGVjU3Rh dGUqIGV4ZWMpCi0gICAgOiBtX2Vycm9yKGV4ZWMtPnZtKCksIGpzVW5kZWZpbmVkKCkpCiB7CiAg ICAgaWYgKCFleGVjLT5hcmd1bWVudENvdW50KCkpCiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxlU3RyZWFtSlNTb3VyY2UuaCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxlU3RyZWFtSlNTb3VyY2UuaAppbmRl eCA0NDYzNDYxMjY2YTZkZWYyMzM4NTU2MDBjMmY3ODdhMjgzMGEyMDc2Li43Mzc5MzBmMTFjNWY0 ZDdlNjQ4YTQ4ODc0M2JmYzM5NjlmNGZlYWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9SZWFkYWJsZVN0cmVhbUpTU291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW1KU1NvdXJjZS5oCkBAIC01Miw3ICs1Miw3IEBAIHB1 YmxpYzoKICAgICBib29sIHN0YXJ0KCkgeyByZXR1cm4gdHJ1ZTsgfQogCiAgICAgLy8gUmVhZGFi bGVTdHJlYW1Tb3VyY2UgQVBJLgotICAgIHZpcnR1YWwgYm9vbCBpc0Vycm9yZWQoKSB7IHJldHVy biAhbV9lcnJvci5nZXQoKS5pc1VuZGVmaW5lZCgpOyB9CisgICAgdmlydHVhbCBib29sIGlzRXJy b3JlZCgpIHsgcmV0dXJuIG1fZXJyb3I7IH0KIAogcHJpdmF0ZToKICAgICB2b2lkIHNldEludGVy bmFsRXJyb3IoSlNDOjpFeGVjU3RhdGUqLCBjb25zdCBTdHJpbmcmKTsK 248239 2015-03-09 03:37:52 -0700 2015-03-09 04:36:42 -0700 Patch for landing bug-142397-20150309113728.patch text/plain 2065 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM3MmQ0NTFmMjM2N2Rh NGM5OWM4ZGIzZWFjNDYyNjY3YjljNWNlNC4uY2RmODFkNDFiZTY1MmUzNTlhOWU1MWNmZTZjNDI4 ZDgwZTgyZjExNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTA2ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4gYW5kIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KKworICAgICAgICBSZWFkYWJsZVN0cmVh bUpTU291cmNlIHNob3VsZCB1c2UgSlNDOjpTdHJvbmcgVW5zcGVjaWZpZWRCb29sVHlwZSBvcGVy YXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQy Mzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQmVuamFtaW4gUG91bGFpbi4KKworICAgICAgICBO byBiZWhhdmlvciBjaGFuZ2UuIEN1cnJlbnQgdGVzdHMgY292ZXIgdGhlIGNoYW5nZXMuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9SZWFkYWJsZVN0cmVhbUpTU291cmNlLmNwcDoKKyAgICAgICAg KiBiaW5kaW5ncy9qcy9SZWFkYWJsZVN0cmVhbUpTU291cmNlLmg6CisKIDIwMTUtMDMtMDggIERl YW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgTWVkaWFdIFZpZGVv IGJ1ZmZlciBwcm9ncmVzcyBtaXNzaW5nIG9uIGlQaG9uZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxlU3RyZWFtSlNTb3VyY2UuY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW1KU1NvdXJjZS5jcHAKaW5kZXggYjgxYWFj ZDUwMDhiNTc0NDgyZDllYzE2M2E3YTM3MGFlZDdjZDdkNy4uM2MzMzY1NTE1MmRiZjIyOTU0ZmE0 OTdlNDE4MDhlM2ZlM2ZlMzUwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvUmVhZGFibGVTdHJlYW1KU1NvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvUmVhZGFibGVTdHJlYW1KU1NvdXJjZS5jcHAKQEAgLTY3LDcgKzY3LDYgQEAgUmVmPFJl YWRhYmxlU3RyZWFtSlNTb3VyY2U+IFJlYWRhYmxlU3RyZWFtSlNTb3VyY2U6OmNyZWF0ZShKU0M6 OkV4ZWNTdGF0ZSogZXhlYykKIH0KIAogUmVhZGFibGVTdHJlYW1KU1NvdXJjZTo6UmVhZGFibGVT dHJlYW1KU1NvdXJjZShKU0M6OkV4ZWNTdGF0ZSogZXhlYykKLSAgICA6IG1fZXJyb3IoZXhlYy0+ dm0oKSwganNVbmRlZmluZWQoKSkKIHsKICAgICBpZiAoIWV4ZWMtPmFyZ3VtZW50Q291bnQoKSkK ICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv UmVhZGFibGVTdHJlYW1KU1NvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUmVh ZGFibGVTdHJlYW1KU1NvdXJjZS5oCmluZGV4IDQ0NjM0NjEyNjZhNmRlZjIzMzg1NTYwMGMyZjc4 N2EyODMwYTIwNzYuLjE3ZTU4NWQ2OTU2N2E3YzcwMTk1MjZjOGFlNjQ1NjY2NGQ3MmRmOWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxlU3RyZWFtSlNTb3Vy Y2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9SZWFkYWJsZVN0cmVhbUpTU291 cmNlLmgKQEAgLTUyLDcgKzUyLDcgQEAgcHVibGljOgogICAgIGJvb2wgc3RhcnQoKSB7IHJldHVy biB0cnVlOyB9CiAKICAgICAvLyBSZWFkYWJsZVN0cmVhbVNvdXJjZSBBUEkuCi0gICAgdmlydHVh bCBib29sIGlzRXJyb3JlZCgpIHsgcmV0dXJuICFtX2Vycm9yLmdldCgpLmlzVW5kZWZpbmVkKCk7 IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNFcnJvcmVkKCkgeyByZXR1cm4gISFtX2Vycm9yOyB9CiAK IHByaXZhdGU6CiAgICAgdm9pZCBzZXRJbnRlcm5hbEVycm9yKEpTQzo6RXhlY1N0YXRlKiwgY29u c3QgU3RyaW5nJik7Cg==