142395 2015-03-06 06:44:40 -0800 Don't use dispatch_semaphore in NetworkCacheStorage 2015-03-06 09:31:42 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue oldest_to_newest 1074917 0 koivisto 2015-03-06 06:44:40 -0800 Less platform code 1074918 1 248062 koivisto 2015-03-06 06:49:07 -0800 Created attachment 248062 patch 1074919 2 commit-queue 2015-03-06 06:50:27 -0800 Attachment 248062 did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:98: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1074965 3 koivisto 2015-03-06 09:31:42 -0800 https://trac.webkit.org/r181161 248062 2015-03-06 06:49:07 -0800 2015-03-06 08:21:57 -0800 patch disk-cache-semaphore.patch text/plain 5014 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTE1NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAzLTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCB1c2UgZGlzcGF0Y2hf c2VtYXBob3JlIGluIE5ldHdvcmtDYWNoZVN0b3JhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjM5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlSU9DaGFubmVsLmg6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlSU9DaGFubmVsQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6SU9D aGFubmVsOjpyZWFkKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpJT0NoYW5uZWw6 OnJlYWRTeW5jKToKKworICAgICAgICAgICAgQWRkIHJlYWRTeW5jIHRvIGVuY2Fwc3VsYXRlIHRo ZSBzZW1hcGhvcmUuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2Fj aGVTdG9yYWdlQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6U3RvcmFn ZTo6dHJhdmVyc2UpOgorCiAyMDE1LTAzLTA2ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdh bGlhLmNvbT4KIAogICAgICAgICBVbmd1YXJkZWQgR1RLLXNwZWNpZmljIG1lbWJlciBhbmQgbWV0 aG9kIHVzYWdlIGluIERyYXdpbmdBcmVhSW1wbApJbmRleDogU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsLmgJ KHJldmlzaW9uIDE4MTE0MCkKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZUlPQ2hhbm5lbC5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw3IEBA IHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPElPQ2hhbm5lbD4gb3Blbihjb25zdCBTdHJpbmcmIGZp bGUsIFR5cGUpOwogCiAgICAgdm9pZCByZWFkKHNpemVfdCBvZmZzZXQsIHNpemVfdCwgc3RkOjpm dW5jdGlvbjx2b2lkIChEYXRhJiwgaW50IGVycm9yKT4pOworICAgIHZvaWQgcmVhZFN5bmMoc2l6 ZV90IG9mZnNldCwgc2l6ZV90LCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKERhdGEmLCBpbnQgZXJyb3Ip Pik7CiAgICAgdm9pZCB3cml0ZShzaXplX3Qgb2Zmc2V0LCBjb25zdCBEYXRhJiwgc3RkOjpmdW5j dGlvbjx2b2lkIChpbnQgZXJyb3IpPik7CiAKICAgICBpbnQgZmlsZURlc2NyaXB0b3IoKSBjb25z dCB7IHJldHVybiBtX2ZpbGVEZXNjcmlwdG9yOyB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5uZWxDb2NvYS5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0No YW5uZWxDb2NvYS5tbQkocmV2aXNpb24gMTgxMTQwKQorKysgU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsQ29jb2EubW0JKHdvcmtpbmcgY29w eSkKQEAgLTc1LDcgKzc1LDcgQEAgUmVmPElPQ2hhbm5lbD4gSU9DaGFubmVsOjpvcGVuKGNvbnN0 IFN0cgogICAgIHJldHVybiBhZG9wdFJlZigqbmV3IElPQ2hhbm5lbChmZCkpOwogfQogCi12b2lk IElPQ2hhbm5lbDo6cmVhZChzaXplX3Qgb2Zmc2V0LCBzaXplX3Qgc2l6ZSwgc3RkOjpmdW5jdGlv bjx2b2lkICggRGF0YSYsIGludCBlcnJvcik+IGNvbXBsZXRpb25IYW5kbGVyKQordm9pZCBJT0No YW5uZWw6OnJlYWQoc2l6ZV90IG9mZnNldCwgc2l6ZV90IHNpemUsIHN0ZDo6ZnVuY3Rpb248dm9p ZCAoRGF0YSYsIGludCBlcnJvcik+IGNvbXBsZXRpb25IYW5kbGVyKQogewogICAgIFJlZlB0cjxJ T0NoYW5uZWw+IGNoYW5uZWwodGhpcyk7CiAgICAgYm9vbCBkaWRDYWxsQ29tcGxldGlvbkhhbmRs ZXIgPSBmYWxzZTsKQEAgLTk0LDYgKzk0LDE3IEBAIHZvaWQgSU9DaGFubmVsOjpyZWFkKHNpemVf dCBvZmZzZXQsIHNpemUKICAgICB9KTsKIH0KIAorLy8gRklYTUU6IEl0IHdvdWxkIGJlIGJldHRl ciB0byBkbyB3aXRob3V0IHRoaXMuCit2b2lkIElPQ2hhbm5lbDo6cmVhZFN5bmMoc2l6ZV90IG9m ZnNldCwgc2l6ZV90IHNpemUsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoRGF0YSYsIGludCBlcnJvcik+ IGNvbXBsZXRpb25IYW5kbGVyKQoreworICAgIGF1dG8gc2VtYXBob3JlID0gYWRvcHREaXNwYXRj aChkaXNwYXRjaF9zZW1hcGhvcmVfY3JlYXRlKDApKTsKKyAgICByZWFkKG9mZnNldCwgc2l6ZSwg W3NlbWFwaG9yZSwgJmNvbXBsZXRpb25IYW5kbGVyXShEYXRhJiBkYXRhLCBpbnQgZXJyb3IpIHsK KyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoZGF0YSwgZXJyb3IpOworICAgICAgICBkaXNwYXRj aF9zZW1hcGhvcmVfc2lnbmFsKHNlbWFwaG9yZS5nZXQoKSk7CisgICAgfSk7CisgICAgZGlzcGF0 Y2hfc2VtYXBob3JlX3dhaXQoc2VtYXBob3JlLmdldCgpLCBESVNQQVRDSF9USU1FX0ZPUkVWRVIp OworfQorCiB2b2lkIElPQ2hhbm5lbDo6d3JpdGUoc2l6ZV90IG9mZnNldCwgY29uc3QgRGF0YSYg ZGF0YSwgc3RkOjpmdW5jdGlvbjx2b2lkIChpbnQgZXJyb3IpPiBjb21wbGV0aW9uSGFuZGxlcikK IHsKICAgICBSZWZQdHI8SU9DaGFubmVsPiBjaGFubmVsKHRoaXMpOwpJbmRleDogU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZUNvY29hLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtD YWNoZVN0b3JhZ2VDb2NvYS5tbQkocmV2aXNpb24gMTgxMTQwKQorKysgU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZUNvY29hLm1tCSh3b3JraW5n IGNvcHkpCkBAIC00MjgsMjEgKzQyOCwxOSBAQCB2b2lkIFN0b3JhZ2U6OnRyYXZlcnNlKHN0ZDo6 ZnVuY3Rpb248dm9pCiAgICAgU3RyaW5nQ2FwdHVyZSBjYWNoZVBhdGhDYXB0dXJlKG1fZGlyZWN0 b3J5UGF0aCk7CiAgICAgaW9RdWV1ZSgpLmRpc3BhdGNoKFt0aGlzLCBjYWNoZVBhdGhDYXB0dXJl LCB0cmF2ZXJzZUhhbmRsZXJdIHsKICAgICAgICAgU3RyaW5nIGNhY2hlUGF0aCA9IGNhY2hlUGF0 aENhcHR1cmUuc3RyaW5nKCk7Ci0gICAgICAgIGF1dG8gc2VtYXBob3JlID0gYWRvcHREaXNwYXRj aChkaXNwYXRjaF9zZW1hcGhvcmVfY3JlYXRlKDApKTsKLSAgICAgICAgdHJhdmVyc2VDYWNoZUZp bGVzKGNhY2hlUGF0aCwgW3RoaXMsICZzZW1hcGhvcmUsICZ0cmF2ZXJzZUhhbmRsZXJdKGNvbnN0 IFN0cmluZyYgZmlsZU5hbWUsIGNvbnN0IFN0cmluZyYgcGFydGl0aW9uUGF0aCkgeworICAgICAg ICB0cmF2ZXJzZUNhY2hlRmlsZXMoY2FjaGVQYXRoLCBbdGhpcywgJnRyYXZlcnNlSGFuZGxlcl0o Y29uc3QgU3RyaW5nJiBmaWxlTmFtZSwgY29uc3QgU3RyaW5nJiBwYXJ0aXRpb25QYXRoKSB7CiAg ICAgICAgICAgICBhdXRvIGZpbGVQYXRoID0gV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9u ZW50KHBhcnRpdGlvblBhdGgsIGZpbGVOYW1lKTsKICAgICAgICAgICAgIGF1dG8gY2hhbm5lbCA9 IElPQ2hhbm5lbDo6b3BlbihmaWxlUGF0aCwgSU9DaGFubmVsOjpUeXBlOjpSZWFkKTsKICAgICAg ICAgICAgIGNvbnN0IHNpemVfdCBoZWFkZXJSZWFkU2l6ZSA9IDE2IDw8IDEwOwotICAgICAgICAg ICAgY2hhbm5lbC0+cmVhZCgwLCBoZWFkZXJSZWFkU2l6ZSwgW3RoaXMsICZzZW1hcGhvcmUsICZ0 cmF2ZXJzZUhhbmRsZXJdKERhdGEmIGZpbGVEYXRhLCBpbnQpIHsKKyAgICAgICAgICAgIC8vIEZJ WE1FOiBUcmF2ZXJzYWwgaXMgc2xvd2VyIHRoYW4gaXQgc2hvdWxkIGJlIGR1ZSB0byBsYWNrIG9m IHBhcmFsbGVsaXNtLgorICAgICAgICAgICAgY2hhbm5lbC0+cmVhZFN5bmMoMCwgaGVhZGVyUmVh ZFNpemUsIFt0aGlzLCAmdHJhdmVyc2VIYW5kbGVyXShEYXRhJiBmaWxlRGF0YSwgaW50KSB7CiAg ICAgICAgICAgICAgICAgRW50cnlNZXRhRGF0YSBtZXRhRGF0YTsKICAgICAgICAgICAgICAgICBE YXRhIGhlYWRlckRhdGE7CiAgICAgICAgICAgICAgICAgaWYgKGRlY29kZUVudHJ5SGVhZGVyKGZp bGVEYXRhLCBtZXRhRGF0YSwgaGVhZGVyRGF0YSkpIHsKICAgICAgICAgICAgICAgICAgICAgRW50 cnkgZW50cnkgeyBtZXRhRGF0YS5rZXksIG1ldGFEYXRhLnRpbWVTdGFtcCwgaGVhZGVyRGF0YSwg eyB9IH07CiAgICAgICAgICAgICAgICAgICAgIHRyYXZlcnNlSGFuZGxlcigmZW50cnkpOwogICAg ICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICBkaXNwYXRjaF9zZW1hcGhvcmVfc2lnbmFs KHNlbWFwaG9yZS5nZXQoKSk7CiAgICAgICAgICAgICB9KTsKLSAgICAgICAgICAgIGRpc3BhdGNo X3NlbWFwaG9yZV93YWl0KHNlbWFwaG9yZS5nZXQoKSwgRElTUEFUQ0hfVElNRV9GT1JFVkVSKTsK ICAgICAgICAgfSk7CiAgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpcywgdHJh dmVyc2VIYW5kbGVyXSB7CiAgICAgICAgICAgICB0cmF2ZXJzZUhhbmRsZXIobnVsbHB0cik7Cg==