142385 2015-03-05 23:34:29 -0800 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished 2015-03-06 09:21:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue pnormand svillar zan oldest_to_newest 1074851 0 cgarcia 2015-03-05 23:34:29 -0800 This is because I'm using GMainLoopSource created on the heap and destroyed automatically when reached for the timeout. We should use stack allocated one that will be cancelled when current scope is destroyed. 1074852 1 cgarcia 2015-03-05 23:34:58 -0800 TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources... (pid=20904) /webkit2/WebKitWebView/resources: OK /webkit2/WebKitWebView/history-cache: OK /webkit2/WebKitWebView/sync-request-on-max-conns: OK /webkit2/WebKitWebResource/loading: OK /webkit2/WebKitWebResource/response: OK /webkit2/WebKitWebResource/mime-type: OK /webkit2/WebKitWebResource/suggested-filename: OK /webkit2/WebKitWebResource/active-uri: OK /webkit2/WebKitWebResource/get-data: OK /webkit2/WebKitWebPage/send-request: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:709:testWebViewSyncRequestOnMaxConns(SyncRequestOnMaxConnsTest*, gconstpointer)::__lambda2: code should not be reached FAIL GTester: last random seed: R02S24f485eab1e5cd6f16d591e4d82f8a9d (pid=21130) FAIL: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources 1074853 2 248044 cgarcia 2015-03-05 23:36:53 -0800 Created attachment 248044 Patch 1074854 3 commit-queue 2015-03-05 23:38:59 -0800 Attachment 248044 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:710: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:713: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1074960 4 cgarcia 2015-03-06 09:21:43 -0800 Committed r181159: <http://trac.webkit.org/changeset/181159> 248044 2015-03-05 23:36:53 -0800 2015-03-06 01:18:48 -0800 Patch wk2-fix-unit-test.diff text/plain 1943 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiYzEy NmQ5Li43MmYwYzJlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDMtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2Vi S2l0V2ViVmlldy9zeW5jLXJlcXVlc3Qtb24tbWF4LWNvbm5zIG1pZ2h0IGZhaWwgYWZ0ZXIgZmlu aXNoZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MjM4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVz ZSBzdGFjayBhbGxvY2F0ZWQgR01haW5Mb29wU291cmNlcyB0byBtYWtlIHN1cmUgdGhleSBhcmUK KyAgICAgICAgY2FuY2VsbGVkIGF1dG9tYXRpY2FsbHkgaWYgdGhlIHRlc3QgZmluaXNoZXMgYmVm b3JlIHRoZXkgaGF2ZQorICAgICAgICBiZWVuIHByb2Nlc3NlZC4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0UmVzb3VyY2VzLmNwcDoKKyAgICAgICAgKHRl c3RXZWJWaWV3U3luY1JlcXVlc3RPbk1heENvbm5zKToKKwogMjAxNS0wMy0wNSAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFRlc3RFeHBlY3RhdGlv bnMgZm9yIGlvcy1zaW11bGF0b3Itd2syIHNob3VsZCBmYWxsIGJhY2sgdG8gJ3drMicgYWZ0ZXIg J2lvcy1zaW11bGF0b3InCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDJHdGsvVGVzdFJlc291cmNlcy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDJHdGsvVGVzdFJlc291cmNlcy5jcHAKaW5kZXggMGZkZWMwZS4uMjZmOWNjOSAxMDA2NDQK LS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RSZXNvdXJjZXMu Y3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0UmVzb3Vy Y2VzLmNwcApAQCAtNzA2LDkgKzcwNiwxMSBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViVmlld1N5bmNS ZXF1ZXN0T25NYXhDb25ucyhTeW5jUmVxdWVzdE9uTWF4Q29ubnNUZXN0KiB0ZXN0LCBnYwogICAg IH0KIAogICAgIC8vIEJ5IGRlZmF1bHQgc3luYyBYSFJzIGhhdmUgYSAxMCBzZWNvbmRzIHRpbWVv dXQsIHdlIGRvbid0IHdhbnQgdG8gd2FpdCBhbGwgdGhhdCBzbyB1c2Ugb3VyIG93biB0aW1lb3V0 LgotICAgIEdNYWluTG9vcFNvdXJjZTo6c2NoZWR1bGVBZnRlckRlbGF5QW5kRGVsZXRlT25EZXN0 cm95KCJUaW1lb3V0IiwgW10geyBnX2Fzc2VydF9ub3RfcmVhY2hlZCgpOyB9LCBzdGQ6OmNocm9u bzo6c2Vjb25kcygxKSk7CisgICAgR01haW5Mb29wU291cmNlIHRpbWVvdXRTb3VyY2U7CisgICAg dGltZW91dFNvdXJjZS5zY2hlZHVsZUFmdGVyRGVsYXkoIlRpbWVvdXQiLCBbXSB7IGdfYXNzZXJ0 X25vdF9yZWFjaGVkKCk7IH0sIHN0ZDo6Y2hyb25vOjpzZWNvbmRzKDEpKTsKIAotICAgIEdNYWlu TG9vcFNvdXJjZTo6c2NoZWR1bGVBbmREZWxldGVPbkRlc3Ryb3koIlVubG9jayBTZXJ2ZXIgSWRs ZSIsIFsmbG9ja10geyBsb2NrLnVubG9jaygpOyB9KTsKKyAgICBHTWFpbkxvb3BTb3VyY2UgdW5s b2NrU2VydmVyU291cmNlOworICAgIHVubG9ja1NlcnZlclNvdXJjZS5zY2hlZHVsZSgiVW5sb2Nr IFNlcnZlciBJZGxlIiwgWyZsb2NrXSB7IGxvY2sudW5sb2NrKCk7IH0pOwogICAgIHRlc3QtPndh aXRVbnRpbFJlc291cmNlc0xvYWRlZChzX21heENvbm5lY3Rpb25zUGVySG9zdCArIDMpOyAvLyBz X21heENvbm5lY3Rpb25zUGVySG9zdCByZXNvdXJjZSArIG1haW4gcmVzb3VyY2UgKyAyIFhIUi4K IH0KIAo=