142372 2015-03-05 17:05:58 -0800 Adjust volume box to not intersect with rest of inline controls 2015-03-05 17:35:01 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned oldest_to_newest 1074761 0 roger_fong 2015-03-05 17:05:58 -0800 rdar://problem/20064327 Since the backgrounds are now transparent-ish we can’t just have the volume box and bottom control strip intersect anymore. 1074762 1 248022 roger_fong 2015-03-05 17:07:51 -0800 Created attachment 248022 patch 1074769 2 248022 bfulgham 2015-03-05 17:24:33 -0800 Comment on attachment 248022 patch View in context: https://bugs.webkit.org/attachment.cgi?id=248022&action=review It would be nice to see a picture of what this change looks like, but I don't see anything obviously wrong with the changes. r=me. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:199 > + width: 76px; Mmmmm! Magic numbers! 1074774 3 roger_fong 2015-03-05 17:35:01 -0800 http://trac.webkit.org/changeset/181122 248022 2015-03-05 17:07:51 -0800 2015-03-05 17:24:33 -0800 patch patch.patch text/plain 1884 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTEyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTA1ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRqdXN0IHZvbHVtZSBib3gg dG8gbm90IGludGVyc2VjdCB3aXRoIHJlc3Qgb2YgaW5saW5lIG1lZGlhIGNvbnRyb2xzIG9uIE9T WC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjM3 Mi4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwMDY0MzI3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNBcHBsZS5jc3M6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250 cm9scy1wYW5lbCAudm9sdW1lLWJveCk6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1j b250cm9scy1wYW5lbCAudm9sdW1lLWJveDphY3RpdmUpOgorCiAyMDE1LTAzLTA1ICBUaW1vdGh5 IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICA8YXR0YWNobWVu dD4gc2hvdWxkIGFsbG93IHRoZSB0aXRsZSBwcm9wZXJ0eSB0byBvdmVycmlkZSBpdHMgdGl0bGUK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xz QXBwbGUuY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250 cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuY3NzCShyZXZpc2lvbiAxODExMjApCisrKyBTb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmNzcwkod29y a2luZyBjb3B5KQpAQCAtMTY5LDExICsxNjksMTIgQEAgYXVkaW86Oi13ZWJraXQtbWVkaWEtY29u dHJvbHMtcGFuZWwgLnZvbAogICAgIGJvdHRvbTogMDsKICAgICBsZWZ0OiAwOwogCi0gICAgLXdl YmtpdC10cmFuc2Zvcm06IHJvdGF0ZSgtOTBkZWcpIHRyYW5zbGF0ZVkoLTRweCkgdHJhbnNsYXRl WCgtNXB4KTsKKyAgICAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlKC05MGRlZykgdHJhbnNsYXRl WSgtNHB4KSB0cmFuc2xhdGVYKDIwcHgpOwogICAgIC13ZWJraXQtdHJhbnNmb3JtLW9yaWdpbjog MTFweCAxMXB4OwogCiAgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiYSgwLDAsMCwwLjgpOwotICAg IGJvcmRlci1yYWRpdXM6IDRweDsKKyAgICBib3JkZXItYm90dG9tLXJpZ2h0LXJhZGl1czogNHB4 OworICAgIGJvcmRlci10b3AtcmlnaHQtcmFkaXVzOiA0cHg7CiAKICAgICBkaXNwbGF5OiAtd2Vi a2l0LWZsZXg7CiAgICAgLXdlYmtpdC1mbGV4LWRpcmVjdGlvbjogcm93OwpAQCAtMTk1LDcgKzE5 Niw3IEBAIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsIC52b2wKIGF1ZGlvOjot d2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsIC52b2x1bWUtYm94OmFjdGl2ZSB7CiAgICAgb3Bh Y2l0eTogMTsKICAgICAvKiByZXNpemUgdG8gdXNhYmxlIGFtb3VudCAocmF0aGVyIHRoYW4gZGlz cGxheTpub25lKSBmb3IgQVggYW5kIEZLQSAqLwotICAgIHdpZHRoOiAxMDFweDsKKyAgICB3aWR0 aDogNzZweDsKIH0KIAogYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdm9sdW1lLXNsaWRl ciwK