142367 2015-03-05 15:34:19 -0800 Web Inspector: Follow-up fixes to ObjectTreeBaseTreeElement 2015-03-05 16:50:23 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1074715 0 joepeck 2015-03-05 15:34:19 -0800 * SUMMARY Some last minute changes caused asserts / uncaught exceptions with Sets / Maps. Fix them. 1074716 1 248011 joepeck 2015-03-05 15:35:04 -0800 Created attachment 248011 [PATCH] Proposed Fix 1074755 2 248011 commit-queue 2015-03-05 16:50:18 -0800 Comment on attachment 248011 [PATCH] Proposed Fix Clearing flags on attachment: 248011 Committed r181119: <http://trac.webkit.org/changeset/181119> 1074756 3 commit-queue 2015-03-05 16:50:23 -0800 All reviewed patches have been landed. Closing bug. 248011 2015-03-05 15:35:04 -0800 2015-03-05 16:50:18 -0800 [PATCH] Proposed Fix followup.patch text/plain 2527 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFmNTVmMzEuLjVhNjE4ZWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRm9sbG93 LXVwIGZpeGVzIHRvIE9iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjM2NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9PYmpl Y3RUcmVlTWFwRW50cnlUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmpl Y3RUcmVlTWFwRW50cnlUcmVlRWxlbWVudC5wcm90b3R5cGUucHJvcGVydHlQYXRoVHlwZSk6Cisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlU2V0SW5kZXhUcmVlRWxlbWVu dC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RUcmVlU2V0SW5kZXhUcmVlRWxlbWVu dC5wcm90b3R5cGUucmVzb2x2ZWRWYWx1ZVByb3BlcnR5UGF0aCk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuT2JqZWN0VHJlZVNldEluZGV4VHJlZUVsZW1lbnQucHJvdG90eXBlLl90aXRsZUZyYWdt ZW50KToKKwogMjAxNS0wMy0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBPYmplY3RUcmVlQmFzZVRyZWVFbGVtZW50 IHRvIHNoYXJlIGZ1bmN0aW9uYWxpdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVNYXBFbnRyeVRyZWVFbGVtZW50LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZU1hcEVu dHJ5VHJlZUVsZW1lbnQuanMKaW5kZXggZThlM2NmOS4uN2RjMzFkNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZU1hcEVudHJ5 VHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvT2JqZWN0VHJlZU1hcEVudHJ5VHJlZUVsZW1lbnQuanMKQEAgLTU1LDYgKzU1LDExIEBA IFdlYkluc3BlY3Rvci5PYmplY3RUcmVlTWFwRW50cnlUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7 CiAgICAgICAgIHJldHVybiB0aGlzLl9vYmplY3Q7CiAgICAgfSwKIAorICAgIHByb3BlcnR5UGF0 aFR5cGU6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuUHJv cGVydHlQYXRoLlR5cGUuVmFsdWU7CisgICAgfSwKKwogICAgIC8vIFByaXZhdGUKIAogICAgIF90 aXRsZUZyYWdtZW50OiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlU2V0SW5kZXhUcmVlRWxlbWVudC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVTZXRJ bmRleFRyZWVFbGVtZW50LmpzCmluZGV4IGQ5YTg1NzUuLjgxZGI2YTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVTZXRJbmRl eFRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL09iamVjdFRyZWVTZXRJbmRleFRyZWVFbGVtZW50LmpzCkBAIC01NCwxMyArNTQsMTgg QEAgV2ViSW5zcGVjdG9yLk9iamVjdFRyZWVTZXRJbmRleFRyZWVFbGVtZW50LnByb3RvdHlwZSA9 IHsKICAgICAgICAgcmV0dXJuIHRoaXMuX29iamVjdDsKICAgICB9LAogCisgICAgcmVzb2x2ZWRW YWx1ZVByb3BlcnR5UGF0aDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMu cHJvcGVydHlQYXRoLmFwcGVuZFNldEluZGV4KHRoaXMuX29iamVjdCk7CisgICAgfSwKKwogICAg IC8vIFByaXZhdGUKIAogICAgIF90aXRsZUZyYWdtZW50OiBmdW5jdGlvbigpCiAgICAgewogICAg ICAgICB2YXIgY29udGFpbmVyID0gZG9jdW1lbnQuY3JlYXRlRG9jdW1lbnRGcmFnbWVudCgpOwog Ci0gICAgICAgIHZhciBwcm9wZXJ0eVBhdGggPSB0aGlzLnByb3BlcnR5UGF0aC5hcHBlbmRTZXRJ bmRleCh0aGlzLl9vYmplY3QpOworICAgICAgICB2YXIgcHJvcGVydHlQYXRoID0gdGhpcy5yZXNv bHZlZFZhbHVlUHJvcGVydHlQYXRoKCk7CiAKICAgICAgICAgLy8gU2V0IGJ1bGxldC4KICAgICAg ICAgdmFyIG5hbWVFbGVtZW50ID0gY29udGFpbmVyLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoInNwYW4iKSk7Cg==