142366 2015-03-05 15:23:32 -0800 [Win] JSC Build Warnings Need to be Resolved 2015-03-10 12:29:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham mark.lam benjamin bfulgham cmarcelo commit-queue ggaren mark.lam msaboff saam oldest_to_newest 1074713 0 bfulgham 2015-03-05 15:23:32 -0800 There are a number of build warnings that need to be resolved. We are going to be switching build warnings to errors soon, which will turn these into build failures: source\javascriptcore\bytecode\codeblock.cpp(622): warning C4701: potentially uninitialized local variable 'sourceCodeRepresentationDescription' used source\javascriptcore\bytecode\codeblock.cpp(622): warning C4703: potentially uninitialized local pointer variable 'sourceCodeRepresentationDescription' used ..\dfg\DFGSpeculativeJIT32_64.cpp(114): warning C4245: 'initializing' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\dfg\DFGSpeculativeJIT32_64.cpp(118): warning C4245: '=' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\dfg\DFGSpeculativeJIT32_64.cpp(122): warning C4245: '=' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\dfg\DFGSpeculativeJIT32_64.cpp(126): warning C4245: '=' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\runtime\BasicBlockLocation.cpp(57): warning C4245: 'initializing' : conversion from 'int' to 'unsigned int', signed/unsigned mismatch source\javascriptcore\runtime\controlflowprofiler.cpp(117): warning C4701: potentially uninitialized local variable 'bestRange' used ..\..\jsc.cpp(367): warning C4645: function declared with __declspec(noreturn) has a return statement 1075920 1 248320 mark.lam 2015-03-10 01:13:27 -0700 Created attachment 248320 the patch. 1075981 2 248320 darin 2015-03-10 10:35:25 -0700 Comment on attachment 248320 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=248320&action=review > Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:57 > + unsigned minIdx = (unsigned)-1; Maybe UINT_MAX since the previous line uses INT_MAX? Maybe std::numeric_limits<unsigned>::max() if we want to program in C++? 1075984 3 mark.lam 2015-03-10 10:48:11 -0700 (In reply to comment #2) > Maybe UINT_MAX since the previous line uses INT_MAX? Maybe > std::numeric_limits<unsigned>::max() if we want to program in C++? We have a practice of using (unsigned)-1 all over JSC, but I agree that it's time to move to using std::numeric_limits<unsigned>::max(). Will fix. 1076006 4 248339 mark.lam 2015-03-10 11:34:00 -0700 Created attachment 248339 patch 2: applied Darin's feedback. 1076009 5 248339 bfulgham 2015-03-10 11:40:41 -0700 Comment on attachment 248339 patch 2: applied Darin's feedback. r=me 1076032 6 248339 commit-queue 2015-03-10 12:29:42 -0700 Comment on attachment 248339 patch 2: applied Darin's feedback. Clearing flags on attachment: 248339 Committed r181334: <http://trac.webkit.org/changeset/181334> 1076033 7 commit-queue 2015-03-10 12:29:47 -0700 All reviewed patches have been landed. Closing bug. 248320 2015-03-10 01:13:27 -0700 2015-03-10 11:34:00 -0700 the patch. bug-142366.patch text/plain 5322 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxMzE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTAzLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBb V2luXSBKU0MgQnVpbGQgV2FybmluZ3MgTmVlZCB0byBiZSBSZXNvbHZlZC4KKyAgICAgICAgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzE0MjM2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBcHBsaWVkIHNvbWUgYmVuaWduIGNoYW5nZXMgdG8gbWFrZSB0 aGUgTVNWQyBjb21waWxlciBoYXBweS4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5j cHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6ZHVtcEJ5dGVjb2RlKToKKyAgICAgICAgKiBk ZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3Vs YXRpdmVKSVQ6OmZpbGxKU1ZhbHVlKToKKyAgICAgICAgKiBydW50aW1lL0Jhc2ljQmxvY2tMb2Nh dGlvbi5jcHA6CisgICAgICAgIChKU0M6OkJhc2ljQmxvY2tMb2NhdGlvbjo6Z2V0RXhlY3V0ZWRS YW5nZXMpOgorICAgICAgICAqIHJ1bnRpbWUvQ29udHJvbEZsb3dQcm9maWxlci5jcHA6CisgICAg ICAgIChKU0M6OkNvbnRyb2xGbG93UHJvZmlsZXI6Omhhc0Jhc2ljQmxvY2tBdFRleHRPZmZzZXRC ZWVuRXhlY3V0ZWQpOgorCiAyMDE1LTAzLTEwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dpbkNhaXJvXSBVbnJldmlld2VkIGJ1aWxkIGZp eC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3Bw CShyZXZpc2lvbiAxODEzMTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjA3LDcgKzYwNyw3IEBAIHZvaWQgQ29kZUJs b2NrOjpkdW1wQnl0ZWNvZGUoUHJpbnRTdHJlYW0KICAgICAgICAgb3V0LnByaW50ZigiXG5Db25z dGFudHM6XG4iKTsKICAgICAgICAgc2l6ZV90IGkgPSAwOwogICAgICAgICBkbyB7Ci0gICAgICAg ICAgICBjb25zdCBjaGFyKiBzb3VyY2VDb2RlUmVwcmVzZW50YXRpb25EZXNjcmlwdGlvbjsKKyAg ICAgICAgICAgIGNvbnN0IGNoYXIqIHNvdXJjZUNvZGVSZXByZXNlbnRhdGlvbkRlc2NyaXB0aW9u ID0gbnVsbHB0cjsKICAgICAgICAgICAgIHN3aXRjaCAobV9jb25zdGFudHNTb3VyY2VDb2RlUmVw cmVzZW50YXRpb25baV0pIHsKICAgICAgICAgICAgIGNhc2UgU291cmNlQ29kZVJlcHJlc2VudGF0 aW9uOjpEb3VibGU6CiAgICAgICAgICAgICAgICAgc291cmNlQ29kZVJlcHJlc2VudGF0aW9uRGVz Y3JpcHRpb24gPSAiOiBpbiBzb3VyY2UgYXMgZG91YmxlIjsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNp b24gMTgxMzE0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VDMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTExLDcgKzExMSw3IEBAIGJvb2wgU3BlY3Vs YXRpdmVKSVQ6OmZpbGxKU1ZhbHVlKEVkZ2UgZWQKICAgICAgICAgICAgIG1fZ3Bycy5sb2NrKGdw cik7CiAgICAgICAgIH0KICAgICAgICAgdGFnR1BSID0gYWxsb2NhdGUoKTsKLSAgICAgICAgdWlu dDMyX3QgdGFnID0gSlNWYWx1ZTo6RW1wdHlWYWx1ZVRhZzsKKyAgICAgICAgaW50MzJfdCB0YWcg PSBKU1ZhbHVlOjpFbXB0eVZhbHVlVGFnOwogICAgICAgICBEYXRhRm9ybWF0IGZpbGxGb3JtYXQg PSBEYXRhRm9ybWF0SlM7CiAgICAgICAgIHN3aXRjaCAoaW5mby5yZWdpc3RlckZvcm1hdCgpKSB7 CiAgICAgICAgIGNhc2UgRGF0YUZvcm1hdEludDMyOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQmFzaWNCbG9ja0xvY2F0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9CYXNpY0Jsb2NrTG9jYXRpb24uY3BwCShyZXZpc2lvbiAx ODEzMTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9CYXNpY0Jsb2NrTG9jYXRp b24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw3IEBAIFZlY3RvcjxzdGQ6OnBhaXI8 aW50LCBpbnQ+PiBCYXNpY0Jsb2NrTG8KICAgICBpbnQgbmV4dFJhbmdlU3RhcnQgPSBtX3N0YXJ0 T2Zmc2V0OwogICAgIHdoaWxlIChnYXBzLnNpemUoKSkgewogICAgICAgICBHYXAgbWluR2FwKElO VF9NQVgsIDApOwotICAgICAgICB1bnNpZ25lZCBtaW5JZHggPSAtMTsKKyAgICAgICAgdW5zaWdu ZWQgbWluSWR4ID0gKHVuc2lnbmVkKS0xOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGlkeCA9IDA7 IGlkeCA8IGdhcHMuc2l6ZSgpOyBpZHgrKykgewogICAgICAgICAgICAgLy8gQmVjYXVzZSB3ZSBr bm93IHRoYXQgdGhlIEdhcHMgaW5zaWRlIG1fZ2FwcyBhcmVuJ3QgZW5jbG9zZWQgd2l0aGluIG9u ZSBhbm90aGVyLCBpdCBzdWZmaWNlcyB0byBqdXN0IGNoZWNrIHRoZSBmaXJzdCBlbGVtZW50IHRv IHRlc3Qgb3JkZXJpbmcuCiAgICAgICAgICAgICBpZiAoZ2Fwc1tpZHhdLmZpcnN0IDwgbWluR2Fw LmZpcnN0KSB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db250cm9sRmxv d1Byb2ZpbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9Db250cm9sRmxvd1Byb2ZpbGVyLmNwcAkocmV2aXNpb24gMTgxMzE0KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29udHJvbEZsb3dQcm9maWxlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTEwNCw2ICsxMDQsNyBAQCBib29sIENvbnRyb2xGbG93UHJvZmlsZXI6Omhhc0Jhc2lj QmxvY2tBCiAgICAgaW50IGJlc3REaXN0YW5jZSA9IElOVF9NQVg7CiAgICAgQmFzaWNCbG9ja1Jh bmdlIGJlc3RSYW5nZTsKICAgICBiZXN0UmFuZ2UubV9zdGFydE9mZnNldCA9IGJlc3RSYW5nZS5t X2VuZE9mZnNldCA9IC0xOworICAgIGJlc3RSYW5nZS5tX2hhc0V4ZWN1dGVkID0gZmFsc2U7IC8v IFN1cHByZXNzIE1TVkMgd2FybmluZy4KICAgICAvLyBCZWNhdXNlIHNvbWUgcmFuZ2VzIG1heSBv dmVybGFwIGJlY2F1c2Ugb2YgZnVuY3Rpb24gYm91bmRhcmllcywgbWFrZSBzdXJlIHRvIGZpbmQg dGhlIHNtYWxsZXN0IHJhbmdlIGVuY2xvc2luZyB0aGUgb2Zmc2V0LgogICAgIGZvciAoQmFzaWNC bG9ja1JhbmdlIHJhbmdlIDogYmxvY2tzKSB7CiAgICAgICAgIGlmIChyYW5nZS5tX3N0YXJ0T2Zm c2V0IDw9IG9mZnNldCAmJiBvZmZzZXQgPD0gcmFuZ2UubV9lbmRPZmZzZXQgJiYgKHJhbmdlLm1f ZW5kT2Zmc2V0IC0gcmFuZ2UubV9zdGFydE9mZnNldCkgPCBiZXN0RGlzdGFuY2UpIHsKSW5kZXg6 IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODEzMTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAzLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KKworICAgICAgICBbV2luXSBKU0MgQnVpbGQgV2FybmluZ3MgTmVlZCB0byBiZSBSZXNv bHZlZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0MjM2Nj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Db21waWxlci5oOgor ICAgICAgICAtIE1TVkMgYWxzbyBkb2VzIG5vdCBoYXZlIHRoZSBDT05TSURFUlNfVU5SRUFDSEFC TEVfQ09ERSBxdWlyay4KKwogMjAxNS0wMy0wOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVl QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE4MTMwNy4K SW5kZXg6IFNvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dU Ri93dGYvQ29tcGlsZXIuaAkocmV2aXNpb24gMTgxMzE0KQorKysgU291cmNlL1dURi93dGYvQ29t cGlsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODEsMTAgKzgxLDYgQEAKICNkZWZpbmUgV1RGX0NP TVBJTEVSX1NVUFBPUlRTX0NYWF9VU0VSX0xJVEVSQUxTIDEKICNlbmRpZgogCi0jaWYgIUNPTVBJ TEVSKENMQU5HKQotI2RlZmluZSBXVEZfQ09NUElMRVJfUVVJUktfQ09OU0lERVJTX1VOUkVBQ0hB QkxFX0NPREUgMQotI2VuZGlmCi0KICNpZiBDT01QSUxFUihHQ0MpICYmICFDT01QSUxFUihDTEFO RykgJiYgZGVmaW5lZChfX1NURENfVkVSU0lPTl9fKSAmJiBfX1NURENfVkVSU0lPTl9fID49IDIw MTExMkwKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NfU1RBVElDX0FTU0VSVCAxCiAj ZW5kaWYKQEAgLTEyOCw2ICsxMjQsMTAgQEAKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVTkNDIDEK ICNlbmRpZgogCisjaWYgIUNPTVBJTEVSKENMQU5HKSAmJiAhQ09NUElMRVIoTVNWQykKKyNkZWZp bmUgV1RGX0NPTVBJTEVSX1FVSVJLX0NPTlNJREVSU19VTlJFQUNIQUJMRV9DT0RFIDEKKyNlbmRp ZgorCiAvKiA9PT09IENPTVBJTEVSX1NVUFBPUlRTIC0gYWRkaXRpb25hbCBjb21waWxlciBmZWF0 dXJlIGRldGVjdGlvbiwgaW4gYWxwaGFiZXRpY2FsIG9yZGVyID09PT0gKi8KIAogLyogQ09NUElM RVJfU1VQUE9SVFMoRUFCSSkgKi8K 248339 2015-03-10 11:34:00 -0700 2015-03-10 12:29:42 -0700 patch 2: applied Darin's feedback. bug-142366.patch text/plain 5360 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxMzI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTAzLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBb V2luXSBKU0MgQnVpbGQgV2FybmluZ3MgTmVlZCB0byBiZSBSZXNvbHZlZC4KKyAgICAgICAgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzE0MjM2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBcHBsaWVkIHNvbWUgYmVuaWduIGNoYW5nZXMgdG8gbWFrZSB0 aGUgTVNWQyBjb21waWxlciBoYXBweS4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5j cHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6ZHVtcEJ5dGVjb2RlKToKKyAgICAgICAgKiBk ZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3Vs YXRpdmVKSVQ6OmZpbGxKU1ZhbHVlKToKKyAgICAgICAgKiBydW50aW1lL0Jhc2ljQmxvY2tMb2Nh dGlvbi5jcHA6CisgICAgICAgIChKU0M6OkJhc2ljQmxvY2tMb2NhdGlvbjo6Z2V0RXhlY3V0ZWRS YW5nZXMpOgorICAgICAgICAqIHJ1bnRpbWUvQ29udHJvbEZsb3dQcm9maWxlci5jcHA6CisgICAg ICAgIChKU0M6OkNvbnRyb2xGbG93UHJvZmlsZXI6Omhhc0Jhc2ljQmxvY2tBdFRleHRPZmZzZXRC ZWVuRXhlY3V0ZWQpOgorCiAyMDE1LTAzLTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnph cm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBHQ0M6IENSQVNIKCkgc2hvdWxkIGJlIGFubm90YXRl ZCB3aXRoIE5PUkVUVVJOCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv Q29kZUJsb2NrLmNwcAkocmV2aXNpb24gMTgxMzI5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwNyw3ICs2MDcsNyBA QCB2b2lkIENvZGVCbG9jazo6ZHVtcEJ5dGVjb2RlKFByaW50U3RyZWFtCiAgICAgICAgIG91dC5w cmludGYoIlxuQ29uc3RhbnRzOlxuIik7CiAgICAgICAgIHNpemVfdCBpID0gMDsKICAgICAgICAg ZG8gewotICAgICAgICAgICAgY29uc3QgY2hhciogc291cmNlQ29kZVJlcHJlc2VudGF0aW9uRGVz Y3JpcHRpb247CisgICAgICAgICAgICBjb25zdCBjaGFyKiBzb3VyY2VDb2RlUmVwcmVzZW50YXRp b25EZXNjcmlwdGlvbiA9IG51bGxwdHI7CiAgICAgICAgICAgICBzd2l0Y2ggKG1fY29uc3RhbnRz U291cmNlQ29kZVJlcHJlc2VudGF0aW9uW2ldKSB7CiAgICAgICAgICAgICBjYXNlIFNvdXJjZUNv ZGVSZXByZXNlbnRhdGlvbjo6RG91YmxlOgogICAgICAgICAgICAgICAgIHNvdXJjZUNvZGVSZXBy ZXNlbnRhdGlvbkRlc2NyaXB0aW9uID0gIjogaW4gc291cmNlIGFzIGRvdWJsZSI7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82 NC5jcHAJKHJldmlzaW9uIDE4MTMyOSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMSw3ICsxMTEsNyBA QCBib29sIFNwZWN1bGF0aXZlSklUOjpmaWxsSlNWYWx1ZShFZGdlIGVkCiAgICAgICAgICAgICBt X2dwcnMubG9jayhncHIpOwogICAgICAgICB9CiAgICAgICAgIHRhZ0dQUiA9IGFsbG9jYXRlKCk7 Ci0gICAgICAgIHVpbnQzMl90IHRhZyA9IEpTVmFsdWU6OkVtcHR5VmFsdWVUYWc7CisgICAgICAg IGludDMyX3QgdGFnID0gSlNWYWx1ZTo6RW1wdHlWYWx1ZVRhZzsKICAgICAgICAgRGF0YUZvcm1h dCBmaWxsRm9ybWF0ID0gRGF0YUZvcm1hdEpTOwogICAgICAgICBzd2l0Y2ggKGluZm8ucmVnaXN0 ZXJGb3JtYXQoKSkgewogICAgICAgICBjYXNlIERhdGFGb3JtYXRJbnQzMjoKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Jhc2ljQmxvY2tMb2NhdGlvbi5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQmFzaWNCbG9ja0xvY2F0aW9uLmNw cAkocmV2aXNpb24gMTgxMzI5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQmFz aWNCbG9ja0xvY2F0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsNyBAQCBWZWN0 b3I8c3RkOjpwYWlyPGludCwgaW50Pj4gQmFzaWNCbG9ja0xvCiAgICAgaW50IG5leHRSYW5nZVN0 YXJ0ID0gbV9zdGFydE9mZnNldDsKICAgICB3aGlsZSAoZ2Fwcy5zaXplKCkpIHsKICAgICAgICAg R2FwIG1pbkdhcChJTlRfTUFYLCAwKTsKLSAgICAgICAgdW5zaWduZWQgbWluSWR4ID0gLTE7Cisg ICAgICAgIHVuc2lnbmVkIG1pbklkeCA9IHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWduZWQ+Ojpt YXgoKTsKICAgICAgICAgZm9yICh1bnNpZ25lZCBpZHggPSAwOyBpZHggPCBnYXBzLnNpemUoKTsg aWR4KyspIHsKICAgICAgICAgICAgIC8vIEJlY2F1c2Ugd2Uga25vdyB0aGF0IHRoZSBHYXBzIGlu c2lkZSBtX2dhcHMgYXJlbid0IGVuY2xvc2VkIHdpdGhpbiBvbmUgYW5vdGhlciwgaXQgc3VmZmlj ZXMgdG8ganVzdCBjaGVjayB0aGUgZmlyc3QgZWxlbWVudCB0byB0ZXN0IG9yZGVyaW5nLgogICAg ICAgICAgICAgaWYgKGdhcHNbaWR4XS5maXJzdCA8IG1pbkdhcC5maXJzdCkgewpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29udHJvbEZsb3dQcm9maWxlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29udHJvbEZsb3dQcm9maWxl ci5jcHAJKHJldmlzaW9uIDE4MTMyOSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NvbnRyb2xGbG93UHJvZmlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsNiArMTA0LDcg QEAgYm9vbCBDb250cm9sRmxvd1Byb2ZpbGVyOjpoYXNCYXNpY0Jsb2NrQQogICAgIGludCBiZXN0 RGlzdGFuY2UgPSBJTlRfTUFYOwogICAgIEJhc2ljQmxvY2tSYW5nZSBiZXN0UmFuZ2U7CiAgICAg YmVzdFJhbmdlLm1fc3RhcnRPZmZzZXQgPSBiZXN0UmFuZ2UubV9lbmRPZmZzZXQgPSAtMTsKKyAg ICBiZXN0UmFuZ2UubV9oYXNFeGVjdXRlZCA9IGZhbHNlOyAvLyBTdXBwcmVzcyBNU1ZDIHdhcm5p bmcuCiAgICAgLy8gQmVjYXVzZSBzb21lIHJhbmdlcyBtYXkgb3ZlcmxhcCBiZWNhdXNlIG9mIGZ1 bmN0aW9uIGJvdW5kYXJpZXMsIG1ha2Ugc3VyZSB0byBmaW5kIHRoZSBzbWFsbGVzdCByYW5nZSBl bmNsb3NpbmcgdGhlIG9mZnNldC4KICAgICBmb3IgKEJhc2ljQmxvY2tSYW5nZSByYW5nZSA6IGJs b2NrcykgewogICAgICAgICBpZiAocmFuZ2UubV9zdGFydE9mZnNldCA8PSBvZmZzZXQgJiYgb2Zm c2V0IDw9IHJhbmdlLm1fZW5kT2Zmc2V0ICYmIChyYW5nZS5tX2VuZE9mZnNldCAtIHJhbmdlLm1f c3RhcnRPZmZzZXQpIDwgYmVzdERpc3RhbmNlKSB7CkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxMzI5KQor KysgU291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAxNS0wMy0xMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dp bl0gSlNDIEJ1aWxkIFdhcm5pbmdzIE5lZWQgdG8gYmUgUmVzb2x2ZWQuCisgICAgICAgIDxodHRw czovL3dlYmtpdC5vcmcvYi8xNDIzNjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiB3dGYvQ29tcGlsZXIuaDoKKyAgICAgICAgLSBNU1ZDIGFsc28g ZG9lcyBub3QgaGF2ZSB0aGUgQ09OU0lERVJTX1VOUkVBQ0hBQkxFX0NPREUgcXVpcmsuCisKIDIw MTUtMDMtMTAgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBi bWFsbG9jOiB0cnlGYXN0TWFsbG9jIHNob3VsZG4ndCBjcmFzaApJbmRleDogU291cmNlL1dURi93 dGYvQ29tcGlsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCShy ZXZpc2lvbiAxODEzMjkpCisrKyBTb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCSh3b3JraW5nIGNv cHkpCkBAIC04MSwxMCArODEsNiBAQAogI2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hY X1VTRVJfTElURVJBTFMgMQogI2VuZGlmCiAKLSNpZiAhQ09NUElMRVIoQ0xBTkcpCi0jZGVmaW5l IFdURl9DT01QSUxFUl9RVUlSS19DT05TSURFUlNfVU5SRUFDSEFCTEVfQ09ERSAxCi0jZW5kaWYK LQogI2lmIENPTVBJTEVSKEdDQykgJiYgIUNPTVBJTEVSKENMQU5HKSAmJiBkZWZpbmVkKF9fU1RE Q19WRVJTSU9OX18pICYmIF9fU1REQ19WRVJTSU9OX18gPj0gMjAxMTEyTAogI2RlZmluZSBXVEZf Q09NUElMRVJfU1VQUE9SVFNfQ19TVEFUSUNfQVNTRVJUIDEKICNlbmRpZgpAQCAtMTI4LDYgKzEy NCwxMCBAQAogI2RlZmluZSBXVEZfQ09NUElMRVJfU1VOQ0MgMQogI2VuZGlmCiAKKyNpZiAhQ09N UElMRVIoQ0xBTkcpICYmICFDT01QSUxFUihNU1ZDKQorI2RlZmluZSBXVEZfQ09NUElMRVJfUVVJ UktfQ09OU0lERVJTX1VOUkVBQ0hBQkxFX0NPREUgMQorI2VuZGlmCisKIC8qID09PT0gQ09NUElM RVJfU1VQUE9SVFMgLSBhZGRpdGlvbmFsIGNvbXBpbGVyIGZlYXR1cmUgZGV0ZWN0aW9uLCBpbiBh bHBoYWJldGljYWwgb3JkZXIgPT09PSAqLwogCiAvKiBDT01QSUxFUl9TVVBQT1JUUyhFQUJJKSAq Lwo=