142362 2015-03-05 13:20:43 -0800 Two text carets result when dragging a file into a contentEditable area that preventDefault()s the "drop" event 2015-03-05 16:37:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton dino enrica rniwa sam simon.fraser oldest_to_newest 1074663 0 thorton 2015-03-05 13:20:43 -0800 Two text carets result when dragging a file into a contentEditable area that preventDefault()s the "drop" event 1074664 1 247988 thorton 2015-03-05 13:21:01 -0800 Created attachment 247988 Patch 1074665 2 247989 thorton 2015-03-05 13:22:12 -0800 Created attachment 247989 manual test case 1074747 3 thorton 2015-03-05 16:37:21 -0800 http://trac.webkit.org/changeset/181115 247988 2015-03-05 13:21:01 -0800 2015-03-05 16:27:48 -0800 Patch bug-142362-20150305132042.patch text/plain 6360 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIwNjFiNjk3NGE3N2E4 ZWM1NzE0MTE0OGJjOTU4NmY5NzAxYWFiMS4uMTI2ZDE0MDMzMzQ0NTVmMGFkN2QwNDlkZGQ4Zjgw OGFiNjQzYmRiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE1LTAzLTA1ICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBUd28gdGV4 dCBjYXJldHMgcmVzdWx0IHdoZW4gZHJhZ2dpbmcgYSBmaWxlIGludG8gYSBjb250ZW50RWRpdGFi bGUgYXJlYSB0aGF0IHByZXZlbnREZWZhdWx0KClzIHRoZSAiZHJvcCIgZXZlbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjM2MgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjAwNDY0MzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwYWdlL0RyYWdDb250cm9sbGVyLmg6CisgICAgICAgICogcGFn ZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6 Y2xlYXJEcmFnQ2FyZXQpOgorICAgICAgICBSZW5hbWUgY2FuY2VsRHJhZyB0byBjbGVhckRyYWdD YXJldCwgc2luY2UgdGhhdCdzIHJlYWxseSB3aGF0IGl0IGRvZXMuCisKKyAgICAgICAgKFdlYkNv cmU6OkRyYWdDb250cm9sbGVyOjp0cnlEb2N1bWVudERyYWcpOgorICAgICAgICBXaGVuIHVwZGF0 aW5nIHRoZSBkcmFnIHBvc2l0aW9uLCBpZiB3ZSdyZSBub3cgb3ZlciBhIDxpbnB1dCB0eXBlPSJm aWxlIj4sCisgICAgICAgIGNsZWFyIHRoZSBkcmFnIGNhcmV0LiBUaGlzIGF2b2lkcyBsZWF2aW5n IGEgY2FyZXQgYmVoaW5kIHdoZW4gZHJhZ2dpbmcKKyAgICAgICAgb3ZlciBhIDxpbnB1dCB0eXBl PSJmaWxlIj4gaW5zaWRlIGEgY29udGVudEVkaXRhYmxlIGFyZWEuCisKKyAgICAgICAgKFdlYkNv cmU6OkRyYWdDb250cm9sbGVyOjpwZXJmb3JtRHJhZ09wZXJhdGlvbik6CisgICAgICAgIFdoZW4g dGhlIGNvbnRlbnQgcHJldmVudERlZmF1bHQoKXMgd2hpbGUgZmluaXNoaW5nIGEgZHJhZywgd2Ug c2hvdWxkIHN0aWxsCisgICAgICAgIGNsZWFyIHRoZSBkcmFnIGNhcmV0LCBiZWNhdXNlIGl0J3Mg cG9zc2libGUgdGhhdCB0aGUgY2xpZW50IGRpZCBub3QKKyAgICAgICAgcHJldmVudERlZmF1bHQo KSBvbiBkcmFnb3Zlci9ldGMuLCBzbyB3ZSB3b3VsZCBoYXZlIHNldCBhIGN1cnNvciwgYW5kCisg ICAgICAgIG5vdyBuZWVkIHRvIGNsZWFyIGl0IHNvIHRoYXQgaXQgZG9lc24ndCBnZXQgbGVmdCBi ZWhpbmQuCisKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdDb250cm9sbGVyOjptb3VzZU1vdmVkSW50 b0RvY3VtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdDb250cm9sbGVyOjpkcmFnRW50ZXJl ZE9yVXBkYXRlZCk6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6Y29uY2x1ZGVF ZGl0RHJhZyk6CisgICAgICAgIEFkanVzdCB0byByZW5hbWVkIGNsZWFyRHJhZ0NhcmV0LgorCisg ICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6ZHJhZ0VuZGVkKToKKyAgICAgICAgTWFr ZSB1c2Ugb2YgY2xlYXJEcmFnQ2FyZXQgKHdoaWNoIGlzIGVxdWl2YWxlbnQgdG8gdGhpcyBsaW5l KS4KKwogMjAxNS0wMy0wNCAgVGltb3RoeSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CiAKICAgICAgICAgPGF0dGFjaG1lbnQ+IGljb25zIGFyZSBsb3ctcmVzb2x1dGlvbiB3aGVu IHRyYW5zZm9ybWVkIG9yIHVuZGVyIHBhZ2Ugc2NhbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29u dHJvbGxlci5jcHAKaW5kZXggMTk2MWEzZjNlNGUyZDUzY2YwY2JlNjc4Y2VmYTA4MDczNjkxMDU1 OS4uN2EzYzMwNGE4NDg2MGVmYTc4MzI0NTliMzYyMzRkZjZmYzU0NWRhNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKQEAgLTE1Niw4ICsxNTYsNyBAQCBib29sIERyYWdD b250cm9sbGVyOjpkcmFnSXNNb3ZlKEZyYW1lU2VsZWN0aW9uJiBzZWxlY3Rpb24sIERyYWdEYXRh JiBkcmFnRGF0YSkKICAgICByZXR1cm4gbV9kb2N1bWVudFVuZGVyTW91c2UgPT0gbV9kcmFnSW5p dGlhdG9yICYmIHZpc2libGVTZWxlY3Rpb24uaXNDb250ZW50RWRpdGFibGUoKSAmJiB2aXNpYmxl U2VsZWN0aW9uLmlzUmFuZ2UoKSAmJiAhaXNDb3B5S2V5RG93bihkcmFnRGF0YSk7CiB9CiAKLS8v IEZJWE1FOiBUaGlzIG1ldGhvZCBpcyBwb29ybHkgbmFtZWQuICBXZSdyZSBqdXN0IGNsZWFyaW5n IHRoZSBzZWxlY3Rpb24gZnJvbSB0aGUgZG9jdW1lbnQgdGhpcyBkcmFnIGlzIGV4aXRpbmcuCi12 b2lkIERyYWdDb250cm9sbGVyOjpjYW5jZWxEcmFnKCkKK3ZvaWQgRHJhZ0NvbnRyb2xsZXI6OmNs ZWFyRHJhZ0NhcmV0KCkKIHsKICAgICBtX3BhZ2UuZHJhZ0NhcmV0Q29udHJvbGxlcigpLmNsZWFy KCk7CiB9CkBAIC0xNjYsNyArMTY1LDcgQEAgdm9pZCBEcmFnQ29udHJvbGxlcjo6ZHJhZ0VuZGVk KCkKIHsKICAgICBtX2RyYWdJbml0aWF0b3IgPSAwOwogICAgIG1fZGlkSW5pdGlhdGVEcmFnID0g ZmFsc2U7Ci0gICAgbV9wYWdlLmRyYWdDYXJldENvbnRyb2xsZXIoKS5jbGVhcigpOworICAgIGNs ZWFyRHJhZ0NhcmV0KCk7CiAgICAgCiAgICAgbV9jbGllbnQuZHJhZ0VuZGVkKCk7CiB9CkBAIC0y MTYsNiArMjE1LDcgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6cGVyZm9ybURyYWdPcGVyYXRpb24o RHJhZ0RhdGEmIGRyYWdEYXRhKQogICAgICAgICAgICAgZGF0YVRyYW5zZmVyLT5zZXRBY2Nlc3NQ b2xpY3koRGF0YVRyYW5zZmVyQWNjZXNzUG9saWN5OjpOdW1iKTsgLy8gSW52YWxpZGF0ZSBkYXRh VHJhbnNmZXIgaGVyZSBmb3Igc2VjdXJpdHkuCiAgICAgICAgIH0KICAgICAgICAgaWYgKHByZXZl bnRlZERlZmF1bHQpIHsKKyAgICAgICAgICAgIGNsZWFyRHJhZ0NhcmV0KCk7CiAgICAgICAgICAg ICBtX2RvY3VtZW50VW5kZXJNb3VzZSA9IDA7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAgICAgfQpAQCAtMjQzLDcgKzI0Myw3IEBAIHZvaWQgRHJhZ0NvbnRyb2xsZXI6Om1vdXNlTW92 ZWRJbnRvRG9jdW1lbnQoRG9jdW1lbnQqIG5ld0RvY3VtZW50KQogCiAgICAgLy8gSWYgd2Ugd2Vy ZSBvdmVyIGFub3RoZXIgZG9jdW1lbnQgY2xlYXIgdGhlIHNlbGVjdGlvbgogICAgIGlmIChtX2Rv Y3VtZW50VW5kZXJNb3VzZSkKLSAgICAgICAgY2FuY2VsRHJhZygpOworICAgICAgICBjbGVhckRy YWdDYXJldCgpOwogICAgIG1fZG9jdW1lbnRVbmRlck1vdXNlID0gbmV3RG9jdW1lbnQ7CiB9CiAK QEAgLTI1Myw3ICsyNTMsNyBAQCBEcmFnT3BlcmF0aW9uIERyYWdDb250cm9sbGVyOjpkcmFnRW50 ZXJlZE9yVXBkYXRlZChEcmFnRGF0YSYgZHJhZ0RhdGEpCiAKICAgICBtX2RyYWdEZXN0aW5hdGlv bkFjdGlvbiA9IG1fY2xpZW50LmFjdGlvbk1hc2tGb3JEcmFnKGRyYWdEYXRhKTsKICAgICBpZiAo bV9kcmFnRGVzdGluYXRpb25BY3Rpb24gPT0gRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uTm9uZSkgewot ICAgICAgICBjYW5jZWxEcmFnKCk7IC8vIEZJWE1FOiBXaHkgbm90IGNhbGwgbW91c2VNb3ZlZElu dG9Eb2N1bWVudChudWxscHRyKT8KKyAgICAgICAgY2xlYXJEcmFnQ2FyZXQoKTsgLy8gRklYTUU6 IFdoeSBub3QgY2FsbCBtb3VzZU1vdmVkSW50b0RvY3VtZW50KG51bGxwdHIpPwogICAgICAgICBy ZXR1cm4gRHJhZ09wZXJhdGlvbk5vbmU7CiAgICAgfQogCkBAIC0zMjMsNyArMzIzLDcgQEAgYm9v bCBEcmFnQ29udHJvbGxlcjo6dHJ5RG9jdW1lbnREcmFnKERyYWdEYXRhJiBkcmFnRGF0YSwgRHJh Z0Rlc3RpbmF0aW9uQWN0aW9uIGEKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgaWYgKGlz SGFuZGxpbmdEcmFnKSB7Ci0gICAgICAgIG1fcGFnZS5kcmFnQ2FyZXRDb250cm9sbGVyKCkuY2xl YXIoKTsKKyAgICAgICAgY2xlYXJEcmFnQ2FyZXQoKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAg ICAgfQogCkBAIC0zNDcsNiArMzQ3LDggQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6dHJ5RG9jdW1l bnREcmFnKERyYWdEYXRhJiBkcmFnRGF0YSwgRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uIGEKICAgICAg ICAgCiAgICAgICAgIGlmICghbV9maWxlSW5wdXRFbGVtZW50VW5kZXJNb3VzZSkKICAgICAgICAg ICAgIG1fcGFnZS5kcmFnQ2FyZXRDb250cm9sbGVyKCkuc2V0Q2FyZXRQb3NpdGlvbihtX2RvY3Vt ZW50VW5kZXJNb3VzZS0+ZnJhbWUoKS0+dmlzaWJsZVBvc2l0aW9uRm9yUG9pbnQocG9pbnQpKTsK KyAgICAgICAgZWxzZQorICAgICAgICAgICAgY2xlYXJEcmFnQ2FyZXQoKTsKIAogICAgICAgICBG cmFtZSogaW5uZXJGcmFtZSA9IGVsZW1lbnQtPmRvY3VtZW50KCkuZnJhbWUoKTsKICAgICAgICAg ZHJhZ09wZXJhdGlvbiA9IGRyYWdJc01vdmUoaW5uZXJGcmFtZS0+c2VsZWN0aW9uKCksIGRyYWdE YXRhKSA/IERyYWdPcGVyYXRpb25Nb3ZlIDogRHJhZ09wZXJhdGlvbkNvcHk7CkBAIC0zNzYsNyAr Mzc4LDcgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6dHJ5RG9jdW1lbnREcmFnKERyYWdEYXRhJiBk cmFnRGF0YSwgRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uIGEKICAgICB9CiAgICAgCiAgICAgLy8gV2Ug YXJlIG5vdCBvdmVyIGFuIGVkaXRhYmxlIHJlZ2lvbi4gTWFrZSBzdXJlIHdlJ3JlIGNsZWFyaW5n IGFueSBwcmlvciBkcmFnIGN1cnNvci4KLSAgICBtX3BhZ2UuZHJhZ0NhcmV0Q29udHJvbGxlcigp LmNsZWFyKCk7CisgICAgY2xlYXJEcmFnQ2FyZXQoKTsKICAgICBpZiAobV9maWxlSW5wdXRFbGVt ZW50VW5kZXJNb3VzZSkKICAgICAgICAgbV9maWxlSW5wdXRFbGVtZW50VW5kZXJNb3VzZS0+c2V0 Q2FuUmVjZWl2ZURyb3BwZWRGaWxlcyhmYWxzZSk7CiAgICAgbV9maWxlSW5wdXRFbGVtZW50VW5k ZXJNb3VzZSA9IDA7CkBAIC00NzMsMTIgKzQ3NSwxMiBAQCBib29sIERyYWdDb250cm9sbGVyOjpj b25jbHVkZUVkaXREcmFnKERyYWdEYXRhJiBkcmFnRGF0YSkKICAgICB9CiAKICAgICBpZiAoIW1f cGFnZS5kcmFnQ29udHJvbGxlcigpLmNhblByb2Nlc3NEcmFnKGRyYWdEYXRhKSkgewotICAgICAg ICBtX3BhZ2UuZHJhZ0NhcmV0Q29udHJvbGxlcigpLmNsZWFyKCk7CisgICAgICAgIGNsZWFyRHJh Z0NhcmV0KCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKICAgICBWaXNpYmxlU2Vs ZWN0aW9uIGRyYWdDYXJldCA9IG1fcGFnZS5kcmFnQ2FyZXRDb250cm9sbGVyKCkuY2FyZXRQb3Np dGlvbigpOwotICAgIG1fcGFnZS5kcmFnQ2FyZXRDb250cm9sbGVyKCkuY2xlYXIoKTsKKyAgICBj bGVhckRyYWdDYXJldCgpOwogICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBkcmFnQ2FyZXQudG9O b3JtYWxpemVkUmFuZ2UoKTsKICAgICBSZWZQdHI8RWxlbWVudD4gcm9vdEVkaXRhYmxlRWxlbWVu dCA9IGlubmVyRnJhbWUtPnNlbGVjdGlvbigpLnNlbGVjdGlvbigpLnJvb3RFZGl0YWJsZUVsZW1l bnQoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5o IGIvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5oCmluZGV4IGQ3YjI4NzE0Yjc5 MWUxYmQwMmM5MjQ1MDJkNDZlZWY1NTYwMTU4MWYuLjg1YWQ1MmY0YmEzOGQwN2RkMWQ1YzgxNjMy YTVhYjAwMTIyNWVhODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRy b2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmgKQEAgLTEw NCw3ICsxMDQsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgdHJ5RG9jdW1l bnREcmFnKERyYWdEYXRhJiwgRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uLCBEcmFnT3BlcmF0aW9uJik7 CiAgICAgICAgIGJvb2wgdHJ5REhUTUxEcmFnKERyYWdEYXRhJiwgRHJhZ09wZXJhdGlvbiYpOwog ICAgICAgICBEcmFnT3BlcmF0aW9uIGRyYWdPcGVyYXRpb24oRHJhZ0RhdGEmKTsKLSAgICAgICAg dm9pZCBjYW5jZWxEcmFnKCk7CisgICAgICAgIHZvaWQgY2xlYXJEcmFnQ2FyZXQoKTsKICAgICAg ICAgYm9vbCBkcmFnSXNNb3ZlKEZyYW1lU2VsZWN0aW9uJiwgRHJhZ0RhdGEmKTsKICAgICAgICAg Ym9vbCBpc0NvcHlLZXlEb3duKERyYWdEYXRhJik7CiAK 247989 2015-03-05 13:22:12 -0800 2015-03-05 13:22:12 -0800 manual test case ce.html text/html 160 thorton PGJvZHkgc3R5bGU9ImZvbnQtc2l6ZTogMjRwdDsiIGNvbnRlbnRFZGl0YWJsZT5kcm9wIGhlcmU8 L2JvZHk+CjxzY3JpcHQ+CmRvY3VtZW50LmJvZHkuYWRkRXZlbnRMaXN0ZW5lcigiZHJvcCIsIGZ1 bmN0aW9uIChlKSB7IGUucHJldmVudERlZmF1bHQoKTsgfSk7Cjwvc2NyaXB0Pg==