142361 2015-03-05 13:14:14 -0800 Fix the build when NEON_INTRINSICS is enabled 2015-03-05 15:56:55 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other All RESOLVED FIXED P2 Blocker --- 1 sperez webkit-unassigned cgarcia commit-queue dino kondapallykalyan ossy simon.fraser oldest_to_newest 1074660 0 sperez 2015-03-05 13:14:14 -0800 Project does not compile when ARM_NEON_INTRINSICS is enabled. In file 'WebKit/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp' variable 'isAlphaImage' is used as a function (i.e., isAlphaImage()) and in file 'WebKit/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h' a ';' is missing. 1074668 1 247990 sperez 2015-03-05 13:28:16 -0800 Created attachment 247990 A patch that fixes the bug 1074706 2 ossy 2015-03-05 15:09:55 -0800 Just to note: r177000 caused the isAlphaImage issue and r170433 caused the return issue. Thanks for the fix. But it means that we didn't enable NEON on our ARM bots, but we should. 1074726 3 247990 commit-queue 2015-03-05 15:56:50 -0800 Comment on attachment 247990 A patch that fixes the bug Clearing flags on attachment: 247990 Committed r181110: <http://trac.webkit.org/changeset/181110> 1074727 4 commit-queue 2015-03-05 15:56:55 -0800 All reviewed patches have been landed. Closing bug. 247990 2015-03-05 13:28:16 -0800 2015-03-05 15:56:50 -0800 A patch that fixes the bug fix-arm-neon-build.diff text/plain 2779 sperez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NDBjY2Q3Li42YmE1ZjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTUtMDMtMDUgIFNhbmR5IFBlcmV6ICA8c3BlcmV6QGluZGFiYS5lcz4KKworICAgICAg ICBGaXggdGhlIGJ1aWxkIHdoZW4gTkVPTl9JTlRSSU5TSUNTIGlzIGVuYWJsZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjM2MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY3B1L2FybS9maWx0ZXJzL0ZFQmxlbmRORU9OLmg6CisgICAgICAgIChXZWJDb3JlOjpGRUJs ZW5kOjpwbGF0Zm9ybUFwcGx5U29mdHdhcmUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRkVHYXVzc2lhbkJsdXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c3RhbmRhcmRC b3hCbHVyKToKKwogMjAxNS0wMy0wNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgW1NPVVBdIENoZWNrIFRMUyBlcnJvcnMgYXMgc29vbiBhcyB0 aGV5IGFyZSBzZXQgaW4gdGhlIFNvdXBNZXNzYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRlcnMvRkVCbGVuZE5FT04uaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9hcm0vZmlsdGVycy9GRUJsZW5kTkVPTi5o CmluZGV4IDkxYjcyYTMuLjUwZWM4NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NwdS9hcm0vZmlsdGVycy9GRUJsZW5kTkVPTi5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9hcm0vZmlsdGVycy9GRUJsZW5kTkVPTi5oCkBA IC0xMjYsNyArMTI2LDcgQEAgdm9pZCBGRUJsZW5kOjpwbGF0Zm9ybUFwcGx5U29mdHdhcmUoKQog CiAgICAgaWYgKHBpeGVsQXJyYXlMZW5ndGggPj0gOCkgewogICAgICAgICBwbGF0Zm9ybUFwcGx5 TkVPTihzcmNQaXhlbEFycmF5QS0+ZGF0YSgpLCBzcmNQaXhlbEFycmF5Qi0+ZGF0YSgpLCBkc3RQ aXhlbEFycmF5LT5kYXRhKCksIHBpeGVsQXJyYXlMZW5ndGgpOwotICAgICAgICByZXR1cm4KKyAg ICAgICAgcmV0dXJuOwogICAgIH0KICAgICAvLyBJZiB0aGVyZSBpcyBqdXN0IG9uZSBwaXhlbCB3 ZSBleHBhbmQgaXQgdG8gdHdvLgogICAgIEFTU0VSVChwaXhlbEFycmF5TGVuZ3RoID4gMCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFR2F1 c3NpYW5CbHVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMv RkVHYXVzc2lhbkJsdXIuY3BwCmluZGV4IDg1YmNhNzQuLjNlM2NmMjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVHYXVzc2lhbkJsdXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVHYXVzc2lh bkJsdXIuY3BwCkBAIC0zNDUsNyArMzQ1LDcgQEAgaW5saW5lIHZvaWQgc3RhbmRhcmRCb3hCbHVy KFVpbnQ4Q2xhbXBlZEFycmF5KiBzcmMsIFVpbnQ4Q2xhbXBlZEFycmF5KiBkc3QsIHVuc2kKICAg ICAgICAgaWYgKGtlcm5lbFNpemVYKSB7CiAgICAgICAgICAgICBrZXJuZWxQb3NpdGlvbihpLCBr ZXJuZWxTaXplWCwgZHhMZWZ0LCBkeFJpZ2h0KTsKICNpZiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJ Q1MpCi0gICAgICAgICAgICBpZiAoIWlzQWxwaGFJbWFnZSgpKQorICAgICAgICAgICAgaWYgKCFp c0FscGhhSW1hZ2UpCiAgICAgICAgICAgICAgICAgYm94Qmx1ck5FT04oc3JjLCBkc3QsIGtlcm5l bFNpemVYLCBkeExlZnQsIGR4UmlnaHQsIDQsIHN0cmlkZSwgcGFpbnRTaXplLndpZHRoKCksIHBh aW50U2l6ZS5oZWlnaHQoKSk7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgYm94 Qmx1cihzcmMsIGRzdCwga2VybmVsU2l6ZVgsIGR4TGVmdCwgZHhSaWdodCwgNCwgc3RyaWRlLCBw YWludFNpemUud2lkdGgoKSwgcGFpbnRTaXplLmhlaWdodCgpLCB0cnVlLCBlZGdlTW9kZSk7CkBA IC0zNTgsNyArMzU4LDcgQEAgaW5saW5lIHZvaWQgc3RhbmRhcmRCb3hCbHVyKFVpbnQ4Q2xhbXBl ZEFycmF5KiBzcmMsIFVpbnQ4Q2xhbXBlZEFycmF5KiBkc3QsIHVuc2kKICAgICAgICAgaWYgKGtl cm5lbFNpemVZKSB7CiAgICAgICAgICAgICBrZXJuZWxQb3NpdGlvbihpLCBrZXJuZWxTaXplWSwg ZHlMZWZ0LCBkeVJpZ2h0KTsKICNpZiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJQ1MpCi0gICAgICAg ICAgICBpZiAoIWlzQWxwaGFJbWFnZSgpKQorICAgICAgICAgICAgaWYgKCFpc0FscGhhSW1hZ2Up CiAgICAgICAgICAgICAgICAgYm94Qmx1ck5FT04oc3JjLCBkc3QsIGtlcm5lbFNpemVZLCBkeUxl ZnQsIGR5UmlnaHQsIHN0cmlkZSwgNCwgcGFpbnRTaXplLmhlaWdodCgpLCBwYWludFNpemUud2lk dGgoKSk7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgYm94Qmx1cihzcmMsIGRz dCwga2VybmVsU2l6ZVksIGR5TGVmdCwgZHlSaWdodCwgc3RyaWRlLCA0LCBwYWludFNpemUuaGVp Z2h0KCksIHBhaW50U2l6ZS53aWR0aCgpLCB0cnVlLCBlZGdlTW9kZSk7Cg==