142347 2015-03-05 09:16:52 -0800 [GTK] Contents not shown when entering AC mode unless the window is resized 2015-03-10 06:40:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson zan oldest_to_newest 1074536 0 cgarcia 2015-03-05 09:16:52 -0800 This can be easily reproduced with the simple tests case joanie posted in bug #142333. <html> <body> <div style="-webkit-transform: translate3d(0, 0, 0);">foo</div> </body> </html> Just open that in MiniBrowser, not always but very often the foo text is not shown. Resize the window and it appears. The problem is once again that we are now creating the redirected X window in realize method. When entering AC mode we resize the redirected window to the drawing area size. since the size hasn't changed from the drawing area point of view, the web process is not notified. The WebProcess always uses the window size, instead of the root layer size, to make sure it's in sync, see the comment in LayerTreeHostGtk::compositeLayersToContext(). So, we need to enforce a resize when we change the size of the redirected window when entering AC mode. 1074537 1 247956 cgarcia 2015-03-05 09:18:53 -0800 Created attachment 247956 Patch 1074539 2 commit-queue 2015-03-05 09:20:29 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1075367 3 248187 cgarcia 2015-03-08 04:01:34 -0700 Created attachment 248187 Updated patch I've realized that my previous patch only worked for the case when we enter AC mode after the web view is realized. If it's happens before, we have a pending resize on map, and we do the actual resize after the web view is realized and mapped. In that case we also need to enforce a resize to make sure the web process uses the right context size. 1075378 4 248187 zan 2015-03-08 10:44:11 -0700 Comment on attachment 248187 Updated patch OK. 1075550 5 cgarcia 2015-03-09 02:07:27 -0700 hmm, I'm still not sure this patch is enough :-( I've noticed that the problem still happens when the web process enters in AC mode before the web view is realized, not that often, but still happens. The thing is that the web process enters in AC mode, and the layer tree host is created, but without a native window handle. Thant means that from the UI process point of view we haven't entered AC mode, because the layer tree context (which is the native window handle) is still 0. When the web view is realized, we create the redirected window, but we don't know id the web process is in AC mode or not, so we always create the window at 1x1, and we send the native window handle. Then the texture mapper is created in the web process and layers are flushed. Layers are composited to context for resizing, but using a 1x1 context size. The next DidUpdateBackingStoreState message received in the UI process contains the layer tree context, and then is when we enter AC mode from the UI process point of view, and we resize the redirected composite window. So, I think the problem is that point where the web process is in AC mode, but the UI isn't. Maybe we could notify the UI process somehow when the layer tree host is created, and if we still don't have a valid layer tree context we know we are waiting for the native window handle. When the web view is realized, if we know that the web process is in AC mode, we can create the redirected window with the right size and we don't need to resize it. The problem I'm seeing when the web process enters AC mode before the web view is realized is not exactly the same than the other case, contents are rendered, but layout is not correct. So, maybe this is a different issue. It's easy to reproduce with epiphany: 1- Go to google, and search for something you know will give a youtube link 2- Middle click the youtube link to open a new tab 3- Visit the tab After 3, sometimes the layout of youtube is like if the web view were a lot smaller (like the mobile layout, using a single column). 1075554 6 cgarcia 2015-03-09 02:45:49 -0700 I'm not sure the problem i actually related to the accelerated compositing mode, I've managed to reproduce the issue disabling AC, it didn't happen that often, but I could still reproduce the problem. So, maybe this is a completely different issue, more related with the layout, and probably related with the delayed resize we do when the web view hasn't been mapped yet. 1075953 7 cgarcia 2015-03-10 06:39:07 -0700 Committed r181324: <http://trac.webkit.org/changeset/181324> 1075954 8 cgarcia 2015-03-10 06:40:12 -0700 Landed the first patch in the end, since the other problem seems to be a different issue, I'll open a new bug report for that. 247956 2015-03-05 09:18:53 -0800 2015-03-08 04:01:34 -0700 Patch wk2-force-resize.diff text/plain 2709 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMTQyNWQxLi4wZDljYTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg QEAKIDIwMTUtMDMtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIENvbnRlbnRzIG5vdCBzaG93biB3aGVuIGVudGVyaW5nIEFDIG1v ZGUgdW5sZXNzIHRoZSB3aW5kb3cgaXMgcmVzaXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgb25jZSBhZ2FpbiB0aGF0IHdl IGFyZSBub3cgY3JlYXRpbmcgdGhlIHJlZGlyZWN0ZWQKKyAgICAgICAgWCB3aW5kb3cgaW4gcmVh bGl6ZSBtZXRob2QuIFdoZW4gZW50ZXJpbmcgQUMgbW9kZSB3ZSByZXNpemUgdGhlCisgICAgICAg IHJlZGlyZWN0ZWQgd2luZG93IHRvIHRoZSBkcmF3aW5nIGFyZWEgc2l6ZS4gU2luY2UgdGhlIHNp emUgaGFzbid0CisgICAgICAgIGNoYW5nZWQgZnJvbSB0aGUgZHJhd2luZyBhcmVhIHBvaW50IG9m IHZpZXcsIHRoZSB3ZWIgcHJvY2VzcyBpcworICAgICAgICBub3Qgbm90aWZpZWQuIFRoZSBXZWJQ cm9jZXNzIGFsd2F5cyB1c2VzIHRoZSB3aW5kb3cgc2l6ZSwgaW5zdGVhZAorICAgICAgICBvZiB0 aGUgcm9vdCBsYXllciBzaXplLCB0byBtYWtlIHN1cmUgaXQncyBpbiBzeW5jLCBzZWUgdGhlIGNv bW1lbnQKKyAgICAgICAgaW4gTGF5ZXJUcmVlSG9zdEd0azo6Y29tcG9zaXRlTGF5ZXJzVG9Db250 ZXh0KCkuIFNvLCB3ZSBuZWVkIHRvCisgICAgICAgIGVuZm9yY2UgYSByZXNpemUgd2hlbiB3ZSBj aGFuZ2UgdGhlIHNpemUgb2YgdGhlIHJlZGlyZWN0ZWQgd2luZG93CisgICAgICAgIHdoZW4gZW50 ZXJpbmcgQUMgbW9kZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXdCYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlRW50ZXJBY2NlbGVyYXRlZENv bXBvc2l0aW5nTW9kZSk6CisgICAgICAgICogVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBs Lmg6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhUHJveHlJbXBsOjpmb3JjZVJlc2l6ZSk6 CisKKzIwMTUtMDMtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCiAgICAgICAgIFJFR1JFU1NJT04ocjE4MDkyNCk6IEFTU0VSVElPTiBGQUlMRUQ6ICFmcm9t LmlzRW1wdHkoKSBpbiBXZWJDb3JlOjpUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6cmVjdFRvUmVjdAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMzQ1CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXdCYXNlLmNwcAppbmRleCBkN2NkYjlhLi4wYzhiYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC0xMzE4 LDcgKzEzMTgsMTAgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUVudGVyQWNjZWxlcmF0ZWRDb21w b3NpdGluZ01vZGUoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFcKICAgICBEcmF3aW5nQXJlYVBy b3h5SW1wbCogZHJhd2luZ0FyZWEgPSBzdGF0aWNfY2FzdDxEcmF3aW5nQXJlYVByb3h5SW1wbCo+ KHByaXYtPnBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKSk7CiAgICAgaWYgKCFkcmF3aW5nQXJlYSkK ICAgICAgICAgcmV0dXJuOworCiAgICAgcHJpdi0+cmVkaXJlY3RlZFdpbmRvdy0+cmVzaXplKGRy YXdpbmdBcmVhLT5zaXplKCkpOworICAgIC8vIEZvcmNlIGEgcmVzaXplIHRvIGVuc3VyZSB0aGUg bmV3IHJlZGlyZWN0ZWQgd2luZG93IHNpemUgaXMgdXNlZCBieSB0aGUgV2ViUHJvY2Vzcy4KKyAg ICBkcmF3aW5nQXJlYS0+Zm9yY2VSZXNpemUoKTsKICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKHdl YmtpdFdlYlZpZXdCYXNlKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv RHJhd2luZ0FyZWFQcm94eUltcGwuaAppbmRleCAzMWU2MjBiLi42YTA1MmIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwuaApAQCAtNTIsNiAr NTIsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXROYXRpdmVTdXJmYWNlSGFuZGxlRm9yQ29tcG9z aXRpbmcodWludDY0X3QpOwogI2VuZGlmCiAKKyAgICB2b2lkIGZvcmNlUmVzaXplKCkgeyBzaXpl RGlkQ2hhbmdlKCk7IH0KKwogcHJpdmF0ZToKICAgICAvLyBEcmF3aW5nQXJlYVByb3h5CiAgICAg dmlydHVhbCB2b2lkIHNpemVEaWRDaGFuZ2UoKTsK 248187 2015-03-08 04:01:34 -0700 2015-03-08 10:44:11 -0700 Updated patch wk2-redirected-window-resize.diff text/plain 3360 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNmIyYTliLi5mZjMyNzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTUtMDMtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIENvbnRlbnRzIG5vdCBzaG93biB3aGVuIGVudGVyaW5nIEFDIG1v ZGUgdW5sZXNzIHRoZSB3aW5kb3cgaXMgcmVzaXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgb25jZSBhZ2FpbiB0aGF0IHdl IGFyZSBub3cgY3JlYXRpbmcgdGhlIHJlZGlyZWN0ZWQKKyAgICAgICAgWCB3aW5kb3cgaW4gcmVh bGl6ZSBtZXRob2QuIFdoZW4gZW50ZXJpbmcgQUMgbW9kZSB3ZSByZXNpemUgdGhlCisgICAgICAg IHJlZGlyZWN0ZWQgd2luZG93IHRvIHRoZSBkcmF3aW5nIGFyZWEgc2l6ZS4gU2luY2UgdGhlIHNp emUgaGFzbid0CisgICAgICAgIGNoYW5nZWQgZnJvbSB0aGUgZHJhd2luZyBhcmVhIHBvaW50IG9m IHZpZXcsIHRoZSB3ZWIgcHJvY2VzcyBpcworICAgICAgICBub3Qgbm90aWZpZWQuIFRoZSBXZWJQ cm9jZXNzIGFsd2F5cyB1c2VzIHRoZSB3aW5kb3cgc2l6ZSwgaW5zdGVhZAorICAgICAgICBvZiB0 aGUgcm9vdCBsYXllciBzaXplLCB0byBtYWtlIHN1cmUgaXQncyBpbiBzeW5jLCBzZWUgdGhlIGNv bW1lbnQKKyAgICAgICAgaW4gTGF5ZXJUcmVlSG9zdEd0azo6Y29tcG9zaXRlTGF5ZXJzVG9Db250 ZXh0KCkuIFNvLCB3ZSBuZWVkIHRvCisgICAgICAgIGVuZm9yY2UgYSByZXNpemUgd2hlbiB3ZSBj aGFuZ2UgdGhlIHNpemUgb2YgdGhlIHJlZGlyZWN0ZWQgd2luZG93CisgICAgICAgIHdoZW4gZW50 ZXJpbmcgQUMgbW9kZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXdCYXNlLmNwcDoKKyAgICAgICAgKHJlc2l6ZVdlYktpdFdlYlZpZXdCYXNlRnJvbUFsbG9jYXRp b24pOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRp bmdNb2RlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwuaDoKKyAg ICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eUltcGw6OmZvcmNlUmVzaXplKToKKwogMjAx NS0wMy0wNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMTgwOTI0KTogQVNTRVJUSU9OIEZBSUxFRDogIWZyb20uaXNFbXB0 eSgpIGluIFdlYkNvcmU6OlRyYW5zZm9ybWF0aW9uTWF0cml4OjpyZWN0VG9SZWN0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAKaW5kZXggZTAxYjczNi4uZTM5YWVkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtNjI3LDggKzYyNywx MSBAQCBzdGF0aWMgdm9pZCByZXNpemVXZWJLaXRXZWJWaWV3QmFzZUZyb21BbGxvY2F0aW9uKFdl YktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZQogICAgIERyYXdpbmdBcmVhUHJveHlJbXBsKiBk cmF3aW5nQXJlYSA9IHN0YXRpY19jYXN0PERyYXdpbmdBcmVhUHJveHlJbXBsKj4ocHJpdi0+cGFn ZVByb3h5LT5kcmF3aW5nQXJlYSgpKTsKIAogI2lmIFVTRShURVhUVVJFX01BUFBFUl9HTCkgJiYg UExBVEZPUk0oWDExKQotICAgIGlmIChzaXplQ2hhbmdlZCAmJiBwcml2LT5yZWRpcmVjdGVkV2lu ZG93ICYmIGRyYXdpbmdBcmVhICYmIGRyYXdpbmdBcmVhLT5pc0luQWNjZWxlcmF0ZWRDb21wb3Np dGluZ01vZGUoKSkKKyAgICBpZiAoc2l6ZUNoYW5nZWQgJiYgcHJpdi0+cmVkaXJlY3RlZFdpbmRv dyAmJiBkcmF3aW5nQXJlYSAmJiBkcmF3aW5nQXJlYS0+aXNJbkFjY2VsZXJhdGVkQ29tcG9zaXRp bmdNb2RlKCkpIHsKICAgICAgICAgcHJpdi0+cmVkaXJlY3RlZFdpbmRvdy0+cmVzaXplKHZpZXdS ZWN0LnNpemUoKSk7CisgICAgICAgIGlmIChwcml2LT5uZWVkc1Jlc2l6ZU9uTWFwKQorICAgICAg ICAgICAgZHJhd2luZ0FyZWEtPmZvcmNlUmVzaXplKCk7CisgICAgfQogI2VuZGlmCiAKICAgICBp ZiAoZHJhd2luZ0FyZWEpCkBAIC0xMzE4LDcgKzEzMjEsMTAgQEAgdm9pZCB3ZWJraXRXZWJWaWV3 QmFzZUVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoV2ViS2l0V2ViVmlld0Jhc2UqIHdl YmtpdFcKICAgICBEcmF3aW5nQXJlYVByb3h5SW1wbCogZHJhd2luZ0FyZWEgPSBzdGF0aWNfY2Fz dDxEcmF3aW5nQXJlYVByb3h5SW1wbCo+KHByaXYtPnBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKSk7 CiAgICAgaWYgKCFkcmF3aW5nQXJlYSkKICAgICAgICAgcmV0dXJuOworCiAgICAgcHJpdi0+cmVk aXJlY3RlZFdpbmRvdy0+cmVzaXplKGRyYXdpbmdBcmVhLT5zaXplKCkpOworICAgIC8vIEZvcmNl IGEgcmVzaXplIHRvIGVuc3VyZSB0aGUgbmV3IHJlZGlyZWN0ZWQgd2luZG93IHNpemUgaXMgdXNl ZCBieSB0aGUgV2ViUHJvY2Vzcy4KKyAgICBkcmF3aW5nQXJlYS0+Zm9yY2VSZXNpemUoKTsKICNl bHNlCiAgICAgVU5VU0VEX1BBUkFNKHdlYmtpdFdlYlZpZXdCYXNlKTsKICNlbmRpZgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmggYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwuaAppbmRleCAzMWU2 MjBiLi42YTA1MmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2lu Z0FyZWFQcm94eUltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0Fy ZWFQcm94eUltcGwuaApAQCAtNTIsNiArNTIsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXROYXRp dmVTdXJmYWNlSGFuZGxlRm9yQ29tcG9zaXRpbmcodWludDY0X3QpOwogI2VuZGlmCiAKKyAgICB2 b2lkIGZvcmNlUmVzaXplKCkgeyBzaXplRGlkQ2hhbmdlKCk7IH0KKwogcHJpdmF0ZToKICAgICAv LyBEcmF3aW5nQXJlYVByb3h5CiAgICAgdmlydHVhbCB2b2lkIHNpemVEaWRDaGFuZ2UoKTsK