142338 2015-03-05 06:10:11 -0800 [cmake] Handle unused parameter warnings as build errors except in WebKit2 2015-03-10 01:34:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142497 1 ossy ossy cgarcia commit-queue gyuyoung.kim ossy oldest_to_newest 1074491 0 ossy 2015-03-05 06:10:11 -0800 To match the actual Mac settings, we should handle unused parameter warnings as build build errors, except in WebKit2. In WebKit2, we should simply suppress them, because Mac port does the same, there is no reason to newly introduced unused parameter warnings in WebKit2 again and again. 1074492 1 247948 ossy 2015-03-05 06:13:23 -0800 Created attachment 247948 Patch 1074495 2 ossy 2015-03-05 06:23:19 -0800 webkit-dev thread: https://lists.webkit.org/pipermail/webkit-dev/2015-March/027269.html 1074496 3 ossy 2015-03-05 06:28:38 -0800 (In reply to comment #0) > To match the actual Mac settings, we should handle unused parameter warnings > as build build errors, except in WebKit2. In WebKit2, we should simply > suppress them, because Mac port does the same, there is no reason to > newly introduced unused parameter warnings in WebKit2 again and again. typo: ... no reason to _fix_ newly ... 1074778 4 247948 gyuyoung.kim 2015-03-05 17:46:17 -0800 Comment on attachment 247948 Patch Nobody replied this mail thread. So let's omit to make sound of unused param warning in WebKit2 as Mac port. 1075702 5 248267 ossy 2015-03-09 12:10:48 -0700 Created attachment 248267 Patch patch for landing, last EWS check to make sure we won't break the build. 1075921 6 248267 commit-queue 2015-03-10 01:33:59 -0700 Comment on attachment 248267 Patch Clearing flags on attachment: 248267 Committed r181318: <http://trac.webkit.org/changeset/181318> 1075922 7 commit-queue 2015-03-10 01:34:02 -0700 All reviewed patches have been landed. Closing bug. 247948 2015-03-05 06:13:23 -0800 2015-03-09 12:10:43 -0700 Patch bug-142338-20150305061303.patch text/plain 2532 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzE4MDkwZmU0YzFkNDcx MjhlYWJjZjUzYzBmMzMzNjdlYjlmNjc2MS4uNWEwNjg3MmM4N2FjYmNkYmZkZDRmMTRiMTc5NzI1 MjRlOTFjMzlkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAzLTA1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2NtYWtlXSBIYW5k bGUgdW51c2VkIHBhcmFtZXRlciB3YXJuaW5ncyBhcyBidWlsZCBlcnJvcnMgZXhjZXB0IGluIFdl YktpdDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MjMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Q01ha2VMaXN0cy50eHQ6CisKIDIwMTUtMDMtMDUgIEx1a2FzeiBCaWFsZWsgIDxsLmJpYWxla0Bz YW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIENyYXNoIHdoZW4gIkRvd25sb2FkIExp bmtlZCBGaWxlIiBmcm9tIE1pbmlCcm93c2VyIGNvbnRleHQgbWVudSBpcyBjbGlja2VkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJLaXQyL0NN YWtlTGlzdHMudHh0CmluZGV4IDc1NjM5OTM2M2QxODE1ZTA5M2Y3YzgyOTJkZjMyMjVhYTU5YmI0 YTUuLmUzZjAzOWMxNWI4MzY0MTc2Nzk1MjRiYWIxN2FkMTU5MDNhZTdjYzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NNYWtl TGlzdHMudHh0CkBAIC03NTcsNiArNzU3LDEwIEBAIG1hY3JvKEFERF9XRUJLSVQyX1BSRUZJWF9I RUFERVIgX3RhcmdldCkKICAgICBlbmRpZiAoKQogZW5kbWFjcm8oKQogCisjIFN1cHByZXNzIHVu dXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MgZm9yIHNvdXJjZXMgaW4gV2ViS2l0Mi4KK3NldChDTUFL RV9DX0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1Xbm8tdW51c2VkLXBhcmFtZXRlciIpCitzZXQo Q01BS0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9GTEFHU30gLVduby11bnVzZWQtcGFyYW1ldGVy IikKKwogV0VCS0lUX0lOQ0xVREVfQ09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCiAKIEdFTkVSQVRF X1dFQktJVDJfTUVTU0FHRV9TT1VSQ0VTKFdlYktpdDJfREVSSVZFRF9TT1VSQ0VTICIke1dlYktp dDJfTUVTU0FHRVNfSU5fRklMRVN9IikKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRI ZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKaW5kZXggNDIw ZWJlMTA4NDgxZGU0MTIwMjM1ODUwMGFhZDgwNzIyY2JjOWEwMC4uMzIwYjk0ZjUxMDdiM2NiZGEy NGU0M2Q5ZThiOWEwNmU2OWMyMTVhMSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdEhl bHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKQEAgLTIy LDcgKzIyLDcgQEAgbWFjcm8oV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdGFyZ2V0 KQogCiAgICAgICAgICMgRW5hYmxlIGVycm9ycyBvbiB3YXJuaW5nCiAgICAgICAgIGlmIChPUFRJ T05fRU5BQkxFX1dFUlJPUikKLSAgICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiLVdl cnJvciAtV25vLWVycm9yPXVudXNlZC1wYXJhbWV0ZXIgJHtPTERfQ09NUElMRV9GTEFHU30iKQor ICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdTICItV2Vycm9yICR7T0xEX0NPTVBJTEVf RkxBR1N9IikKICAgICAgICAgZW5kaWYgKCkKIAogICAgICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRp ZXMoJHtfdGFyZ2V0fSBQUk9QRVJUSUVTCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VM b2cKaW5kZXggYzM2NDgxNGUyYTZjOWMzMTVmM2Q4NWRkN2ZiN2VmYzczZGEzMDRmZi4uN2E4MDdi NDdmZjA2ZjM3MTc1ZTM3MjFlOTVkYWE5MjM5OTU0NjBiYiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9n CisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAzLTA1ICBDc2FiYSBPc3p0 cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2NtYWtlXSBIYW5kbGUgdW51 c2VkIHBhcmFtZXRlciB3YXJuaW5ncyBhcyBidWlsZCBlcnJvcnMgZXhjZXB0IGluIFdlYktpdDIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjMzOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNl L2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2U6CisKIDIwMTUtMDMtMDMgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIENvbnZlcnQgTWFudWFsVGVzdHMvc3ZnLXRv b2x0aXAuc3ZnIHRvIGEgRFJUIHRlc3QK 248267 2015-03-09 12:10:48 -0700 2015-03-10 01:33:59 -0700 Patch bug-142338-20150309121024.patch text/plain 2478 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODNmMWRkMThjMmRiZDhk YzI0NGU1YmUzNzI1ZjM1Y2JkMmYwZWEwYS4uMjUwY2I3NDM0NzgzMDc5YTllNmM3MDBkMzAyZjY2 Yjc3YmU0MGIxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAzLTA5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2NtYWtlXSBIYW5k bGUgdW51c2VkIHBhcmFtZXRlciB3YXJuaW5ncyBhcyBidWlsZCBlcnJvcnMgZXhjZXB0IGluIFdl YktpdDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MjMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IEd5dXlvdW5nIEtpbS4KKworICAgICAgICAqIENN YWtlTGlzdHMudHh0OgorCiAyMDE1LTAzLTA5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBs ZS5jb20+CiAKICAgICAgICAgYm1hbGxvYzogdHJ5RmFzdE1hbGxvYyBzaG91bGRuJ3QgY3Jhc2gK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktp dDIvQ01ha2VMaXN0cy50eHQKaW5kZXggMjNhYzJlMTJiYzJmOTVlYTZlZDZhMDMxYjE0M2Y2MmE3 YWUzYmRmNS4uYjY1YWVlNjYyZjViZGM5ZmIzNmUzZmY3YTRiOTRkYWZlZGE2MDQ1ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIv Q01ha2VMaXN0cy50eHQKQEAgLTc2MCw2ICs3NjAsMTAgQEAgbWFjcm8oQUREX1dFQktJVDJfUFJF RklYX0hFQURFUiBfdGFyZ2V0KQogICAgIGVuZGlmICgpCiBlbmRtYWNybygpCiAKKyMgU3VwcHJl c3MgdW51c2VkIHBhcmFtZXRlciB3YXJuaW5ncyBmb3Igc291cmNlcyBpbiBXZWJLaXQyLgorc2V0 KENNQUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gLVduby11bnVzZWQtcGFyYW1ldGVyIikK K3NldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtV25vLXVudXNlZC1wYXJh bWV0ZXIiKQorCiBXRUJLSVRfSU5DTFVERV9DT05GSUdfRklMRVNfSUZfRVhJU1RTKCkKIAogR0VO RVJBVEVfV0VCS0lUMl9NRVNTQUdFX1NPVVJDRVMoV2ViS2l0Ml9ERVJJVkVEX1NPVVJDRVMgIiR7 V2ViS2l0Ml9NRVNTQUdFU19JTl9GSUxFU30iKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dl YktpdEhlbHBlcnMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQppbmRl eCA0MjBlYmUxMDg0ODFkZTQxMjAyMzU4NTAwYWFkODA3MjJjYmM5YTAwLi4zMjBiOTRmNTEwN2Iz Y2JkYTI0ZTQzZDllOGI5YTA2ZTY5YzIxNWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQpA QCAtMjIsNyArMjIsNyBAQCBtYWNybyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90 YXJnZXQpCiAKICAgICAgICAgIyBFbmFibGUgZXJyb3JzIG9uIHdhcm5pbmcKICAgICAgICAgaWYg KE9QVElPTl9FTkFCTEVfV0VSUk9SKQotICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdT ICItV2Vycm9yIC1Xbm8tZXJyb3I9dW51c2VkLXBhcmFtZXRlciAke09MRF9DT01QSUxFX0ZMQUdT fSIpCisgICAgICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIi1XZXJyb3IgJHtPTERfQ09N UElMRV9GTEFHU30iKQogICAgICAgICBlbmRpZiAoKQogCiAgICAgICAgIHNldF90YXJnZXRfcHJv cGVydGllcygke190YXJnZXR9IFBST1BFUlRJRVMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCBjMzY0ODE0ZTJhNmM5YzMxNWYzZDg1ZGQ3ZmI3ZWZjNzNkYTMwNGZmLi5k N2VmYjA5MTc2ODU1YjA2MDE2NDU3MDJiNDIyMzhiYzg3NDg0MTI3IDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDMtMDkgIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbY21ha2VdIEhhbmRs ZSB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGFzIGJ1aWxkIGVycm9ycyBleGNlcHQgaW4gV2Vi S2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQy MzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcgS2ltLgorCisgICAgICAgICogU291 cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2U6CisKIDIwMTUtMDMtMDMgIERhbmllbCBCYXRl cyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIENvbnZlcnQgTWFudWFsVGVzdHMvc3Zn LXRvb2x0aXAuc3ZnIHRvIGEgRFJUIHRlc3QK