142331 2015-03-05 02:11:32 -0800 [cmake] Fix the web replay build 2015-03-05 09:10:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy burg commit-queue gyuyoung.kim ossy oldest_to_newest 1074445 0 ossy 2015-03-05 02:11:32 -0800 issue 1: --------- /usr/bin/python2.7 /home/webkit/WebKit/Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py --outputDir /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/ --framework WebCore /home/webkit/WebKit/Source/WebCore/replay/WebInputs.json Traceback (most recent call last): File "/home/webkit/WebKit/Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py", line 1048, in <module> raise e # Force the build to fail. __main__.TypecheckException: Unknown type 'double' referenced by member 'fallbackValue' of input 'DocumentLastModifiedDate' After http://trac.webkit.org/changeset/178714 jsc/replay/JSInputs.json is needed in WebCore too. issue 2: --------- ../../Source/WebCore/inspector/InspectorReplayAgent.cpp: In function 'Inspector::Protocol::Replay::SessionState WebCore::buildInspectorObjectForSessionState(WebCore::SessionState)': ../../Source/WebCore/inspector/InspectorReplayAgent.cpp:96:1: error: control reaches end of non-void function [-Werror=return-type] ../../Source/WebCore/inspector/InspectorReplayAgent.cpp: In function 'Inspector::Protocol::Replay::SegmentState WebCore::buildInspectorObjectForSegmentState(WebCore::SegmentState)': ../../Source/WebCore/inspector/InspectorReplayAgent.cpp:106:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors Unfortunately GCC can't handle properly if there is return in all cases of an enum class. We should add unreachable returns as workaround to silence this GCC warning. 1074446 1 247939 ossy 2015-03-05 02:13:45 -0800 Created attachment 247939 Patch 1074448 2 247939 gyuyoung.kim 2015-03-05 02:23:52 -0800 Comment on attachment 247939 Patch I'm not a reviewer for inspector reviewer though, this change seems reasonable. r=me. 1074449 3 gyuyoung.kim 2015-03-05 02:27:12 -0800 (In reply to comment #2) > Comment on attachment 247939 [details] > Patch > > I'm not a reviewer for inspector reviewer though, this change seems > reasonable. r=me. s/inspector reviewer/inspector/g It would be nicer to land this change after passing all ews. 1074452 4 ossy 2015-03-05 02:29:07 -0800 (In reply to comment #3) > It would be nicer to land this change after passing all ews. Sure, I'll wait for EWS and let Brian to comment it. 1074526 5 247939 burg 2015-03-05 08:59:04 -0800 Comment on attachment 247939 Patch Looks good to me. Thanks ossy! 1074533 6 247939 commit-queue 2015-03-05 09:09:57 -0800 Comment on attachment 247939 Patch Clearing flags on attachment: 247939 Committed r181081: <http://trac.webkit.org/changeset/181081> 1074534 7 commit-queue 2015-03-05 09:10:01 -0800 All reviewed patches have been landed. Closing bug. 247939 2015-03-05 02:13:45 -0800 2015-03-05 09:09:57 -0800 Patch bug-142331-20150305021325.patch text/plain 2915 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJjMmUxZDU3ZWM0MWYz YzU3MjNlM2IxZjlmZWJkYzRhZDU0YjYyYi4uYTU4OWNlMGMwYTcxMWM2YTBhNTQ0YzAyMjE4Mzdi ZDlkNTlhMmMxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTA1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2NtYWtlXSBGaXgg dGhlIHdlYiByZXBsYXkgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MjMzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL0luc3Bl Y3RvclJlcGxheUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkSW5zcGVjdG9yT2Jq ZWN0Rm9yU2Vzc2lvblN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkSW5zcGVjdG9yT2Jq ZWN0Rm9yU2VnbWVudFN0YXRlKToKKwogMjAxNS0wMy0wNSAgR3J6ZWdvcnogQ3phamtvd3NraSAg PGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBUZXh0Q2hlY2tpbmdQYXJhZ3Jh cGg6OmlzRW1wdHkoKSBpcyBzdWZmaWNpZW50IHRvIGNoZWNrIHdoZXRoZXIgcGFyYWdyYXBoIGlz IGVtcHR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDZhYjhiOTgwNTdiNjFiYTFmYTQ0MTJmNDEx OTRjYTdhMGE5NWNiNDYuLjk4MTE3Nzc3YWJjNDYyY2VlYzVjNDMxYmMxODU0N2E1Njg4NDVjODUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0zMDg0LDcgKzMwODQsNyBAQCBpZiAoRU5BQkxFX1dF Ql9SRVBMQVkpCiAgICAgICAgICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0vcmVwbGF5IgogICAgICkK IAotICAgIHNldChXZWJDb3JlX1dFQl9SRVBMQVlfSU5QVVRTICR7Q01BS0VfQ1VSUkVOVF9TT1VS Q0VfRElSfS9yZXBsYXkvV2ViSW5wdXRzLmpzb24pCisgICAgc2V0KFdlYkNvcmVfV0VCX1JFUExB WV9JTlBVVFMgJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L3JlcGxheS9XZWJJbnB1dHMuanNv biAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vcmVwbGF5L0pTSW5wdXRzLmpzb24pCiAgICAgYWRkX2N1 c3RvbV9jb21tYW5kKAogICAgICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9E SVJ9L1dlYlJlcGxheUlucHV0cy5oICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9XZWJS ZXBsYXlJbnB1dHMuY3BwCiAgICAgICAgIE1BSU5fREVQRU5ERU5DWSAke0pBVkFTQ1JJUFRDT1JF X0RJUn0vcmVwbGF5L3NjcmlwdHMvQ29kZUdlbmVyYXRvclJlcGxheUlucHV0cy5weQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlcGxheUFnZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXBsYXlBZ2VudC5jcHAKaW5kZXgg MmY2ODc1MzIwNTk2OTc0ODE4ZjYyYTY1ZDE4ZTk3NjNkMzQ0NjdjOC4uNWNhZTYwMTU3Yzc4MDg4 OTRjYWY5YjYyODkzZmJlMGZhZTY0MGEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvclJlcGxheUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yUmVwbGF5QWdlbnQuY3BwCkBAIC05Myw2ICs5Myw5IEBAIHN0YXRpYyBJ bnNwZWN0b3I6OlByb3RvY29sOjpSZXBsYXk6OlNlc3Npb25TdGF0ZSBidWlsZEluc3BlY3Rvck9i amVjdEZvclNlc3Npb25TCiAgICAgY2FzZSBXZWJDb3JlOjpTZXNzaW9uU3RhdGU6OkluYWN0aXZl OiByZXR1cm4gSW5zcGVjdG9yOjpQcm90b2NvbDo6UmVwbGF5OjpTZXNzaW9uU3RhdGU6OkluYWN0 aXZlOwogICAgIGNhc2UgV2ViQ29yZTo6U2Vzc2lvblN0YXRlOjpSZXBsYXlpbmc6IHJldHVybiBJ bnNwZWN0b3I6OlByb3RvY29sOjpSZXBsYXk6OlNlc3Npb25TdGF0ZTo6UmVwbGF5aW5nOwogICAg IH0KKworICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIEluc3Bl Y3Rvcjo6UHJvdG9jb2w6OlJlcGxheTo6U2Vzc2lvblN0YXRlOjpJbmFjdGl2ZTsKIH0KIAogc3Rh dGljIEluc3BlY3Rvcjo6UHJvdG9jb2w6OlJlcGxheTo6U2VnbWVudFN0YXRlIGJ1aWxkSW5zcGVj dG9yT2JqZWN0Rm9yU2VnbWVudFN0YXRlKFdlYkNvcmU6OlNlZ21lbnRTdGF0ZSBzZWdtZW50U3Rh dGUpCkBAIC0xMDMsNiArMTA2LDkgQEAgc3RhdGljIEluc3BlY3Rvcjo6UHJvdG9jb2w6OlJlcGxh eTo6U2VnbWVudFN0YXRlIGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yU2VnbWVudFMKICAgICBjYXNl IFdlYkNvcmU6OlNlZ21lbnRTdGF0ZTo6TG9hZGVkOiByZXR1cm4gSW5zcGVjdG9yOjpQcm90b2Nv bDo6UmVwbGF5OjpTZWdtZW50U3RhdGU6OkxvYWRlZDsKICAgICBjYXNlIFdlYkNvcmU6OlNlZ21l bnRTdGF0ZTo6RGlzcGF0Y2hpbmc6IHJldHVybiBJbnNwZWN0b3I6OlByb3RvY29sOjpSZXBsYXk6 OlNlZ21lbnRTdGF0ZTo6RGlzcGF0Y2hpbmc7CiAgICAgfQorCisgICAgUkVMRUFTRV9BU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gSW5zcGVjdG9yOjpQcm90b2NvbDo6UmVwbGF5OjpT ZWdtZW50U3RhdGU6OlVubG9hZGVkOwogfQogCiBjbGFzcyBTZXJpYWxpemVJbnB1dFRvSlNPTkZ1 bmN0b3Igewo=