142315 2015-03-04 17:31:15 -0800 Web Inspector: REGRESSION (r171645): up/down key navigation of timeline sidebar tree elements is broken when scope bar filters are applied 2015-06-16 17:33:50 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg mattbaker commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1074308 0 burg 2015-03-04 17:31:15 -0800 Steps to reproduce: 1. Populate some timelines data 2. Select the Layout timeline 3. Select a scope bar filter for a record type that is non-contiguous (usually, Styles Invalidated and Styles Recalculated are fine) 4. Click on a record tree element in sidebar 5. Keyboard up/down until it stops working (beeps) From my quick experiments, it appears that the sidebar content tree outline is rendered using the filtered tree elements, but pressing up/down keys tries to navigate to the next/previous unfiltered data grid node. If that node is filtered out, then nothing happens in response to key event (seems to eventually fire [NSResponder:noResponderFor] and beep.) 1074309 1 webkit-bug-importer 2015-03-04 17:31:33 -0800 <rdar://problem/20048730> 1098165 2 mattbaker 2015-05-29 13:31:32 -0700 Caused by http://trac.webkit.org/changeset/171645. Looking over TreeOutline.js, the real problem seems to be with traverseNextTreeElement and traversePreviousTreeElement. The above revision changed the criteria for tree elements being considered revealed, causing the latent bug in element traversal to manifest. 1100824 3 254609 mattbaker 2015-06-09 15:47:31 -0700 Created attachment 254609 [Patch] Proposed Fix 1101275 4 254609 timothy 2015-06-11 07:48:56 -0700 Comment on attachment 254609 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254609&action=review > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039 > + var depthChange = 0; Is this indent right? 1102094 5 mattbaker 2015-06-15 17:25:31 -0700 (In reply to comment #4) > Comment on attachment 254609 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254609&action=review > > > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039 > > + var depthChange = 0; > > Is this indent right? Could you clarify? 1102097 6 254609 timothy 2015-06-15 17:37:00 -0700 Comment on attachment 254609 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254609&action=review >>> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039 >>> + var depthChange = 0; >> >> Is this indent right? > > Could you clarify? The patch on my phone looks like this like is a 4 spaces less than it should be. It could be the rendering or maybe there is a tab? 1102385 7 254609 mattbaker 2015-06-16 16:43:28 -0700 Comment on attachment 254609 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254609&action=review >>>> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1039 >>>> + var depthChange = 0; >>> >>> Is this indent right? >> >> Could you clarify? > > The patch on my phone looks like this like is a 4 spaces less than it should be. It could be the rendering or maybe there is a tab? Weird, it looks that way on my phone too. It looks correct on my laptop, and I confirmed that the indentation is identical to the line below it. 1102413 8 254609 commit-queue 2015-06-16 17:33:46 -0700 Comment on attachment 254609 [Patch] Proposed Fix Clearing flags on attachment: 254609 Committed r185629: <http://trac.webkit.org/changeset/185629> 1102414 9 commit-queue 2015-06-16 17:33:50 -0700 All reviewed patches have been landed. Closing bug. 254609 2015-06-09 15:47:31 -0700 2015-06-16 17:33:46 -0700 [Patch] Proposed Fix bug-142315-20150609154703.patch text/plain 5918 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 NDNjN2VhNjI5MDk0YTY3NjNmNDhhZTgwYzFmM2NkMzg3MjM1Zjc3Li5kYWI1MjVkM2E5Njc2OWE0 M2Q1YjA4ZjE2OTYxNjllY2ExZWJlODU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNS0wNi0wOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjE3MTY0NSk6IHVwL2Rvd24g a2V5IG5hdmlnYXRpb24gb2YgdGltZWxpbmUgc2lkZWJhciB0cmVlIGVsZW1lbnRzIGlzIGJyb2tl biB3aGVuIHNjb3BlIGJhciBmaWx0ZXJzIGFyZSBhcHBsaWVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIzMTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcmVlT3V0bGluZSdzIGVsZW1lbnQgdHJhdmVy c2FsIGFsZ29yaXRobXMgaGF2ZSBiZWVuIHJld3JpdHRlbiB0byBjb3JyZWN0bHkgc2tpcCBvdmVy IHVucmV2ZWFsZWQgdHJlZSBlbGVtZW50cy4KKyAgICAgICAgUHJldmlvdXNseSB0cmF2ZXJzYWwg d291bGQgaGFsdCBhZnRlciBlbmNvdW50ZXJpbmcgYSBoaWRkZW4gZWxlbWVudC4gV2Ugbm93IHVz ZSBhbiBpdGVyYXRpdmUgYXBwcm9hY2gsIHdpdGgKKyAgICAgICAgZWFjaCBpdGVyYXRpb24gcHJv ZHVjaW5nIHRoZSBuZXh0IChvciBwcmV2aW91cykgZWxlbWVudCwgd2l0aCByZXNwZWN0IHRvIHRo ZSBsYXN0IGNhbmRpZGF0ZSBlbGVtZW50LiBJdGVyYXRpb24KKyAgICAgICAgYmVnaW5zIHdpdGgg dGhlIGN1cnJlbnQgbm9kZSwgYW5kIGhhbHRzIG9uY2UgYSB2YWxpZCBlbGVtZW50IGlzIGZvdW5k IG9yIGNhbmRpZGF0ZSBlbGVtZW50cyBhcmUgZXhoYXVzdGVkLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UcmVl RWxlbWVudC5wcm90b3R5cGUudHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQuc2hvdWxkU2tpcCk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuVHJlZUVsZW1lbnQucHJvdG90eXBlLnRyYXZlcnNlTmV4dFRy ZWVFbGVtZW50KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UcmVlRWxlbWVudC5wcm90b3R5cGUu dHJhdmVyc2VQcmV2aW91c1RyZWVFbGVtZW50LnNob3VsZFNraXApOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlRyZWVFbGVtZW50LnByb3RvdHlwZS50cmF2ZXJzZVByZXZpb3VzVHJlZUVsZW1lbnQp OgorCiAyMDE1LTA2LTA4ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBDbGVhcmluZyBhY3RpdmUgVGltZWxpbmUgcmVjb3JkaW5nIHNo b3VsZCBzdG9wIGNhcHR1cmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcwppbmRleCBmM2I2MzQ2YjNhYWFhYzMw ZDE0NDM1MTkyNDI3NDg3ZGQwNjM5MzI5Li4zZTFkMjE5OTE3MTVkYmY1MWZmN2JhYWE4ZmZkNTIz YzMxMWJjYzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UcmVlT3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcwpAQCAtMTAzMiw1OCArMTAzMiw1NCBAQCBXZWJJ bnNwZWN0b3IuVHJlZUVsZW1lbnQgPSBjbGFzcyBUcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3Bl Y3Rvci5PYmplY3QKIAogICAgIHRyYXZlcnNlTmV4dFRyZWVFbGVtZW50KHNraXBVbnJldmVhbGVk LCBzdGF5V2l0aGluLCBkb250UG9wdWxhdGUsIGluZm8pCiAgICAgewotICAgICAgICBpZiAoIWRv bnRQb3B1bGF0ZSAmJiB0aGlzLmhhc0NoaWxkcmVuKQotICAgICAgICAgICAgdGhpcy5vbnBvcHVs YXRlLmNhbGwodGhpcyk7IC8vIEZJWE1FOiBUaGlzIHNob3VsZG4ndCBuZWVkIHRvIHVzZSBjYWxs LCBidXQgdGhpcyBpcyB3b3JraW5nIGFyb3VuZCBhIEpTQyBidWcuIGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzc0ODExCi0KLSAgICAgICAgaWYgKGluZm8pCi0gICAgICAgICAgICBpbmZvLmRlcHRoQ2hh bmdlID0gMDsKLQotICAgICAgICB2YXIgZWxlbWVudCA9IHNraXBVbnJldmVhbGVkID8gKHRoaXMu cmV2ZWFsZWQoKSA/IHRoaXMuY2hpbGRyZW5bMF0gOiBudWxsKSA6IHRoaXMuY2hpbGRyZW5bMF07 Ci0gICAgICAgIGlmIChlbGVtZW50ICYmICghc2tpcFVucmV2ZWFsZWQgfHwgKHNraXBVbnJldmVh bGVkICYmIHRoaXMuZXhwYW5kZWQpKSkgewotICAgICAgICAgICAgaWYgKGluZm8pCi0gICAgICAg ICAgICAgICAgaW5mby5kZXB0aENoYW5nZSA9IDE7Ci0gICAgICAgICAgICByZXR1cm4gZWxlbWVu dDsKKyAgICAgICAgZnVuY3Rpb24gc2hvdWxkU2tpcChlbGVtZW50KSB7CisgICAgICAgICAgICBy ZXR1cm4gc2tpcFVucmV2ZWFsZWQgJiYgIWVsZW1lbnQucmV2ZWFsZWQoKTsKICAgICAgICAgfQog Ci0gICAgICAgIGlmICh0aGlzID09PSBzdGF5V2l0aGluKQotICAgICAgICAgICAgcmV0dXJuIG51 bGw7Ci0KLSAgICAgICAgZWxlbWVudCA9IHNraXBVbnJldmVhbGVkID8gKHRoaXMucmV2ZWFsZWQo KSA/IHRoaXMubmV4dFNpYmxpbmcgOiBudWxsKSA6IHRoaXMubmV4dFNpYmxpbmc7Ci0gICAgICAg IGlmIChlbGVtZW50KQotICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7Ci0KLSAgICAgICAgZWxl bWVudCA9IHRoaXM7Ci0gICAgICAgIHdoaWxlIChlbGVtZW50ICYmICFlbGVtZW50LnJvb3QgJiYg IShza2lwVW5yZXZlYWxlZCA/IChlbGVtZW50LnJldmVhbGVkKCkgPyBlbGVtZW50Lm5leHRTaWJs aW5nIDogbnVsbCkgOiBlbGVtZW50Lm5leHRTaWJsaW5nKSAmJiBlbGVtZW50LnBhcmVudCAhPT0g c3RheVdpdGhpbikgewotICAgICAgICAgICAgaWYgKGluZm8pCi0gICAgICAgICAgICAgICAgaW5m by5kZXB0aENoYW5nZSAtPSAxOwotICAgICAgICAgICAgZWxlbWVudCA9IGVsZW1lbnQucGFyZW50 OwotICAgICAgICB9CisgICAgICAgIHZhciBkZXB0aENoYW5nZSA9IDA7CisgICAgICAgIHZhciBl bGVtZW50ID0gdGhpczsKKyAgICAgICAgZG8geworICAgICAgICAgICAgaWYgKGVsZW1lbnQuaGFz Q2hpbGRyZW4gJiYgZWxlbWVudC5leHBhbmRlZCAmJiAhc2hvdWxkU2tpcChlbGVtZW50KSkgewor ICAgICAgICAgICAgICAgIGlmICghZG9udFBvcHVsYXRlKQorICAgICAgICAgICAgICAgICAgICBl bGVtZW50Lm9ucG9wdWxhdGUoKTsKKyAgICAgICAgICAgICAgICBlbGVtZW50ID0gZWxlbWVudC5j aGlsZHJlblswXTsKKyAgICAgICAgICAgICAgICBkZXB0aENoYW5nZSArPSAxOworICAgICAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICB3aGlsZSAoZWxlbWVudCAmJiAhZWxlbWVudC5u ZXh0U2libGluZyAmJiBlbGVtZW50LnBhcmVudCAmJiAhZWxlbWVudC5wYXJlbnQucm9vdCAmJiBl bGVtZW50LnBhcmVudCAhPT0gc3RheVdpdGhpbikgeworICAgICAgICAgICAgICAgICAgICBlbGVt ZW50ID0gZWxlbWVudC5wYXJlbnQ7CisgICAgICAgICAgICAgICAgICAgIGRlcHRoQ2hhbmdlIC09 IDE7CisgICAgICAgICAgICAgICAgfQogCi0gICAgICAgIGlmICghZWxlbWVudCkKLSAgICAgICAg ICAgIHJldHVybiBudWxsOworICAgICAgICAgICAgICAgIGlmIChlbGVtZW50KQorICAgICAgICAg ICAgICAgICAgICBlbGVtZW50ID0gZWxlbWVudC5uZXh0U2libGluZzsKKyAgICAgICAgICAgIH0K KyAgICAgICAgfSB3aGlsZSAoZWxlbWVudCAmJiBzaG91bGRTa2lwKGVsZW1lbnQpKTsKIAotICAg ICAgICByZXR1cm4gKHNraXBVbnJldmVhbGVkID8gKGVsZW1lbnQucmV2ZWFsZWQoKSA/IGVsZW1l bnQubmV4dFNpYmxpbmcgOiBudWxsKSA6IGVsZW1lbnQubmV4dFNpYmxpbmcpOworICAgICAgICBp ZiAoaW5mbykKKyAgICAgICAgICAgIGluZm8uZGVwdGhDaGFuZ2UgPSBkZXB0aENoYW5nZTsKKyAg ICAgICAgcmV0dXJuIGVsZW1lbnQ7CiAgICAgfQogCiAgICAgdHJhdmVyc2VQcmV2aW91c1RyZWVF bGVtZW50KHNraXBVbnJldmVhbGVkLCBkb250UG9wdWxhdGUpCiAgICAgewotICAgICAgICB2YXIg ZWxlbWVudCA9IHNraXBVbnJldmVhbGVkID8gKHRoaXMucmV2ZWFsZWQoKSA/IHRoaXMucHJldmlv dXNTaWJsaW5nIDogbnVsbCkgOiB0aGlzLnByZXZpb3VzU2libGluZzsKLSAgICAgICAgaWYgKCFk b250UG9wdWxhdGUgJiYgZWxlbWVudCAmJiBlbGVtZW50Lmhhc0NoaWxkcmVuKQotICAgICAgICAg ICAgZWxlbWVudC5vbnBvcHVsYXRlKCk7Ci0KLSAgICAgICAgd2hpbGUgKGVsZW1lbnQgJiYgKHNr aXBVbnJldmVhbGVkID8gKGVsZW1lbnQucmV2ZWFsZWQoKSAmJiBlbGVtZW50LmV4cGFuZGVkID8g ZWxlbWVudC5jaGlsZHJlbltlbGVtZW50LmNoaWxkcmVuLmxlbmd0aCAtIDFdIDogbnVsbCkgOiBl bGVtZW50LmNoaWxkcmVuW2VsZW1lbnQuY2hpbGRyZW4ubGVuZ3RoIC0gMV0pKSB7Ci0gICAgICAg ICAgICBpZiAoIWRvbnRQb3B1bGF0ZSAmJiBlbGVtZW50Lmhhc0NoaWxkcmVuKQotICAgICAgICAg ICAgICAgIGVsZW1lbnQub25wb3B1bGF0ZSgpOwotICAgICAgICAgICAgZWxlbWVudCA9IChza2lw VW5yZXZlYWxlZCA/IChlbGVtZW50LnJldmVhbGVkKCkgJiYgZWxlbWVudC5leHBhbmRlZCA/IGVs ZW1lbnQuY2hpbGRyZW5bZWxlbWVudC5jaGlsZHJlbi5sZW5ndGggLSAxXSA6IG51bGwpIDogZWxl bWVudC5jaGlsZHJlbltlbGVtZW50LmNoaWxkcmVuLmxlbmd0aCAtIDFdKTsKKyAgICAgICAgZnVu Y3Rpb24gc2hvdWxkU2tpcChlbGVtZW50KSB7CisgICAgICAgICAgICByZXR1cm4gc2tpcFVucmV2 ZWFsZWQgJiYgIWVsZW1lbnQucmV2ZWFsZWQoKTsKICAgICAgICAgfQogCi0gICAgICAgIGlmIChl bGVtZW50KQotICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7Ci0KLSAgICAgICAgaWYgKCF0aGlz LnBhcmVudCB8fCB0aGlzLnBhcmVudC5yb290KQotICAgICAgICAgICAgcmV0dXJuIG51bGw7Cisg ICAgICAgIHZhciBlbGVtZW50ID0gdGhpczsKKyAgICAgICAgZG8geworICAgICAgICAgICAgaWYg KGVsZW1lbnQucHJldmlvdXNTaWJsaW5nKSB7CisgICAgICAgICAgICAgICAgZWxlbWVudCA9IGVs ZW1lbnQucHJldmlvdXNTaWJsaW5nOworICAgICAgICAgICAgICAgIHdoaWxlIChlbGVtZW50ICYm IGVsZW1lbnQuaGFzQ2hpbGRyZW4gJiYgZWxlbWVudC5leHBhbmRlZCAmJiAhc2hvdWxkU2tpcChl bGVtZW50KSkgeworICAgICAgICAgICAgICAgICAgICBpZiAoIWRvbnRQb3B1bGF0ZSkKKyAgICAg ICAgICAgICAgICAgICAgICAgIGVsZW1lbnQub25wb3B1bGF0ZSgpOworICAgICAgICAgICAgICAg ICAgICBlbGVtZW50ID0gZWxlbWVudC5jaGlsZHJlbi5sYXN0VmFsdWU7CisgICAgICAgICAgICAg ICAgfQorICAgICAgICAgICAgfSBlbHNlCisgICAgICAgICAgICAgICAgZWxlbWVudCA9IGVsZW1l bnQucGFyZW50ICYmIGVsZW1lbnQucGFyZW50LnJvb3QgPyBudWxsIDogZWxlbWVudC5wYXJlbnQ7 CisgICAgICAgIH0gd2hpbGUgKGVsZW1lbnQgJiYgc2hvdWxkU2tpcChlbGVtZW50KSk7CiAKLSAg ICAgICAgcmV0dXJuIHRoaXMucGFyZW50OworICAgICAgICByZXR1cm4gZWxlbWVudDsKICAgICB9 CiAKICAgICBpc0V2ZW50V2l0aGluRGlzY2xvc3VyZVRyaWFuZ2xlKGV2ZW50KQo=