142294 2015-03-04 10:45:08 -0800 Message UI process when contentSize changes 2015-03-04 13:46:31 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin simon.fraser thorton oldest_to_newest 1074120 0 bdakin 2015-03-04 10:45:08 -0800 We should message the UI process when contentSize changes. This will enable us to account for dynamic heights in our scrolling performance test. rdar://problem/19963165 1074121 1 247869 bdakin 2015-03-04 10:49:11 -0800 Created attachment 247869 Patch 1074126 2 247869 kling 2015-03-04 11:02:36 -0800 Comment on attachment 247869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247869&action=review r=me > Source/WebKit2/UIProcess/PageClient.h:-158 > -#if PLATFORM(EFL) > virtual void didChangeContentSize(const WebCore::IntSize&) = 0; > -#endif Since you're unmasking a pure virtual here, you'll need to update the Gtk+ subclass of PageClient as well. 1074215 3 bdakin 2015-03-04 13:46:31 -0800 (In reply to comment #2) > Comment on attachment 247869 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247869&action=review > > r=me > > > Source/WebKit2/UIProcess/PageClient.h:-158 > > -#if PLATFORM(EFL) > > virtual void didChangeContentSize(const WebCore::IntSize&) = 0; > > -#endif > > Since you're unmasking a pure virtual here, you'll need to update the Gtk+ > subclass of PageClient as well. Thanks Andreas! I fixed this. http://trac.webkit.org/changeset/181023 247869 2015-03-04 10:49:11 -0800 2015-03-04 11:02:36 -0800 Patch for-review-os.txt text/plain 7376 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTAwMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDE1LTAzLTA0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBNZXNzYWdlIFVJIHByb2Nlc3Mgd2hl biBjb250ZW50U2l6ZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDIyOTQKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAg ICByZGFyOi8vcHJvYmxlbS8xOTk2MzE2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggdW4taWZkZWZzIHRoZSBkaWRDaGFuZ2VDb250 ZW50U2l6ZSBtZXNzYWdlIHNvIHRoYXQgd2UgY2FuIHVzZSBpdCBvbiBNYWMgCisgICAgICAgIGFz IHdlbGwuIAorCisgICAgICAgIE5ldyBwcml2YXRlIG1ldGhvZCB0aGF0IHN1YmNsYXNzZXMgY2Fu IG92ZXJyaWRlIHdoZW4gdGhleSBuZWVkIHRvIGRvIHNvbWV0aGluZyAKKyAgICAgICAgd2l0aCBj b250ZW50U2l6ZSBjaGFuZ2VzLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tWaWV3 UHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAg ICAgKC1bV0tWaWV3IF9kaWRDaGFuZ2VDb250ZW50U2l6ZTpdKToKKyAgICAgICAgKiBVSVByb2Nl c3MvUGFnZUNsaWVudC5oOgorCisgICAgICAgIFVuLWlmZGVmLgorICAgICAgICAqIFVJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRpZENo YW5nZUNvbnRlbnRTaXplKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6Cisg ICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbjoKKyAgICAgICAgKiBV SVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLmg6CisgICAgICAgICogVUlQcm9jZXNzL21hYy9Q YWdlQ2xpZW50SW1wbC5tbToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmRpZENo YW5nZUNvbnRlbnRTaXplKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YkNocm9tZUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNocm9tZUNsaWVudDo6Y29u dGVudHNTaXplQ2hhbmdlZCk6CisKIDIwMTUtMDMtMDQgIERlYmFyc2hpIFJheSAgPGRlYmFyc2hp ckBnbm9tZS5vcmc+CiAKICAgICAgICAgW0dUS10gV2ViVmlldyBzaG91bGQgaG9sZCBhIHJlZmVy ZW5jZSBvbiBXZWJDb250ZXh0IGJlY2F1c2Ugbm9uLWRlZmF1bHQgY29udGV4dHMgYXJlIGEgcmVh bGl0eQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCShyZXZpc2lvbiAx ODA5NjUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCSh3b3JraW5n IGNvcHkpCkBAIC0xNTMsOSArMTUzLDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBib29sIGhh bmRsZVJ1bk9wZW5QYW5lbChXZWJQYWdlUHJveHkqLCBXZWJGcmFtZVByb3h5KiwgV2ViT3BlblBh bmVsUGFyYW1ldGVycyosIFdlYk9wZW5QYW5lbFJlc3VsdExpc3RlbmVyUHJveHkqKSB7IHJldHVy biBmYWxzZTsgfQogCi0jaWYgUExBVEZPUk0oRUZMKQogICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFu Z2VDb250ZW50U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJikgPSAwOwotI2VuZGlmCiAKICNp ZiBQTEFURk9STShHVEspICYmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAgICAgdmlydHVhbCB2b2lk IHN0YXJ0RHJhZyhjb25zdCBXZWJDb3JlOjpEcmFnRGF0YSYsIFBhc3NSZWZQdHI8U2hhcmVhYmxl Qml0bWFwPiBkcmFnSW1hZ2UpID0gMDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAxODA5NjUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzY2MCwxMiArMzY2MCwx MCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6aGFuZGxlRG93bmxvYWRSZXF1ZXN0CiAgICAgbV9wYWdl Q2xpZW50LmhhbmRsZURvd25sb2FkUmVxdWVzdChkb3dubG9hZCk7CiB9CiAKLSNpZiBVU0UoQ09P UkRJTkFURURfR1JBUEhJQ1NfTVVMVElQUk9DRVNTKQogdm9pZCBXZWJQYWdlUHJveHk6OmRpZENo YW5nZUNvbnRlbnRTaXplKGNvbnN0IEludFNpemUmIHNpemUpCiB7CiAgICAgbV9wYWdlQ2xpZW50 LmRpZENoYW5nZUNvbnRlbnRTaXplKHNpemUpOwogfQotI2VuZGlmCiAKICNpZiBFTkFCTEUoSU5Q VVRfVFlQRV9DT0xPUikKIHZvaWQgV2ViUGFnZVByb3h5OjpzaG93Q29sb3JQaWNrZXIoY29uc3Qg V2ViQ29yZTo6Q29sb3ImIGluaXRpYWxDb2xvciwgY29uc3QgSW50UmVjdCYgZWxlbWVudFJlY3Qp CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiAx ODA5NjUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJKHdvcmtp bmcgY29weSkKQEAgLTExNDgsOSArMTE0OCwxMCBAQCBwcml2YXRlOgogICAgIHZvaWQgcGFnZURp ZFJlcXVlc3RTY3JvbGwoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmKTsKICAgICB2b2lkIHBhZ2VU cmFuc2l0aW9uVmlld3BvcnRSZWFkeSgpOwogICAgIHZvaWQgZGlkRmluZFpvb21hYmxlQXJlYShj b25zdCBXZWJDb3JlOjpJbnRQb2ludCYsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKTsKLSAgICB2 b2lkIGRpZENoYW5nZUNvbnRlbnRTaXplKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKTsKICNlbmRp ZgogCisgICAgdm9pZCBkaWRDaGFuZ2VDb250ZW50U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXpl Jik7CisKICNpZiBFTkFCTEUoSU5QVVRfVFlQRV9DT0xPUikKICAgICB2b2lkIHNob3dDb2xvclBp Y2tlcihjb25zdCBXZWJDb3JlOjpDb2xvciYgaW5pdGlhbENvbG9yLCBjb25zdCBXZWJDb3JlOjpJ bnRSZWN0Jik7CiAgICAgdmlydHVhbCB2b2lkIGRpZENob29zZUNvbG9yKGNvbnN0IFdlYkNvcmU6 OkNvbG9yJikgb3ZlcnJpZGU7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5Lm1lc3NhZ2VzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4JKHJldmlzaW9uIDE4MDk2NSkKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4JKHdvcmtpbmcgY29weSkK QEAgLTk5LDkgKzk5LDEwIEBAIG1lc3NhZ2VzIC0+IFdlYlBhZ2VQcm94eSB7CiAgICAgUGFnZURp ZFJlcXVlc3RTY3JvbGwoV2ViQ29yZTo6SW50UG9pbnQgcG9pbnQpCiAgICAgUGFnZVRyYW5zaXRp b25WaWV3cG9ydFJlYWR5KCkKICAgICBEaWRGaW5kWm9vbWFibGVBcmVhKFdlYkNvcmU6OkludFBv aW50IHRhcmdldCwgV2ViQ29yZTo6SW50UmVjdCBhcmVhKQotICAgIERpZENoYW5nZUNvbnRlbnRT aXplKFdlYkNvcmU6OkludFNpemUgbmV3U2l6ZSkKICNlbmRpZgogCisgICAgRGlkQ2hhbmdlQ29u dGVudFNpemUoV2ViQ29yZTo6SW50U2l6ZSBuZXdTaXplKQorCiAjaWYgRU5BQkxFKElOUFVUX1RZ UEVfQ09MT1IpCiAgICAgU2hvd0NvbG9yUGlja2VyKFdlYkNvcmU6OkNvbG9yIGluaXRpYWxDb2xv ciwgV2ViQ29yZTo6SW50UmVjdCBlbGVtZW50UmVjdCk7CiAgICAgU2V0Q29sb3JQaWNrZXJDb2xv cihXZWJDb3JlOjpDb2xvciBjb2xvcik7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaAkocmV2aXNpb24gMTgwOTY1KQorKysg U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmgJKHdvcmtp bmcgY29weSkKQEAgLTE0MSw0ICsxNDEsNiBAQAogLSAodm9pZClfZGlzbWlzc0NvbnRlbnRSZWxh dGl2ZUNoaWxkV2luZG93czsKICNlbmRpZgogCistICh2b2lkKV9kaWRDaGFuZ2VDb250ZW50U2l6 ZTooTlNTaXplKW5ld1NpemU7CisKIEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDE4MDk2NSkKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDQwNSw2ICs0 NDA1LDExIEBAIC0gKHZvaWQpX2NvbXBsZXRlSW1tZWRpYXRlQWN0aW9uQW5pbWF0aW8KIHsKIH0K IAorLSAodm9pZClfZGlkQ2hhbmdlQ29udGVudFNpemU6KE5TU2l6ZSluZXdTaXplCit7CisKK30K KwogLSAodm9pZClfZGlzbWlzc0NvbnRlbnRSZWxhdGl2ZUNoaWxkV2luZG93cwogewogICAgIC8v IEZJWE1FOiBXZSBkb24ndCBrbm93IHdoaWNoIHBhbmVsIHdlIGFyZSBkaXNtaXNzaW5nLCBpdCBt YXkgbm90IGV2ZW4gYmUgaW4gdGhlIGN1cnJlbnQgcGFnZSAoc2VlIDxyZGFyOi8vcHJvYmxlbS8x Mzg3NTc2Nj4pLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50 SW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNs aWVudEltcGwuaAkocmV2aXNpb24gMTgwOTY1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9QYWdlQ2xpZW50SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Myw2ICs4Myw3IEBAIHBy aXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGRpZENvbW1pdExvYWRGb3JNYWluRnJhbWUoY29uc3Qg U3RyaW5nJiBtaW1lVHlwZSwgYm9vbCB1c2VDdXN0b21Db250ZW50UHJvdmlkZXIpIG92ZXJyaWRl OwogICAgIHZpcnR1YWwgdm9pZCBkaWRGaW5pc2hMb2FkaW5nRGF0YUZvckN1c3RvbUNvbnRlbnRQ cm92aWRlcihjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZEZpbGVuYW1lLCBjb25zdCBJUEM6OkRhdGFS ZWZlcmVuY2UmKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlRG93bmxvYWRSZXF1 ZXN0KERvd25sb2FkUHJveHkqKSBvdmVycmlkZTsKKyAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdl Q29udGVudFNpemUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYpIG92ZXJyaWRlOwogICAgIHZpcnR1 YWwgdm9pZCBzZXRDdXJzb3IoY29uc3QgV2ViQ29yZTo6Q3Vyc29yJikgb3ZlcnJpZGU7CiAgICAg dmlydHVhbCB2b2lkIHNldEN1cnNvckhpZGRlblVudGlsTW91c2VNb3Zlcyhib29sKSBvdmVycmlk ZTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlVmlld3BvcnRQcm9wZXJ0aWVzKGNvbnN0IFdl YkNvcmU6OlZpZXdwb3J0QXR0cmlidXRlcyYpIG92ZXJyaWRlOwpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbC5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCShyZXZpc2lvbiAxODA5NjUp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0zMjIsNiArMzIyLDExIEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OmhhbmRs ZURvd25sb2FkUmVxdWUKICNlbmRpZgogfQogCit2b2lkIFBhZ2VDbGllbnRJbXBsOjpkaWRDaGFu Z2VDb250ZW50U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBuZXdTaXplKQoreworICAgIFtt X3drVmlldyBfZGlkQ2hhbmdlQ29udGVudFNpemU6bmV3U2l6ZV07Cit9CisKIHZvaWQgUGFnZUNs aWVudEltcGw6OnNldEN1cnNvcihjb25zdCBXZWJDb3JlOjpDdXJzb3ImIGN1cnNvcikKIHsKICAg ICAvLyBGSVhNRTogV291bGQgYmUgbmljZSB0byBzaGFyZSB0aGlzIGNvZGUgd2l0aCBXZWJLaXQx J3MgV2ViQ2hyb21lQ2xpZW50LgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAkocmV2aXNp b24gMTgwOTY1KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJDaHJvbWVDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjMsOSArNTIzLDcgQEAgdm9p ZCBXZWJDaHJvbWVDbGllbnQ6OmNvbnRlbnRzU2l6ZUNoYW5nZQogICAgICAgICBtX3BhZ2UtPmRy YXdpbmdBcmVhKCktPmxheWVyVHJlZUhvc3QoKS0+c2l6ZURpZENoYW5nZShzaXplKTsKICNlbmRp ZgogCi0jaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTX01VTFRJUFJPQ0VTUykKICAgICBtX3Bh Z2UtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGlkQ2hhbmdlQ29udGVudFNpemUoc2l6 ZSkpOwotI2VuZGlmCiAKICAgICBtX3BhZ2UtPmRyYXdpbmdBcmVhKCktPm1haW5GcmFtZUNvbnRl bnRTaXplQ2hhbmdlZChzaXplKTsKIAo=