142278 2015-03-04 08:14:27 -0800 Silence GCC's -Wstrict-prototypes 2015-03-04 17:52:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rishi.is webkit-unassigned commit-queue oldest_to_newest 1074067 0 rishi.is 2015-03-04 08:14:27 -0800 In ANSI C, one must specify the argument types (even if it is void) in a function prototype. Otherwise GCC complains. I have gcc-4.9.2 here. In file included from /usr/include/webkitgtk-4.0/JavaScriptCore/JavaScript.h:31:0, from goawebview.c:27: /usr/include/webkitgtk-4.0/JavaScriptCore/JSContextRef.h:51:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] JS_EXPORT JSContextGroupRef JSContextGroupCreate() CF_AVAILABLE(10_6, 7_0); ^ 1074128 1 247871 rishi.is 2015-03-04 11:06:51 -0800 Created attachment 247871 Patch 1074317 2 247871 commit-queue 2015-03-04 17:52:21 -0800 Comment on attachment 247871 Patch Clearing flags on attachment: 247871 Committed r181059: <http://trac.webkit.org/changeset/181059> 1074318 3 commit-queue 2015-03-04 17:52:23 -0800 All reviewed patches have been landed. Closing bug. 247871 2015-03-04 11:06:51 -0800 2015-03-04 17:52:21 -0800 Patch bug-142278-20150304200630.patch text/plain 1220 rishi.is U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwOTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YWQ3NDYyMmU2MjBhZTA1MTg5YzljMmVlZGU4NmViYjRlYTAwNjY2Li5jYjc3MzhhMzY3OTNkOGZh OWIzZTgzMzA0NjA0ZTBlNzk1Yjk3Zjk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0wMy0wNCAgRGViYXJzaGkgUmF5ICA8ZGViYXJzaGlyQGdub21lLm9y Zz4KKworICAgICAgICBTaWxlbmNlIEdDQydzIC1Xc3RyaWN0LXByb3RvdHlwZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjI3OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQVBJL0pTQ29udGV4dFJl Zi5oOgorCiAyMDE1LTAzLTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgREZHIElSIHNob3VsZCByZWZlciB0byBGdW5jdGlvbkV4ZWN1dGFibGVzIGRpcmVjdGx5 IGFuZCBub3QgdmlhIHRoZSBDb2RlQmxvY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvSlNDb250ZXh0UmVmLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29u dGV4dFJlZi5oCmluZGV4IGNiMjVjMDAwN2Q1Nzg1OGIxMWIzZDgyYmViMzdiYzYwZTliODBkNWYu LjBjODAwYmNlZDRhNmFiOWRjN2RhYmFhZGQzYTZlYmU2YjdmNWYwZjMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0UmVmLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuaApAQCAtNDgsNyArNDgsNyBAQCBleHRlcm4gIkMi IHsKICBzeW5jaHJvbml6YXRpb24gaXMgcmVxdWlyZWQuCiBAcmVzdWx0IFRoZSBjcmVhdGVkIEpT Q29udGV4dEdyb3VwLgogKi8KLUpTX0VYUE9SVCBKU0NvbnRleHRHcm91cFJlZiBKU0NvbnRleHRH cm91cENyZWF0ZSgpIENGX0FWQUlMQUJMRSgxMF82LCA3XzApOworSlNfRVhQT1JUIEpTQ29udGV4 dEdyb3VwUmVmIEpTQ29udGV4dEdyb3VwQ3JlYXRlKHZvaWQpIENGX0FWQUlMQUJMRSgxMF82LCA3 XzApOwogCiAvKiEKIEBmdW5jdGlvbgo=