142264 2015-03-04 00:42:03 -0800 Update time elapsed/remaining displayed for inline media controls on OSX 2015-03-04 13:17:50 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned oldest_to_newest 1074015 0 roger_fong 2015-03-04 00:42:03 -0800 Update the time displays based off of new display spec for mac osx. rdar://problem/19997487 1074016 1 247850 roger_fong 2015-03-04 00:47:11 -0800 Created attachment 247850 patch 1074129 2 247850 dino 2015-03-04 11:12:52 -0800 Comment on attachment 247850 patch FWIW, I was looking at this for iOS and decided I needed four different classes: time < 10 mins (3 digits), time < 60 mins (4 digits), time < 10 hours (5 digits) and then 6 digits for everything else (assuming we'd rarely care about 100 hour videos) 1074179 3 roger_fong 2015-03-04 12:35:03 -0800 Based on the OSX specs it looks like we at minimum display 4 digits, even if the length is < 10 minutes. It does however, look like we display only 5 digits if the time is >= 1 hour, < 10 h, and 6 digits for > 10 hours I'll make another class. 1074194 4 roger_fong 2015-03-04 13:17:50 -0800 Landed with an extra class for ten-hour-long-time: http://trac.webkit.org/changeset/181015 247850 2015-03-04 00:47:11 -0800 2015-03-04 11:12:52 -0800 patch patch.patch text/plain 2978 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDk5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAzLTAzICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIGVsYXBzZWQvcmVt YWluaW5nIHRpbWUgZGlzcGxheXMgb24gbWVkaWEgaW5saW5lIGNvbnRyb2xzIG9uIE9TWC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjI2NC4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE5OTk3NDg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERpdiBzdXJyb3VuZGluZyB0aW1lcyBzZXQgd2lkdGhz IHRoYXQgc251Z2x5IGZpdCB0aGUgdGltZSBkaXNwbGF5LiBBIGxhcmdlciB3aWR0aCBpcyB1c2Vk IGZvciB0aW1lcyB0aGF0IGFyZQorICAgICAgICBhbiBob3VyIG9yIGxvbmdlci4gVGltZSBlbGFw c2VkIGlzIHJpZ2h0IGp1c3RpZmllZC4gVGltZSByZW1haW5pbmcgaXMgbGVmdCBqdXN0aWZpZWQu CisgICAgICAgIFRpbWVzIGFyZSBkaXNwbGF5ZWQgaW4gMTFwdCBIZWx2ZXRpY2EgTmV1ZS4KKyAg ICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmNzczoKKyAg ICAgICAgKGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWUtcmVtYWluaW5nLWRpc3Bs YXkpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1l LWRpc3BsYXkpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1y ZW1haW5pbmctZGlzcGxheS5ob3VyLWxvbmctdGltZSk6CisgICAgICAgIChhdWRpbzo6LXdlYmtp dC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxheS5ob3VyLWxvbmctdGltZSk6CisK IDIwMTUtMDMtMDMgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgU2Nyb2xsIHNuYXAgcG9pbnRzIGFyZSBub3Qgc3VwcG9ydGVkIG9uIHRoZSBtYWluIGZyYW1l CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0FwcGxlLmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29u dHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmNzcwkocmV2aXNpb24gMTgwOTEzKQorKysgU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5jc3MJKHdv cmtpbmcgY29weSkKQEAgLTM4OSwxNSArMzkxLDExIEBAIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNv bnRyb2xzLXRpbWUtcmVtYWkKICAgICAtd2Via2l0LXVzZXItc2VsZWN0OiBub25lOwogICAgIC13 ZWJraXQtZmxleDogMCAwIDA7CiAgICAgZGlzcGxheTogLXdlYmtpdC1mbGV4OwotICAgIC13ZWJr aXQtanVzdGlmeS1jb250ZW50OiBjZW50ZXI7Ci0gICAgLXdlYmtpdC1hbGlnbi1pdGVtczogY2Vu dGVyOwogICAgIGN1cnNvcjogZGVmYXVsdDsKLSAgICBmb250OiAtd2Via2l0LXNtYWxsLWNvbnRy b2w7Ci0gICAgZm9udC1zaXplOiA5cHg7CiAgICAgb3ZlcmZsb3cteTogaGlkZGVuOwogICAgIG92 ZXJmbG93LXg6IGhpZGRlbjsKLSAgICB3aWR0aDogNDVweDsKLSAgICBtaW4td2lkdGg6IDQ1cHg7 CisgICAgZm9udC1mYW1pbHk6ICdIZWx2ZXRpY2EgTmV1ZSc7CisgICAgZm9udC1zaXplOiAxMXB4 OwogICAgIGNvbG9yOiB3aGl0ZTsKICAgICB0ZXh0LXNoYWRvdzogYmxhY2sgMHB4IDFweCAxcHg7 CiAgICAgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsKQEAgLTQxMiwxMiArNDEwLDMwIEBAIHZpZGVv Ojotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWN1cnJlbnQtdGkKIGF1ZGlvOjotd2Via2l0LW1lZGlh LWNvbnRyb2xzLWN1cnJlbnQtdGltZS1kaXNwbGF5IHsKICAgICBtYXJnaW4tbGVmdDogMTZweDsK ICAgICBtYXJnaW4tcmlnaHQ6IDhweDsKKyAgICB3aWR0aDogMjhweDsKKyAgICBtaW4td2lkdGg6 IDI4cHg7CisgICAgLXdlYmtpdC1hbGlnbi1pdGVtczogZmxleC1lbmQ7CisgICAgLXdlYmtpdC1q dXN0aWZ5LWNvbnRlbnQ6IGZsZXgtZW5kOwogfQogCiB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250 cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5LAogYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJv bHMtdGltZS1yZW1haW5pbmctZGlzcGxheSB7CiAgICAgbWFyZ2luLWxlZnQ6IDhweDsKICAgICBt YXJnaW4tcmlnaHQ6IDE2cHg7CisgICAgd2lkdGg6IDMycHg7CisgICAgbWluLXdpZHRoOiAzMnB4 OworICAgIC13ZWJraXQtYWxpZ24taXRlbXM6IGZsZXgtc3RhcnQ7CisgICAgLXdlYmtpdC1qdXN0 aWZ5LWNvbnRlbnQ6IGZsZXgtc3RhcnQ7Cit9CisKK3ZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRy b2xzLXRpbWUtcmVtYWluaW5nLWRpc3BsYXkuaG91ci1sb25nLXRpbWUsCithdWRpbzo6LXdlYmtp dC1tZWRpYS1jb250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5LmhvdXItbG9uZy10aW1lIHsK KyAgICBtaW4td2lkdGg6IDQ4cHg7Cit9CisKK3ZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xz LWN1cnJlbnQtdGltZS1kaXNwbGF5LmhvdXItbG9uZy10aW1lLAorYXVkaW86Oi13ZWJraXQtbWVk aWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXkuaG91ci1sb25nLXRpbWUgeworICAgIG1p bi13aWR0aDogNDRweDsKIH0KIAogdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZWxp bmUtY29udGFpbmVyLAo=