142252 2015-03-03 18:11:23 -0800 Remove WK_AVAILABLE and related macros when we cannot determine iOS/Mac version 2015-03-04 10:49:38 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck andersca ddkilzer joepeck oldest_to_newest 1073910 0 joepeck 2015-03-03 18:11:23 -0800 * SUMMARY Better build fix when PLATFORM_NAME is unknown/missing. In such cases, we cannot determine the iOS/Mac version numbers, so just remove WK_AVAILABLE / WK_DEPRECATED macros that may contain WK_MAC_TBA/WK_IOS_TBA in the postprocess build step so we don't output a broken NS macro. 1073913 1 247823 joepeck 2015-03-03 18:15:06 -0800 Created attachment 247823 [PATCH] Proposed Fix 1074099 2 247823 ddkilzer 2015-03-04 09:43:55 -0800 Comment on attachment 247823 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=247823&action=review r=me > Source/WebKit2/mac/postprocess-framework-headers.sh:50 > + if [[ -n $OSX_VERSION ]] && [[ -n $IOS_VERSION ]]; then Should the variables be double-quoted in case they're not set? if [[ -n "$OSX_VERSION" ]] && [[ -n "$IOS_VERSION" ]]; then 1074122 3 joepeck 2015-03-04 10:49:38 -0800 http://trac.webkit.org/changeset/181004 247823 2015-03-03 18:15:06 -0800 2015-03-04 09:43:55 -0800 [PATCH] Proposed Fix build.patch text/plain 3299 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkZTBkYzkxLi5lMjAzN2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTUtMDMtMDMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBSZW1vdmUgV0tfQVZBSUxBQkxFIGFuZCByZWxhdGVkIG1hY3JvcyB3aGVuIHdlIGNh bm5vdCBkZXRlcm1pbmUgaU9TL01hYyB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIyNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIG1hYyAvIGlvcyB2ZXJzaW9uIHdhcyB1bmFibGUg dG8gYmUgZGV0ZXJtaW5lZCBzdHJpcCB0aGUgV0tfQVZBSUxBQkxFCisgICAgICAgIGFuZCBXS19E RVBSRUNBVEVEIG1hY3JvcyB0byBhdm9pZCBvdXRwdXRpbmcgYSBicm9rZW4gbWFjcm8uCisKKyAg ICAgICAgKiBtYWMvcG9zdHByb2Nlc3MtZnJhbWV3b3JrLWhlYWRlcnMuc2g6CisKKzIwMTUtMDMt MDMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBCdWls ZCBGaXg6IEFkZCBmYWxsIGJhY2sgaGFuZGxpbmcgaW4gcG9zdHByb2Nlc3Mgc2NyaXB0IGZvciBt aXNzaW5nL3Vua25vd24gcGxhdGZvcm0gbmFtZS4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBi eSBEYXZpZCBLaWx6ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9tYWMvcG9zdHByb2Nl c3MtZnJhbWV3b3JrLWhlYWRlcnMuc2ggYi9Tb3VyY2UvV2ViS2l0Mi9tYWMvcG9zdHByb2Nlc3Mt ZnJhbWV3b3JrLWhlYWRlcnMuc2gKaW5kZXggYjQ3MDdiNS4uYTc1ZTBmZSAxMDA3NTUKLS0tIGEv U291cmNlL1dlYktpdDIvbWFjL3Bvc3Rwcm9jZXNzLWZyYW1ld29yay1oZWFkZXJzLnNoCisrKyBi L1NvdXJjZS9XZWJLaXQyL21hYy9wb3N0cHJvY2Vzcy1mcmFtZXdvcmstaGVhZGVycy5zaApAQCAt NDEsMTUgKzQxLDIwIEBAIGZ1bmN0aW9uIHJld3JpdGVfaGVhZGVycyAoKSB7CiAgICAgZWxpZiBb WyAiJHtQTEFURk9STV9OQU1FfSIgPX4gImlwaG9uZSIgXV07IHRoZW4KICAgICAgICAgSU9TX1ZF UlNJT049JHtJUEhPTkVPU19ERVBMT1lNRU5UX1RBUkdFVC9cLi9ffQogICAgICAgICBPU1hfVkVS U0lPTj0iTkEiCi0gICAgZWxzZQotICAgICAgICBJT1NfVkVSU0lPTj0iOV8wIgotICAgICAgICBP U1hfVkVSU0lPTj0iTkEiCiAgICAgZmkKIAogICAgIGZvciBIRUFERVJfUEFUSCBpbiAkMS8qLmg7 IGRvCiAgICAgICAgIGlmIFtbICRIRUFERVJfUEFUSCAtbnQgJFRJTUVTVEFNUF9QQVRIIF1dOyB0 aGVuCi0gICAgICAgICAgICBzZWQgLWUgcy9XS19NQUNfVEJBLyR7T1NYX1ZFUlNJT059LyAtZSBz L1dLX0lPU19UQkEvJHtJT1NfVkVSU0lPTn0vIC1lIHMvXldLX0NMQVNTX0FWQUlMQUJMRS9OU19D TEFTU19BVkFJTEFCTEUvIC1lIHMvV0tfQVZBSUxBQkxFL05TX0FWQUlMQUJMRS8gLWUgcy9XS19E RVBSRUNBVEVEL05TX0RFUFJFQ0FURUQvIC1lIHMvV0tfREVTSUdOQVRFRF9JTklUSUFMSVpFUi9O U19ERVNJR05BVEVEX0lOSVRJQUxJWkVSLyAtZSBzL1dLX0VOVU1fQVZBSUxBQkxFL05TX0VOVU1f QVZBSUxBQkxFLyAtZSBzL1dLX1VOQVZBSUxBQkxFL05TX1VOQVZBSUxBQkxFLyAtZSBzL1dLX0FT U1VNRV9OT05OVUxMX0JFR0lOL05TX0FTU1VNRV9OT05OVUxMX0JFR0lOLyAtZSBzL1dLX0FTU1VN RV9OT05OVUxMX0VORC9OU19BU1NVTUVfTk9OTlVMTF9FTkQvIC1lIHMvV0tfTlVMTEFCTEVfUFJP UEVSVFkvbnVsbGFibGUsLyAtZSBzL1dLX05VTExBQkxFX1NQRUNJRklFUi9fX251bGxhYmxlL2cg LWUgcy9XS19OVUxMQUJMRS9udWxsYWJsZS9nIC1lIHMvV0tfTlVMTF9VTlNQRUNJRklFRC9udWxs X3Vuc3BlY2lmaWVkLyAke0hFQURFUl9QQVRIfSA+ICR7VEFSR0VUX1RFTVBfRElSfS8ke0hFQURF Ul9QQVRIIyMqL30gfHwgZXhpdCAkXzsKLSAgICAgICAgICAgIG12ICR7VEFSR0VUX1RFTVBfRElS fS8ke0hFQURFUl9QQVRIIyMqL30gJEhFQURFUl9QQVRIOworICAgICAgICAgICAgZGl0dG8gJHtI RUFERVJfUEFUSH0gJHtUQVJHRVRfVEVNUF9ESVJ9LyR7SEVBREVSX1BBVEgjIyovfQorCisgICAg ICAgICAgICBpZiBbWyAtbiAkT1NYX1ZFUlNJT04gXV0gJiYgW1sgLW4gJElPU19WRVJTSU9OIF1d OyB0aGVuCisgICAgICAgICAgICAgICAgc2VkIC1pIC50bXAgLWUgcy9XS19NQUNfVEJBLyR7T1NY X1ZFUlNJT059L2cgLWUgcy9XS19JT1NfVEJBLyR7SU9TX1ZFUlNJT059L2cgJHtUQVJHRVRfVEVN UF9ESVJ9LyR7SEVBREVSX1BBVEgjIyovfSB8fCBleGl0ICRfCisgICAgICAgICAgICBlbHNlCisg ICAgICAgICAgICAgICAgc2VkIC1pIC50bXAgLUUgLWUgJ3MvV0tfKENMQVNTX3xFTlVNXyk/QVZB SUxBQkxFKF9JT1N8X01BQyk/XCguK1wpLy9nJyAtZSAncy9XS19ERVBSRUNBVEVEXCguK1wpLy9n JyAke1RBUkdFVF9URU1QX0RJUn0vJHtIRUFERVJfUEFUSCMjKi99IHx8IGV4aXQgJF8KKyAgICAg ICAgICAgIGZpCisKKyAgICAgICAgICAgIHNlZCAtaSAudG1wIC1lIHMvXldLX0NMQVNTX0FWQUlM QUJMRS9OU19DTEFTU19BVkFJTEFCTEUvIC1lIHMvV0tfQVZBSUxBQkxFL05TX0FWQUlMQUJMRS8g LWUgcy9XS19ERVBSRUNBVEVEL05TX0RFUFJFQ0FURUQvIC1lIHMvV0tfREVTSUdOQVRFRF9JTklU SUFMSVpFUi9OU19ERVNJR05BVEVEX0lOSVRJQUxJWkVSLyAtZSBzL1dLX0VOVU1fQVZBSUxBQkxF L05TX0VOVU1fQVZBSUxBQkxFLyAtZSBzL1dLX1VOQVZBSUxBQkxFL05TX1VOQVZBSUxBQkxFLyAt ZSBzL1dLX0FTU1VNRV9OT05OVUxMX0JFR0lOL05TX0FTU1VNRV9OT05OVUxMX0JFR0lOLyAtZSBz L1dLX0FTU1VNRV9OT05OVUxMX0VORC9OU19BU1NVTUVfTk9OTlVMTF9FTkQvIC1lIHMvV0tfTlVM TEFCTEVfUFJPUEVSVFkvbnVsbGFibGUsLyAtZSBzL1dLX05VTExBQkxFX1NQRUNJRklFUi9fX251 bGxhYmxlL2cgLWUgcy9XS19OVUxMQUJMRS9udWxsYWJsZS9nIC1lIHMvV0tfTlVMTF9VTlNQRUNJ RklFRC9udWxsX3Vuc3BlY2lmaWVkLyAke1RBUkdFVF9URU1QX0RJUn0vJHtIRUFERVJfUEFUSCMj Ki99IHx8IGV4aXQgJF8KKyAgICAgICAgICAgIG12ICR7VEFSR0VUX1RFTVBfRElSfS8ke0hFQURF Ul9QQVRIIyMqL30gJEhFQURFUl9QQVRICiAgICAgICAgIGZpCiAgICAgZG9uZQogfQo=