142245 2015-03-03 16:40:20 -0800 [WK2] Fix memory leak in _getCookieHeadersForTask 2015-03-03 18:51:45 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez ap commit-queue eric.carlson kling oldest_to_newest 1073867 0 cdumez 2015-03-03 16:40:20 -0800 Fix memory leak in _getCookieHeadersForTask. We are leaking the CFDictionary returned by webKitCookieStorageCopyRequestHeaderFieldsForURL(). 1073871 1 247813 cdumez 2015-03-03 16:43:55 -0800 Created attachment 247813 Patch 1073927 2 247813 commit-queue 2015-03-03 18:51:40 -0800 Comment on attachment 247813 Patch Clearing flags on attachment: 247813 Committed r180982: <http://trac.webkit.org/changeset/180982> 1073928 3 commit-queue 2015-03-03 18:51:45 -0800 All reviewed patches have been landed. Closing bug. 247813 2015-03-03 16:43:55 -0800 2015-03-03 18:51:40 -0800 Patch bug-142245-20150303164337.patch text/plain 2067 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwOTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDNhNDQzZWU1MDMyYmZi NWJiOTdjZDYzMDBlYjU2ZTVhMTM4ZWNkZC4uMmJlOWRkZDMzYjM3OTNkYmFiOTE4NzkxZmU4NDk4 MDQ5MjU3ZTc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAzLTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gRml4IG1lbW9yeSBs ZWFrIGluIF9nZXRDb29raWVIZWFkZXJzRm9yVGFzaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMjQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IG1lbW9yeSBsZWFrIGluIF9nZXRDb29raWVIZWFk ZXJzRm9yVGFzay4gV2UgYXJlIGxlYWtpbmcgdGhlIENGRGljdGlvbmFyeQorICAgICAgICByZXR1 cm5lZCBieSB3ZWJLaXRDb29raWVTdG9yYWdlQ29weVJlcXVlc3RIZWFkZXJGaWVsZHNGb3JVUkwo KS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHJlc3NlcyB0aGUgaXNzdWUgYnkgc3RvcmluZyB0 aGUgcmV0dXJuIENGRGljdGlvbmFyeSBpbiBhCisgICAgICAgIFJldGFpblB0cjxDRkRpY3Rpb25h cnlSZWY+LgorCisgICAgICAgICogU2hhcmVkL21hYy9Db29raWVTdG9yYWdlU2hpbS5tbToKKyAg ICAgICAgKC1bV0tOU1VSTFNlc3Npb25Mb2NhbCBfZ2V0Q29va2llSGVhZGVyc0ZvclRhc2s6Y29t cGxldGlvbkhhbmRsZXI6XSk6CisKIDIwMTUtMDMtMDMgIEFudHRpIEtvaXZpc3RvICA8YW50dGlA YXBwbGUuY29tPgogCiAgICAgICAgIEluY2x1ZGUga2V5IHRvIE5ldHdvcmtDYWNoZVN0b3JhZ2U6 OkVudHJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0Nvb2tpZVN0b3Jh Z2VTaGltLm1tIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9Db29raWVTdG9yYWdlU2hpbS5t bQppbmRleCAwNzBhODQxNDQyZTdmYWE1ZThjZWI4OGMyNzYxMTBlZWM4NzIxNDhjLi4zYTQ2NTQy ODQ0OTVmNmQ3MzMwODM1NWE4MDk2ZDkzNmM0Yzc4ZjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvbWFjL0Nvb2tpZVN0b3JhZ2VTaGltLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW0KQEAgLTExOSw4ICsxMTksOSBAQCAtICh2 b2lkKV9nZXRDb29raWVIZWFkZXJzRm9yVGFzazooTlNVUkxTZXNzaW9uVGFzayopdGFzayBjb21w bGV0aW9uSGFuZGxlcjooQ29tcAogCiAgICAgUmV0YWluUHRyPE5TVVJMU2Vzc2lvblRhc2s+IHN0 cm9uZ1Rhc2sgPSB0YXNrOwogICAgIENvbXBsZXRpb25IYW5kbGVyQmxvY2sgY29tcGxldGlvbkhh bmRsZXJDb3B5ID0gW2NvbXBsZXRpb25IYW5kbGVyIGNvcHldOwotICAgIFJ1bkxvb3A6Om1haW4o KS5kaXNwYXRjaChbc3Ryb25nVGFzaywgY29tcGxldGlvbkhhbmRsZXJDb3B5XXsKLSAgICAgICAg Y29tcGxldGlvbkhhbmRsZXJDb3B5KFdlYktpdDo6d2ViS2l0Q29va2llU3RvcmFnZUNvcHlSZXF1 ZXN0SGVhZGVyRmllbGRzRm9yVVJMKG51bGxwdHIsIChDRlVSTFJlZilbW3N0cm9uZ1Rhc2sgY3Vy cmVudFJlcXVlc3RdIFVSTF0pKTsKKyAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3N0cm9u Z1Rhc2ssIGNvbXBsZXRpb25IYW5kbGVyQ29weV0geworICAgICAgICBSZXRhaW5QdHI8Q0ZEaWN0 aW9uYXJ5UmVmPiBoZWFkZXJzID0gYWRvcHRDRihXZWJLaXQ6OndlYktpdENvb2tpZVN0b3JhZ2VD b3B5UmVxdWVzdEhlYWRlckZpZWxkc0ZvclVSTChudWxscHRyLCAoQ0ZVUkxSZWYpW1tzdHJvbmdU YXNrIGN1cnJlbnRSZXF1ZXN0XSBVUkxdKSk7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyQ29w eShoZWFkZXJzLmdldCgpKTsKICAgICAgICAgW2NvbXBsZXRpb25IYW5kbGVyQ29weSByZWxlYXNl XTsKICAgICB9KTsKIH0K