142242 2015-03-03 16:22:36 -0800 [Mac] Track localized name follows locale instead of primary language 2015-03-03 19:34:10 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue eric.carlson jer.noble oldest_to_newest 1073855 0 ap 2015-03-03 16:22:36 -0800 We always use AppleLanguages for choosing localized strings (often via CFBundle), except for localized language names in track names. These are localized using the system locale. I think that this is inconsistent and incorrect. This is observable on tests, media/video-controls-captions-trackmenu-localized.html and media/video-controls-captions-trackmenu-sorted.html fail when system locale is non-English. Also, one of these tests actually attempts to test Japanese, and fails, getting English results instead. rdar://problem/20000365 1073857 1 247809 ap 2015-03-03 16:27:12 -0800 Created attachment 247809 proposed fix 1073880 2 247809 eric.carlson 2015-03-03 16:56:35 -0800 Comment on attachment 247809 proposed fix Thank you! 1073934 3 247809 commit-queue 2015-03-03 19:34:06 -0800 Comment on attachment 247809 proposed fix Clearing flags on attachment: 247809 Committed r180984: <http://trac.webkit.org/changeset/180984> 1073935 4 commit-queue 2015-03-03 19:34:10 -0800 All reviewed patches have been landed. Closing bug. 247809 2015-03-03 16:27:12 -0800 2015-03-03 19:34:06 -0800 proposed fix TrackLanguage.txt text/plain 3717 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDk2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAzLTAzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFRyYWNrIGxvY2Fs aXplZCBuYW1lIGZvbGxvd3MgbG9jYWxlIGluc3RlYWQgb2YgcHJpbWFyeSBsYW5ndWFnZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMjQyCisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzIwMDAwMzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0NhcHRpb25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFG LmNwcDogKFdlYkNvcmU6OnRyYWNrRGlzcGxheU5hbWUpOiBVc2UgdGhlCisgICAgICAgIGxhbmd1 YWdlIGZvciBsb2NhbGl6YXRpb24sIGFzIENGQnVuZGxlIGRvZXMuCisKIDIwMTUtMDMtMDMgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBY2Nlc3MgQXBwbGljYXRp b25DYWNoZVN0b3JhZ2UgZ2xvYmFsIGluc3RhbmNlIHZpYSBzaW5nbGV0b24oKSBzdGF0aWMgbWVt YmVyIGZ1bmN0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0NhcHRpb25Vc2VyUHJlZmVy ZW5jZXNNZWRpYUFGLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0NhcHRp b25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFGLmNwcAkocmV2aXNpb24gMTgwODkxKQorKysgU291cmNl L1dlYkNvcmUvcGFnZS9DYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTU5Miw3ICs1OTIsNyBAQCBzdGF0aWMgU3RyaW5nIHRyYWNrRGlzcGxheU5hbWUo VGV4dFRyYWNrCiAgICAgU3RyaW5nIGxhYmVsID0gdHJhY2stPmxhYmVsKCk7CiAgICAgU3RyaW5n IHRyYWNrTGFuZ3VhZ2VJZGVudGlmaWVyID0gdHJhY2stPmxhbmd1YWdlKCk7CiAKLSAgICBSZXRh aW5QdHI8Q0ZMb2NhbGVSZWY+IGN1cnJlbnRMb2NhbGUgPSBhZG9wdENGKENGTG9jYWxlQ29weUN1 cnJlbnQoKSk7CisgICAgUmV0YWluUHRyPENGTG9jYWxlUmVmPiBjdXJyZW50TG9jYWxlID0gYWRv cHRDRihDRkxvY2FsZUNyZWF0ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBkZWZhdWx0TGFuZ3VhZ2Uo KS5jcmVhdGVDRlN0cmluZygpLmdldCgpKSk7CiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBs b2NhbGVJZGVudGlmaWVyID0gYWRvcHRDRihDRkxvY2FsZUNyZWF0ZUNhbm9uaWNhbExvY2FsZUlk ZW50aWZpZXJGcm9tU3RyaW5nKGtDRkFsbG9jYXRvckRlZmF1bHQsIHRyYWNrTGFuZ3VhZ2VJZGVu dGlmaWVyLmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCkpKTsKICAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdS ZWY+IGxhbmd1YWdlQ0YgPSBhZG9wdENGKENGTG9jYWxlQ29weURpc3BsYXlOYW1lRm9yUHJvcGVy dHlWYWx1ZShjdXJyZW50TG9jYWxlLmdldCgpLCBrQ0ZMb2NhbGVMYW5ndWFnZUNvZGUsIGxvY2Fs ZUlkZW50aWZpZXIuZ2V0KCkpKTsKICAgICBTdHJpbmcgbGFuZ3VhZ2UgPSBsYW5ndWFnZUNGLmdl dCgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwOTYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDMtMDMgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gVHJhY2sgbG9jYWxpemVk IG5hbWUgZm9sbG93cyBsb2NhbGUgaW5zdGVhZCBvZiBwcmltYXJ5IGxhbmd1YWdlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIyNDIKKyAgICAgICAg cmRhcjovL3Byb2JsZW0vMjAwMDAzNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9tZWRpYS92aWRlby1jb250cm9scy1jYXB0 aW9ucy10cmFja21lbnUtc29ydGVkLWV4cGVjdGVkLnR4dDogVGhpcworICAgICAgICB0ZXN0IG5v dyBzdWNjZXNzZnVsbHkgc3dpdGNoZXMgdG8gSmFwYW5lc2UsIGFzIG9yaWdpbmFsbHkgaW50ZW5k ZWQuCisKIDIwMTUtMDMtMDMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAg ICAgICAgIENvbnZlcnQgTWFudWFsVGVzdHMvc3ZnLXRvb2x0aXAuc3ZnIHRvIGEgRFJUIHRlc3QK SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9tZWRpYS92aWRlby1jb250cm9scy1jYXB0 aW9ucy10cmFja21lbnUtc29ydGVkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvbWVkaWEvdmlkZW8tY29udHJvbHMtY2FwdGlvbnMtdHJhY2ttZW51 LXNvcnRlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE4MDg5MSkKKysrIExheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9tZWRpYS92aWRlby1jb250cm9scy1jYXB0aW9ucy10cmFja21lbnUtc29ydGVk LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjUsOSArMjUsOSBAQCBSVU4oaW50ZXJu YWxzLnNldHRpbmdzLnNldFNob3VsZERpc3BsYXlUCiBSVU4oaW50ZXJuYWxzLnNldHRpbmdzLnNl dFNob3VsZERpc3BsYXlUcmFja0tpbmQoJ1N1YnRpdGxlcycsIHRydWUpKQogRVhQRUNURUQgKHRy YWNrTWVudUl0ZW1zWzBdLnRleHRDb250ZW50ID09ICdPZmYnKSBPSwogRVhQRUNURUQgKHRyYWNr TWVudUl0ZW1zWzFdLnRleHRDb250ZW50ID09ICdBdXRvIChSZWNvbW1lbmRlZCknKSBPSwotRVhQ RUNURUQgKHRyYWNrTWVudUl0ZW1zWzJdLnRleHRDb250ZW50ID09ICd6IChKYXBhbmVzZSknKSBP SwotRVhQRUNURUQgKHRyYWNrTWVudUl0ZW1zWzNdLnRleHRDb250ZW50ID09ICd2IChFbmdsaXNo KScpIE9LCi1FWFBFQ1RFRCAodHJhY2tNZW51SXRlbXNbNF0udGV4dENvbnRlbnQgPT0gJ3ggKEVu Z2xpc2gtQXVzdHJhbGlhKScpIE9LCitFWFBFQ1RFRCAodHJhY2tNZW51SXRlbXNbMl0udGV4dENv bnRlbnQgPT0gJ3ogKEphcGFuZXNlKScpLCBPQlNFUlZFRCAneiAo5pel5pys6KqeKScgRkFJTAor RVhQRUNURUQgKHRyYWNrTWVudUl0ZW1zWzNdLnRleHRDb250ZW50ID09ICd2IChFbmdsaXNoKScp LCBPQlNFUlZFRCAndiAo6Iux6KqeKScgRkFJTAorRVhQRUNURUQgKHRyYWNrTWVudUl0ZW1zWzRd LnRleHRDb250ZW50ID09ICd4IChFbmdsaXNoLUF1c3RyYWxpYSknKSwgT0JTRVJWRUQgJ3ggKOiL seiqni3jgqrjg7zjgrnjg4jjg6njg6rjgqIpJyBGQUlMCiBFWFBFQ1RFRCAodmlkZW8udGV4dFRy YWNrcy5sZW5ndGggPT0gJzYnKSBPSwogRVhQRUNURUQgKHRyYWNrTWVudUl0ZW1zLmxlbmd0aCA9 PSAnNScpIE9LCiAK