142235 2015-03-03 14:34:41 -0800 bmalloc: Added missing features to the malloc zone introspection API 2015-03-03 14:46:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren commit-queue oldest_to_newest 1073808 0 ggaren 2015-03-03 14:34:41 -0800 bmalloc: Added missing features to the malloc zone introspection API 1073809 1 247795 ggaren 2015-03-03 14:36:24 -0800 Created attachment 247795 Patch 1073811 2 commit-queue 2015-03-03 14:39:27 -0800 Attachment 247795 did not pass style-queue: ERROR: Source/bmalloc/bmalloc/Zone.cpp:42: good_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/bmalloc/bmalloc/Zone.cpp:60: force_lock is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/bmalloc/bmalloc/Zone.cpp:64: force_unlock is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/bmalloc/bmalloc/Zone.cpp:80: type_mask is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/bmalloc/bmalloc/Zone.cpp:80: zone_address is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1073812 3 ggaren 2015-03-03 14:41:37 -0800 > ERROR: Source/bmalloc/bmalloc/Zone.cpp:42: good_size is incorrectly named. > Don't use underscores in your identifier names. > [readability/naming/underscores] [4] > ERROR: Source/bmalloc/bmalloc/Zone.cpp:60: force_lock is incorrectly named. > Don't use underscores in your identifier names. > [readability/naming/underscores] [4] > ERROR: Source/bmalloc/bmalloc/Zone.cpp:64: force_unlock is incorrectly > named. Don't use underscores in your identifier names. > [readability/naming/underscores] [4] > ERROR: Source/bmalloc/bmalloc/Zone.cpp:80: type_mask is incorrectly named. > Don't use underscores in your identifier names. > [readability/naming/underscores] [4] > ERROR: Source/bmalloc/bmalloc/Zone.cpp:80: zone_address is incorrectly > named. Don't use underscores in your identifier names. > [readability/naming/underscores] [4] These are to match the callback API. 1073813 4 247795 kling 2015-03-03 14:42:42 -0800 Comment on attachment 247795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247795&action=review r=me > Source/bmalloc/ChangeLog:26 > + Zone class since the can stand alone. the can stand alone. > Source/bmalloc/bmalloc/Zone.cpp:71 > +static void statistics(malloc_zone_t*, malloc_statistics_t* statistics) > +{ > + memset(statistics, 0, sizeof(malloc_statistics_t)); > +} I guess we can assume that no one would be annoying enough to call this with statistics=nullptr. 1073816 5 ggaren 2015-03-03 14:46:20 -0800 Committed r180958: <http://trac.webkit.org/changeset/180958> 247795 2015-03-03 14:36:24 -0800 2015-03-03 14:42:42 -0800 Patch bug-142235-20150303143606.patch text/plain 5020 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDk1NSkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE1LTAzLTAzICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogQWRkZWQgbWlz c2luZyBmZWF0dXJlcyB0byB0aGUgbWFsbG9jIHpvbmUgaW50cm9zcGVjdGlvbiBBUEkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjIzNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgc2hvdWxkIGZp eCB0aGUgY3Jhc2ggd2Ugc2F3IG9uIHRoZSBpT1MgUExUIGJvdAorICAgICAgICAoYy5mLiBodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xODA2MDQpLgorCisgICAgICAgICogYm1hbGxv Yy9ab25lLmNwcDoKKyAgICAgICAgKGJtYWxsb2M6Omdvb2Rfc2l6ZSk6CisgICAgICAgIChibWFs bG9jOjpjaGVjayk6CisgICAgICAgIChibWFsbG9jOjpwcmludCk6CisgICAgICAgIChibWFsbG9j Ojpsb2cpOgorICAgICAgICAoYm1hbGxvYzo6Zm9yY2VfbG9jayk6CisgICAgICAgIChibWFsbG9j Ojpmb3JjZV91bmxvY2spOgorICAgICAgICAoYm1hbGxvYzo6c3RhdGlzdGljcyk6CisgICAgICAg IChibWFsbG9jOjpzaXplKToKKyAgICAgICAgKGJtYWxsb2M6OmVudW1lcmF0b3IpOiBQcm92aWRl IGFsbCBvZiB0aGVzZSBmdW5jdGlvbnMgc2luY2UgdGhleSBhcmUgY2FsbGVkCisgICAgICAgIGlu ZGlzY3JpbWluYXRlbHkgb24gYWxsIHpvbmVzLgorCisgICAgICAgIChibWFsbG9jOjpab25lOjpa b25lKToKKyAgICAgICAgKGJtYWxsb2M6OlpvbmU6OnNpemUpOiBEZWxldGVkLgorICAgICAgICAo Ym1hbGxvYzo6Wm9uZTo6ZW51bWVyYXRvcik6IERlbGV0ZWQuIE1vdmVkIHRoZXNlIGZ1bmN0aW9u cyBvdXQgb2YgdGhlCisgICAgICAgIFpvbmUgY2xhc3Mgc2luY2UgdGhlIGNhbiBzdGFuZCBhbG9u ZS4KKworICAgICAgICAqIGJtYWxsb2MvWm9uZS5oOgorCiAyMDE1LTAzLTAzICBHZW9mZnJleSBH YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgYm1hbGxvYyBzaG91bGQgaW1wbGVt ZW50IG1hbGxvYyBpbnRyb3NwZWN0aW9uICh0byBzdG9wIGZhbHNlLXBvc2l0aXZlIGxlYWtzIHdo ZW4gTWFsbG9jU3RhY2tMb2dnaW5nIGlzIG9mZikKSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxs b2MvWm9uZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9ab25lLmNw cAkocmV2aXNpb24gMTgwOTU0KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9ab25lLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjgsMTMgKzI4LDYgQEAKIAogbmFtZXNwYWNlIGJtYWxsb2Mgewog Ci0vLyBUaGUgbWVtb3J5IGFuYWx5c2lzIEFQSSByZXF1aXJlcyB0aGUgY29udGVudHMgb2YgdGhp cyBzdHJ1Y3QgdG8gYmUgYSBzdGF0aWMKLS8vIGNvbnN0YW50IGluIHRoZSBwcm9ncmFtIGJpbmFy eS4gVGhlIGxlYWtzIHByb2Nlc3Mgd2lsbCBsb2FkIHRoaXMgc3RydWN0Ci0vLyBvdXQgb2YgdGhl IHByb2dyYW0gYmluYXJ5IChhbmQgbm90IG91dCBvZiB0aGUgcnVubmluZyBwcm9jZXNzKS4KLXN0 YXRpYyBtYWxsb2NfaW50cm9zcGVjdGlvbl90IGludHJvc3BlY3QgPSB7Ci0gICAgLmVudW1lcmF0 b3IgPSBab25lOjplbnVtZXJhdG9yCi19OwotCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdGF0aWMg dm9pZCByZW1vdGVSZWFkKHRhc2tfdCB0YXNrLCBtZW1vcnlfcmVhZGVyX3QgcmVhZGVyLCB2bV9h ZGRyZXNzX3QgcG9pbnRlciwgVCYgcmVzdWx0KQogewogICAgIHZvaWQqIHRtcDsKQEAgLTQyLDE1 ICszNSw0OSBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdGF0aWMgdm9pZCByZW1vdGVSCiAgICAg bWVtY3B5KCZyZXN1bHQsIHRtcCwgc2l6ZW9mKFQpKTsKIH0KIAotLy8gU3VwcG9ydCBtYWxsb2Nf em9uZV9mcm9tX3B0ciwgd2hpY2ggY2FsbHMgc2l6ZSgpIG9uIGVhY2ggcmVnaXN0ZXJlZCB6b25l Lgotc2l6ZV90IFpvbmU6OnNpemUobWFsbG9jX3pvbmVfdCosIGNvbnN0IHZvaWQqKQorLy8gVGhl c2UgZnVuY3Rpb24gcG9pbnRlcnMgYXJlIGludm9rZWQgdW5jb25kaXRpb25hbGx5IG9uIGFsbCB6 b25lcyBieSB2YXJpb3VzCisvLyBzeXN0ZW0gdG9vbHMuIFdlIGRvbid0IHN1cHBvcnQgYW55IG9m IHRoZXNlIGZlYXR1cmVzLCBidXQgd2UgcHJvdmlkZQorLy8ganVzdCBlbm91Z2ggZnVuY3Rpb25h bGl0eSBub3QgdG8gY3Jhc2guCisKK3N0YXRpYyBzaXplX3QgZ29vZF9zaXplKG1hbGxvY196b25l X3QqLCBzaXplX3Qgc2l6ZSkKK3sKKyAgICByZXR1cm4gc2l6ZTsKK30KKworc3RhdGljIGJvb2xl YW5fdCBjaGVjayhtYWxsb2Nfem9uZV90KikKK3sKKyAgICByZXR1cm4gdHJ1ZTsKK30KKworc3Rh dGljIHZvaWQgcHJpbnQobWFsbG9jX3pvbmVfdCosIGJvb2xlYW5fdCkKK3sKK30KKworc3RhdGlj IHZvaWQgbG9nKG1hbGxvY196b25lX3QqLCB2b2lkKikKK3sKK30KKworc3RhdGljIHZvaWQgZm9y Y2VfbG9jayhtYWxsb2Nfem9uZV90KikKK3sKK30KKworc3RhdGljIHZvaWQgZm9yY2VfdW5sb2Nr KG1hbGxvY196b25lX3QqKQoreworfQorCitzdGF0aWMgdm9pZCBzdGF0aXN0aWNzKG1hbGxvY196 b25lX3QqLCBtYWxsb2Nfc3RhdGlzdGljc190KiBzdGF0aXN0aWNzKQoreworICAgIG1lbXNldChz dGF0aXN0aWNzLCAwLCBzaXplb2YobWFsbG9jX3N0YXRpc3RpY3NfdCkpOworfQorCitzdGF0aWMg c2l6ZV90IHNpemUobWFsbG9jX3pvbmVfdCosIGNvbnN0IHZvaWQqKQogewogICAgIC8vIE91ciB6 b25lIGlzIG5vdCBwdWJsaWMgQVBJLCBzbyBubyBwb2ludGVyIGNhbiBiZWxvbmcgdG8gdXMuCiAg ICAgcmV0dXJuIDA7CiB9CiAKIC8vIFRoaXMgZnVuY3Rpb24gcnVucyBpbnNpZGUgdGhlIGxlYWtz IHByb2Nlc3MuCi1rZXJuX3JldHVybl90IFpvbmU6OmVudW1lcmF0b3IodGFza190IHRhc2ssIHZv aWQqIGNvbnRleHQsIHVuc2lnbmVkIHR5cGVfbWFzaywgdm1fYWRkcmVzc190IHpvbmVfYWRkcmVz cywgbWVtb3J5X3JlYWRlcl90IHJlYWRlciwgdm1fcmFuZ2VfcmVjb3JkZXJfdCByZWNvcmRlcikK K3N0YXRpYyBrZXJuX3JldHVybl90IGVudW1lcmF0b3IodGFza190IHRhc2ssIHZvaWQqIGNvbnRl eHQsIHVuc2lnbmVkIHR5cGVfbWFzaywgdm1fYWRkcmVzc190IHpvbmVfYWRkcmVzcywgbWVtb3J5 X3JlYWRlcl90IHJlYWRlciwgdm1fcmFuZ2VfcmVjb3JkZXJfdCByZWNvcmRlcikKIHsKICAgICBa b25lIHJlbW90ZVpvbmU7CiAgICAgcmVtb3RlUmVhZCh0YXNrLCByZWFkZXIsIHpvbmVfYWRkcmVz cywgcmVtb3RlWm9uZSk7CkBAIC02OCw5ICs5NSwyMyBAQCBrZXJuX3JldHVybl90IFpvbmU6OmVu dW1lcmF0b3IodGFza190IHRhCiAgICAgcmV0dXJuIDA7CiB9CiAKKy8vIFRoZSBtZW1vcnkgYW5h bHlzaXMgQVBJIHJlcXVpcmVzIHRoZSBjb250ZW50cyBvZiB0aGlzIHN0cnVjdCB0byBiZSBhIHN0 YXRpYworLy8gY29uc3RhbnQgaW4gdGhlIHByb2dyYW0gYmluYXJ5LiBUaGUgbGVha3MgcHJvY2Vz cyB3aWxsIGxvYWQgdGhpcyBzdHJ1Y3QKKy8vIG91dCBvZiB0aGUgcHJvZ3JhbSBiaW5hcnkgKGFu ZCBub3Qgb3V0IG9mIHRoZSBydW5uaW5nIHByb2Nlc3MpLgorc3RhdGljIG1hbGxvY19pbnRyb3Nw ZWN0aW9uX3QgaW50cm9zcGVjdCA9IHsKKyAgICAuZW51bWVyYXRvciA9IGJtYWxsb2M6OmVudW1l cmF0b3IsCisgICAgLmdvb2Rfc2l6ZSA9IGJtYWxsb2M6Omdvb2Rfc2l6ZSwKKyAgICAuY2hlY2sg PSBibWFsbG9jOjpjaGVjaywKKyAgICAucHJpbnQgPSBibWFsbG9jOjpwcmludCwKKyAgICAubG9n ID0gYm1hbGxvYzo6bG9nLAorICAgIC5mb3JjZV9sb2NrID0gYm1hbGxvYzo6Zm9yY2VfbG9jaywK KyAgICAuZm9yY2VfdW5sb2NrID0gYm1hbGxvYzo6Zm9yY2VfdW5sb2NrLAorICAgIC5zdGF0aXN0 aWNzID0gYm1hbGxvYzo6c3RhdGlzdGljcworfTsKKwogWm9uZTo6Wm9uZSgpCiB7Ci0gICAgbWFs bG9jX3pvbmVfdDo6c2l6ZSA9IHNpemU7CisgICAgbWFsbG9jX3pvbmVfdDo6c2l6ZSA9ICZibWFs bG9jOjpzaXplOwogICAgIG1hbGxvY196b25lX3Q6OnpvbmVfbmFtZSA9ICJXZWJLaXQgTWFsbG9j IjsKICAgICBtYWxsb2Nfem9uZV90OjppbnRyb3NwZWN0ID0gJmJtYWxsb2M6OmludHJvc3BlY3Q7 CiAgICAgbWFsbG9jX3pvbmVfdDo6dmVyc2lvbiA9IDQ7CkluZGV4OiBTb3VyY2UvYm1hbGxvYy9i bWFsbG9jL1pvbmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1pvbmUu aAkocmV2aXNpb24gMTgwOTU0KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9ab25lLmgJKHdv cmtpbmcgY29weSkKQEAgLTM4LDkgKzM4LDYgQEAgcHVibGljOgogICAgIC8vIEVub3VnaCBjYXBh Y2l0eSB0byB0cmFjayBhIDY0R0IgaGVhcCwgc28gcHJvYmFibHkgZW5vdWdoIGZvciBhbnl0aGlu Zy4KICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IGNhcGFjaXR5ID0gMjA0ODsKIAotICAgIHN0YXRp YyBzaXplX3Qgc2l6ZShtYWxsb2Nfem9uZV90KiwgY29uc3Qgdm9pZCopOwotICAgIHN0YXRpYyBr ZXJuX3JldHVybl90IGVudW1lcmF0b3IodGFza190LCB2b2lkKiBjb250ZXh0LCB1bnNpZ25lZCB0 eXBlX21hc2ssIHZtX2FkZHJlc3NfdCwgbWVtb3J5X3JlYWRlcl90LCB2bV9yYW5nZV9yZWNvcmRl cl90KTsKLQogICAgIFpvbmUoKTsKIAogICAgIHZvaWQgYWRkU3VwZXJDaHVuayhTdXBlckNodW5r Kik7Cg==