142226 2015-03-03 10:42:46 -0800 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator' 2015-03-05 20:05:01 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer achristensen ap commit-queue darin dbates ddkilzer glenn jake.nielsen.webkit simon.fraser oldest_to_newest 1073709 0 ddkilzer 2015-03-03 10:42:46 -0800 LayoutTests/platform/wk2/TestExpectations contains expectations for all (or Apple-only?) WebKit2 ports, so they are less-specific than LayoutTests/platform/ios-simulator/TestExpectations, which are shared test expectations for both WK1 and WK2 tests on iOS Simulator. The current order for ios-simulator-wk2 is this: ios-simulator-wk2, wk2, ios-simulator I propose changing it to this: ios-simulator-wk2, ios-simulator, wk2 This has the additional benefit of fixing the expected results for this test because it's marked as [ Failure ] in wk2, but [ Skip ] in ios-simulator: fast/dynamic/window-resize-scrollbars-test.html 1073712 1 247770 ddkilzer 2015-03-03 10:46:45 -0800 Created attachment 247770 Patch v1 1073713 2 ddkilzer 2015-03-03 10:49:34 -0800 (In reply to comment #0) > This has the additional benefit of fixing the expected results for this test > because it's marked as [ Failure ] in wk2, but [ Skip ] in ios-simulator: > > fast/dynamic/window-resize-scrollbars-test.html And I think switching the order of test expectations for ios-simulator-wk2 is better than trying to move the [ Failure ] expectation from platform/wk2/TestExpectations to somewhere else (namely each port-specific TestExpectations file). 1073716 3 ap 2015-03-03 10:52:30 -0800 What is the order on Mac? For expected results, it's "mac-wk2 -> wk2 -> mac-mavericks -> mac -> generic" (on Mavericks), but I'm not quite sure what the order is for TestExpectations. 1073728 4 ddkilzer 2015-03-03 11:30:36 -0800 (In reply to comment #3) > What is the order on Mac? > > For expected results, it's "mac-wk2 -> wk2 -> mac-mavericks -> mac -> > generic" (on Mavericks), but I'm not quite sure what the order is for > TestExpectations. For mac-yosemite-wk2, it is: mac-wk2, wk2, mac Which is basically the same as the "Baseline search path" without "generic" at the end. I assume the TestExpectations files are parsed in the same order as the test results, or nothing would really make sense. :) What am I missing here? Should the [ Failure ] result for fast/dynamic/window-resize-scrollbars-test.html move out of wk2/TestExpectations (and into mac-wk2/TestExpectations?) so the [ Skip ] result in ios-simulator/TestExpectations is recognized? 1074798 5 darin 2015-03-05 19:21:06 -0800 Oops, I didn’t see Alexey’s question. 1074815 6 247770 commit-queue 2015-03-05 20:04:55 -0800 Comment on attachment 247770 Patch v1 Clearing flags on attachment: 247770 Committed r181131: <http://trac.webkit.org/changeset/181131> 1074816 7 commit-queue 2015-03-05 20:05:01 -0800 All reviewed patches have been landed. Closing bug. 247770 2015-03-03 10:46:45 -0800 2015-03-05 20:04:55 -0800 Patch v1 bug-142226-20150303104627.patch text/plain 1592 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwOTI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTg2YmI2MTM4OGEyYTdkMzU0NWFlYjBiZjc5NDZjZDBh ZTFlMzM5Zi4uNzJhMTkyYWFiODIxNWZlMTM5OWM0ZWRjOGY5OGMzNDA0ZjkxNDJjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDE1LTAzLTAzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAg ICAgICAgW2lPU10gVGVzdEV4cGVjdGF0aW9ucyBmb3IgaW9zLXNpbXVsYXRvci13azIgc2hvdWxk IGZhbGwgYmFjayB0byAnd2syJyBhZnRlciAnaW9zLXNpbXVsYXRvcicKKyAgICAgICAgPGh0dHA6 Ly93ZWJraXQub3JnL2IvMTQyMjI2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToKKyAgICAgICAg KElPU1NpbXVsYXRvclBvcnQuZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0aCk6IFN3aXRjaCB0 aGUKKyAgICAgICAgVGVzdEV4cGVjdGF0aW9ucyBvcmRlciBvZiBpb3Mtc2ltdWxhdG9yLXdrMiBm cm9tIHRoaXM6CisgICAgICAgICAgaW9zLXNpbXVsYXRvci13azIsIHdrMiwgaW9zLXNpbXVsYXRv cgorICAgICAgICBUbyB0aGlzOgorICAgICAgICAgIGlvcy1zaW11bGF0b3Itd2syLCBpb3Mtc2lt dWFsdG9yLCB3azIKKworMjAxNS0wMy0wMyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUu Y29tPgorCiAgICAgICAgIGBidWlsZC13ZWJraXQgLS1oZWxwYCBpcyB3cm9uZyBhYm91dCBob3cg dG8gYnVpbGQgZm9yIHRoZSBpT1Mgc2ltdWxhdG9yCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9y Zy9iLzE0MjIyMz4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lv cy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKaW5kZXggNzVjMGJlOTRj NTU1NTE1OTFkNjkyZTAyOTI3NzFjNmNjZmI4YTYwNS4uZGEyMWMzYmNhYzdlMDUwYTJlNWRiMmZm NWNlN2VhMDE0ZDcyYmQ0MyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2lvcy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CkBAIC0xOTMs NyArMTkzLDcgQEAgY2xhc3MgSU9TU2ltdWxhdG9yUG9ydChQb3J0KToKIAogICAgIGRlZiBkZWZh dWx0X2Jhc2VsaW5lX3NlYXJjaF9wYXRoKHNlbGYpOgogICAgICAgICBpZiBzZWxmLmdldF9vcHRp b24oJ3dlYmtpdF90ZXN0X3J1bm5lcicpOgotICAgICAgICAgICAgZmFsbGJhY2tfbmFtZXMgPSBb c2VsZi5fd2syX3BvcnRfbmFtZSgpLCAnd2syJ10gKyBbc2VsZi5wb3J0X25hbWVdCisgICAgICAg ICAgICBmYWxsYmFja19uYW1lcyA9IFtzZWxmLl93azJfcG9ydF9uYW1lKCldICsgW3NlbGYucG9y dF9uYW1lXSArIFsnd2syJ10KICAgICAgICAgZWxzZToKICAgICAgICAgICAgIGZhbGxiYWNrX25h bWVzID0gW3NlbGYucG9ydF9uYW1lICsgJy13azEnXSArIFtzZWxmLnBvcnRfbmFtZV0KIAo=