142219 2015-03-03 09:30:36 -0800 [buildbot] mastercfg_unittest.py should be runnable easily 2015-03-05 11:33:35 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy ap cdumez commit-queue glenn lforschler mmirman ossy rniwa oldest_to_newest 1073681 0 ossy 2015-03-03 09:30:36 -0800 Now mastercfg_unittest.py isn't runnable out-of-the-box, because newer twisted moved NoResource from twisted.web.error to twisted.web.resource . The short term fix is to autoinstall the twisted version used by build.webkit.org buildmaster - Twisted 12.1.0 . I'm on it, patch is coming soon. 1074416 1 247935 ossy 2015-03-04 23:54:17 -0800 Created attachment 247935 Patch With this fix mastercfg_unittest.py works out-of-the-box on Linux and Mac too. The next step will be to run it automatically on the bots. 1074424 2 ap 2015-03-05 00:32:09 -0800 For the ignorant among us, how does one run a python unit test "out of the box"? Is there a specific command? The only thing I know how to use is test-webkitpy, and then (barely) buildbot's checkconfig. 1074425 3 ossy 2015-03-05 00:37:08 -0800 (In reply to comment #2) > For the ignorant among us, how does one run a python unit test "out of the > box"? Is there a specific command? > > The only thing I know how to use is test-webkitpy, and then (barely) > buildbot's checkconfig. cd Tools/BuildSlaveSupport/build.webkit.org-config ./mastercfg_unittest.py Unfortunately test-webkitpy can't run unit tests in build.webkit.org-config for some reason, for example "." and "-" characters in the directory name. I tried to rename the directory and add it to test-webkitpy, but it isn't enough, there are more issues should be fixed. 1074428 4 ossy 2015-03-05 00:41:11 -0800 One more thing: You can't run each unittest in webkitpy by hand, because they don't have this code at the end and don't have execute bit: if __name__ == '__main__': unittest.main() test-webkitpy collects/executes unit tests parallel in a different way. 1074574 5 cdumez 2015-03-05 10:39:05 -0800 I tested this patch and was able to run mastercfg_unittest.py on Mac. 1074577 6 247935 cdumez 2015-03-05 10:46:46 -0800 Comment on attachment 247935 Patch r=me. 1074598 7 247935 commit-queue 2015-03-05 11:33:30 -0800 Comment on attachment 247935 Patch Clearing flags on attachment: 247935 Committed r181088: <http://trac.webkit.org/changeset/181088> 1074599 8 commit-queue 2015-03-05 11:33:35 -0800 All reviewed patches have been landed. Closing bug. 247935 2015-03-04 23:54:17 -0800 2015-03-05 11:33:30 -0800 Patch bug-142219-20150304235357.patch text/plain 7201 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMDY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGI5ZjEyYzliNTYxNmU4ZGY2YTI3MmY4NDFiZjRhMWRj MTE4ZTBiNC4uYjViMjZjM2MwNWJkOTMyNTM0Y2RjYWJlZmE0MGNjOGYyMjI4YzhhMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE1LTAzLTA0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW2J1aWxkYm90XSBtYXN0ZXJjZmdfdW5pdHRlc3QucHkgc2hvdWxkIGJlIHJ1bm5h YmxlIGVhc2lseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQyMjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQnVpbGRib3QgMC44LjZwMSBydW5zIG9uIGJ1aWxkLndlYmtpdCBvcmcgd2l0aCBUd2lzdGVk IDEyLjEuMCwgd2hpY2ggaXMKKyAgICAgICAgdGhlIGxhc3QgVHdpc3RlZCB2ZXJzaW9uIHdvcmtz IHRvZ2V0aGVyIHdpdGggdGhpcyBidWlsZGJvdCB2ZXJzaW9uLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2F1dG9pbnN0YWxsLnB5OgorICAgICAgICAoQXV0b0lu c3RhbGxlcik6IEFkZGVkIHByZXBlbmRfdG9fc2VhcmNoX3BhdGggYXJndW1lbnQgdG8gYmUgYWJs ZQorICAgICAgICB0byBwcmVmZXIgYXV0b2luc3RhbGxlZCBwYWNrYWdlIHRvIHN5c3RlbSBwYWNr YWdlLgorICAgICAgICAoQXV0b0luc3RhbGxlci5fX2luaXRfXyk6CisgICAgICAgIChBdXRvSW5z dGFsbGVyLl9zZXRfdXBfdGFyZ2V0X2Rpcik6CisgICAgICAgIChBdXRvSW5zdGFsbGVyLl9leHRy YWN0X3Rhcik6IFJlbmFtZWQgZnJvbSBfZXh0cmFjdF90YXJneiwgbm93IGl0IHdvcmtzIHdpdGgg dGFyLmJ6MiB0b28uCisgICAgICAgIChBdXRvSW5zdGFsbGVyLl9wcmVwYXJlX3BhY2thZ2UpOgor ICAgICAgICAoQXV0b0luc3RhbGxlci5fZXh0cmFjdF90YXJneik6IFJlbmFtZWQgdG8gX2V4dHJh Y3RfdGFyLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5w eToKKyAgICAgICAgKEF1dG9pbnN0YWxsSW1wb3J0SG9vay5faW5zdGFsbF9idWlsZGJvdCk6IEF1 dG9pbnN0YWxsIFR3aXN0ZWQgMTIuMS4wLgorCiAyMDE1LTAzLTA0ICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTgxMDU0LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL2F1dG9pbnN0YWxsLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L2F1dG9pbnN0YWxsLnB5CmluZGV4IGUxMjdkZDRjYjA3MmI4MjFjZTY2MDkwNzEwNzU3NTdjNTFm MDM3ZTguLjEzZWJhMmVhMzlhYzc5MjRmOWMyYWE2YWFkZDljYjU0MGM4NmUzZWQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkK QEAgLTU3LDcgKzU3LDcgQEAgY2xhc3MgQXV0b0luc3RhbGxlcihvYmplY3QpOgogCiAgICAgIiIi U3VwcG9ydHMgYXV0b21hdGljYWxseSBpbnN0YWxsaW5nIFB5dGhvbiBwYWNrYWdlcyBmcm9tIGFu IFVSTC4KIAotICAgIFN1cHBvcnRzIHVuY29tcHJlc3NlZCBmaWxlcywgLnRhci5neiwgYW5kIC56 aXAgZm9ybWF0cy4KKyAgICBTdXBwb3J0cyB1bmNvbXByZXNzZWQgZmlsZXMsIC50YXIuZ3osIC50 YXIuYnoyIGFuZCAuemlwIGZvcm1hdHMuCiAKICAgICBCYXNpYyB1c2FnZToKIApAQCAtNzAsMTMg KzcwLDE1IEBAIGNsYXNzIEF1dG9JbnN0YWxsZXIob2JqZWN0KToKIAogICAgICIiIgogCi0gICAg ZGVmIF9faW5pdF9fKHNlbGYsIGFwcGVuZF90b19zZWFyY2hfcGF0aD1GYWxzZSwgbWFrZV9wYWNr YWdlPVRydWUsCisgICAgZGVmIF9faW5pdF9fKHNlbGYsIGFwcGVuZF90b19zZWFyY2hfcGF0aD1G YWxzZSwgcHJlcGVuZF90b19zZWFyY2hfcGF0aD1GYWxzZSwgbWFrZV9wYWNrYWdlPVRydWUsCiAg ICAgICAgICAgICAgICAgIHRhcmdldF9kaXI9Tm9uZSwgdGVtcF9kaXI9Tm9uZSk6CiAgICAgICAg ICIiIkNyZWF0ZSBhbiBBdXRvSW5zdGFsbGVyIGluc3RhbmNlLCBhbmQgc2V0IHVwIHRoZSB0YXJn ZXQgZGlyZWN0b3J5LgogCiAgICAgICAgIEFyZ3M6CiAgICAgICAgICAgYXBwZW5kX3RvX3NlYXJj aF9wYXRoOiBBIGJvb2xlYW4gdmFsdWUgb2Ygd2hldGhlciB0byBhcHBlbmQgdGhlCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB0YXJnZXQgZGlyZWN0b3J5IHRvIHRoZSBzeXMucGF0 aCBzZWFyY2ggcGF0aC4KKyAgICAgICAgICBwcmVwZW5kX3RvX3NlYXJjaF9wYXRoOiBBIGJvb2xl YW4gdmFsdWUgb2Ygd2hldGhlciB0byBwcmVwZW5kIHRoZQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdGFyZ2V0IGRpcmVjdG9yeSB0byB0aGUgc3lzLnBhdGggc2VhcmNoIHBhdGgu CiAgICAgICAgICAgbWFrZV9wYWNrYWdlOiBBIGJvb2xlYW4gdmFsdWUgb2Ygd2hldGhlciB0byBt YWtlIHRoZSB0YXJnZXQKICAgICAgICAgICAgICAgICAgICAgICAgIGRpcmVjdG9yeSBhIHBhY2th Z2UuICBUaGlzIGFkZHMgYW4gX19pbml0X18ucHkgZmlsZQogICAgICAgICAgICAgICAgICAgICAg ICAgdG8gdGhlIHRhcmdldCBkaXJlY3RvcnkgLS0gYWxsb3dpbmcgcGFja2FnZXMgYW5kCkBAIC05 OCw3ICsxMDAsNyBAQCBjbGFzcyBBdXRvSW5zdGFsbGVyKG9iamVjdCk6CiAgICAgICAgICAgICB0 YXJnZXRfZGlyID0gb3MucGF0aC5qb2luKHRoaXNfZGlyLCAiYXV0b2luc3RhbGxlZCIpCiAKICAg ICAgICAgIyBFbnN1cmUgdGhhdCB0aGUgdGFyZ2V0IGRpcmVjdG9yeSBleGlzdHMuCi0gICAgICAg IHNlbGYuX3NldF91cF90YXJnZXRfZGlyKHRhcmdldF9kaXIsIGFwcGVuZF90b19zZWFyY2hfcGF0 aCwgbWFrZV9wYWNrYWdlKQorICAgICAgICBzZWxmLl9zZXRfdXBfdGFyZ2V0X2Rpcih0YXJnZXRf ZGlyLCBhcHBlbmRfdG9fc2VhcmNoX3BhdGgsIHByZXBlbmRfdG9fc2VhcmNoX3BhdGgsIG1ha2Vf cGFja2FnZSkKIAogICAgICAgICBzZWxmLl90YXJnZXRfZGlyID0gdGFyZ2V0X2RpcgogICAgICAg ICBzZWxmLl90ZW1wX2RpciA9IHRlbXBfZGlyCkBAIC0xMDcsMTQgKzEwOSwxNSBAQCBjbGFzcyBB dXRvSW5zdGFsbGVyKG9iamVjdCk6CiAgICAgICAgIHdpdGggY29kZWNzLm9wZW4ocGF0aCwgInci LCBlbmNvZGluZykgYXMgZmlsZWhhbmRsZToKICAgICAgICAgICAgIGZpbGVoYW5kbGUud3JpdGUo dGV4dCkKIAotICAgIGRlZiBfc2V0X3VwX3RhcmdldF9kaXIoc2VsZiwgdGFyZ2V0X2RpciwgYXBw ZW5kX3RvX3NlYXJjaF9wYXRoLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFrZV9wYWNr YWdlKToKKyAgICBkZWYgX3NldF91cF90YXJnZXRfZGlyKHNlbGYsIHRhcmdldF9kaXIsIGFwcGVu ZF90b19zZWFyY2hfcGF0aCwgcHJlcGVuZF90b19zZWFyY2hfcGF0aCwgbWFrZV9wYWNrYWdlKToK ICAgICAgICAgIiIiU2V0IHVwIGEgdGFyZ2V0IGRpcmVjdG9yeS4KIAogICAgICAgICBBcmdzOgog ICAgICAgICAgIHRhcmdldF9kaXI6IFRoZSBwYXRoIHRvIHRoZSB0YXJnZXQgZGlyZWN0b3J5IHRv IHNldCB1cC4KICAgICAgICAgICBhcHBlbmRfdG9fc2VhcmNoX3BhdGg6IEEgYm9vbGVhbiB2YWx1 ZSBvZiB3aGV0aGVyIHRvIGFwcGVuZCB0aGUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHRhcmdldCBkaXJlY3RvcnkgdG8gdGhlIHN5cy5wYXRoIHNlYXJjaCBwYXRoLgorICAgICAg ICAgIHByZXBlbmRfdG9fc2VhcmNoX3BhdGg6IEEgYm9vbGVhbiB2YWx1ZSBvZiB3aGV0aGVyIHRv IHByZXBlbmQgdGhlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0YXJnZXQgZGly ZWN0b3J5IHRvIHRoZSBzeXMucGF0aCBzZWFyY2ggcGF0aC4KICAgICAgICAgICBtYWtlX3BhY2th Z2U6IEEgYm9vbGVhbiB2YWx1ZSBvZiB3aGV0aGVyIHRvIG1ha2UgdGhlIHRhcmdldAogICAgICAg ICAgICAgICAgICAgICAgICAgZGlyZWN0b3J5IGEgcGFja2FnZS4gIFRoaXMgYWRkcyBhbiBfX2lu aXRfXy5weSBmaWxlCiAgICAgICAgICAgICAgICAgICAgICAgICB0byB0aGUgdGFyZ2V0IGRpcmVj dG9yeSAtLSBhbGxvd2luZyBwYWNrYWdlcyBhbmQKQEAgLTEyOCw2ICsxMzEsOSBAQCBjbGFzcyBB dXRvSW5zdGFsbGVyKG9iamVjdCk6CiAgICAgICAgIGlmIGFwcGVuZF90b19zZWFyY2hfcGF0aDoK ICAgICAgICAgICAgIHN5cy5wYXRoLmFwcGVuZCh0YXJnZXRfZGlyKQogCisgICAgICAgIGlmIHBy ZXBlbmRfdG9fc2VhcmNoX3BhdGg6CisgICAgICAgICAgICBzeXMucGF0aC5pbnNlcnQoMCwgdGFy Z2V0X2RpcikKKwogICAgICAgICBpZiBtYWtlX3BhY2thZ2U6CiAgICAgICAgICAgICBzZWxmLl9t YWtlX3BhY2thZ2UodGFyZ2V0X2RpcikKIApAQCAtMTk2LDkgKzIwMiwxNyBAQCBjbGFzcyBBdXRv SW5zdGFsbGVyKG9iamVjdCk6CiAgICAgICAgIHZlcnNpb25fcGF0aCA9IHNlbGYuX3VybF9kb3du bG9hZGVkX3BhdGgodGFyZ2V0X25hbWUpCiAgICAgICAgIHNlbGYuX3dyaXRlX2ZpbGUodmVyc2lv bl9wYXRoLCB1cmwsICJ1dGYtOCIpCiAKLSAgICBkZWYgX2V4dHJhY3RfdGFyZ3ooc2VsZiwgcGF0 aCwgc2NyYXRjaF9kaXIpOgotICAgICAgICAjIHRhcmZpbGUuZXh0cmFjdGFsbCgpIGV4dHJhY3Rz IHRvIGEgcGF0aCB3aXRob3V0IHRoZSB0cmFpbGluZyAiLnRhci5neiIuCi0gICAgICAgIHRhcmdl dF9iYXNlbmFtZSA9IG9zLnBhdGguYmFzZW5hbWUocGF0aFs6LWxlbigiLnRhci5neiIpXSkKKyAg ICBkZWYgX2V4dHJhY3RfdGFyKHNlbGYsIHBhdGgsIHNjcmF0Y2hfZGlyKToKKyAgICAgICAgIyB0 YXJmaWxlLmV4dHJhY3RhbGwoKSBleHRyYWN0cyB0byBhIHBhdGggd2l0aG91dCB0aGUgdHJhaWxp bmcgIi50YXIuZ3oiIG9yICIudGFyLmJ6MiIuCisKKyAgICAgICAgaWYgcGF0aC5lbmRzd2l0aCgi LnRhci5neiIpOgorICAgICAgICAgICAgdGFyRmlsZVN1ZmZpeCA9ICIudGFyLmd6IgorICAgICAg ICBlbGlmIHBhdGguZW5kc3dpdGgoIi50YXIuYnoyIik6CisgICAgICAgICAgICB0YXJGaWxlU3Vm Zml4ID0gIi50YXIuYnoyIgorICAgICAgICBlbHNlOgorICAgICAgICAgICAgcmFpc2UgRXhjZXB0 aW9uKCIuLi4iKQorCisgICAgICAgIHRhcmdldF9iYXNlbmFtZSA9IG9zLnBhdGguYmFzZW5hbWUo cGF0aFs6LWxlbih0YXJGaWxlU3VmZml4KV0pCiAgICAgICAgIHRhcmdldF9wYXRoID0gb3MucGF0 aC5qb2luKHNjcmF0Y2hfZGlyLCB0YXJnZXRfYmFzZW5hbWUpCiAKICAgICAgICAgdHJ5OgpAQCAt MjkwLDggKzMwNCw4IEBAIGNsYXNzIEF1dG9JbnN0YWxsZXIob2JqZWN0KToKICAgICAgICAgIyBG SVhNRTogQWRkIG90aGVyIG5hdHVyYWwgZXh0ZW5zaW9ucy4KICAgICAgICAgaWYgcGF0aC5lbmRz d2l0aCgiLnppcCIpOgogICAgICAgICAgICAgbmV3X3BhdGggPSBzZWxmLl91bnppcChwYXRoLCBz Y3JhdGNoX2RpcikKLSAgICAgICAgZWxpZiBwYXRoLmVuZHN3aXRoKCIudGFyLmd6Iik6Ci0gICAg ICAgICAgICBuZXdfcGF0aCA9IHNlbGYuX2V4dHJhY3RfdGFyZ3oocGF0aCwgc2NyYXRjaF9kaXIp CisgICAgICAgIGVsaWYgcGF0aC5lbmRzd2l0aCgiLnRhci5neiIpIG9yIHBhdGguZW5kc3dpdGgo Ii50YXIuYnoyIik6CisgICAgICAgICAgICBuZXdfcGF0aCA9IHNlbGYuX2V4dHJhY3RfdGFyKHBh dGgsIHNjcmF0Y2hfZGlyKQogICAgICAgICBlbGlmIF9DQUNIRV9FTlZfVkFSIGluIG9zLmVudmly b246CiAgICAgICAgICAgICBuZXdfcGF0aCA9IHBhdGgKICAgICAgICAgICAgIGlmIG9zLnBhdGgu ZGlybmFtZShwYXRoKSA9PSBvcy5wYXRoLm5vcm1wYXRoKG9zLmVudmlyb25bX0NBQ0hFX0VOVl9W QVJdKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2lu aXRfXy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQpp bmRleCA3YmYxM2QwZmU2N2U0Mzc0MDYzMmQ1MGUzNGU1ZmFiYjQxMTY2OGJmLi5kYzE3ODJhNjIx ZWFiY2E5OGVkZWVhNWI4ZTlkMWQxZTBhMTM5NGM3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5CkBAIC0xMzcsNiArMTM3LDEwIEBAIGNsYXNzIEF1 dG9pbnN0YWxsSW1wb3J0SG9vayhvYmplY3QpOgogICAgICAgICBpbnN0YWxsZXIuaW5zdGFsbCh1 cmw9Imh0dHA6Ly9weXBpLnB5dGhvbi5vcmcvcGFja2FnZXMvc291cmNlL1MvU1FMQWxjaGVteS9T UUxBbGNoZW15LTAuNy43LnRhci5neiNtZDU9ZGRmNmRmN2UwMTRjZWEzMThmYTk4MTM2NGYzZjkz YjkiLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVy bF9zdWJwYXRoPSJTUUxBbGNoZW15LTAuNy43L2xpYi9zcWxhbGNoZW15IikKIAorICAgICAgICB0 d2lzdGVkX2RpciA9IHNlbGYuX2ZzLmpvaW4oX0FVVE9JTlNUQUxMRURfRElSLCAidHdpc3RlZCIp CisgICAgICAgIGluc3RhbGxlciA9IEF1dG9JbnN0YWxsZXIocHJlcGVuZF90b19zZWFyY2hfcGF0 aD1UcnVlLCB0YXJnZXRfZGlyPXR3aXN0ZWRfZGlyKQorICAgICAgICBpbnN0YWxsZXIuaW5zdGFs bCh1cmw9Imh0dHBzOi8vcHlwaS5weXRob24ub3JnL3BhY2thZ2VzL3NvdXJjZS9UL1R3aXN0ZWQv VHdpc3RlZC0xMi4xLjAudGFyLmJ6MiNtZDU9ZjM5NmYxZDZmNTMyMWU4NjljMmY4OWIyMTk2YTll YjUiLCB1cmxfc3VicGF0aD0iVHdpc3RlZC0xMi4xLjAvdHdpc3RlZCIpCisKICAgICAgICAgc2Vs Zi5faW5zdGFsbCgiaHR0cDovL3B5cGkucHl0aG9uLm9yZy9wYWNrYWdlcy9zb3VyY2UvYi9idWls ZGJvdC9idWlsZGJvdC0wLjguNnAxLnRhci5neiNtZDU9YjY3MjdkMjgxMGM2OTIwNjJjNjU3NDky YmNiZWFjNmEiLCAiYnVpbGRib3QtMC44LjZwMS9idWlsZGJvdCIpCiAKICAgICBkZWYgX2luc3Rh bGxfY292ZXJhZ2Uoc2VsZik6Cg==