142213 2015-03-02 22:47:01 -0800 Fix build warning in WebKit2/Shared module 2015-03-03 21:26:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm shiva.jm commit-queue darin simon.fraser oldest_to_newest 1073623 0 shiva.jm 2015-03-02 22:47:01 -0800 Got below build warning on latest build, might have casued by issue: https://bugs.webkit.org/show_bug.cgi?id=138684 ../../Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:368:13: warning: unused parameter ‘element’ [-Wunused-parameter] static void pathPointCountApplierFunction(void* info, const PathElement* element) 1073637 1 247754 shiva.jm 2015-03-03 00:32:25 -0800 Created attachment 247754 Patch Fix build warning by using UNUSED_PARAM macro. 1073664 2 247754 simon.fraser 2015-03-03 08:04:37 -0800 Comment on attachment 247754 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247754&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:370 > static void pathPointCountApplierFunction(void* info, const PathElement* element) > { > + UNUSED_PARAM(element); It would be better to just remove the parameter name. 1073942 3 247828 shiva.jm 2015-03-03 20:25:08 -0800 Created attachment 247828 Patch-Updated-Review1 updated the patch as per review comments. 1073963 4 247828 commit-queue 2015-03-03 21:26:14 -0800 Comment on attachment 247828 Patch-Updated-Review1 Clearing flags on attachment: 247828 Committed r180988: <http://trac.webkit.org/changeset/180988> 1073964 5 commit-queue 2015-03-03 21:26:19 -0800 All reviewed patches have been landed. Closing bug. 247754 2015-03-03 00:32:25 -0800 2015-03-03 20:25:08 -0800 Patch bug-142213.patch text/plain 1265 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDkyNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAzICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViS2l0Mi9TaGFyZWQgbW9kdWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgYnkgdXNpbmcgVU5VU0VEX1BB UkFNIG1hY3JvLgorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHA6 CisgICAgICAgIChJUEM6OnBhdGhQb2ludENvdW50QXBwbGllckZ1bmN0aW9uKToKKwogMjAxNS0w My0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTihyMTc3MDc1KTogV2ViUHJvY2VzcyBjcmFzaGVzIHdoZW4gZW50ZXJpbmcg YWNjZWxlcmF0aW5nIGNvbXBvc2l0aW5nIG1vZGUgYmVmb3JlIHRoZSBXZWJWaWV3IGlzIHJlYWxp emVkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29k ZXJzLmNwcAkocmV2aXNpb24gMTgwOTI0KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNv cmVBcmd1bWVudENvZGVycy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2Nyw2ICszNjcsOCBAQCBi b29sIEFyZ3VtZW50Q29kZXI8SW50U2l6ZT46OmRlY29kZShBcmd1CiAKIHN0YXRpYyB2b2lkIHBh dGhQb2ludENvdW50QXBwbGllckZ1bmN0aW9uKHZvaWQqIGluZm8sIGNvbnN0IFBhdGhFbGVtZW50 KiBlbGVtZW50KQogeworICAgIFVOVVNFRF9QQVJBTShlbGVtZW50KTsKKwogICAgIHVpbnQ2NF90 KiBwb2ludENvdW50ID0gc3RhdGljX2Nhc3Q8dWludDY0X3QqPihpbmZvKTsKICAgICArKypwb2lu dENvdW50OwogfQo= 247828 2015-03-03 20:25:08 -0800 2015-03-03 21:26:14 -0800 Patch-Updated-Review1 bug-142213-updated.patch text/plain 1328 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDk4NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAzICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViS2l0Mi9TaGFyZWQgbW9kdWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgYnkgcmVtb3ZpbmcgYXJndW1l bnQgbmFtZSBmcm9tIGZ1bmN0aW9uLgorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVu dENvZGVycy5jcHA6CisgICAgICAgIChJUEM6OnBhdGhQb2ludENvdW50QXBwbGllckZ1bmN0aW9u KToKKwogMjAxNS0wMy0wMyAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAg ICAgW0NvbnRlbnQgRmlsdGVyaW5nXSBTZXBhcmF0ZSB1bmJsb2NrIGhhbmRsaW5nIGludG8gaXRz IG93biBjbGFzcwpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENv ZGVycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1 bWVudENvZGVycy5jcHAJKHJldmlzaW9uIDE4MDk4NSkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjUsNyArMzY1 LDcgQEAgYm9vbCBBcmd1bWVudENvZGVyPEludFNpemU+OjpkZWNvZGUoQXJndQogICAgIHJldHVy biBTaW1wbGVBcmd1bWVudENvZGVyPEludFNpemU+OjpkZWNvZGUoZGVjb2RlciwgaW50U2l6ZSk7 CiB9CiAKLXN0YXRpYyB2b2lkIHBhdGhQb2ludENvdW50QXBwbGllckZ1bmN0aW9uKHZvaWQqIGlu Zm8sIGNvbnN0IFBhdGhFbGVtZW50KiBlbGVtZW50KQorc3RhdGljIHZvaWQgcGF0aFBvaW50Q291 bnRBcHBsaWVyRnVuY3Rpb24odm9pZCogaW5mbywgY29uc3QgUGF0aEVsZW1lbnQqKQogewogICAg IHVpbnQ2NF90KiBwb2ludENvdW50ID0gc3RhdGljX2Nhc3Q8dWludDY0X3QqPihpbmZvKTsKICAg ICArKypwb2ludENvdW50Owo=