142201 2015-03-02 17:45:13 -0800 Adopt new API for keyboard interaction 2015-03-03 10:52:41 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified iOS 8.1 RESOLVED FIXED P2 Normal --- 1 enrica enrica oldest_to_newest 1073541 0 enrica 2015-03-02 17:45:13 -0800 rdar://problem/19924949 1073542 1 247726 enrica 2015-03-02 17:47:23 -0800 Created attachment 247726 Patch 1073553 2 247731 enrica 2015-03-02 18:15:48 -0800 Created attachment 247731 Patch2 I found a mistake in the previous one. 1073569 3 247731 joepeck 2015-03-02 19:06:50 -0800 Comment on attachment 247731 Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=247731&action=review r=me > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1226 > +#if (__IPHONE_OS_VERSION_MIN_REQUIRED > 80300) Nit: I think you can drop the parenthesis here. 1073694 4 enrica 2015-03-03 09:46:35 -0800 Committed revision 180939. 1073717 5 enrica 2015-03-03 10:52:41 -0800 Fixed typo in platform guard. Committed revision 180943. 247726 2015-03-02 17:47:23 -0800 2015-03-02 18:15:48 -0800 Patch newkbapi.txt text/plain 2366 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDkxMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAyICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgbmV3IEFQSSBmb3Ig a2V5Ym9hcmQgaW50ZXJhY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDIyMDEKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTk5MjQ5NDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IGlucHV0QXNzaXN0YW50SXRlbV0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9pbnB1 dEFzc2lzdGFudEl0ZW1dKToKKwogMjAxNS0wMy0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBh cHBsZS5jb20+CiAKICAgICAgICAgTG90cyBvZjogRVJST1I6IFVuaGFuZGxlZCB3ZWIgcHJvY2Vz cyBtZXNzYWdlIFdlYlBhZ2VHcm91cFByb3h5OlJlbW92ZUFsbFVzZXJDb250ZW50RmlsdGVycwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDE4MDc2NykKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xMjIzLDYgKzEyMjMsMjEgQEAgLSAoVUlWaWV3ICopaW5wdXRBY2Nlc3NvcnlWaWV3CiAg ICAgcmV0dXJuIF9mb3JtQWNjZXNzb3J5Vmlldy5nZXQoKTsKIH0KIAorI2lmIChfX0lQSE9ORV9P U19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA4MDMwMCkKKy0gKFVJVGV4dElucHV0QXNzaXN0YW50 SXRlbSAqKWlucHV0QXNzaXN0YW50SXRlbQoreworICAgIGlmICghX2Zvcm1BY2Nlc3NvcnlWaWV3 KSB7CisgICAgICAgIF9mb3JtQWNjZXNzb3J5VmlldyA9IGFkb3B0TlMoW1tVSVdlYkZvcm1BY2Nl c3NvcnkgYWxsb2NdIGluaXRdKTsKKyAgICAgICAgW19mb3JtQWNjZXNzb3J5VmlldyBzZXREZWxl Z2F0ZTpzZWxmXTsKKyAgICB9CisgICAgcmV0dXJuIChbX2Zvcm1BY2Nlc3NvcnlWaWV3IHJlc3Bv bmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoaW5wdXRBc3Npc3RhbnRJdGVtKV0pID8gW19mb3JtQWNj ZXNzb3J5VmlldyBpbnB1dEFzc2lzdGFudEl0ZW1dIDogbmlsOworfQorCistIChVSVRleHRJbnB1 dEFzc2lzdGFudEl0ZW0gKilfaW5wdXRBc3Npc3RhbnRJdGVtCit7CisgICAgcmV0dXJuIFtzZWxm IGlucHV0QXNzaXN0YW50SXRlbV07Cit9CisjZWxzZQogLSAoTlNBcnJheSAqKWlucHV0QXNzaXN0 YW50QnV0dG9uSXRlbXMKIHsKICAgICBpZiAoIV9mb3JtQWNjZXNzb3J5VmlldykgewpAQCAtMTIz MSw2ICsxMjQ2LDcgQEAgLSAoTlNBcnJheSAqKWlucHV0QXNzaXN0YW50QnV0dG9uSXRlbXMKICAg ICB9CiAgICAgcmV0dXJuIChbX2Zvcm1BY2Nlc3NvcnlWaWV3IHJlc3BvbmRzVG9TZWxlY3RvcjpA c2VsZWN0b3IoYnV0dG9uSXRlbXMpXSkgPyBbX2Zvcm1BY2Nlc3NvcnlWaWV3IGJ1dHRvbkl0ZW1z XSA6IG5pbDsKIH0KKyNlbmRpZgogCiAtIChOU0FycmF5ICopc3VwcG9ydGVkUGFzdGVib2FyZFR5 cGVzRm9yQ3VycmVudFNlbGVjdGlvbgogewpAQCAtMjM0MSwxOCArMjM1Nyw2IEBAIC0gKFVJVGV4 dElucHV0VHJhaXRzICopdGV4dElucHV0VHJhaXRzCiAgICAgcmV0dXJuIF90cmFpdHMuZ2V0KCk7 CiB9CiAKLSNpZiAoX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gODAzMDApCi0t IChVSVRleHRJbnB1dEFzc2lzdGFudEl0ZW0gKilpbnB1dEFzc2lzdGFudEl0ZW0KLXsKLSAgICBy ZXR1cm4gbmlsOwotfQotCi0tIChVSVRleHRJbnB1dEFzc2lzdGFudEl0ZW0gKilfaW5wdXRBc3Np c3RhbnRJdGVtCi17Ci0gICAgcmV0dXJuIG5pbDsKLX0KLSNlbmRpZgotCiAtIChVSVRleHRJbnRl cmFjdGlvbkFzc2lzdGFudCAqKWludGVyYWN0aW9uQXNzaXN0YW50CiB7CiAgICAgcmV0dXJuIF90 ZXh0U2VsZWN0aW9uQXNzaXN0YW50LmdldCgpOwo= 247731 2015-03-02 18:15:48 -0800 2015-03-02 19:06:50 -0800 Patch2 newkbapi.txt text/plain 2300 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDkxMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTAyICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgbmV3IEFQSSBmb3Ig a2V5Ym9hcmQgaW50ZXJhY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDIyMDEKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTk5MjQ5NDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IGlucHV0QXNzaXN0YW50SXRlbV0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9pbnB1 dEFzc2lzdGFudEl0ZW1dKToKKwogMjAxNS0wMy0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBh cHBsZS5jb20+CiAKICAgICAgICAgTG90cyBvZjogRVJST1I6IFVuaGFuZGxlZCB3ZWIgcHJvY2Vz cyBtZXNzYWdlIFdlYlBhZ2VHcm91cFByb3h5OlJlbW92ZUFsbFVzZXJDb250ZW50RmlsdGVycwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDE4MDc2NykKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xMjIzLDE1ICsxMjIzLDIyIEBAIC0gKFVJVmlldyAqKWlucHV0QWNjZXNzb3J5Vmlldwog ICAgIHJldHVybiBfZm9ybUFjY2Vzc29yeVZpZXcuZ2V0KCk7CiB9CiAKLS0gKE5TQXJyYXkgKilp bnB1dEFzc2lzdGFudEJ1dHRvbkl0ZW1zCisjaWYgKF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JF UVVJUkVEID4gODAzMDApCistIChVSVRleHRJbnB1dEFzc2lzdGFudEl0ZW0gKilpbnB1dEFzc2lz dGFudEl0ZW0KIHsKICAgICBpZiAoIV9mb3JtQWNjZXNzb3J5VmlldykgewogICAgICAgICBfZm9y bUFjY2Vzc29yeVZpZXcgPSBhZG9wdE5TKFtbVUlXZWJGb3JtQWNjZXNzb3J5IGFsbG9jXSBpbml0 XSk7CiAgICAgICAgIFtfZm9ybUFjY2Vzc29yeVZpZXcgc2V0RGVsZWdhdGU6c2VsZl07CiAgICAg fQotICAgIHJldHVybiAoW19mb3JtQWNjZXNzb3J5VmlldyByZXNwb25kc1RvU2VsZWN0b3I6QHNl bGVjdG9yKGJ1dHRvbkl0ZW1zKV0pID8gW19mb3JtQWNjZXNzb3J5VmlldyBidXR0b25JdGVtc10g OiBuaWw7CisgICAgcmV0dXJuIChbX2Zvcm1BY2Nlc3NvcnlWaWV3IHJlc3BvbmRzVG9TZWxlY3Rv cjpAc2VsZWN0b3IoaW5wdXRBc3Npc3RhbnRJdGVtKV0pID8gW19mb3JtQWNjZXNzb3J5VmlldyBp bnB1dEFzc2lzdGFudEl0ZW1dIDogbmlsOwogfQogCistIChVSVRleHRJbnB1dEFzc2lzdGFudEl0 ZW0gKilfaW5wdXRBc3Npc3RhbnRJdGVtCit7CisgICAgcmV0dXJuIFtzZWxmIGlucHV0QXNzaXN0 YW50SXRlbV07Cit9CisjZW5kaWYKKwogLSAoTlNBcnJheSAqKXN1cHBvcnRlZFBhc3RlYm9hcmRU eXBlc0ZvckN1cnJlbnRTZWxlY3Rpb24KIHsKICAgICBpZiAoX3BhZ2UtPmVkaXRvclN0YXRlKCku c2VsZWN0aW9uSXNOb25lKQpAQCAtMjM0MSwxOCArMjM0OCw2IEBAIC0gKFVJVGV4dElucHV0VHJh aXRzICopdGV4dElucHV0VHJhaXRzCiAgICAgcmV0dXJuIF90cmFpdHMuZ2V0KCk7CiB9CiAKLSNp ZiAoX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gODAzMDApCi0tIChVSVRleHRJ bnB1dEFzc2lzdGFudEl0ZW0gKilpbnB1dEFzc2lzdGFudEl0ZW0KLXsKLSAgICByZXR1cm4gbmls OwotfQotCi0tIChVSVRleHRJbnB1dEFzc2lzdGFudEl0ZW0gKilfaW5wdXRBc3Npc3RhbnRJdGVt Ci17Ci0gICAgcmV0dXJuIG5pbDsKLX0KLSNlbmRpZgotCiAtIChVSVRleHRJbnRlcmFjdGlvbkFz c2lzdGFudCAqKWludGVyYWN0aW9uQXNzaXN0YW50CiB7CiAgICAgcmV0dXJuIF90ZXh0U2VsZWN0 aW9uQXNzaXN0YW50LmdldCgpOwo=