142197 2015-03-02 16:28:35 -0800 SpeculativeJIT::emitAllocateArguments() should be a bit faster, and shouldn't do destructor initialization 2015-03-02 16:46:33 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 141174 1 fpizlo fpizlo oldest_to_newest 1073510 0 fpizlo 2015-03-02 16:28:35 -0800 Patch forthcoming. 1073515 1 247717 fpizlo 2015-03-02 16:33:45 -0800 Created attachment 247717 the patch 1073516 2 247717 ggaren 2015-03-02 16:36:16 -0800 Comment on attachment 247717 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=247717&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + (JSC::DFG::SpeculativeJIT::emitAllocateArguments): Use shift instead of mul, since mul doesn't automatically strength-reduce to shift. Also lass the structure as a TrustedImmPtr. lass => pass 1073523 3 fpizlo 2015-03-02 16:46:33 -0800 Landed in http://trac.webkit.org/changeset/180909 247717 2015-03-02 16:33:45 -0800 2015-03-02 16:36:16 -0800 the patch blah.patch text/plain 3050 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwOTA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE1LTAzLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3BlY3VsYXRpdmVKSVQ6OmVtaXRBbGxvY2F0ZUFyZ3VtZW50cygpIHNob3VsZCBiZSBhIGJpdCBm YXN0ZXIsIGFuZCBzaG91bGRuJ3QgZG8gZGVzdHJ1Y3RvciBpbml0aWFsaXphdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTk3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3Vs YXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjplbWl0QWxs b2NhdGVBcmd1bWVudHMpOiBVc2Ugc2hpZnQgaW5zdGVhZCBvZiBtdWwsIHNpbmNlIG11bCBkb2Vz bid0IGF1dG9tYXRpY2FsbHkgc3RyZW5ndGgtcmVkdWNlIHRvIHNoaWZ0LiBBbHNvIGxhc3MgdGhl IHN0cnVjdHVyZSBhcyBhIFRydXN0ZWRJbW1QdHIuCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0 aXZlSklULmg6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmVtaXRBbGxvY2F0 ZVZhcmlhYmxlU2l6ZWRKU09iamVjdCk6IFJhdGlvbmFsaXplIHRoaXMgYSBiaXQuIFRoZSBvdGhl ciBlbWl0QWxsb2NhdGUuLi4gbWV0aG9kcyB0YWtlIGEgdGVtcGxhdGVkIHN0cnVjdHVyZSBzbyB0 aGF0IGl0IGNhbiBiZSBlaXRoZXIgYSBUcnVzdGVkSW1tUHRyIG9yIGEgcmVnaXN0ZXIuIEFsc28g ZG9uJ3QgZG8gZGVzdHJ1Y3RvciBpbml0aWFsaXphdGlvbiwgc2luY2UgaXRzIG9uZSBjbGllbnQg ZG9lc24ndCBuZWVkIGl0LCBhbmQgaXQncyBhY3R1YWxseSBwcm9iYWJseSB3cm9uZy4KKwogMjAx NS0wMy0wMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRXhjZXB0 aW9uIHN0YWNrIHVud2luZGluZyBpbiBKU0MgaGFuZ3Mgd2hpbGUgdGhlIFRpbWVsaW5lIFByb2Zp bGVyIGlzIGVuYWJsZWQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1 bGF0aXZlSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1NwZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24gMTgwODg4KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMiw5 ICsxMTIsOSBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjplbWl0QWxsb2NhdGVBcmd1bWVuCiAgICAg U3RydWN0dXJlKiBzdHJ1Y3R1cmUgPSBtX2ppdC5ncmFwaCgpLmdsb2JhbE9iamVjdEZvcihtX2N1 cnJlbnROb2RlLT5vcmlnaW4uc2VtYW50aWMpLT5hcmd1bWVudHNTdHJ1Y3R1cmUoKTsKIAogICAg IG1faml0LmxvYWQzMihKSVRDb21waWxlcjo6cGF5bG9hZEZvcihKU1N0YWNrOjpBcmd1bWVudENv dW50KSwgc2NyYXRjaEdQUjEpOwotICAgIG1faml0Lm11bDMyKFRydXN0ZWRJbW0zMihzaXplb2Yo SlNWYWx1ZSkpLCBzY3JhdGNoR1BSMSwgc2NyYXRjaEdQUjEpOworICAgIG1faml0LmxzaGlmdDMy KFRydXN0ZWRJbW0zMigzKSwgc2NyYXRjaEdQUjEpOwogICAgIG1faml0LmFkZDMyKFRydXN0ZWRJ bW0zMihBcmd1bWVudHM6Om9mZnNldE9mSW5saW5lUmVnaXN0ZXJBcnJheSgpKSwgc2NyYXRjaEdQ UjEpOwotICAgIGVtaXRBbGxvY2F0ZVZhcmlhYmxlU2l6ZWRKU09iamVjdDxBcmd1bWVudHM+KHJl c3VsdEdQUiwgc3RydWN0dXJlLCBzY3JhdGNoR1BSMSwgc2NyYXRjaEdQUjEsIHNjcmF0Y2hHUFIy LCBzbG93UGF0aCk7CisgICAgZW1pdEFsbG9jYXRlVmFyaWFibGVTaXplZEpTT2JqZWN0PEFyZ3Vt ZW50cz4ocmVzdWx0R1BSLCBUcnVzdGVkSW1tUHRyKHN0cnVjdHVyZSksIHNjcmF0Y2hHUFIxLCBz Y3JhdGNoR1BSMSwgc2NyYXRjaEdQUjIsIHNsb3dQYXRoKTsKIAogICAgIG1faml0LnN0b3JlUHRy KFRydXN0ZWRJbW1QdHIoMCksIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKHJlc3VsdEdQUiwgQXJn dW1lbnRzOjpvZmZzZXRPZkFjdGl2YXRpb24oKSkpOwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCShyZXZpc2lvbiAxODA4ODgpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHdvcmtpbmcgY29w eSkKQEAgLTIyOTgsOCArMjI5OCw3IEBAIHB1YmxpYzoKIAogICAgICAgICBzZWxlY3RlZFNtYWxs U3BhY2UubGluaygmbV9qaXQpOwogCi0gICAgICAgIGVtaXRBbGxvY2F0ZUpTT2JqZWN0KHJlc3Vs dEdQUiwgc2NyYXRjaEdQUjEsIFRydXN0ZWRJbW1QdHIoc3RydWN0dXJlKSwgVHJ1c3RlZEltbVB0 cigwKSwgc2NyYXRjaEdQUjIsIHNsb3dQYXRoKTsKLSAgICAgICAgbV9qaXQuc3RvcmVQdHIoVHJ1 c3RlZEltbVB0cihzdHJ1Y3R1cmUtPmNsYXNzSW5mbygpKSwgTWFjcm9Bc3NlbWJsZXI6OkFkZHJl c3MocmVzdWx0R1BSLCBKU0Rlc3RydWN0aWJsZU9iamVjdDo6Y2xhc3NJbmZvT2Zmc2V0KCkpKTsK KyAgICAgICAgZW1pdEFsbG9jYXRlSlNPYmplY3QocmVzdWx0R1BSLCBzY3JhdGNoR1BSMSwgc3Ry dWN0dXJlLCBUcnVzdGVkSW1tUHRyKDApLCBzY3JhdGNoR1BSMiwgc2xvd1BhdGgpOwogICAgIH0K IAogICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBUPgo=