142194 2015-03-02 16:03:50 -0800 bmalloc: Eagerly remove allocated objects from the free list 2015-03-02 16:38:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 1073494 0 ggaren 2015-03-02 16:03:50 -0800 bmalloc: Eagerly remove allocated objects from the free list 1073496 1 247711 ggaren 2015-03-02 16:08:53 -0800 Created attachment 247711 Patch 1073504 2 247711 kling 2015-03-02 16:20:41 -0800 Comment on attachment 247711 Patch r=me 1073517 3 ggaren 2015-03-02 16:38:48 -0800 Committed r180908: <http://trac.webkit.org/changeset/180908> 247711 2015-03-02 16:08:53 -0800 2015-03-02 16:20:41 -0800 Patch bug-142194-20150302160835.patch text/plain 6506 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDkwNikKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE1LTAzLTAyICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogRWFnZXJseSBy ZW1vdmUgYWxsb2NhdGVkIG9iamVjdHMgZnJvbSB0aGUgZnJlZSBsaXN0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDIxOTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHJlZHVjZXMgdGhlIHByZXNz dXJlIHRvIGdhcmJhZ2UgY29sbGVjdCB0aGUgZnJlZSBsaXN0LgorCisgICAgICAgIE1pZ2h0IGJl IGEgMSUgc3BlZWR1cCBvbiBNYWxsb2NCZW5jaC4KKworICAgICAgICAqIGJtYWxsb2MvRnJlZUxp c3QuY3BwOiBQdXQgdGhpcyBjb21tZW50IGF0IHRoZSB0b3Agb2YgdGhlIGZpbGUgaW5zdGVhZAor ICAgICAgICBvZiByZXBlYXRpbmcgaXQgaW5zaWRlIG9mIGVhY2ggZnVuY3Rpb24uIFRyaWVkIHRv IGNsYXJpZnkgdGhlIGRldGFpbHMuCisKKyAgICAgICAgKGJtYWxsb2M6OkZyZWVMaXN0Ojp0YWtl R3JlZWR5KTogTWF0Y2hlZCB0aGUgb3RoZXIgaXRlcmF0aW9uIGNvZGUgaW4gdGhpcworICAgICAg ICBmaWxlIGZvciBjb25zaXN0ZW5jeSAtLSBldmVuIHRob3VnaCBlaXRoZXIgZGlyZWN0aW9uIHdv cmtzIGZpbmUgaW4gdGhpcworICAgICAgICBmdW5jdGlvbi4KKworICAgICAgICAoYm1hbGxvYzo6 RnJlZUxpc3Q6OnRha2UpOiBDaGFuZ2UgdG8gaXRlcmF0ZSBmcm9tIGxvdyB0byBoaWdoIHNvIHRo YXQgd2UKKyAgICAgICAgY2FuIG1haW50YWluIGFuIGluZGV4IGludG8gdGhlIHZlY3RvciB0aGF0 IGlzIG5vdCBkaXN0dXJiZWQgZXZlbiBpZiB3ZQorICAgICAgICBwb3AgZnJvbSB0aGUgbWlkZGxl ICh3aGljaCBpbnZhbGlkYXRlcyB0aGUgbGFzdCBpbmRleCBpbiB0aGUgdmVjdG9yKS4KKworICAg ICAgICBEZWNyZW1lbnQgaSB3aGVuIHBvcHBpbmcgZnJvbSB0aGUgbWlkZGxlIHRvIG1ha2Ugc3Vy ZSB0aGF0IHdlIGRvbid0CisgICAgICAgIHNraXAgdGhlIG5leHQgaXRlbSBhZnRlciBwb3BwaW5n LgorCisgICAgICAgIChibWFsbG9jOjpGcmVlTGlzdDo6cmVtb3ZlSW52YWxpZEFuZER1cGxpY2F0 ZUVudHJpZXMpOiBEaXR0by4KKwogMjAxNS0wMi0yNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBGaXhlZCBhIHR5cG8gaW4gdGhlIHByZXZpb3VzIGNvbW1pdC4K SW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRnJlZUxpc3QuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRnJlZUxpc3QuY3BwCShyZXZpc2lvbiAxODA3OTcpCisr KyBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0ZyZWVMaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjksMTggKzI5LDI0IEBACiAKIG5hbWVzcGFjZSBibWFsbG9jIHsKIAorLy8gV2UgZG9uJ3QgZWFn ZXJseSByZW1vdmUgaW52YWxpZGF0ZWQgZW50cmllcyBmcm9tIHRoZSBmcmVlIGxpc3Qgd2hlbiB3 ZSBtZXJnZQorLy8gbGFyZ2Ugb2JqZWN0cy4gVGhpcyBtZWFucyB0aGF0IHRoZSBmcmVlIGxpc3Qg Y2FuIGNvbnRhaW4gaW52YWxpZCBhbmQvb3IKKy8vIGR1cGxpY2F0ZSBlbnRyaWVzLiAoUmVwZWF0 aW5nIGEgbWVyZ2UtYW5kLXRoZW4tc3BsaXQgcHJvZHVjZXMgYSBkdXBsaWNhdGUuKQorCisvLyBU byBhdm9pZCBpbmZpbml0ZSBncm93dGggaW4gaW52YWxpZCBlbnRyaWVzLCB3ZSBpbmNyZW1lbnRh bGx5IHJlbW92ZQorLy8gaW52YWxpZCBlbnRyaWVzIGFzIHdlIGRpc2NvdmVyIHRoZW0gZHVyaW5n IGFsbG9jYXRpb24sIGFuZCB3ZSBhbHNvIGdhcmJhZ2UKKy8vIGNvbGxlY3QgdGhlIGZyZWUgbGlz dCBhcyBpdCBncm93cy4KKwogTGFyZ2VPYmplY3QgRnJlZUxpc3Q6OnRha2VHcmVlZHkoT3duZXIg b3duZXIpCiB7Ci0gICAgZm9yIChzaXplX3QgaSA9IG1fdmVjdG9yLnNpemUoKTsgaS0tID4gMDsg KSB7Ci0gICAgICAgIC8vIFdlIGRvbid0IGVhZ2VybHkgcmVtb3ZlIGl0ZW1zIHdoZW4gd2UgbWVy Z2UgYW5kL29yIHNwbGl0IHJhbmdlcywKLSAgICAgICAgLy8gc28gd2UgbmVlZCB0byB2YWxpZGF0 ZSBlYWNoIGZyZWUgbGlzdCBlbnRyeSBiZWZvcmUgdXNpbmcgaXQuCisgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBtX3ZlY3Rvci5zaXplKCk7ICsraSkgewogICAgICAgICBMYXJnZU9iamVjdCBs YXJnZU9iamVjdChMYXJnZU9iamVjdDo6RG9Ob3RWYWxpZGF0ZSwgbV92ZWN0b3JbaV0uYmVnaW4o KSk7CiAgICAgICAgIGlmICghbGFyZ2VPYmplY3QuaXNWYWxpZEFuZEZyZWUob3duZXIsIG1fdmVj dG9yW2ldLnNpemUoKSkpIHsKLSAgICAgICAgICAgIG1fdmVjdG9yLnBvcChpKTsKKyAgICAgICAg ICAgIG1fdmVjdG9yLnBvcChpLS0pOwogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0K IAotICAgICAgICBtX3ZlY3Rvci5wb3AoaSk7CisgICAgICAgIG1fdmVjdG9yLnBvcChpLS0pOwog ICAgICAgICByZXR1cm4gbGFyZ2VPYmplY3Q7CiAgICAgfQogCkBAIC00OSwyNyArNTUsMjkgQEAg TGFyZ2VPYmplY3QgRnJlZUxpc3Q6OnRha2VHcmVlZHkoT3duZXIgbwogCiBMYXJnZU9iamVjdCBG cmVlTGlzdDo6dGFrZShPd25lciBvd25lciwgc2l6ZV90IHNpemUpCiB7Ci0gICAgTGFyZ2VPYmpl Y3QgZmlyc3Q7Ci0gICAgc2l6ZV90IGVuZCA9IG1fdmVjdG9yLnNpemUoKSA+IGZyZWVMaXN0U2Vh cmNoRGVwdGggPyBtX3ZlY3Rvci5zaXplKCkgLSBmcmVlTGlzdFNlYXJjaERlcHRoIDogMDsKLSAg ICBmb3IgKHNpemVfdCBpID0gbV92ZWN0b3Iuc2l6ZSgpOyBpLS0gPiBlbmQ7ICkgewotICAgICAg ICAvLyBXZSBkb24ndCBlYWdlcmx5IHJlbW92ZSBpdGVtcyB3aGVuIHdlIG1lcmdlIGFuZC9vciBz cGxpdCByYW5nZXMsIHNvCi0gICAgICAgIC8vIHdlIG5lZWQgdG8gdmFsaWRhdGUgZWFjaCBmcmVl IGxpc3QgZW50cnkgYmVmb3JlIHVzaW5nIGl0LgorICAgIExhcmdlT2JqZWN0IGNhbmRpZGF0ZTsK KyAgICBzaXplX3QgY2FuZGlkYXRlSW5kZXg7CisgICAgc2l6ZV90IGJlZ2luID0gbV92ZWN0b3Iu c2l6ZSgpID4gZnJlZUxpc3RTZWFyY2hEZXB0aCA/IG1fdmVjdG9yLnNpemUoKSAtIGZyZWVMaXN0 U2VhcmNoRGVwdGggOiAwOworICAgIGZvciAoc2l6ZV90IGkgPSBiZWdpbjsgaSA8IG1fdmVjdG9y LnNpemUoKTsgKytpKSB7CiAgICAgICAgIExhcmdlT2JqZWN0IGxhcmdlT2JqZWN0KExhcmdlT2Jq ZWN0OjpEb05vdFZhbGlkYXRlLCBtX3ZlY3RvcltpXS5iZWdpbigpKTsKICAgICAgICAgaWYgKCFs YXJnZU9iamVjdC5pc1ZhbGlkQW5kRnJlZShvd25lciwgbV92ZWN0b3JbaV0uc2l6ZSgpKSkgewot ICAgICAgICAgICAgbV92ZWN0b3IucG9wKGkpOworICAgICAgICAgICAgbV92ZWN0b3IucG9wKGkt LSk7CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQogCiAgICAgICAgIGlmIChsYXJn ZU9iamVjdC5zaXplKCkgPCBzaXplKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAg aWYgKCEhZmlyc3QgJiYgZmlyc3QuYmVnaW4oKSA8IGxhcmdlT2JqZWN0LmJlZ2luKCkpCisgICAg ICAgIGlmICghIWNhbmRpZGF0ZSAmJiBjYW5kaWRhdGUuYmVnaW4oKSA8IGxhcmdlT2JqZWN0LmJl Z2luKCkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICBmaXJzdCA9IGxhcmdlT2Jq ZWN0OworICAgICAgICBjYW5kaWRhdGUgPSBsYXJnZU9iamVjdDsKKyAgICAgICAgY2FuZGlkYXRl SW5kZXggPSBpOwogICAgIH0KLSAgICAKLSAgICByZXR1cm4gZmlyc3Q7CisKKyAgICBpZiAoISFj YW5kaWRhdGUpCisgICAgICAgIG1fdmVjdG9yLnBvcChjYW5kaWRhdGVJbmRleCk7CisgICAgcmV0 dXJuIGNhbmRpZGF0ZTsKIH0KIAogTGFyZ2VPYmplY3QgRnJlZUxpc3Q6OnRha2UoT3duZXIgb3du ZXIsIHNpemVfdCBhbGlnbm1lbnQsIHNpemVfdCBzaXplLCBzaXplX3QgdW5hbGlnbmVkU2l6ZSkK QEAgLTc3LDE0ICs4NSwxMyBAQCBMYXJnZU9iamVjdCBGcmVlTGlzdDo6dGFrZShPd25lciBvd25l ciwgCiAgICAgQkFTU0VSVChpc1Bvd2VyT2ZUd28oYWxpZ25tZW50KSk7CiAgICAgc2l6ZV90IGFs aWdubWVudE1hc2sgPSBhbGlnbm1lbnQgLSAxOwogCi0gICAgTGFyZ2VPYmplY3QgZmlyc3Q7Ci0g ICAgc2l6ZV90IGVuZCA9IG1fdmVjdG9yLnNpemUoKSA+IGZyZWVMaXN0U2VhcmNoRGVwdGggPyBt X3ZlY3Rvci5zaXplKCkgLSBmcmVlTGlzdFNlYXJjaERlcHRoIDogMDsKLSAgICBmb3IgKHNpemVf dCBpID0gbV92ZWN0b3Iuc2l6ZSgpOyBpLS0gPiBlbmQ7ICkgewotICAgICAgICAvLyBXZSBkb24n dCBlYWdlcmx5IHJlbW92ZSBpdGVtcyB3aGVuIHdlIG1lcmdlIGFuZC9vciBzcGxpdCByYW5nZXMs IHNvCi0gICAgICAgIC8vIHdlIG5lZWQgdG8gdmFsaWRhdGUgZWFjaCBmcmVlIGxpc3QgZW50cnkg YmVmb3JlIHVzaW5nIGl0LgorICAgIExhcmdlT2JqZWN0IGNhbmRpZGF0ZTsKKyAgICBzaXplX3Qg Y2FuZGlkYXRlSW5kZXg7CisgICAgc2l6ZV90IGJlZ2luID0gbV92ZWN0b3Iuc2l6ZSgpID4gZnJl ZUxpc3RTZWFyY2hEZXB0aCA/IG1fdmVjdG9yLnNpemUoKSAtIGZyZWVMaXN0U2VhcmNoRGVwdGgg OiAwOworICAgIGZvciAoc2l6ZV90IGkgPSBiZWdpbjsgaSA8IG1fdmVjdG9yLnNpemUoKTsgKytp KSB7CiAgICAgICAgIExhcmdlT2JqZWN0IGxhcmdlT2JqZWN0KExhcmdlT2JqZWN0OjpEb05vdFZh bGlkYXRlLCBtX3ZlY3RvcltpXS5iZWdpbigpKTsKICAgICAgICAgaWYgKCFsYXJnZU9iamVjdC5p c1ZhbGlkQW5kRnJlZShvd25lciwgbV92ZWN0b3JbaV0uc2l6ZSgpKSkgewotICAgICAgICAgICAg bV92ZWN0b3IucG9wKGkpOworICAgICAgICAgICAgbV92ZWN0b3IucG9wKGktLSk7CiAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgfQogCkBAIC05NCwzMSArMTAxLDM0IEBAIExhcmdlT2Jq ZWN0IEZyZWVMaXN0Ojp0YWtlKE93bmVyIG93bmVyLCAKICAgICAgICAgaWYgKHRlc3QobGFyZ2VP YmplY3QuYmVnaW4oKSwgYWxpZ25tZW50TWFzaykgJiYgbGFyZ2VPYmplY3Quc2l6ZSgpIDwgdW5h bGlnbmVkU2l6ZSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCi0gICAgICAgIGlmICghIWZpcnN0 ICYmIGZpcnN0LmJlZ2luKCkgPCBsYXJnZU9iamVjdC5iZWdpbigpKQorICAgICAgICBpZiAoISFj YW5kaWRhdGUgJiYgY2FuZGlkYXRlLmJlZ2luKCkgPCBsYXJnZU9iamVjdC5iZWdpbigpKQogICAg ICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgZmlyc3QgPSBsYXJnZU9iamVjdDsKKyAgICAg ICAgY2FuZGlkYXRlID0gbGFyZ2VPYmplY3Q7CisgICAgICAgIGNhbmRpZGF0ZUluZGV4ID0gaTsK ICAgICB9CiAgICAgCi0gICAgcmV0dXJuIGZpcnN0OworICAgIGlmICghIWNhbmRpZGF0ZSkKKyAg ICAgICAgbV92ZWN0b3IucG9wKGNhbmRpZGF0ZUluZGV4KTsKKyAgICByZXR1cm4gY2FuZGlkYXRl OwogfQogCiB2b2lkIEZyZWVMaXN0OjpyZW1vdmVJbnZhbGlkQW5kRHVwbGljYXRlRW50cmllcyhP d25lciBvd25lcikKIHsKLSAgICBmb3IgKHNpemVfdCBpID0gbV92ZWN0b3Iuc2l6ZSgpOyBpLS0g PiAwOyApIHsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fdmVjdG9yLnNpemUoKTsgKytp KSB7CiAgICAgICAgIExhcmdlT2JqZWN0IGxhcmdlT2JqZWN0KExhcmdlT2JqZWN0OjpEb05vdFZh bGlkYXRlLCBtX3ZlY3RvcltpXS5iZWdpbigpKTsKICAgICAgICAgaWYgKCFsYXJnZU9iamVjdC5p c1ZhbGlkQW5kRnJlZShvd25lciwgbV92ZWN0b3JbaV0uc2l6ZSgpKSkgewotICAgICAgICAgICAg bV92ZWN0b3IucG9wKGkpOworICAgICAgICAgICAgbV92ZWN0b3IucG9wKGktLSk7CiAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgbGFyZ2VPYmplY3Qu c2V0TWFya2VkKGZhbHNlKTsKICAgICB9CiAKLSAgICBmb3IgKHNpemVfdCBpID0gbV92ZWN0b3Iu c2l6ZSgpOyBpLS0gPiAwOyApIHsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fdmVjdG9y LnNpemUoKTsgKytpKSB7CiAgICAgICAgIExhcmdlT2JqZWN0IGxhcmdlT2JqZWN0KExhcmdlT2Jq ZWN0OjpEb05vdFZhbGlkYXRlLCBtX3ZlY3RvcltpXS5iZWdpbigpKTsKICAgICAgICAgaWYgKGxh cmdlT2JqZWN0LmlzTWFya2VkKCkpIHsKLSAgICAgICAgICAgIG1fdmVjdG9yLnBvcChpKTsKKyAg ICAgICAgICAgIG1fdmVjdG9yLnBvcChpLS0pOwogICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgIH0KIAo=