142190 2015-03-02 15:18:09 -0800 Return disk cache entries from the new disk cache 2015-03-02 15:25:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1073462 0 andersca 2015-03-02 15:18:09 -0800 Return disk cache entries from the new disk cache 1073464 1 247703 andersca 2015-03-02 15:21:16 -0800 Created attachment 247703 Patch 1073466 2 commit-queue 2015-03-02 15:22:50 -0800 Attachment 247703 did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:373: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1073468 3 247703 koivisto 2015-03-02 15:24:46 -0800 Comment on attachment 247703 Patch r=me 1073469 4 andersca 2015-03-02 15:25:39 -0800 Committed r180899: <http://trac.webkit.org/changeset/180899> 247703 2015-03-02 15:21:16 -0800 2015-03-02 15:24:46 -0800 Patch bug-142190-20150302152105.patch text/plain 4792 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjAwZTZmZjhkYjI4ZjEz YmE2YTg4MTAwMGMwZDg2ZjJlYzRjZTUzOS4uODZhNmVkZGIxNzg2MzA1ZTkxMDJmMzMzNTNkYTU0 YTU1MjkzYmM0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAzLTAyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV0dXJuIGRpc2sg Y2FjaGUgZW50cmllcyBmcm9tIHRoZSBuZXcgZGlzayBjYWNoZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTkwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmZldGNoRGlza0NhY2hlRW50cmllcyk6CisgICAg ICAgIENhbGwgTmV0d29ya0NhY2hlOjp0cmF2ZXJzZSgpIHRvIGdldCBhbGwgdGhlIGNhY2hlIGVu dHJpZXMsIHVuaXF1ZSB0aGVpciBvcmlnaW5zIGFuZCBwYXNzIHRoZW0gYmFjayB3aXRoIHRoZSBj b21wbGV0aW9uIGhhbmRsZXIuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3 b3JrQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OnRyYXZlcnNlKToK KyAgICAgICAgTmV3IGhlbHBlciBmdW5jdGlvbiB0aGF0IHRyYXZlcnNlcyBuZXR3b3JrIGNhY2hl IGVudHJpZXMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUu aDoKKwogMjAxNS0wMy0wMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIHdheSB0byBkdW1wIGNhY2hlIG1ldGEgZGF0YSB0byBmaWxlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXggY2E0ZmQ2 MTgxNjk2NTE3NGFiNzgzY2ZlMjA5Y2Y4NmNiOGNlNWJkNi4uM2U2NjkzM2MxNmVkMTVkY2VkMTIx M2M2ZWUwYWI5MDkyYzNkNjFhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL05ldHdvcmtQcm9jZXNzLmNwcApAQCAtNTAsNiArNTAsNyBAQAogI2luY2x1ZGUgPFdlYkNv cmUvTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9QbGF0Zm9ybUNv b2tpZUphci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXF1ZXN0Lmg+CisjaW5jbHVk ZSA8V2ViQ29yZS9TZWN1cml0eU9yaWdpbkhhc2guaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Nlc3Np b25JRC5oPgogI2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0 cmluZy5oPgpAQCAtNTgsNiArNTksMTAgQEAKICNpbmNsdWRlICJTZWNJdGVtU2hpbS5oIgogI2Vu ZGlmCiAKKyNpZiBFTkFCTEUoTkVUV09SS19DQUNIRSkKKyNpbmNsdWRlICJOZXR3b3JrQ2FjaGVD b2RlcnMuaCIKKyNlbmRpZgorCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNl IFdlYktpdCB7CkBAIC0yNjMsOSArMjY4LDI1IEBAIHN0YXRpYyB2b2lkIGZldGNoRGlza0NhY2hl RW50cmllcyhTZXNzaW9uSUQgc2Vzc2lvbklELCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKFZlY3RvCiB7 CiAjaWYgRU5BQkxFKE5FVFdPUktfQ0FDSEUpCiAgICAgaWYgKE5ldHdvcmtDYWNoZTo6c2luZ2xl dG9uKCkuaXNFbmFibGVkKCkpIHsKLSAgICAgICAgLy8gRklYTUU6IEhhbmRsZSB0aGlzLgotICAg ICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW2NvbXBsZXRpb25IYW5kbGVyXSB7Ci0gICAg ICAgICAgICBjb21wbGV0aW9uSGFuZGxlcih7IH0pOworICAgICAgICBhdXRvKiBvcmlnaW5zID0g bmV3IEhhc2hTZXQ8UmVmUHRyPFNlY3VyaXR5T3JpZ2luPj4oKTsKKworICAgICAgICBOZXR3b3Jr Q2FjaGU6OnNpbmdsZXRvbigpLnRyYXZlcnNlKFtjb21wbGV0aW9uSGFuZGxlciwgb3JpZ2luc10o Y29uc3QgTmV0d29ya0NhY2hlOjpFbnRyeSAqZW50cnkpIHsKKyAgICAgICAgICAgIGlmICghZW50 cnkpIHsKKyAgICAgICAgICAgICAgICBWZWN0b3I8V2Vic2l0ZURhdGE6OkVudHJ5PiBlbnRyaWVz OworCisgICAgICAgICAgICAgICAgZm9yIChhdXRvJiBvcmlnaW4gOiAqb3JpZ2lucykKKyAgICAg ICAgICAgICAgICAgICAgZW50cmllcy5hcHBlbmQoV2Vic2l0ZURhdGE6OkVudHJ5IHsgb3JpZ2lu LCBXZWJzaXRlRGF0YVR5cGVEaXNrQ2FjaGUgfSk7CisKKyAgICAgICAgICAgICAgICBkZWxldGUg b3JpZ2luczsKKworICAgICAgICAgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbY29t cGxldGlvbkhhbmRsZXIsIGVudHJpZXNdIHsKKyAgICAgICAgICAgICAgICAgICAgY29tcGxldGlv bkhhbmRsZXIoZW50cmllcyk7CisgICAgICAgICAgICAgICAgfSk7CisKKyAgICAgICAgICAgICAg ICByZXR1cm47CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIG9yaWdpbnMtPmFkZChTZWN1 cml0eU9yaWdpbjo6Y3JlYXRlKGVudHJ5LT5yZXNwb25zZS51cmwoKSkpOwogICAgICAgICB9KTsK IAogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAppbmRleCA1YTVlMTNmZjNlNDU3ZDhkMjc4ZmM2ZmIw YjUzMjkzMDIxODg3MzdmLi40OGQ4OTE2NGI5YWNmY2E0N2MwYTdlMzkwNDhmNDFiOTFhYzUwYmRk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr Q2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZS5jcHAKQEAgLTM3MCw2ICszNzAsMjcgQEAgdm9pZCBOZXR3b3JrQ2FjaGU6OnVwZGF0 ZShjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIG9yaWdpbmFsUmVxdWVzdCwgY29uc3QK ICAgICB9KTsKIH0KIAordm9pZCBOZXR3b3JrQ2FjaGU6OnRyYXZlcnNlKHN0ZDo6ZnVuY3Rpb248 dm9pZCAoY29uc3QgRW50cnkqKT4mJiB0cmF2ZXJzZUhhbmRsZXIpCit7CisgICAgQVNTRVJUKGlz RW5hYmxlZCgpKTsKKworICAgIG1fc3RvcmFnZS0+dHJhdmVyc2UoW3RyYXZlcnNlSGFuZGxlcl0o Y29uc3QgTmV0d29ya0NhY2hlS2V5JiBrZXksIGNvbnN0IE5ldHdvcmtDYWNoZVN0b3JhZ2U6OkVu dHJ5KiBlbnRyeSkgeworICAgICAgICBpZiAoIWVudHJ5KSB7CisgICAgICAgICAgICB0cmF2ZXJz ZUhhbmRsZXIobnVsbHB0cik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAg ICAgICBOZXR3b3JrQ2FjaGU6OkVudHJ5IGNhY2hlRW50cnk7CisgICAgICAgIGNhY2hlRW50cnku c3RvcmFnZUVudHJ5ID0gKmVudHJ5OworCisgICAgICAgIE5ldHdvcmtDYWNoZURlY29kZXIgZGVj b2RlcihjYWNoZUVudHJ5LnN0b3JhZ2VFbnRyeS5oZWFkZXIuZGF0YSgpLCBjYWNoZUVudHJ5LnN0 b3JhZ2VFbnRyeS5oZWFkZXIuc2l6ZSgpKTsKKyAgICAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShj YWNoZUVudHJ5LnJlc3BvbnNlKSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB0cmF2 ZXJzZUhhbmRsZXIoJmNhY2hlRW50cnkpOworICAgIH0pOworfQorCiBTdHJpbmcgTmV0d29ya0Nh Y2hlOjpkdW1wRmlsZVBhdGgoKSBjb25zdAogewogICAgIHJldHVybiBXZWJDb3JlOjpwYXRoQnlB cHBlbmRpbmdDb21wb25lbnQobV9zdG9yYWdlLT5iYXNlRGlyZWN0b3J5UGF0aCgpLCAiZHVtcC5q c29uIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9O ZXR3b3JrQ2FjaGUuaCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZS5oCmluZGV4IDFlNTQ5Y2I4ZjAwZGYxMzk5OTEyNTZmMzFhZWM4MWRiZmIyNGQxMDMu LmUzNDU2M2EwYzVmNjc2ZTM3Y2NhOTYzOTNlOTQxZjkxMjI4MDdmNjUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5oCkBAIC05OSw2 ICs5OSw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHN0b3JlKGNvbnN0IFdlYkNvcmU6OlJlc291cmNl UmVxdWVzdCYsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmLCBSZWZQdHI8V2ViQ29y ZTo6U2hhcmVkQnVmZmVyPiYmLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKE1hcHBlZEJvZHkmKT4pOwog ICAgIHZvaWQgdXBkYXRlKGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYsIGNvbnN0IEVu dHJ5JiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYgdmFsaWRhdGluZ1Jlc3BvbnNl KTsKIAorICAgIHZvaWQgdHJhdmVyc2Uoc3RkOjpmdW5jdGlvbjx2b2lkIChjb25zdCBFbnRyeSop PiYmKTsKKwogICAgIHZvaWQgY2xlYXIoKTsKIAogICAgIHZvaWQgZHVtcENvbnRlbnRzVG9GaWxl KCk7Cg==