142181 2015-03-02 10:58:17 -0800 REGRESSION: fast/css/acid2-pixel.html and http/tests/misc/acid2-pixel.html became flaky 2015-03-03 17:01:06 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 142249 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=acid2 P1 Normal --- 1 ap sabouhallawa commit-queue esprehn+autocc gyuyoung.kim hyatt koivisto sabouhallawa simon.fraser zalan oldest_to_newest 1073379 0 ap 2015-03-02 10:58:17 -0800 These tests became flaky on February 26th. First recorded failure in 180720, although the actual culprit could be substantially earlier. layer at (84,144) size 144x24 RenderBlock (positioned) {DIV} at (48,72) size 144x24 [bgcolor=#FF0000] RenderBlock {DIV} at (0,0) size 144x0 - RenderInline {OBJECT} at (0,0) size 131x14 - RenderInline {OBJECT} at (0,0) size 131x14 - RenderImage {OBJECT} at (13,0) size 131x24 [border: none (12px solid #000000) none] + RenderInline {OBJECT} at (0,0) size 35x14 + RenderInline {OBJECT} at (0,0) size 35x14 + RenderImage {OBJECT} at (109,24) size 35x0 [border: none (12px solid #000000) none] RenderBlock (floating) {DIV} at (0,0) size 144x24 [border: none (12px solid #FF0000) none (12px solid #000000)] RenderBlock {DIV} at (0,0) size 144x24 [border: none (24px solid #FFFF00)] layer at (84,216) size 144x24 1073380 1 simon.fraser 2015-03-02 11:00:51 -0800 Possibly caused by 1073386 2 simon.fraser 2015-03-02 11:17:40 -0800 I was thinking of http://trac.webkit.org/changeset/180683 1073390 3 ap 2015-03-02 11:23:33 -0800 Should I try rolling it out to confirm? 1073416 4 ap 2015-03-02 12:38:39 -0800 I tested locally. Got a flaky failure with r180683, not failure with r180682. run-webkit-tests LayoutTests/fast/css/acid2-pixel.html --repeat 1000 -f --child-processes=50 1073574 5 247736 sabouhallawa 2015-03-02 19:24:08 -0800 Created attachment 247736 Patch 1073752 6 247736 simon.fraser 2015-03-03 12:20:53 -0800 Comment on attachment 247736 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247736&action=review > Source/WebCore/ChangeLog:13 > + calls. In a very rare case, the layout does not finish reconstructing the > + render tree when the test runner dumps it. This introduced flakiness in We should fix DRT and WTR to update style before the final layout. 1073754 7 247736 koivisto 2015-03-03 12:23:10 -0800 Comment on attachment 247736 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247736&action=review > Source/WebCore/ChangeLog:14 > + calls. In a very rare case, the layout does not finish reconstructing the > + render tree when the test runner dumps it. This introduced flakiness in > + this test. What case? > Source/WebCore/html/HTMLObjectElement.cpp:140 > clearUseFallbackContent(); > - setNeedsStyleRecalc(SyntheticStyleChange); > + setNeedsStyleRecalc(ReconstructRenderTree); This feels like papering over the actual problem. 1073886 8 ap 2015-03-03 17:01:06 -0800 Said asked me to roll out the offending patch for now. *** This bug has been marked as a duplicate of bug 142249 *** 247736 2015-03-02 19:24:08 -0800 2015-03-03 12:23:47 -0800 Patch bug-142181-20150302192351.patch text/plain 2867 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDkxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE1LTAzLTAyICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TjogZmFzdC9jc3MvYWNpZDItcGl4ZWwuaHRtbCBhbmQgaHR0cC90ZXN0cy9taXNjL2FjaWQyLXBp eGVsLmh0bWwgYmVjYW1lIGZsYWt5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQyMTgxLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgYSByZWdyZXNzaW9uIGZyb20gaHR0cDovL3RyYWMud2Vi a2l0Lm9yZy9jaGFuZ2VzZXQvMTgwNjgzLiBUaGUKKyAgICAgICAgY2hhbmdlIGluIEhUTUxQbHVn SW5JbWFnZUVsZW1lbnQ6OndpbGxSZWNhbGNTdHlsZSgpIGNhdXNlZCB0aGUgcmVuZGVyCisgICAg ICAgIHRyZWUgb2YgdGhlIGltYWdlIG9iamVjdCB0byBiZSByZWNvbnN0cnVjdGVkIHdoaWxlIERv Y3VtZW50OjpyZWNhbGNTdHlsZSgpCisgICAgICAgIHdoZW4gaXQgaXMgY2FsbGVkIGZyb20gTGF5 ZXJGbHVzaENvbnRyb2xsZXI6OmZsdXNoTGF5ZXJzKCkgdmlhIG90aGVyCisgICAgICAgIGNhbGxz LiBJbiBhIHZlcnkgcmFyZSBjYXNlLCB0aGUgbGF5b3V0IGRvZXMgbm90IGZpbmlzaCByZWNvbnN0 cnVjdGluZyB0aGUKKyAgICAgICAgcmVuZGVyIHRyZWUgd2hlbiB0aGUgdGVzdCBydW5uZXIgZHVt cHMgaXQuIFRoaXMgaW50cm9kdWNlZCBmbGFraW5lc3MgaW4KKyAgICAgICAgdGhpcyB0ZXN0Lgor ICAgICAgICAKKyAgICAgICAgUmV2ZXJ0IHRoZSBjaGFuZ2UgbWFkZSBpbiBIVE1MUGx1Z0luSW1h Z2VFbGVtZW50Ojp3aWxsUmVjYWxjU3R5bGUoKSBzaW5jZQorICAgICAgICBpdCB3YXMgcmVsYXhp bmcgdGhlIGNvbmRpdGlvbiB0byBjYWxsIHNldE5lZWRzU3R5bGVSZWNhbGMoKS4gQW5kIGFkZCB0 aGUKKyAgICAgICAgcmVjb25zdHJ1Y3Rpb24gcmVxdWVzdCBpbiBIVE1MT2JqZWN0RWxlbWVudDo6 cGFyc2VBdHRyaWJ1dGUoKSBpbnN0ZWFkLgorCisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MT2JqZWN0RWxlbWVudDo6cGFyc2VBdHRy aWJ1dGUpOgorICAgICAgICAqIGh0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MUGx1Z0luSW1hZ2VFbGVtZW50Ojp3aWxsUmVjYWxjU3R5bGUpOgor CiAyMDE1LTAzLTAyICBZb2F2IFdlaXNzICA8eW9hdkB5b2F2LndzPgogCiAgICAgICAgIEFkZCBh IG1pY3JvdGFzayBhYnN0cmFjdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT2Jq ZWN0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT2Jq ZWN0RWxlbWVudC5jcHAJKHJldmlzaW9uIDE4MDc2MykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE9iamVjdEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzcsNyArMTM3LDcgQEAg dm9pZCBIVE1MT2JqZWN0RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUoYwogICAgICAgICByZXR1cm47 CiAKICAgICBjbGVhclVzZUZhbGxiYWNrQ29udGVudCgpOwotICAgIHNldE5lZWRzU3R5bGVSZWNh bGMoU3ludGhldGljU3R5bGVDaGFuZ2UpOworICAgIHNldE5lZWRzU3R5bGVSZWNhbGMoUmVjb25z dHJ1Y3RSZW5kZXJUcmVlKTsKIH0KIAogc3RhdGljIHZvaWQgbWFwRGF0YVBhcmFtVG9TcmMoVmVj dG9yPFN0cmluZz4qIHBhcmFtTmFtZXMsIFZlY3RvcjxTdHJpbmc+KiBwYXJhbVZhbHVlcykKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAko cmV2aXNpb24gMTgwNzYzKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VF bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM3LDcgKzIzNyw3IEBAIGJvb2wgSFRNTFBs dWdJbkltYWdlRWxlbWVudDo6d2lsbFJlY2FsY1MKIAogICAgIC8vIEZJWE1FOiBUaGVyZSBzaG91 ZG4ndCBiZSBuZWVkIHRvIGZvcmNlIHJlbmRlciB0cmVlIHJlY29uc3RydWN0aW9uIGhlcmUuCiAg ICAgLy8gSXQgaXMgb25seSBkb25lIGJlY2F1c2UgbG9hZGluZyBhbmQgbG9hZCBldmVudCBkaXNw YXRjaGluZyBpcyB0aWVkIHRvIHJlbmRlciB0cmVlIGNvbnN0cnVjdGlvbi4KLSAgICBpZiAoIXVz ZUZhbGxiYWNrQ29udGVudCgpICYmIG5lZWRzV2lkZ2V0VXBkYXRlKCkgJiYgcmVuZGVyZXIoKSAm JiAoZGlzcGxheVN0YXRlKCkgIT0gRGlzcGxheWluZ1NuYXBzaG90KSkKKyAgICBpZiAoIXVzZUZh bGxiYWNrQ29udGVudCgpICYmIG5lZWRzV2lkZ2V0VXBkYXRlKCkgJiYgcmVuZGVyZXIoKSAmJiAh aXNJbWFnZVR5cGUoKSAmJiAoZGlzcGxheVN0YXRlKCkgIT0gRGlzcGxheWluZ1NuYXBzaG90KSkK ICAgICAgICAgc2V0TmVlZHNTdHlsZVJlY2FsYyhSZWNvbnN0cnVjdFJlbmRlclRyZWUpOwogICAg IHJldHVybiB0cnVlOwogfQo=