142164 2015-03-02 05:52:17 -0800 [SOUP] Use SoupMessage::starting instead of SoupSession::request-started 2015-03-03 02:25:17 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Soup P2 Normal --- 141508 1 cgarcia webkit-unassigned danw gustavo svillar oldest_to_newest 1073288 0 cgarcia 2015-03-02 05:52:17 -0800 SoupSession::request-started is deprecated in libsoup 2.50. Both signals are equivalent, but SoupMessage::starting is also emitted for resources loaded from the disk cache. This fixes web timing calculations for cached resources, since we were not initializing m_requestStart. 1073289 1 247662 cgarcia 2015-03-02 05:54:12 -0800 Created attachment 247662 Patch 1073292 2 247662 svillar 2015-03-02 06:15:07 -0800 Comment on attachment 247662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247662&action=review Makes sense. Any test that could start have started to pass due to this change? > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:119 > #endif Pretty unfortunate to have the WebTiming stuff here. Hopefully we could remove it with the starting signal at some point. 1073293 3 cgarcia 2015-03-02 06:19:48 -0800 (In reply to comment #2) > Comment on attachment 247662 [details] > Patch Thanks! > View in context: > https://bugs.webkit.org/attachment.cgi?id=247662&action=review > > Makes sense. Any test that could start have started to pass due to this > change? I've tried all webtiming tests in TestExpectations before the patch and all of them passed, so . . . Anyway, this only affects disk cached resources, so I guess that's not the case of any test. > > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:119 > > #endif > > Pretty unfortunate to have the WebTiming stuff here. Hopefully we could > remove it with the starting signal at some point. Yes, indeed. 1073642 4 cgarcia 2015-03-03 02:25:17 -0800 Committed r180928: <http://trac.webkit.org/changeset/180928> 247662 2015-03-02 05:54:12 -0800 2015-03-02 06:15:07 -0800 Patch wk-soup-message-starting.diff text/plain 3902 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YjExNzM3Li5hNTI2MTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTUtMDMtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtTT1VQXSBVc2UgU291cE1lc3NhZ2U6OnN0YXJ0aW5nIGluc3RlYWQgb2Yg U291cFNlc3Npb246OnJlcXVlc3Qtc3RhcnRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyMTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU291cFNlc3Npb246OnJlcXVlc3Qtc3RhcnRlZCBpcyBkZXBy ZWNhdGVkIGluIGxpYnNvdXAgMi41MC4gQm90aAorICAgICAgICBzaWduYWxzIGFyZSBlcXVpdmFs ZW50LCBidXQgU291cE1lc3NhZ2U6OnN0YXJ0aW5nIGlzIGFsc28gZW1pdHRlZAorICAgICAgICBm b3IgcmVzb3VyY2VzIGxvYWRlZCBmcm9tIHRoZSBkaXNrIGNhY2hlLiBUaGlzIGZpeGVzIHdlYiB0 aW1pbmcKKyAgICAgICAgY2FsY3VsYXRpb25zIGZvciBjYWNoZWQgcmVzb3VyY2VzLCBzaW5jZSB3 ZSB3ZXJlIG5vdCBpbml0aWFsaXppbmcKKyAgICAgICAgbV9yZXF1ZXN0U3RhcnQuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OnN0YXJ0aW5nQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRl U291cE1lc3NhZ2VGb3JIYW5kbGVBbmRSZXF1ZXN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvdXBO ZXR3b3JrU2Vzc2lvbjo6U291cE5ldHdvcmtTZXNzaW9uKToKKworMjAxNS0wMy0wMiAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW1NPVVBdIFN5 bmNocm9ub3VzIFhNTEh0dHBSZXF1ZXN0cyBjYW4gdGltZSBvdXQgd2hlbiB3ZSByZWFjaCB0aGUg bWF4IGNvbm5lY3Rpb25zIGxpbWl0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDE1MDgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCBhMzhmODVk Li4wZWY4OTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtODMzLDYgKzgzMywxMyBAQCB2 b2lkIFJlc291cmNlSGFuZGxlOjpkaWRTdGFydFJlcXVlc3QoKQogICAgIGdldEludGVybmFsKCkt Pm1fcmVzcG9uc2UucmVzb3VyY2VMb2FkVGltaW5nKCkucmVxdWVzdFN0YXJ0ID0gbWlsaXNlY29u ZHNTaW5jZVJlcXVlc3QobV9yZXF1ZXN0VGltZSk7CiB9CiAKKyNpZiBTT1VQX0NIRUNLX1ZFUlNJ T04oMiwgNTAsIDApCitzdGF0aWMgdm9pZCBzdGFydGluZ0NhbGxiYWNrKFNvdXBNZXNzYWdlKiwg UmVzb3VyY2VIYW5kbGUqIGhhbmRsZSkKK3sKKyAgICBoYW5kbGUtPmRpZFN0YXJ0UmVxdWVzdCgp OworfQorI2VuZGlmIC8vIFNPVVBfQ0hFQ0tfVkVSU0lPTigyLCA1MCwgMCkKKwogc3RhdGljIHZv aWQgbmV0d29ya0V2ZW50Q2FsbGJhY2soU291cE1lc3NhZ2UqLCBHU29ja2V0Q2xpZW50RXZlbnQg ZXZlbnQsIEdJT1N0cmVhbSosIGdwb2ludGVyIGRhdGEpCiB7CiAgICAgUmVzb3VyY2VIYW5kbGUq IGhhbmRsZSA9IHN0YXRpY19jYXN0PFJlc291cmNlSGFuZGxlKj4oZGF0YSk7CkBAIC05MzksNiAr OTQ2LDkgQEAgc3RhdGljIGJvb2wgY3JlYXRlU291cE1lc3NhZ2VGb3JIYW5kbGVBbmRSZXF1ZXN0 KFJlc291cmNlSGFuZGxlKiBoYW5kbGUsIGNvbnN0IFIKICAgICBzb3VwX21lc3NhZ2Vfc2V0X2Zs YWdzKGQtPm1fc291cE1lc3NhZ2UuZ2V0KCksIHN0YXRpY19jYXN0PFNvdXBNZXNzYWdlRmxhZ3M+ KHNvdXBfbWVzc2FnZV9nZXRfZmxhZ3MoZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSkgfCBmbGFncykp OwogCiAjaWYgRU5BQkxFKFdFQl9USU1JTkcpCisjaWYgU09VUF9DSEVDS19WRVJTSU9OKDIsIDUw LCAwKQorICAgIGdfc2lnbmFsX2Nvbm5lY3QoZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSwgInN0YXJ0 aW5nIiwgR19DQUxMQkFDSyhzdGFydGluZ0NhbGxiYWNrKSwgaGFuZGxlKTsKKyNlbmRpZgogICAg IGdfc2lnbmFsX2Nvbm5lY3QoZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSwgIm5ldHdvcmstZXZlbnQi LCBHX0NBTExCQUNLKG5ldHdvcmtFdmVudENhbGxiYWNrKSwgaGFuZGxlKTsKICAgICBnX3NpZ25h bF9jb25uZWN0KGQtPm1fc291cE1lc3NhZ2UuZ2V0KCksICJyZXN0YXJ0ZWQiLCBHX0NBTExCQUNL KHJlc3RhcnRlZENhbGxiYWNrKSwgaGFuZGxlKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNw cAppbmRleCA1M2M5MjhmLi5hZmQ3MzhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNwcApAQCAtODEs NyArODEsNyBAQCBzdGF0aWMgdm9pZCBhdXRoZW50aWNhdGVDYWxsYmFjayhTb3VwU2Vzc2lvbiog c2Vzc2lvbiwgU291cE1lc3NhZ2UqIHNvdXBNZXNzYWdlLAogICAgIGhhbmRsZS0+ZGlkUmVjZWl2 ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKHNlc3Npb24s IHNvdXBNZXNzYWdlLCBzb3VwQXV0aCwgcmV0cnlpbmcsIGhhbmRsZS5nZXQoKSkpOwogfQogCi0j aWYgRU5BQkxFKFdFQl9USU1JTkcpCisjaWYgRU5BQkxFKFdFQl9USU1JTkcpICYmICFTT1VQX0NI RUNLX1ZFUlNJT04oMiwgNTAsIDApCiBzdGF0aWMgdm9pZCByZXF1ZXN0U3RhcnRlZENhbGxiYWNr KFNvdXBTZXNzaW9uKiwgU291cE1lc3NhZ2UqIHNvdXBNZXNzYWdlLCBTb3VwU29ja2V0KiwgZ3Bv aW50ZXIpCiB7CiAgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBzdGF0aWNfY2Fz dDxSZXNvdXJjZUhhbmRsZSo+KGdfb2JqZWN0X2dldF9kYXRhKEdfT0JKRUNUKHNvdXBNZXNzYWdl KSwgImhhbmRsZSIpKTsKQEAgLTExNCw3ICsxMTQsNyBAQCBTb3VwTmV0d29ya1Nlc3Npb246OlNv dXBOZXR3b3JrU2Vzc2lvbihTb3VwQ29va2llSmFyKiBjb29raWVKYXIpCiAgICAgc2V0dXBMb2dn ZXIoKTsKIAogICAgIGdfc2lnbmFsX2Nvbm5lY3QobV9zb3VwU2Vzc2lvbi5nZXQoKSwgImF1dGhl bnRpY2F0ZSIsIEdfQ0FMTEJBQ0soYXV0aGVudGljYXRlQ2FsbGJhY2spLCBudWxscHRyKTsKLSNp ZiBFTkFCTEUoV0VCX1RJTUlORykKKyNpZiBFTkFCTEUoV0VCX1RJTUlORykgJiYgIVNPVVBfQ0hF Q0tfVkVSU0lPTigyLCA1MCwgMCkKICAgICBnX3NpZ25hbF9jb25uZWN0KG1fc291cFNlc3Npb24u Z2V0KCksICJyZXF1ZXN0LXN0YXJ0ZWQiLCBHX0NBTExCQUNLKHJlcXVlc3RTdGFydGVkQ2FsbGJh Y2spLCBudWxscHRyKTsKICNlbmRpZgogfQo=